[INFO] crate asciimath 0.8.3 is already in cache [INFO] extracting crate asciimath 0.8.3 into work/ex/clippy-test-run/sources/stable/reg/asciimath/0.8.3 [INFO] extracting crate asciimath 0.8.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asciimath/0.8.3 [INFO] validating manifest of asciimath-0.8.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of asciimath-0.8.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing asciimath-0.8.3 [INFO] finished frobbing asciimath-0.8.3 [INFO] frobbed toml for asciimath-0.8.3 written to work/ex/clippy-test-run/sources/stable/reg/asciimath/0.8.3/Cargo.toml [INFO] started frobbing asciimath-0.8.3 [INFO] finished frobbing asciimath-0.8.3 [INFO] frobbed toml for asciimath-0.8.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/asciimath/0.8.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting asciimath-0.8.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/asciimath/0.8.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d72cbe8785e02fd241e2167e129222fe33d9142725a5ccd51556ff2f439c4529 [INFO] running `"docker" "start" "-a" "d72cbe8785e02fd241e2167e129222fe33d9142725a5ccd51556ff2f439c4529"` [INFO] [stderr] Checking asciimath v0.8.3 (/opt/crater/workdir) [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/macros.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | _map [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lexer/tests.rs:73:31 [INFO] [stderr] | [INFO] [stderr] 73 | tokenize("abcd", &scope!{}).unwrap(), [INFO] [stderr] | -------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/macros.rs:19:28 [INFO] [stderr] | [INFO] [stderr] 19 | let mut _map = $crate::Scope::with_capacity(_cap); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lexer/tests.rs:73:31 [INFO] [stderr] | [INFO] [stderr] 73 | tokenize("abcd", &scope!{}).unwrap(), [INFO] [stderr] | -------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ast/eval.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let ref mut evaled_args = args.iter(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^--------------- help: try: `let evaled_args = &mut args.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ast/eval.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | Operator::IsEqualTo => Ok(((args[0] == args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(args[0] - args[1]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ast/eval.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | Operator::IsEqualTo => Ok(((args[0] == args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ast/eval.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | Operator::IsNotEqualTo => Ok(((args[0] != args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(args[0] - args[1]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ast/eval.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | Operator::IsNotEqualTo => Ok(((args[0] != args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the VecDeque [INFO] [stderr] --> src/ast/eval.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | return args.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the VecDeque [INFO] [stderr] --> src/ast/eval.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ast/eval.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | return Ok(value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::scope::Scope` [INFO] [stderr] --> src/ast/scope.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | Scope { [INFO] [stderr] 36 | | variables: HashMap::new(), [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/constants/functions.rs:17:54 [INFO] [stderr] | [INFO] [stderr] 17 | let max = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.max(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/constants/functions.rs:17:54 [INFO] [stderr] | [INFO] [stderr] 17 | let max = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.max(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_divided_by_zero)] on by default [INFO] [stderr] = help: Consider using `std::f64::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/constants/functions.rs:18:55 [INFO] [stderr] | [INFO] [stderr] 18 | let min = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.min(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/constants/functions.rs:18:55 [INFO] [stderr] | [INFO] [stderr] 18 | let min = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.min(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using `std::f64::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lexer/index.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let ref mut var = String::new(); [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let var = &mut String::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lexer/index.rs:101:42 [INFO] [stderr] | [INFO] [stderr] 101 | t.push(Token::Number(-1 as NumericLiteral)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | Ok(operands.push(make_node(Token::Operator(operator), Some(args)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 76 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / fn parse_tokens<'a>( [INFO] [stderr] 112 | | tokens: TokenList, [INFO] [stderr] 113 | | scope: &'a Scope, [INFO] [stderr] 114 | | ) -> Result, Error> { [INFO] [stderr] ... | [INFO] [stderr] 152 | | ) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `asciimath`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lexer/tests.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | let mut scope = scope!{ "x" => 0 }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/ast/eval.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | let ref mut evaled_args = args.iter(); [INFO] [stderr] | ----^^^^^^^^^^^^^^^^^^^--------------- help: try: `let evaled_args = &mut args.iter();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ast/eval.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | Operator::IsEqualTo => Ok(((args[0] == args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(args[0] - args[1]).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ast/eval.rs:62:36 [INFO] [stderr] | [INFO] [stderr] 62 | Operator::IsEqualTo => Ok(((args[0] == args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ast/eval.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | Operator::IsNotEqualTo => Ok(((args[0] != args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(args[0] - args[1]).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ast/eval.rs:63:39 [INFO] [stderr] | [INFO] [stderr] 63 | Operator::IsNotEqualTo => Ok(((args[0] != args[1]) as i8).into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the VecDeque [INFO] [stderr] --> src/ast/eval.rs:74:21 [INFO] [stderr] | [INFO] [stderr] 74 | return args.into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the VecDeque [INFO] [stderr] --> src/ast/eval.rs:90:22 [INFO] [stderr] | [INFO] [stderr] 90 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ast/eval.rs:103:31 [INFO] [stderr] | [INFO] [stderr] 103 | return Ok(value.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting i8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ast/scope.rs:15:34 [INFO] [stderr] | [INFO] [stderr] 15 | Variable::Number(val as NumericLiteral) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(val)` [INFO] [stderr] ... [INFO] [stderr] 21 | num_into_var!(i8 i16 i32 i64 u8 u16 u32 u64 isize usize f32); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `ast::scope::Scope` [INFO] [stderr] --> src/ast/scope.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Self { [INFO] [stderr] 35 | | Scope { [INFO] [stderr] 36 | | variables: HashMap::new(), [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/constants/functions.rs:17:54 [INFO] [stderr] | [INFO] [stderr] 17 | let max = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.max(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/constants/functions.rs:17:54 [INFO] [stderr] | [INFO] [stderr] 17 | let max = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.max(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_divided_by_zero)] on by default [INFO] [stderr] = help: Consider using `std::f64::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/constants/functions.rs:18:55 [INFO] [stderr] | [INFO] [stderr] 18 | let min = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.min(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: constant division of 0.0 with 0.0 will always result in NaN [INFO] [stderr] --> src/constants/functions.rs:18:55 [INFO] [stderr] | [INFO] [stderr] 18 | let min = |args: &Args| Ok(args.iter().fold(0. / 0., |acc: NumericLiteral, x| acc.min(*x))); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using `std::f64::NAN` if you would like a constant representing NaN [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lexer/index.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | let ref mut var = String::new(); [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let var = &mut String::new();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lexer/index.rs:101:42 [INFO] [stderr] | [INFO] [stderr] 101 | t.push(Token::Number(-1 as NumericLiteral)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(-1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/parser.rs:76:8 [INFO] [stderr] | [INFO] [stderr] 76 | Ok(operands.push(make_node(Token::Operator(operator), Some(args)))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 76 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:111:1 [INFO] [stderr] | [INFO] [stderr] 111 | / fn parse_tokens<'a>( [INFO] [stderr] 112 | | tokens: TokenList, [INFO] [stderr] 113 | | scope: &'a Scope, [INFO] [stderr] 114 | | ) -> Result, Error> { [INFO] [stderr] ... | [INFO] [stderr] 152 | | ) [INFO] [stderr] 153 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `asciimath`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d72cbe8785e02fd241e2167e129222fe33d9142725a5ccd51556ff2f439c4529"` [INFO] running `"docker" "rm" "-f" "d72cbe8785e02fd241e2167e129222fe33d9142725a5ccd51556ff2f439c4529"` [INFO] [stdout] d72cbe8785e02fd241e2167e129222fe33d9142725a5ccd51556ff2f439c4529