[INFO] crate ascii 0.9.1 is already in cache [INFO] extracting crate ascii 0.9.1 into work/ex/clippy-test-run/sources/stable/reg/ascii/0.9.1 [INFO] extracting crate ascii 0.9.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ascii/0.9.1 [INFO] validating manifest of ascii-0.9.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ascii-0.9.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ascii-0.9.1 [INFO] removed 0 missing tests [INFO] finished frobbing ascii-0.9.1 [INFO] frobbed toml for ascii-0.9.1 written to work/ex/clippy-test-run/sources/stable/reg/ascii/0.9.1/Cargo.toml [INFO] started frobbing ascii-0.9.1 [INFO] removed 0 missing tests [INFO] finished frobbing ascii-0.9.1 [INFO] frobbed toml for ascii-0.9.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ascii/0.9.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ascii-0.9.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ascii/0.9.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 48b8d19c2ea9e388623ccd21094eb65077b85b78071c79a95767f20c0a308996 [INFO] running `"docker" "start" "-a" "48b8d19c2ea9e388623ccd21094eb65077b85b78071c79a95767f20c0a308996"` [INFO] [stderr] Checking ascii v0.9.1 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii_char.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii_str.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ascii_string.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | AsciiString { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ascii_string.rs:424:23 [INFO] [stderr] | [INFO] [stderr] 424 | AsciiString { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii_string.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/free_functions.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii_char.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii_str.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ascii_string.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | AsciiString { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ascii_string.rs:424:23 [INFO] [stderr] | [INFO] [stderr] 424 | AsciiString { vec: vec } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/ascii_string.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/free_functions.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#![rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ascii_char.rs:619:23 [INFO] [stderr] | [INFO] [stderr] 619 | const ERRORMSG_CHAR: &'static str = "not an ASCII character"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ascii_str.rs:510:16 [INFO] [stderr] | [INFO] [stderr] 510 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 511 | | if !self.string.is_empty() { [INFO] [stderr] 512 | | let line = self.string; [INFO] [stderr] 513 | | self.string = &self.string[..0]; [INFO] [stderr] ... | [INFO] [stderr] 517 | | } [INFO] [stderr] 518 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 510 | } else if !self.string.is_empty() { [INFO] [stderr] 511 | let line = self.string; [INFO] [stderr] 512 | self.string = &self.string[..0]; [INFO] [stderr] 513 | Some(line) [INFO] [stderr] 514 | } else { [INFO] [stderr] 515 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ascii_str.rs:528:22 [INFO] [stderr] | [INFO] [stderr] 528 | const ERRORMSG_STR: &'static str = "one or more bytes are not ASCII"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ascii_char.rs:619:23 [INFO] [stderr] | [INFO] [stderr] 619 | const ERRORMSG_CHAR: &'static str = "not an ASCII character"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ascii_str.rs:510:16 [INFO] [stderr] | [INFO] [stderr] 510 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 511 | | if !self.string.is_empty() { [INFO] [stderr] 512 | | let line = self.string; [INFO] [stderr] 513 | | self.string = &self.string[..0]; [INFO] [stderr] ... | [INFO] [stderr] 517 | | } [INFO] [stderr] 518 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 510 | } else if !self.string.is_empty() { [INFO] [stderr] 511 | let line = self.string; [INFO] [stderr] 512 | self.string = &self.string[..0]; [INFO] [stderr] 513 | Some(line) [INFO] [stderr] 514 | } else { [INFO] [stderr] 515 | None [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/ascii_str.rs:528:22 [INFO] [stderr] | [INFO] [stderr] 528 | const ERRORMSG_STR: &'static str = "one or more bytes are not ASCII"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:497:31 [INFO] [stderr] | [INFO] [stderr] 497 | pub fn to_ascii_uppercase(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:508:31 [INFO] [stderr] | [INFO] [stderr] 508 | pub fn to_ascii_lowercase(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:518:33 [INFO] [stderr] | [INFO] [stderr] 518 | pub fn eq_ignore_ascii_case(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:518:47 [INFO] [stderr] | [INFO] [stderr] 518 | pub fn eq_ignore_ascii_case(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 405 | impl_eq! { AsciiString, String } [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 406 | impl_eq! { String, AsciiString } [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 407 | impl_eq! { &'a AsciiStr, String } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 408 | impl_eq! { String, &'a AsciiStr } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 409 | impl_eq! { &'a AsciiStr, AsciiString } [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 410 | impl_eq! { AsciiString, &'a AsciiStr } [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 411 | impl_eq! { &'a str, AsciiString } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 412 | impl_eq! { AsciiString, &'a str } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:497:31 [INFO] [stderr] | [INFO] [stderr] 497 | pub fn to_ascii_uppercase(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:508:31 [INFO] [stderr] | [INFO] [stderr] 508 | pub fn to_ascii_lowercase(&self) -> Self { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:518:33 [INFO] [stderr] | [INFO] [stderr] 518 | pub fn eq_ignore_ascii_case(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ascii_char.rs:518:47 [INFO] [stderr] | [INFO] [stderr] 518 | pub fn eq_ignore_ascii_case(&self, other: &Self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `generic` doesn't need a mutable reference [INFO] [stderr] --> src/ascii_str.rs:721:28 [INFO] [stderr] | [INFO] [stderr] 721 | assert_eq!(generic(&mut "A"), Ok(ascii_str)); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 405 | impl_eq! { AsciiString, String } [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 406 | impl_eq! { String, AsciiString } [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 407 | impl_eq! { &'a AsciiStr, String } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 408 | impl_eq! { String, &'a AsciiStr } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 409 | impl_eq! { &'a AsciiStr, AsciiString } [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 410 | impl_eq! { AsciiString, &'a AsciiStr } [INFO] [stderr] | -------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 411 | impl_eq! { &'a str, AsciiString } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/ascii_string.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | / fn ne(&self, other: &$rhs) -> bool { [INFO] [stderr] 399 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 400 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 412 | impl_eq! { AsciiString, &'a str } [INFO] [stderr] | --------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.09s [INFO] running `"docker" "inspect" "48b8d19c2ea9e388623ccd21094eb65077b85b78071c79a95767f20c0a308996"` [INFO] running `"docker" "rm" "-f" "48b8d19c2ea9e388623ccd21094eb65077b85b78071c79a95767f20c0a308996"` [INFO] [stdout] 48b8d19c2ea9e388623ccd21094eb65077b85b78071c79a95767f20c0a308996