[INFO] crate artifact_serde 0.1.4 is already in cache
[INFO] extracting crate artifact_serde 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/artifact_serde/0.1.4
[INFO] extracting crate artifact_serde 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/artifact_serde/0.1.4
[INFO] validating manifest of artifact_serde-0.1.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of artifact_serde-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing artifact_serde-0.1.4
[INFO] finished frobbing artifact_serde-0.1.4
[INFO] frobbed toml for artifact_serde-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/artifact_serde/0.1.4/Cargo.toml
[INFO] started frobbing artifact_serde-0.1.4
[INFO] finished frobbing artifact_serde-0.1.4
[INFO] frobbed toml for artifact_serde-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/artifact_serde/0.1.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting artifact_serde-0.1.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/artifact_serde/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 26c73a4f45c65d776a972c14df8d3e7715d5ab2ec4bca217563b136ab15b19d4
[INFO] running `"docker" "start" "-a" "26c73a4f45c65d776a972c14df8d3e7715d5ab2ec4bca217563b136ab15b19d4"`
[INFO] [stderr]     Checking artifact_serde v0.1.4 (/opt/crater/workdir)
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/de.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let re = regex::Regex::new(r"^ADC").unwrap();
[INFO] [stderr]    |                                ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `str::starts_with`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:132:30
[INFO] [stderr]     |
[INFO] [stderr] 132 |     let version_and_heroes = deck_bytes.get(0).unwrap();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:135:19
[INFO] [stderr]     |
[INFO] [stderr] 135 |     let version = deck_bytes.get(0).unwrap() >> 4;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:137:21
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let _checksum = deck_bytes.get(1).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:142:24
[INFO] [stderr]     |
[INFO] [stderr] 142 |         total_bytes - *deck_bytes.get(2).unwrap() as usize
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[2]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/de.rs:170:24
[INFO] [stderr]     |
[INFO] [stderr] 170 |               return Err(format!(
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 171 | |                 "error during read_serialized_card, this is a bug if your ADC is confirmed valid, file bug report"
[INFO] [stderr] 172 | |             ));
[INFO] [stderr]     | |_____________^ help: consider using .to_string(): `"error during read_serialized_card, this is a bug if your ADC is confirmed valid, file bug report".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/de.rs:236:17
[INFO] [stderr]     |
[INFO] [stderr] 236 |     deck_bytes: &Vec<u8>,
[INFO] [stderr]     |                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:251:29
[INFO] [stderr]     |
[INFO] [stderr] 251 |             let next_byte = deck_bytes.get(*start_index).unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `deck_bytes[*start_index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/de.rs:263:17
[INFO] [stderr]     |
[INFO] [stderr] 263 |     deck_bytes: &Vec<u8>,
[INFO] [stderr]     |                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:278:18
[INFO] [stderr]     |
[INFO] [stderr] 278 |     let header = deck_bytes.get(*start_index).unwrap();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `deck_bytes[*start_index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/de.rs:297:5
[INFO] [stderr]     |
[INFO] [stderr] 297 | /     match has_extended_count {
[INFO] [stderr] 298 | |         true => {
[INFO] [stderr] 299 | |             read_encoded_u32(0, 0, &deck_bytes, start_index, end_index, &mut (*out_count));
[INFO] [stderr] 300 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 304 | |         }
[INFO] [stderr] 305 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 297 |     if has_extended_count {
[INFO] [stderr] 298 |     read_encoded_u32(0, 0, &deck_bytes, start_index, end_index, &mut (*out_count));
[INFO] [stderr] 299 | } else {
[INFO] [stderr] 300 |     //the count is just the upper two bits + 1 (since we don't encode zero)
[INFO] [stderr] 301 |     *out_count = (header >> 6) as usize + 1;
[INFO] [stderr] 302 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: trivial regex
[INFO] [stderr]   --> src/de.rs:12:32
[INFO] [stderr]    |
[INFO] [stderr] 12 |     let re = regex::Regex::new(r"^ADC").unwrap();
[INFO] [stderr]    |                                ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivial_regex)] on by default
[INFO] [stderr]    = help: consider using `str::starts_with`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:132:30
[INFO] [stderr]     |
[INFO] [stderr] 132 |     let version_and_heroes = deck_bytes.get(0).unwrap();
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:135:19
[INFO] [stderr]     |
[INFO] [stderr] 135 |     let version = deck_bytes.get(0).unwrap() >> 4;
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[0]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:137:21
[INFO] [stderr]     |
[INFO] [stderr] 137 |     let _checksum = deck_bytes.get(1).unwrap();
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[1]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:142:24
[INFO] [stderr]     |
[INFO] [stderr] 142 |         total_bytes - *deck_bytes.get(2).unwrap() as usize
[INFO] [stderr]     |                        ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&deck_bytes[2]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/de.rs:170:24
[INFO] [stderr]     |
[INFO] [stderr] 170 |               return Err(format!(
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 171 | |                 "error during read_serialized_card, this is a bug if your ADC is confirmed valid, file bug report"
[INFO] [stderr] 172 | |             ));
[INFO] [stderr]     | |_____________^ help: consider using .to_string(): `"error during read_serialized_card, this is a bug if your ADC is confirmed valid, file bug report".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/de.rs:236:17
[INFO] [stderr]     |
[INFO] [stderr] 236 |     deck_bytes: &Vec<u8>,
[INFO] [stderr]     |                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:251:29
[INFO] [stderr]     |
[INFO] [stderr] 251 |             let next_byte = deck_bytes.get(*start_index).unwrap();
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `deck_bytes[*start_index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/de.rs:263:17
[INFO] [stderr]     |
[INFO] [stderr] 263 |     deck_bytes: &Vec<u8>,
[INFO] [stderr]     |                 ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a slice. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/de.rs:278:18
[INFO] [stderr]     |
[INFO] [stderr] 278 |     let header = deck_bytes.get(*start_index).unwrap();
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `deck_bytes[*start_index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to match on a boolean expression
[INFO] [stderr]    --> src/de.rs:297:5
[INFO] [stderr]     |
[INFO] [stderr] 297 | /     match has_extended_count {
[INFO] [stderr] 298 | |         true => {
[INFO] [stderr] 299 | |             read_encoded_u32(0, 0, &deck_bytes, start_index, end_index, &mut (*out_count));
[INFO] [stderr] 300 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 304 | |         }
[INFO] [stderr] 305 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool
[INFO] [stderr] help: consider using an if/else expression
[INFO] [stderr]     |
[INFO] [stderr] 297 |     if has_extended_count {
[INFO] [stderr] 298 |     read_encoded_u32(0, 0, &deck_bytes, start_index, end_index, &mut (*out_count));
[INFO] [stderr] 299 | } else {
[INFO] [stderr] 300 |     //the count is just the upper two bits + 1 (since we don't encode zero)
[INFO] [stderr] 301 |     *out_count = (header >> 6) as usize + 1;
[INFO] [stderr] 302 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.46s
[INFO] running `"docker" "inspect" "26c73a4f45c65d776a972c14df8d3e7715d5ab2ec4bca217563b136ab15b19d4"`
[INFO] running `"docker" "rm" "-f" "26c73a4f45c65d776a972c14df8d3e7715d5ab2ec4bca217563b136ab15b19d4"`
[INFO] [stdout] 26c73a4f45c65d776a972c14df8d3e7715d5ab2ec4bca217563b136ab15b19d4