[INFO] crate artifact 0.2.4 is already in cache
[INFO] extracting crate artifact 0.2.4 into work/ex/clippy-test-run/sources/stable/reg/artifact/0.2.4
[INFO] extracting crate artifact 0.2.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/artifact/0.2.4
[INFO] validating manifest of artifact-0.2.4 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of artifact-0.2.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing artifact-0.2.4
[INFO] finished frobbing artifact-0.2.4
[INFO] frobbed toml for artifact-0.2.4 written to work/ex/clippy-test-run/sources/stable/reg/artifact/0.2.4/Cargo.toml
[INFO] started frobbing artifact-0.2.4
[INFO] finished frobbing artifact-0.2.4
[INFO] frobbed toml for artifact-0.2.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/artifact/0.2.4/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting artifact-0.2.4 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/artifact/0.2.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 513deb1564ddd156952a1ac3cde5f87ff3da2cf81f732e1d3a31b49c5e2b6165
[INFO] running `"docker" "start" "-a" "513deb1564ddd156952a1ac3cde5f87ff3da2cf81f732e1d3a31b49c5e2b6165"`
[INFO] [stderr]     Checking artifact v0.2.4 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 |     ArtifactGlobalLib{handle: handle}
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/lib.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 |     ArtifactGlobalLib{handle: handle}
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^ help: replace it with: `handle`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/internal/task.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub const INTERNAL_LOGGER_NAME:&'static str = "Artifact Internal";
[INFO] [stderr]    |                                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same postfix: `LoggerInst`
[INFO] [stderr]   --> src/internal/task.rs:69:1
[INFO] [stderr]    |
[INFO] [stderr] 69 | / enum LoggerInstance{
[INFO] [stderr] 70 | |   FileLoggerInst(Rc<RefCell<File>>, PathBuf),
[INFO] [stderr] 71 | |   StdoutLoggerInst,
[INFO] [stderr] 72 | |   StderrLoggerInst,
[INFO] [stderr] 73 | |   MultiLoggerInst(Vec<String>),
[INFO] [stderr] 74 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/internal/task.rs:46:33
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub const INTERNAL_LOGGER_NAME:&'static str = "Artifact Internal";
[INFO] [stderr]    |                                -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same postfix: `LoggerInst`
[INFO] [stderr]   --> src/internal/task.rs:69:1
[INFO] [stderr]    |
[INFO] [stderr] 69 | / enum LoggerInstance{
[INFO] [stderr] 70 | |   FileLoggerInst(Rc<RefCell<File>>, PathBuf),
[INFO] [stderr] 71 | |   StdoutLoggerInst,
[INFO] [stderr] 72 | |   StderrLoggerInst,
[INFO] [stderr] 73 | |   MultiLoggerInst(Vec<String>),
[INFO] [stderr] 74 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the postfixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/internal/task.rs:135:55
[INFO] [stderr]     |
[INFO] [stderr] 135 |   fn get_formatter<'a>(&'a self, logger_name:&str) -> &'a Box<MessageFormatter> {
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a MessageFormatter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/internal/task.rs:199:7
[INFO] [stderr]     |
[INFO] [stderr] 199 | /       match known_logger {
[INFO] [stderr] 200 | |         &LoggerInstance::FileLoggerInst(ref cell, ref prev_path) => {
[INFO] [stderr] 201 | |           if *prev_path == *path {
[INFO] [stderr] 202 | |             return Some(LoggerInstance::FileLoggerInst(cell.clone(), prev_path.clone()));
[INFO] [stderr] ...   |
[INFO] [stderr] 205 | |         _ => {}
[INFO] [stderr] 206 | |       }
[INFO] [stderr]     | |_______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 199 |       if let &LoggerInstance::FileLoggerInst(ref cell, ref prev_path) = known_logger {
[INFO] [stderr] 200 |   if *prev_path == *path {
[INFO] [stderr] 201 |     return Some(LoggerInstance::FileLoggerInst(cell.clone(), prev_path.clone()));
[INFO] [stderr] 202 |   }
[INFO] [stderr] 203 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/internal/task.rs:199:7
[INFO] [stderr]     |
[INFO] [stderr] 199 | /       match known_logger {
[INFO] [stderr] 200 | |         &LoggerInstance::FileLoggerInst(ref cell, ref prev_path) => {
[INFO] [stderr] 201 | |           if *prev_path == *path {
[INFO] [stderr] 202 | |             return Some(LoggerInstance::FileLoggerInst(cell.clone(), prev_path.clone()));
[INFO] [stderr] ...   |
[INFO] [stderr] 205 | |         _ => {}
[INFO] [stderr] 206 | |       }
[INFO] [stderr]     | |_______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 199 |       match *known_logger {
[INFO] [stderr] 200 |         LoggerInstance::FileLoggerInst(ref cell, ref prev_path) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/internal/task.rs:251:8
[INFO] [stderr]     |
[INFO] [stderr] 251 |     if !self.loggers.get(&logger).is_none() {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.loggers.get(&logger).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/internal/task.rs:250:27
[INFO] [stderr]     |
[INFO] [stderr] 250 |     let disabled_status = self.disabled.get(&logger).map(|b| *b);
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.disabled.get(&logger).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/internal/comm.rs:81:3
[INFO] [stderr]    |
[INFO] [stderr] 81 | /   match *GLOBAL_LOGGER_ACCESS.lock().unwrap() {
[INFO] [stderr] 82 | |     Some(Artifact{ref msg_tx}) => { let _ = msg_tx.send(task::LoggerMessage::PoisonPill); }
[INFO] [stderr] 83 | |     None => {}
[INFO] [stderr] 84 | |   }
[INFO] [stderr]    | |___^ help: try this: `if let Some(Artifact{ref msg_tx}) = *GLOBAL_LOGGER_ACCESS.lock().unwrap() { let _ = msg_tx.send(task::LoggerMessage::PoisonPill); }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use `&Box<T>`. Consider using just `&T`
[INFO] [stderr]    --> src/internal/task.rs:135:55
[INFO] [stderr]     |
[INFO] [stderr] 135 |   fn get_formatter<'a>(&'a self, logger_name:&str) -> &'a Box<MessageFormatter> {
[INFO] [stderr]     |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&'a MessageFormatter`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::borrowed_box)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/internal/task.rs:199:7
[INFO] [stderr]     |
[INFO] [stderr] 199 | /       match known_logger {
[INFO] [stderr] 200 | |         &LoggerInstance::FileLoggerInst(ref cell, ref prev_path) => {
[INFO] [stderr] 201 | |           if *prev_path == *path {
[INFO] [stderr] 202 | |             return Some(LoggerInstance::FileLoggerInst(cell.clone(), prev_path.clone()));
[INFO] [stderr] ...   |
[INFO] [stderr] 205 | |         _ => {}
[INFO] [stderr] 206 | |       }
[INFO] [stderr]     | |_______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 199 |       if let &LoggerInstance::FileLoggerInst(ref cell, ref prev_path) = known_logger {
[INFO] [stderr] 200 |   if *prev_path == *path {
[INFO] [stderr] 201 |     return Some(LoggerInstance::FileLoggerInst(cell.clone(), prev_path.clone()));
[INFO] [stderr] 202 |   }
[INFO] [stderr] 203 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/internal/task.rs:199:7
[INFO] [stderr]     |
[INFO] [stderr] 199 | /       match known_logger {
[INFO] [stderr] 200 | |         &LoggerInstance::FileLoggerInst(ref cell, ref prev_path) => {
[INFO] [stderr] 201 | |           if *prev_path == *path {
[INFO] [stderr] 202 | |             return Some(LoggerInstance::FileLoggerInst(cell.clone(), prev_path.clone()));
[INFO] [stderr] ...   |
[INFO] [stderr] 205 | |         _ => {}
[INFO] [stderr] 206 | |       }
[INFO] [stderr]     | |_______^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 199 |       match *known_logger {
[INFO] [stderr] 200 |         LoggerInstance::FileLoggerInst(ref cell, ref prev_path) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this boolean expression can be simplified
[INFO] [stderr]    --> src/internal/task.rs:251:8
[INFO] [stderr]     |
[INFO] [stderr] 251 |     if !self.loggers.get(&logger).is_none() {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.loggers.get(&logger).is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::nonminimal_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/internal/task.rs:250:27
[INFO] [stderr]     |
[INFO] [stderr] 250 |     let disabled_status = self.disabled.get(&logger).map(|b| *b);
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.disabled.get(&logger).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/internal/comm.rs:81:3
[INFO] [stderr]    |
[INFO] [stderr] 81 | /   match *GLOBAL_LOGGER_ACCESS.lock().unwrap() {
[INFO] [stderr] 82 | |     Some(Artifact{ref msg_tx}) => { let _ = msg_tx.send(task::LoggerMessage::PoisonPill); }
[INFO] [stderr] 83 | |     None => {}
[INFO] [stderr] 84 | |   }
[INFO] [stderr]    | |___^ help: try this: `if let Some(Artifact{ref msg_tx}) = *GLOBAL_LOGGER_ACCESS.lock().unwrap() { let _ = msg_tx.send(task::LoggerMessage::PoisonPill); }`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.73s
[INFO] running `"docker" "inspect" "513deb1564ddd156952a1ac3cde5f87ff3da2cf81f732e1d3a31b49c5e2b6165"`
[INFO] running `"docker" "rm" "-f" "513deb1564ddd156952a1ac3cde5f87ff3da2cf81f732e1d3a31b49c5e2b6165"`
[INFO] [stdout] 513deb1564ddd156952a1ac3cde5f87ff3da2cf81f732e1d3a31b49c5e2b6165