[INFO] crate article-date-extractor 0.1.1 is already in cache [INFO] extracting crate article-date-extractor 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/article-date-extractor/0.1.1 [INFO] extracting crate article-date-extractor 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/article-date-extractor/0.1.1 [INFO] validating manifest of article-date-extractor-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of article-date-extractor-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing article-date-extractor-0.1.1 [INFO] finished frobbing article-date-extractor-0.1.1 [INFO] frobbed toml for article-date-extractor-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/article-date-extractor/0.1.1/Cargo.toml [INFO] started frobbing article-date-extractor-0.1.1 [INFO] finished frobbing article-date-extractor-0.1.1 [INFO] frobbed toml for article-date-extractor-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/article-date-extractor/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting article-date-extractor-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/article-date-extractor/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ccbda5732122b683de6d7f63f08c7910218f08cc34c3dfe5da0f74d1fbb65170 [INFO] running `"docker" "start" "-a" "ccbda5732122b683de6d7f63f08c7910218f08cc34c3dfe5da0f74d1fbb65170"` [INFO] [stderr] Checking tendril v0.3.1 [INFO] [stderr] Compiling string_cache v0.6.2 [INFO] [stderr] Compiling markup5ever v0.3.2 [INFO] [stderr] Checking html5ever v0.18.0 [INFO] [stderr] Checking select v0.4.2 [INFO] [stderr] Checking article-date-extractor v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/extract_date.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .ok_or("None of the formats matched the date".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None of the formats matched the date".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / fn extract_from_ldjson<'a>(html: &'a Document) -> Option { [INFO] [stderr] 40 | | html.find(Attr("type", "application/ld+json")) [INFO] [stderr] 41 | | .next() [INFO] [stderr] 42 | | .map(|ldj| ldj.text()) [INFO] [stderr] ... | [INFO] [stderr] 56 | | }) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / fn extract_from_meta<'a>(html: &'a Document) -> Option { [INFO] [stderr] 100 | | html.find(Name("meta")).flat_map(|meta| { [INFO] [stderr] 101 | | let content = match meta.attr("content") { [INFO] [stderr] 102 | | Some(c) => c, [INFO] [stderr] ... | [INFO] [stderr] 125 | | }).next() [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / fn extract_time_tag<'a>(html: &'a Document) -> Option { [INFO] [stderr] 129 | | html.find(Name("time")).flat_map(|time| { [INFO] [stderr] 130 | | if time.attr("class") == Some("timestamp") { [INFO] [stderr] 131 | | Some(time.text().trim_matches('\n').to_string()) [INFO] [stderr] ... | [INFO] [stderr] 136 | | }).next() [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / fn extract_span_date_published<'a>(html: &'a Document) -> Option { [INFO] [stderr] 140 | | html.find(Name("span")).flat_map(|tag| { [INFO] [stderr] 141 | | if tag.attr("itemprop") == Some("datePublished") { [INFO] [stderr] 142 | | tag.attr("content").map(|v| v.to_string()) [INFO] [stderr] ... | [INFO] [stderr] 148 | | }).next() [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:163:1 [INFO] [stderr] | [INFO] [stderr] 163 | / fn extract_from_html_tag<'a>(html: &'a Document) -> Option { [INFO] [stderr] 164 | | lazy_static! { [INFO] [stderr] 165 | | static ref TAG_RE: Regex = [INFO] [stderr] 166 | | Regex::new(r"(?i)publishdate|pubdate|timestamp|article_date|articledate|date").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 174 | | .or(None) [INFO] [stderr] 175 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/extract_date.rs:210:10 [INFO] [stderr] | [INFO] [stderr] 210 | .ok_or("Couldn't find the date to parse".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Couldn't find the date to parse".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/extract_date.rs:258:25 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(Some(("2015-11-30 23:50:48".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/extract_date.rs:258:25 [INFO] [stderr] | [INFO] [stderr] 258 | assert_eq!(Some(("2015-11-30 23:50:48".to_string())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/extract_date.rs:32:10 [INFO] [stderr] | [INFO] [stderr] 32 | .ok_or("None of the formats matched the date".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "None of the formats matched the date".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / fn extract_from_ldjson<'a>(html: &'a Document) -> Option { [INFO] [stderr] 40 | | html.find(Attr("type", "application/ld+json")) [INFO] [stderr] 41 | | .next() [INFO] [stderr] 42 | | .map(|ldj| ldj.text()) [INFO] [stderr] ... | [INFO] [stderr] 56 | | }) [INFO] [stderr] 57 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:99:1 [INFO] [stderr] | [INFO] [stderr] 99 | / fn extract_from_meta<'a>(html: &'a Document) -> Option { [INFO] [stderr] 100 | | html.find(Name("meta")).flat_map(|meta| { [INFO] [stderr] 101 | | let content = match meta.attr("content") { [INFO] [stderr] 102 | | Some(c) => c, [INFO] [stderr] ... | [INFO] [stderr] 125 | | }).next() [INFO] [stderr] 126 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:128:1 [INFO] [stderr] | [INFO] [stderr] 128 | / fn extract_time_tag<'a>(html: &'a Document) -> Option { [INFO] [stderr] 129 | | html.find(Name("time")).flat_map(|time| { [INFO] [stderr] 130 | | if time.attr("class") == Some("timestamp") { [INFO] [stderr] 131 | | Some(time.text().trim_matches('\n').to_string()) [INFO] [stderr] ... | [INFO] [stderr] 136 | | }).next() [INFO] [stderr] 137 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:139:1 [INFO] [stderr] | [INFO] [stderr] 139 | / fn extract_span_date_published<'a>(html: &'a Document) -> Option { [INFO] [stderr] 140 | | html.find(Name("span")).flat_map(|tag| { [INFO] [stderr] 141 | | if tag.attr("itemprop") == Some("datePublished") { [INFO] [stderr] 142 | | tag.attr("content").map(|v| v.to_string()) [INFO] [stderr] ... | [INFO] [stderr] 148 | | }).next() [INFO] [stderr] 149 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/extract_date.rs:163:1 [INFO] [stderr] | [INFO] [stderr] 163 | / fn extract_from_html_tag<'a>(html: &'a Document) -> Option { [INFO] [stderr] 164 | | lazy_static! { [INFO] [stderr] 165 | | static ref TAG_RE: Regex = [INFO] [stderr] 166 | | Regex::new(r"(?i)publishdate|pubdate|timestamp|article_date|articledate|date").unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 174 | | .or(None) [INFO] [stderr] 175 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/extract_date.rs:210:10 [INFO] [stderr] | [INFO] [stderr] 210 | .ok_or("Couldn't find the date to parse".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "Couldn't find the date to parse".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/integration_test.rs:30:42 [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(NaiveDate::from_ymd(2017, 03, 15), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(NaiveDate::from_ymd(2017, 3, 15), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 30 | assert_eq!(NaiveDate::from_ymd(2017, 0o3, 15), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/integration_test.rs:33:42 [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(NaiveDate::from_ymd(2017, 03, 16), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(NaiveDate::from_ymd(2017, 3, 16), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 33 | assert_eq!(NaiveDate::from_ymd(2017, 0o3, 16), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/integration_test.rs:36:42 [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(NaiveDate::from_ymd(2017, 03, 16), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(NaiveDate::from_ymd(2017, 3, 16), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 36 | assert_eq!(NaiveDate::from_ymd(2017, 0o3, 16), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> tests/integration_test.rs:39:42 [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(NaiveDate::from_ymd(2017, 03, 16), [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(NaiveDate::from_ymd(2017, 3, 16), [INFO] [stderr] | ^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 39 | assert_eq!(NaiveDate::from_ymd(2017, 0o3, 16), [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.12s [INFO] running `"docker" "inspect" "ccbda5732122b683de6d7f63f08c7910218f08cc34c3dfe5da0f74d1fbb65170"` [INFO] running `"docker" "rm" "-f" "ccbda5732122b683de6d7f63f08c7910218f08cc34c3dfe5da0f74d1fbb65170"` [INFO] [stdout] ccbda5732122b683de6d7f63f08c7910218f08cc34c3dfe5da0f74d1fbb65170