[INFO] crate arthas_derive 0.1.0 is already in cache [INFO] extracting crate arthas_derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/arthas_derive/0.1.0 [INFO] extracting crate arthas_derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthas_derive/0.1.0 [INFO] validating manifest of arthas_derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arthas_derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arthas_derive-0.1.0 [INFO] finished frobbing arthas_derive-0.1.0 [INFO] frobbed toml for arthas_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/arthas_derive/0.1.0/Cargo.toml [INFO] started frobbing arthas_derive-0.1.0 [INFO] finished frobbing arthas_derive-0.1.0 [INFO] frobbed toml for arthas_derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthas_derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arthas_derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/arthas_derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 012603a2c6dba5271af5072f2f546e10ea328fecfda6d1c530d3e9dad87746f3 [INFO] running `"docker" "start" "-a" "012603a2c6dba5271af5072f2f546e10ea328fecfda6d1c530d3e9dad87746f3"` [INFO] [stderr] warning: proc-macro library `arthas_derive` should not specify `plugin = true` [INFO] [stderr] warning: library `arthas_derive` should only specify `proc-macro = true` instead of setting `crate-type` [INFO] [stderr] Checking arthas_derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if ident.to_string() == "arthas" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | if ident.to_string() == "rename" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:346:16 [INFO] [stderr] | [INFO] [stderr] 346 | if ident.to_string() == "_id" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:358:16 [INFO] [stderr] | [INFO] [stderr] 358 | if ident.to_string() == "arthas" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:362:32 [INFO] [stderr] | [INFO] [stderr] 362 | if ident.to_string() == "is_one" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:420:73 [INFO] [stderr] | [INFO] [stderr] 420 | } else if is_vec(generic_type) && !vec_is_struct_type(generic_type) { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 421 | | false [INFO] [stderr] 422 | | } else if is_hashmap(generic_type) && !hashmap_is_struct_type(generic_type) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:418:72 [INFO] [stderr] | [INFO] [stderr] 418 | if is_option(generic_type) && !option_is_struct_type(generic_type) { [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 419 | | false [INFO] [stderr] 420 | | } else if is_vec(generic_type) && !vec_is_struct_type(generic_type) { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arthas_derive`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:225:16 [INFO] [stderr] | [INFO] [stderr] 225 | if ident.to_string() == "arthas" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | if ident.to_string() == "rename" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:346:16 [INFO] [stderr] | [INFO] [stderr] 346 | if ident.to_string() == "_id" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:358:16 [INFO] [stderr] | [INFO] [stderr] 358 | if ident.to_string() == "arthas" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/lib.rs:362:32 [INFO] [stderr] | [INFO] [stderr] 362 | if ident.to_string() == "is_one" { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `*ident` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/lib.rs:420:73 [INFO] [stderr] | [INFO] [stderr] 420 | } else if is_vec(generic_type) && !vec_is_struct_type(generic_type) { [INFO] [stderr] | _________________________________________________________________________^ [INFO] [stderr] 421 | | false [INFO] [stderr] 422 | | } else if is_hashmap(generic_type) && !hashmap_is_struct_type(generic_type) { [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/lib.rs:418:72 [INFO] [stderr] | [INFO] [stderr] 418 | if is_option(generic_type) && !option_is_struct_type(generic_type) { [INFO] [stderr] | ________________________________________________________________________^ [INFO] [stderr] 419 | | false [INFO] [stderr] 420 | | } else if is_vec(generic_type) && !vec_is_struct_type(generic_type) { [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `arthas_derive`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "012603a2c6dba5271af5072f2f546e10ea328fecfda6d1c530d3e9dad87746f3"` [INFO] running `"docker" "rm" "-f" "012603a2c6dba5271af5072f2f546e10ea328fecfda6d1c530d3e9dad87746f3"` [INFO] [stdout] 012603a2c6dba5271af5072f2f546e10ea328fecfda6d1c530d3e9dad87746f3