[INFO] crate arthas 0.3.0 is already in cache [INFO] extracting crate arthas 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/arthas/0.3.0 [INFO] extracting crate arthas 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthas/0.3.0 [INFO] validating manifest of arthas-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arthas-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arthas-0.3.0 [INFO] removed path dependency arthas_derive from arthas-0.3.0 [INFO] finished frobbing arthas-0.3.0 [INFO] frobbed toml for arthas-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/arthas/0.3.0/Cargo.toml [INFO] started frobbing arthas-0.3.0 [INFO] removed path dependency arthas_derive from arthas-0.3.0 [INFO] finished frobbing arthas-0.3.0 [INFO] frobbed toml for arthas-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arthas/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arthas-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/arthas/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1477fc66d0e2f79492e2e14a3bb0adbb650a9482480df90e35312c7856bb9e0c [INFO] running `"docker" "start" "-a" "1477fc66d0e2f79492e2e14a3bb0adbb650a9482480df90e35312c7856bb9e0c"` [INFO] [stderr] Checking scoped-pool v1.0.0 [INFO] [stderr] Compiling memchr v0.1.11 [INFO] [stderr] Compiling thread-id v2.0.0 [INFO] [stderr] Checking objectid v0.1.0 [INFO] [stderr] Compiling thread_local v0.2.7 [INFO] [stderr] Compiling aho-corasick v0.5.3 [INFO] [stderr] Checking arthas v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistence/meta/mod.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | size: size, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistence/logger/mod.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistence/mod.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | struct_name: struct_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `struct_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/persistence/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | field_int_map: field_int_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_int_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/node/mod.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/data/mod.rs:52:13 [INFO] [stderr] | [INFO] [stderr] 52 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/data/mod.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | _type: _type, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/item/mod.rs:80:17 [INFO] [stderr] | [INFO] [stderr] 80 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/item/mod.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | datas: datas, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `datas` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/item/mod.rs:83:17 [INFO] [stderr] | [INFO] [stderr] 83 | value: value, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/child/mod.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/rc/child/mod.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/searcher/task/mod.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | subs: subs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `subs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/searcher/task/mod.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | orders: orders, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `orders` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/searcher/task/mod.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | order: order, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `order` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/searcher/task/mod.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | subs_length: subs_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `subs_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/searcher/task/mod.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | order_field: order_field, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `order_field` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/comparision/mod.rs:20:13 [INFO] [stderr] | [INFO] [stderr] 20 | field_int: field_int, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `field_int` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/comparision/mod.rs:21:13 [INFO] [stderr] | [INFO] [stderr] 21 | cmp: cmp, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cmp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tree/comparision/mod.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | other: other, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `other` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item/mod.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | item: item, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/item/mod.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Compiling regex v0.1.80 [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:173:24 [INFO] [stderr] | [INFO] [stderr] 173 | const DATA_EXTENSION: &'static str = "ar"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:174:31 [INFO] [stderr] | [INFO] [stderr] 174 | const PERSISTENCE_EXTENSION: &'static str = "arx"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:175:23 [INFO] [stderr] | [INFO] [stderr] 175 | const LOG_EXTENSION: &'static str = "arl"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:176:26 [INFO] [stderr] | [INFO] [stderr] 176 | const SAVING_EXTENSION: &'static str = "saving"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:177:18 [INFO] [stderr] | [INFO] [stderr] 177 | const DATA_DIR: &'static str = "arthas.ar"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/encoder/mod.rs:62:69 [INFO] [stderr] | [INFO] [stderr] 62 | for (index, input) in current_input.as_array().unwrap().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/encoder/mod.rs:119:69 [INFO] [stderr] | [INFO] [stderr] 119 | for (index, input) in current_input.as_array().unwrap().into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/loader/mod.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | / if persistence_option.is_none() { [INFO] [stderr] 92 | | return None; [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ help: replace_it_with: `persistence_option?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/loader/mod.rs:97:8 [INFO] [stderr] | [INFO] [stderr] 97 | if to_value(&persistence.field_int_map).to_string() != to_value(field_int_map).to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_value(&persistence.field_int_map)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_owned)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/loader/mod.rs:97:60 [INFO] [stderr] | [INFO] [stderr] 97 | if to_value(&persistence.field_int_map).to_string() != to_value(field_int_map).to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_value(field_int_map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/loader/mod.rs:143:12 [INFO] [stderr] | [INFO] [stderr] 143 | if to_value(&persistence.field_int_map).to_string() != to_value(field_int_map).to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_value(&persistence.field_int_map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: this creates an owned instance just for comparison [INFO] [stderr] --> src/loader/mod.rs:143:64 [INFO] [stderr] | [INFO] [stderr] 143 | if to_value(&persistence.field_int_map).to_string() != to_value(field_int_map).to_string() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `to_value(field_int_map)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/query/mod.rs:250:10 [INFO] [stderr] | [INFO] [stderr] 250 | ((self.start_time.as_ref().unwrap().elapsed().subsec_nanos()) as f64 / 1000.0).round() / [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((self.start_time.as_ref().unwrap().elapsed().subsec_nanos()))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/tree/node/mod.rs:535:13 [INFO] [stderr] | [INFO] [stderr] 535 | / if compared_action.is_none() { [INFO] [stderr] 536 | | return None; [INFO] [stderr] 537 | | } [INFO] [stderr] | |_____________^ help: replace_it_with: `compared_action?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/tree/node/mod.rs:543:17 [INFO] [stderr] | [INFO] [stderr] 543 | / if merged_action.is_none() { [INFO] [stderr] 544 | | return None; [INFO] [stderr] 545 | | } else { [INFO] [stderr] 546 | | prev_action = merged_action; [INFO] [stderr] 547 | | } [INFO] [stderr] | |_________________^ help: replace_it_with: `merged_action?;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/tree/node/mod.rs:695:9 [INFO] [stderr] | [INFO] [stderr] 695 | / for child in self.group.read().unwrap().values() { [INFO] [stderr] 696 | | return child.read().unwrap().get_value(); [INFO] [stderr] 697 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tree/inserter/mod.rs:28:39 [INFO] [stderr] | [INFO] [stderr] 28 | let node_option = tree.root [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 29 | | .get(&field_int) [INFO] [stderr] 30 | | .unwrap() [INFO] [stderr] | |_________________________________^ help: try this: `&tree.root[&field_int]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tree/searcher/task/mod.rs:23:23 [INFO] [stderr] | [INFO] [stderr] 23 | let rc_data = item.datas.get(&self.field_int).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&item.datas[&self.field_int]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/tree/searcher/task/mod.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | limit: query.limit.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `query.limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tree/searcher/executor/mod.rs:51:43 [INFO] [stderr] | [INFO] [stderr] 51 | let rc_node = tree.root [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 52 | | .get(&sub.field_int) [INFO] [stderr] 53 | | .unwrap(); [INFO] [stderr] | |_________________________________________^ help: try this: `&tree.root[&sub.field_int]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tree/searcher/executor/mod.rs:68:43 [INFO] [stderr] | [INFO] [stderr] 68 | let rc_node = tree.min [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 69 | | .get(&sub.field_int) [INFO] [stderr] 70 | | .unwrap(); [INFO] [stderr] | |_________________________________________^ help: try this: `&tree.min[&sub.field_int]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/tree/searcher/executor/mod.rs:86:43 [INFO] [stderr] | [INFO] [stderr] 86 | let rc_node = tree.max [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 87 | | .get(&sub.field_int) [INFO] [stderr] 88 | | .unwrap(); [INFO] [stderr] | |_________________________________________^ help: try this: `&tree.max[&sub.field_int]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/tree/searcher/executor/mod.rs:273:52 [INFO] [stderr] | [INFO] [stderr] 273 | fn sort_children(children: &mut [RcChild], orders: &Orders) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tree/searcher/entrance_type/mod.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if maximum == min_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(maximum - min_rate).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tree/searcher/entrance_type/mod.rs:53:16 [INFO] [stderr] | [INFO] [stderr] 53 | if maximum == min_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/tree/searcher/entrance_type/mod.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | } else if maximum == max_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(maximum - max_rate).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/tree/searcher/entrance_type/mod.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | } else if maximum == max_rate { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/tree/math/mod.rs:117:64 [INFO] [stderr] | [INFO] [stderr] 117 | let n1 = self.get_str().chars().map(|c| c as usize).fold(0, |a, b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/tree/math/mod.rs:118:65 [INFO] [stderr] | [INFO] [stderr] 118 | let n2 = other.get_str().chars().map(|c| c as usize).fold(0, |a, b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::utc_date::UtcDate` [INFO] [stderr] --> src/types/utc_date/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> UtcDate { [INFO] [stderr] 11 | | UtcDate(UTC::today()) [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | impl Default for types::utc_date::UtcDate { [INFO] [stderr] 9 | fn default() -> Self { [INFO] [stderr] 10 | Self::new() [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `types::utc_date_time::UtcDateTime` [INFO] [stderr] --> src/types/utc_date_time/mod.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | / pub fn new() -> UtcDateTime { [INFO] [stderr] 11 | | UtcDateTime(UTC::now()) [INFO] [stderr] 12 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | impl Default for types::utc_date_time::UtcDateTime { [INFO] [stderr] 9 | fn default() -> Self { [INFO] [stderr] 10 | Self::new() [INFO] [stderr] 11 | } [INFO] [stderr] 12 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `arthas`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "1477fc66d0e2f79492e2e14a3bb0adbb650a9482480df90e35312c7856bb9e0c"` [INFO] running `"docker" "rm" "-f" "1477fc66d0e2f79492e2e14a3bb0adbb650a9482480df90e35312c7856bb9e0c"` [INFO] [stdout] 1477fc66d0e2f79492e2e14a3bb0adbb650a9482480df90e35312c7856bb9e0c