[INFO] crate arrayvec 0.4.8 is already in cache [INFO] extracting crate arrayvec 0.4.8 into work/ex/clippy-test-run/sources/stable/reg/arrayvec/0.4.8 [INFO] extracting crate arrayvec 0.4.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arrayvec/0.4.8 [INFO] validating manifest of arrayvec-0.4.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arrayvec-0.4.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arrayvec-0.4.8 [INFO] finished frobbing arrayvec-0.4.8 [INFO] frobbed toml for arrayvec-0.4.8 written to work/ex/clippy-test-run/sources/stable/reg/arrayvec/0.4.8/Cargo.toml [INFO] started frobbing arrayvec-0.4.8 [INFO] finished frobbing arrayvec-0.4.8 [INFO] frobbed toml for arrayvec-0.4.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arrayvec/0.4.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arrayvec-0.4.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/arrayvec/0.4.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6bb68d73a8c638f18884b320c272859fed319ed5d9155fb116eed24f71fec43 [INFO] running `"docker" "start" "-a" "a6bb68d73a8c638f18884b320c272859fed319ed5d9155fb116eed24f71fec43"` [INFO] [stderr] Checking arrayvec v0.4.8 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | element: element, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `element` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/errors.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | write!(f, "{}: {}", "CapacityError", CAPERROR) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/errors.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | element: element, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `element` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/errors.rs:50:29 [INFO] [stderr] | [INFO] [stderr] 50 | write!(f, "{}: {}", "CapacityError", CAPERROR) [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/errors.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | const CAPERROR: &'static str = "insufficient capacity"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/errors.rs:32:18 [INFO] [stderr] | [INFO] [stderr] 32 | const CAPERROR: &'static str = "insufficient capacity"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/array_string.rs:214:23 [INFO] [stderr] | [INFO] [stderr] 214 | let dst = self.xs.as_mut_ptr().offset(self.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.xs.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/array_string.rs:308:23 [INFO] [stderr] | [INFO] [stderr] 308 | ptr::copy(self.xs.as_ptr().offset(next as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.xs.as_ptr().add(next)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/array_string.rs:309:23 [INFO] [stderr] | [INFO] [stderr] 309 | self.xs.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.xs.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str` [INFO] [stderr] --> src/array_string.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | mem::transmute(sl) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(sl).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_bytes_to_str)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:447:39 [INFO] [stderr] | [INFO] [stderr] 447 | fn lt(&self, rhs: &str) -> bool { &**self < rhs } [INFO] [stderr] | -------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:448:39 [INFO] [stderr] | [INFO] [stderr] 448 | fn le(&self, rhs: &str) -> bool { &**self <= rhs } [INFO] [stderr] | -------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:449:39 [INFO] [stderr] | [INFO] [stderr] 449 | fn gt(&self, rhs: &str) -> bool { &**self > rhs } [INFO] [stderr] | -------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:450:39 [INFO] [stderr] | [INFO] [stderr] 450 | fn ge(&self, rhs: &str) -> bool { &**self >= rhs } [INFO] [stderr] | -------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:457:50 [INFO] [stderr] | [INFO] [stderr] 457 | fn lt(&self, rhs: &ArrayString) -> bool { self < &**rhs } [INFO] [stderr] | ^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:458:50 [INFO] [stderr] | [INFO] [stderr] 458 | fn le(&self, rhs: &ArrayString) -> bool { self <= &**rhs } [INFO] [stderr] | ^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:459:50 [INFO] [stderr] | [INFO] [stderr] 459 | fn gt(&self, rhs: &ArrayString) -> bool { self > &**rhs } [INFO] [stderr] | ^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:460:50 [INFO] [stderr] | [INFO] [stderr] 460 | fn ge(&self, rhs: &ArrayString) -> bool { self >= &**rhs } [INFO] [stderr] | ^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/char.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | if code < MAX_ONE_B && buf.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `ArrayVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:120:1 [INFO] [stderr] | [INFO] [stderr] 120 | / impl ArrayVec { [INFO] [stderr] 121 | | /// Create a new empty `ArrayVec`. [INFO] [stderr] 122 | | /// [INFO] [stderr] 123 | | /// Capacity is inferred from the type parameter. [INFO] [stderr] ... | [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:445:24 [INFO] [stderr] | [INFO] [stderr] 445 | self.drain(index..index + 1).next() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `index..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:845:27 [INFO] [stderr] | [INFO] [stderr] 845 | let src = source_vec.as_ptr().offset(tail as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `source_vec.as_ptr().add(tail)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:846:27 [INFO] [stderr] | [INFO] [stderr] 846 | let dst = source_vec.as_mut_ptr().offset(start as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `source_vec.as_mut_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:881:27 [INFO] [stderr] | [INFO] [stderr] 881 | let mut ptr = self.as_mut_ptr().offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/array_string.rs:214:23 [INFO] [stderr] | [INFO] [stderr] 214 | let dst = self.xs.as_mut_ptr().offset(self.len() as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.xs.as_mut_ptr().add(self.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/array_string.rs:308:23 [INFO] [stderr] | [INFO] [stderr] 308 | ptr::copy(self.xs.as_ptr().offset(next as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.xs.as_ptr().add(next)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/array_string.rs:309:23 [INFO] [stderr] | [INFO] [stderr] 309 | self.xs.as_mut_ptr().offset(idx as isize), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.xs.as_mut_ptr().add(idx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: transmute from a `&mut [u8]` to a `&mut str` [INFO] [stderr] --> src/array_string.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | mem::transmute(sl) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using: `std::str::from_utf8_mut(sl).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_bytes_to_str)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_bytes_to_str [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:447:39 [INFO] [stderr] | [INFO] [stderr] 447 | fn lt(&self, rhs: &str) -> bool { &**self < rhs } [INFO] [stderr] | -------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:448:39 [INFO] [stderr] | [INFO] [stderr] 448 | fn le(&self, rhs: &str) -> bool { &**self <= rhs } [INFO] [stderr] | -------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:449:39 [INFO] [stderr] | [INFO] [stderr] 449 | fn gt(&self, rhs: &str) -> bool { &**self > rhs } [INFO] [stderr] | -------^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/array_string.rs:450:39 [INFO] [stderr] | [INFO] [stderr] 450 | fn ge(&self, rhs: &str) -> bool { &**self >= rhs } [INFO] [stderr] | -------^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `**self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:457:50 [INFO] [stderr] | [INFO] [stderr] 457 | fn lt(&self, rhs: &ArrayString) -> bool { self < &**rhs } [INFO] [stderr] | ^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:458:50 [INFO] [stderr] | [INFO] [stderr] 458 | fn le(&self, rhs: &ArrayString) -> bool { self <= &**rhs } [INFO] [stderr] | ^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:459:50 [INFO] [stderr] | [INFO] [stderr] 459 | fn gt(&self, rhs: &ArrayString) -> bool { self > &**rhs } [INFO] [stderr] | ^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/array_string.rs:460:50 [INFO] [stderr] | [INFO] [stderr] 460 | fn ge(&self, rhs: &ArrayString) -> bool { self >= &**rhs } [INFO] [stderr] | ^^^^^^^^------ [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `**rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/char.rs:33:28 [INFO] [stderr] | [INFO] [stderr] 33 | if code < MAX_ONE_B && buf.len() >= 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `ArrayVec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:120:1 [INFO] [stderr] | [INFO] [stderr] 120 | / impl ArrayVec { [INFO] [stderr] 121 | | /// Create a new empty `ArrayVec`. [INFO] [stderr] 122 | | /// [INFO] [stderr] 123 | | /// Capacity is inferred from the type parameter. [INFO] [stderr] ... | [INFO] [stderr] 601 | | } [INFO] [stderr] 602 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/lib.rs:445:24 [INFO] [stderr] | [INFO] [stderr] 445 | self.drain(index..index + 1).next() [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: use: `index..=index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:845:27 [INFO] [stderr] | [INFO] [stderr] 845 | let src = source_vec.as_ptr().offset(tail as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `source_vec.as_ptr().add(tail)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:846:27 [INFO] [stderr] | [INFO] [stderr] 846 | let dst = source_vec.as_mut_ptr().offset(start as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `source_vec.as_mut_ptr().add(start)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/lib.rs:881:27 [INFO] [stderr] | [INFO] [stderr] 881 | let mut ptr = self.as_mut_ptr().offset(len as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.as_mut_ptr().add(len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> benches/arraystring.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | if !v.try_push(ch).is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `v.try_push(ch).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> tests/tests.rs:149:5 [INFO] [stderr] | [INFO] [stderr] 149 | &data as &Send; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `data;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> tests/tests.rs:150:5 [INFO] [stderr] | [INFO] [stderr] 150 | &data as &Sync; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `data;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> tests/tests.rs:388:16 [INFO] [stderr] | [INFO] [stderr] 388 | if let Err(_) = s.try_push(c) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 389 | | break; [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________- help: try this: `if s.try_push(c).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.48s [INFO] running `"docker" "inspect" "a6bb68d73a8c638f18884b320c272859fed319ed5d9155fb116eed24f71fec43"` [INFO] running `"docker" "rm" "-f" "a6bb68d73a8c638f18884b320c272859fed319ed5d9155fb116eed24f71fec43"` [INFO] [stdout] a6bb68d73a8c638f18884b320c272859fed319ed5d9155fb116eed24f71fec43