[INFO] crate arkecosystem-crypto 0.1.0 is already in cache [INFO] extracting crate arkecosystem-crypto 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/arkecosystem-crypto/0.1.0 [INFO] extracting crate arkecosystem-crypto 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arkecosystem-crypto/0.1.0 [INFO] validating manifest of arkecosystem-crypto-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arkecosystem-crypto-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arkecosystem-crypto-0.1.0 [INFO] finished frobbing arkecosystem-crypto-0.1.0 [INFO] frobbed toml for arkecosystem-crypto-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/arkecosystem-crypto/0.1.0/Cargo.toml [INFO] started frobbing arkecosystem-crypto-0.1.0 [INFO] finished frobbing arkecosystem-crypto-0.1.0 [INFO] frobbed toml for arkecosystem-crypto-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arkecosystem-crypto/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arkecosystem-crypto-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/arkecosystem-crypto/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ca3041fad6c4786c0a4ce05963c7a863636aa822eff17066eb05ca13576a1145 [INFO] running `"docker" "start" "-a" "ca3041fad6c4786c0a4ce05963c7a863636aa822eff17066eb05ca13576a1145"` [INFO] [stderr] Checking bitcoin v0.14.2 [INFO] [stderr] Checking arkecosystem-crypto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/transactions/serializer.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/transactions/serializer.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/transactions/deserializer.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | min: _, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/transactions/deserializer.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | lifetime: _, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MultiSignatureRegistration { ref mut keysgroup, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/transactions/deserializer.rs:288:17 [INFO] [stderr] | [INFO] [stderr] 288 | min: _, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/transactions/deserializer.rs:289:17 [INFO] [stderr] | [INFO] [stderr] 289 | lifetime: _, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `MultiSignatureRegistration { ref mut keysgroup, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enums/transaction_types.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn fee(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | bytes.read(&mut sender_public_key_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | bytes.read(&mut vendor_field_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transactions/deserializer.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | let type_id = transaction.type_id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `transaction.type_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | bytes.read(&mut recipient_id_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | bytes.read(&mut public_key_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:204:8 [INFO] [stderr] | [INFO] [stderr] 204 | if signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:222:12 [INFO] [stderr] | [INFO] [stderr] 222 | if second_signature.len() > 0 && !second_signature.starts_with("ff") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:276:8 [INFO] [stderr] | [INFO] [stderr] 276 | if transaction.second_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/deserializer.rs:286:56 [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => match &mut transaction.asset { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 287 | | &mut Asset::MultiSignatureRegistration { [INFO] [stderr] 288 | | min: _, [INFO] [stderr] 289 | | lifetime: _, [INFO] [stderr] ... | [INFO] [stderr] 297 | | _ => (), [INFO] [stderr] 298 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => if let &mut Asset::MultiSignatureRegistration { [INFO] [stderr] 287 | min: _, [INFO] [stderr] 288 | lifetime: _, [INFO] [stderr] 289 | ref mut keysgroup, [INFO] [stderr] 290 | } = &mut transaction.asset { [INFO] [stderr] 291 | let mut keysgroup = keysgroup.as_mut_slice(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/transactions/deserializer.rs:286:56 [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => match &mut transaction.asset { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 287 | | &mut Asset::MultiSignatureRegistration { [INFO] [stderr] 288 | | min: _, [INFO] [stderr] 289 | | lifetime: _, [INFO] [stderr] ... | [INFO] [stderr] 297 | | _ => (), [INFO] [stderr] 298 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => match *(&mut transaction.asset) { [INFO] [stderr] 287 | Asset::MultiSignatureRegistration { [INFO] [stderr] 288 | min: _, [INFO] [stderr] 289 | lifetime: _, [INFO] [stderr] 290 | ref mut keysgroup, [INFO] [stderr] 291 | } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:302:8 [INFO] [stderr] | [INFO] [stderr] 302 | if transaction.vendor_field_hex.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.vendor_field_hex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | bytes.write(&hex::decode(&transaction.sender_public_key).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | if transaction.vendor_field.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.vendor_field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | bytes.write(transaction.vendor_field.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | } else if transaction.vendor_field_hex.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.vendor_field_hex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / bytes [INFO] [stderr] 37 | | .write(transaction.vendor_field_hex.as_bytes()) [INFO] [stderr] 38 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | bytes.write(&recipient_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / match &transaction.asset { [INFO] [stderr] 76 | | Asset::Signature { public_key } => { [INFO] [stderr] 77 | | let public_key_bytes = hex::decode(public_key).unwrap(); [INFO] [stderr] 78 | | bytes.write(&public_key_bytes).unwrap(); [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | _ => (), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let Asset::Signature { public_key } = &transaction.asset { [INFO] [stderr] 76 | let public_key_bytes = hex::decode(public_key).unwrap(); [INFO] [stderr] 77 | bytes.write(&public_key_bytes).unwrap(); [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | bytes.write(&public_key_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match &transaction.asset { [INFO] [stderr] 86 | | Asset::Delegate { username } => { [INFO] [stderr] 87 | | bytes.write_u8(username.len() as u8).unwrap(); [INFO] [stderr] 88 | | bytes.write(&username.as_bytes()).unwrap(); [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | _ => (), [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let Asset::Delegate { username } = &transaction.asset { [INFO] [stderr] 86 | bytes.write_u8(username.len() as u8).unwrap(); [INFO] [stderr] 87 | bytes.write(&username.as_bytes()).unwrap(); [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | bytes.write(&username.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / match &transaction.asset { [INFO] [stderr] 96 | | Asset::Votes(votes) => { [INFO] [stderr] 97 | | let mut vote_bytes = vec![]; [INFO] [stderr] 98 | | [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => (), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | if let Asset::Votes(votes) = &transaction.asset { [INFO] [stderr] 96 | let mut vote_bytes = vec![]; [INFO] [stderr] 97 | [INFO] [stderr] 98 | for vote in votes { [INFO] [stderr] 99 | let prefix = if vote.starts_with("+") { "01" } else { "00" }; [INFO] [stderr] 100 | let _vote: String = vote.chars().skip(1).collect(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transactions/serializer.rs:100:50 [INFO] [stderr] | [INFO] [stderr] 100 | let prefix = if vote.starts_with("+") { "01" } else { "00" }; [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / bytes [INFO] [stderr] 107 | | .write(&hex::decode(&vote_bytes.join("")).unwrap()) [INFO] [stderr] 108 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match &transaction.asset { [INFO] [stderr] 116 | | Asset::MultiSignatureRegistration { [INFO] [stderr] 117 | | min, [INFO] [stderr] 118 | | keysgroup, [INFO] [stderr] ... | [INFO] [stderr] 140 | | _ => (), [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Asset::MultiSignatureRegistration { [INFO] [stderr] 116 | min, [INFO] [stderr] 117 | keysgroup, [INFO] [stderr] 118 | lifetime, [INFO] [stderr] 119 | } = &transaction.asset { [INFO] [stderr] 120 | let keysgroup_string: String = keysgroup [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transactions/serializer.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | if key.starts_with("+") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | / bytes [INFO] [stderr] 137 | | .write(&hex::decode(keysgroup_string).unwrap()) [INFO] [stderr] 138 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:145:8 [INFO] [stderr] | [INFO] [stderr] 145 | if transaction.signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | bytes.write(&signature_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:150:8 [INFO] [stderr] | [INFO] [stderr] 150 | if transaction.second_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | bytes.write(&second_signature_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:153:15 [INFO] [stderr] | [INFO] [stderr] 153 | } else if transaction.sign_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.sign_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | bytes.write(&sign_signature_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:158:8 [INFO] [stderr] | [INFO] [stderr] 158 | if transaction.signatures.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.signatures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | bytes.write(&signatures_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enums/transaction_types.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn fee(&self) -> u64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | bytes.read(&mut sender_public_key_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | bytes.read(&mut vendor_field_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transactions/deserializer.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | let type_id = transaction.type_id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `transaction.type_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:100:5 [INFO] [stderr] | [INFO] [stderr] 100 | bytes.read(&mut recipient_id_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transactions/transaction.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | buffer.write_u8(self.type_id.clone() as u8).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:130:31 [INFO] [stderr] | [INFO] [stderr] 130 | let recipient_id = if self.recipient_id.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.recipient_id.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | let vendor_field: Vec = if self.vendor_field.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.vendor_field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/transactions/transaction.rs:162:32 [INFO] [stderr] | [INFO] [stderr] 162 | let payload: Vec = match &self.asset { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 163 | | &Asset::Signature { ref public_key } => hex::decode(&public_key).unwrap(), [INFO] [stderr] 164 | | &Asset::Delegate { ref username } => username.to_owned().as_bytes().to_vec(), [INFO] [stderr] 165 | | &Asset::Votes(ref votes) => votes.join("").as_bytes().to_vec(), [INFO] [stderr] ... | [INFO] [stderr] 178 | | _ => vec![], [INFO] [stderr] 179 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 162 | let payload: Vec = match self.asset { [INFO] [stderr] 163 | Asset::Signature { ref public_key } => hex::decode(&public_key).unwrap(), [INFO] [stderr] 164 | Asset::Delegate { ref username } => username.to_owned().as_bytes().to_vec(), [INFO] [stderr] 165 | Asset::Votes(ref votes) => votes.join("").as_bytes().to_vec(), [INFO] [stderr] 166 | Asset::MultiSignatureRegistration { [INFO] [stderr] 167 | min, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/transactions/deserializer.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | bytes.read(&mut public_key_buf).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:184:31 [INFO] [stderr] | [INFO] [stderr] 184 | if !skip_signature && self.signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:189:38 [INFO] [stderr] | [INFO] [stderr] 189 | if !skip_second_signature && self.second_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:204:8 [INFO] [stderr] | [INFO] [stderr] 204 | if signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:222:12 [INFO] [stderr] | [INFO] [stderr] 222 | if second_signature.len() > 0 && !second_signature.starts_with("ff") { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:276:8 [INFO] [stderr] | [INFO] [stderr] 276 | if transaction.second_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/deserializer.rs:286:56 [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => match &mut transaction.asset { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 287 | | &mut Asset::MultiSignatureRegistration { [INFO] [stderr] 288 | | min: _, [INFO] [stderr] 289 | | lifetime: _, [INFO] [stderr] ... | [INFO] [stderr] 297 | | _ => (), [INFO] [stderr] 298 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => if let &mut Asset::MultiSignatureRegistration { [INFO] [stderr] 287 | min: _, [INFO] [stderr] 288 | lifetime: _, [INFO] [stderr] 289 | ref mut keysgroup, [INFO] [stderr] 290 | } = &mut transaction.asset { [INFO] [stderr] 291 | let mut keysgroup = keysgroup.as_mut_slice(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/transactions/deserializer.rs:286:56 [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => match &mut transaction.asset { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 287 | | &mut Asset::MultiSignatureRegistration { [INFO] [stderr] 288 | | min: _, [INFO] [stderr] 289 | | lifetime: _, [INFO] [stderr] ... | [INFO] [stderr] 297 | | _ => (), [INFO] [stderr] 298 | | }, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 286 | TransactionType::MultiSignatureRegistration => match *(&mut transaction.asset) { [INFO] [stderr] 287 | Asset::MultiSignatureRegistration { [INFO] [stderr] 288 | min: _, [INFO] [stderr] 289 | lifetime: _, [INFO] [stderr] 290 | ref mut keysgroup, [INFO] [stderr] 291 | } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/deserializer.rs:302:8 [INFO] [stderr] | [INFO] [stderr] 302 | if transaction.vendor_field_hex.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.vendor_field_hex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | bytes.write(&hex::decode(&transaction.sender_public_key).unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:29:8 [INFO] [stderr] | [INFO] [stderr] 29 | if transaction.vendor_field.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.vendor_field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:32:9 [INFO] [stderr] | [INFO] [stderr] 32 | bytes.write(transaction.vendor_field.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:33:15 [INFO] [stderr] | [INFO] [stderr] 33 | } else if transaction.vendor_field_hex.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.vendor_field_hex.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | / bytes [INFO] [stderr] 37 | | .write(transaction.vendor_field_hex.as_bytes()) [INFO] [stderr] 38 | | .unwrap(); [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | bytes.write(&recipient_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | / match &transaction.asset { [INFO] [stderr] 76 | | Asset::Signature { public_key } => { [INFO] [stderr] 77 | | let public_key_bytes = hex::decode(public_key).unwrap(); [INFO] [stderr] 78 | | bytes.write(&public_key_bytes).unwrap(); [INFO] [stderr] 79 | | } [INFO] [stderr] 80 | | _ => (), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let Asset::Signature { public_key } = &transaction.asset { [INFO] [stderr] 76 | let public_key_bytes = hex::decode(public_key).unwrap(); [INFO] [stderr] 77 | bytes.write(&public_key_bytes).unwrap(); [INFO] [stderr] 78 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | bytes.write(&public_key_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / match &transaction.asset { [INFO] [stderr] 86 | | Asset::Delegate { username } => { [INFO] [stderr] 87 | | bytes.write_u8(username.len() as u8).unwrap(); [INFO] [stderr] 88 | | bytes.write(&username.as_bytes()).unwrap(); [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | _ => (), [INFO] [stderr] 91 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | if let Asset::Delegate { username } = &transaction.asset { [INFO] [stderr] 86 | bytes.write_u8(username.len() as u8).unwrap(); [INFO] [stderr] 87 | bytes.write(&username.as_bytes()).unwrap(); [INFO] [stderr] 88 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | bytes.write(&username.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | / match &transaction.asset { [INFO] [stderr] 96 | | Asset::Votes(votes) => { [INFO] [stderr] 97 | | let mut vote_bytes = vec![]; [INFO] [stderr] 98 | | [INFO] [stderr] ... | [INFO] [stderr] 110 | | _ => (), [INFO] [stderr] 111 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 95 | if let Asset::Votes(votes) = &transaction.asset { [INFO] [stderr] 96 | let mut vote_bytes = vec![]; [INFO] [stderr] 97 | [INFO] [stderr] 98 | for vote in votes { [INFO] [stderr] 99 | let prefix = if vote.starts_with("+") { "01" } else { "00" }; [INFO] [stderr] 100 | let _vote: String = vote.chars().skip(1).collect(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transactions/serializer.rs:100:50 [INFO] [stderr] | [INFO] [stderr] 100 | let prefix = if vote.starts_with("+") { "01" } else { "00" }; [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | / bytes [INFO] [stderr] 107 | | .write(&hex::decode(&vote_bytes.join("")).unwrap()) [INFO] [stderr] 108 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/transactions/serializer.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / match &transaction.asset { [INFO] [stderr] 116 | | Asset::MultiSignatureRegistration { [INFO] [stderr] 117 | | min, [INFO] [stderr] 118 | | keysgroup, [INFO] [stderr] ... | [INFO] [stderr] 140 | | _ => (), [INFO] [stderr] 141 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 115 | if let Asset::MultiSignatureRegistration { [INFO] [stderr] 116 | min, [INFO] [stderr] 117 | keysgroup, [INFO] [stderr] 118 | lifetime, [INFO] [stderr] 119 | } = &transaction.asset { [INFO] [stderr] 120 | let keysgroup_string: String = keysgroup [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/transactions/serializer.rs:124:40 [INFO] [stderr] | [INFO] [stderr] 124 | if key.starts_with("+") { [INFO] [stderr] | ^^^ help: try using a char instead: `'+'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:136:13 [INFO] [stderr] | [INFO] [stderr] 136 | / bytes [INFO] [stderr] 137 | | .write(&hex::decode(keysgroup_string).unwrap()) [INFO] [stderr] 138 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:145:8 [INFO] [stderr] | [INFO] [stderr] 145 | if transaction.signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | bytes.write(&signature_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:150:8 [INFO] [stderr] | [INFO] [stderr] 150 | if transaction.second_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:152:9 [INFO] [stderr] | [INFO] [stderr] 152 | bytes.write(&second_signature_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:153:15 [INFO] [stderr] | [INFO] [stderr] 153 | } else if transaction.sign_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.sign_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:155:9 [INFO] [stderr] | [INFO] [stderr] 155 | bytes.write(&sign_signature_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/serializer.rs:158:8 [INFO] [stderr] | [INFO] [stderr] 158 | if transaction.signatures.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!transaction.signatures.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/transactions/serializer.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | bytes.write(&signatures_bytes).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: Could not compile `arkecosystem-crypto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/transactions/transaction.rs:125:25 [INFO] [stderr] | [INFO] [stderr] 125 | buffer.write_u8(self.type_id.clone() as u8).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.type_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:130:31 [INFO] [stderr] | [INFO] [stderr] 130 | let recipient_id = if self.recipient_id.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.recipient_id.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:138:40 [INFO] [stderr] | [INFO] [stderr] 138 | let vendor_field: Vec = if self.vendor_field.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.vendor_field.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/transactions/transaction.rs:162:32 [INFO] [stderr] | [INFO] [stderr] 162 | let payload: Vec = match &self.asset { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 163 | | &Asset::Signature { ref public_key } => hex::decode(&public_key).unwrap(), [INFO] [stderr] 164 | | &Asset::Delegate { ref username } => username.to_owned().as_bytes().to_vec(), [INFO] [stderr] 165 | | &Asset::Votes(ref votes) => votes.join("").as_bytes().to_vec(), [INFO] [stderr] ... | [INFO] [stderr] 178 | | _ => vec![], [INFO] [stderr] 179 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 162 | let payload: Vec = match self.asset { [INFO] [stderr] 163 | Asset::Signature { ref public_key } => hex::decode(&public_key).unwrap(), [INFO] [stderr] 164 | Asset::Delegate { ref username } => username.to_owned().as_bytes().to_vec(), [INFO] [stderr] 165 | Asset::Votes(ref votes) => votes.join("").as_bytes().to_vec(), [INFO] [stderr] 166 | Asset::MultiSignatureRegistration { [INFO] [stderr] 167 | min, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:184:31 [INFO] [stderr] | [INFO] [stderr] 184 | if !skip_signature && self.signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/transactions/transaction.rs:189:38 [INFO] [stderr] | [INFO] [stderr] 189 | if !skip_second_signature && self.second_signature.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.second_signature.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `arkecosystem-crypto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ca3041fad6c4786c0a4ce05963c7a863636aa822eff17066eb05ca13576a1145"` [INFO] running `"docker" "rm" "-f" "ca3041fad6c4786c0a4ce05963c7a863636aa822eff17066eb05ca13576a1145"` [INFO] [stdout] ca3041fad6c4786c0a4ce05963c7a863636aa822eff17066eb05ca13576a1145