[INFO] crate arguments 0.6.2 is already in cache [INFO] extracting crate arguments 0.6.2 into work/ex/clippy-test-run/sources/stable/reg/arguments/0.6.2 [INFO] extracting crate arguments 0.6.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arguments/0.6.2 [INFO] validating manifest of arguments-0.6.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of arguments-0.6.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing arguments-0.6.2 [INFO] finished frobbing arguments-0.6.2 [INFO] frobbed toml for arguments-0.6.2 written to work/ex/clippy-test-run/sources/stable/reg/arguments/0.6.2/Cargo.toml [INFO] started frobbing arguments-0.6.2 [INFO] finished frobbing arguments-0.6.2 [INFO] frobbed toml for arguments-0.6.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/arguments/0.6.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting arguments-0.6.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/arguments/0.6.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56319dfdedd3bbe6b0bb8eaeedd3117c623badf602fd7dadeb80354999d5906e [INFO] running `"docker" "start" "-a" "56319dfdedd3bbe6b0bb8eaeedd3117c623badf602fd7dadeb80354999d5906e"` [INFO] [stderr] Checking options v0.5.1 [INFO] [stderr] Checking arguments v0.6.2 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::Parser` [INFO] [stderr] --> src/parser.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Parser { [INFO] [stderr] 12 | | Parser { _private: () } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | arguments.options.set(&name, String::from(chunk)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::Parser` [INFO] [stderr] --> src/parser.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Parser { [INFO] [stderr] 12 | | Parser { _private: () } [INFO] [stderr] 13 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 4 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/parser.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | arguments.options.set(&name, String::from(chunk)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `chunk` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match Parser::new().parse(strings!(arguments)) { [INFO] [stderr] 76 | | Ok(_) => unreachable!(), [INFO] [stderr] 77 | | Err(_) => {}, [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = Parser::new().parse(strings!(arguments)) { unreachable!() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.56s [INFO] running `"docker" "inspect" "56319dfdedd3bbe6b0bb8eaeedd3117c623badf602fd7dadeb80354999d5906e"` [INFO] running `"docker" "rm" "-f" "56319dfdedd3bbe6b0bb8eaeedd3117c623badf602fd7dadeb80354999d5906e"` [INFO] [stdout] 56319dfdedd3bbe6b0bb8eaeedd3117c623badf602fd7dadeb80354999d5906e