[INFO] crate args 2.2.0 is already in cache
[INFO] extracting crate args 2.2.0 into work/ex/clippy-test-run/sources/stable/reg/args/2.2.0
[INFO] extracting crate args 2.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/args/2.2.0
[INFO] validating manifest of args-2.2.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of args-2.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing args-2.2.0
[INFO] finished frobbing args-2.2.0
[INFO] frobbed toml for args-2.2.0 written to work/ex/clippy-test-run/sources/stable/reg/args/2.2.0/Cargo.toml
[INFO] started frobbing args-2.2.0
[INFO] finished frobbing args-2.2.0
[INFO] frobbed toml for args-2.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/args/2.2.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting args-2.2.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/args/2.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 82eee3d125f91c56a1dab5dc75fdfdc4b1be79adb18330bd1101cc8f864ae35a
[INFO] running `"docker" "start" "-a" "82eee3d125f91c56a1dab5dc75fdfdc4b1be79adb18330bd1101cc8f864ae35a"`
[INFO] [stderr]     Checking args v2.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/validations/mod.rs:87:49
[INFO] [stderr]    |
[INFO] [stderr] 87 |         OrderValidation { bound: bound.clone(), order: order }
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/errors.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |         ArgsError { desc: desc }
[INFO] [stderr]    |                     ^^^^^^^^^^ help: replace it with: `desc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/options/mod.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             has_arg: has_arg,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `has_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/options/mod.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             occur: occur,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `occur`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/options/mod.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             default: default
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]   --> src/validations/mod.rs:87:49
[INFO] [stderr]    |
[INFO] [stderr] 87 |         OrderValidation { bound: bound.clone(), order: order }
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^ help: replace it with: `order`
[INFO] [stderr]    |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]   --> src/lib.rs:103:24
[INFO] [stderr]    |
[INFO] [stderr] 103| #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]    |                        ^^^^^^^^
[INFO] [stderr]    = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)]
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]   --> src/errors.rs:32:21
[INFO] [stderr]    |
[INFO] [stderr] 32 |         ArgsError { desc: desc }
[INFO] [stderr]    |                     ^^^^^^^^^^ help: replace it with: `desc`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/options/mod.rs:128:13
[INFO] [stderr]     |
[INFO] [stderr] 128 |             has_arg: has_arg,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `has_arg`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/options/mod.rs:129:13
[INFO] [stderr]     |
[INFO] [stderr] 129 |             occur: occur,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `occur`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] error: redundant field names in struct initialization
[INFO] [stderr]    --> src/options/mod.rs:130:13
[INFO] [stderr]     |
[INFO] [stderr] 130 |             default: default
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `default`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:130:21
[INFO] [stderr]     |
[INFO] [stderr] 130 | const SCOPE_PARSE: &'static str = "parse";
[INFO] [stderr]     |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:131:19
[INFO] [stderr]     |
[INFO] [stderr] 131 | const SEPARATOR: &'static str = ",";
[INFO] [stderr]     |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:257:20
[INFO] [stderr]     |
[INFO] [stderr] 257 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 258 | |                 if opt.is_required() {
[INFO] [stderr] 259 | |                     return Err(ArgsError::new(SCOPE_PARSE, &Fail::ArgumentMissing(opt_name.to_string()).to_string()));
[INFO] [stderr] 260 | |                 }
[INFO] [stderr] 261 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 257 |             } else if opt.is_required() {
[INFO] [stderr] 258 |     return Err(ArgsError::new(SCOPE_PARSE, &Fail::ArgumentMissing(opt_name.to_string()).to_string()));
[INFO] [stderr] 259 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:130:21
[INFO] [stderr]     |
[INFO] [stderr] 130 | const SCOPE_PARSE: &'static str = "parse";
[INFO] [stderr]     |                    -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::const_static_lifetime)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] error: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> src/lib.rs:131:19
[INFO] [stderr]     |
[INFO] [stderr] 131 | const SEPARATOR: &'static str = ",";
[INFO] [stderr]     |                  -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] error: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:257:20
[INFO] [stderr]     |
[INFO] [stderr] 257 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 258 | |                 if opt.is_required() {
[INFO] [stderr] 259 | |                     return Err(ArgsError::new(SCOPE_PARSE, &Fail::ArgumentMissing(opt_name.to_string()).to_string()));
[INFO] [stderr] 260 | |                 }
[INFO] [stderr] 261 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: lint level defined here
[INFO] [stderr]    --> src/lib.rs:103:24
[INFO] [stderr]     |
[INFO] [stderr] 103 | #![cfg_attr(test, deny(warnings))]
[INFO] [stderr]     |                        ^^^^^^^^
[INFO] [stderr]     = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)]
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 257 |             } else if opt.is_required() {
[INFO] [stderr] 258 |     return Err(ArgsError::new(SCOPE_PARSE, &Fail::ArgumentMissing(opt_name.to_string()).to_string()));
[INFO] [stderr] 259 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:254:45
[INFO] [stderr]     |
[INFO] [stderr] 254 |             let value = opt.parse(&matches).unwrap_or("".to_string());
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:348:35
[INFO] [stderr]     |
[INFO] [stderr] 348 |           self.values.get(opt_name).ok_or(
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 349 | |             ArgsError::new(opt_name, "does not have a value")
[INFO] [stderr] 350 | |         ).and_then(|value_string| {
[INFO] [stderr]     | |_________^ help: try this: `ok_or_else(|| ArgsError::new(opt_name, "does not have a value"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:351:39
[INFO] [stderr]     |
[INFO] [stderr] 351 |               T::from_str(value_string).or(
[INFO] [stderr]     |  _______________________________________^
[INFO] [stderr] 352 | |                 Err(ArgsError::new(opt_name, &format!("unable to parse '{}'", value_string)))
[INFO] [stderr] 353 | |             )
[INFO] [stderr]     | |_____________^ help: try this: `or_else(|_| Err(ArgsError::new(opt_name, &format!("unable to parse '{}'", value_string))))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:365:35
[INFO] [stderr]     |
[INFO] [stderr] 365 |           self.values.get(opt_name).ok_or(
[INFO] [stderr]     |  ___________________________________^
[INFO] [stderr] 366 | |             ArgsError::new(opt_name, "does not have a value")
[INFO] [stderr] 367 | |         ).and_then(|values_str| {
[INFO] [stderr]     | |_________^ help: try this: `ok_or_else(|| ArgsError::new(opt_name, "does not have a value"))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:369:36
[INFO] [stderr]     |
[INFO] [stderr] 369 |                   T::from_str(value).or(
[INFO] [stderr]     |  ____________________________________^
[INFO] [stderr] 370 | |                     Err(ArgsError::new(opt_name, &format!("unable to parse '{}'", value)))
[INFO] [stderr] 371 | |                 )
[INFO] [stderr]     | |_________________^ help: try this: `or_else(|_| Err(ArgsError::new(opt_name, &format!("unable to parse '{}'", value))))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: You are using an explicit closure for cloning elements
[INFO] [stderr]    --> src/lib.rs:382:9
[INFO] [stderr]     |
[INFO] [stderr] 382 |         self.opts.get(opt_name).map(|opt| opt.clone())
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.opts.get(opt_name).cloned()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::map_clone)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 8 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `args`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "82eee3d125f91c56a1dab5dc75fdfdc4b1be79adb18330bd1101cc8f864ae35a"`
[INFO] running `"docker" "rm" "-f" "82eee3d125f91c56a1dab5dc75fdfdc4b1be79adb18330bd1101cc8f864ae35a"`
[INFO] [stdout] 82eee3d125f91c56a1dab5dc75fdfdc4b1be79adb18330bd1101cc8f864ae35a