[INFO] crate argparse 0.2.2 is already in cache [INFO] extracting crate argparse 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/argparse/0.2.2 [INFO] extracting crate argparse 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/argparse/0.2.2 [INFO] validating manifest of argparse-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of argparse-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing argparse-0.2.2 [INFO] finished frobbing argparse-0.2.2 [INFO] frobbed toml for argparse-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/argparse/0.2.2/Cargo.toml [INFO] started frobbing argparse-0.2.2 [INFO] finished frobbing argparse-0.2.2 [INFO] frobbed toml for argparse-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/argparse/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting argparse-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/argparse/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 74c6abb933e18b12c4b5134fbac3d69782845d0bfedb67361c1109b4fcde4ba9 [INFO] running `"docker" "start" "-a" "74c6abb933e18b12c4b5134fbac3d69782845d0bfedb67361c1109b4fcde4ba9"` [INFO] [stderr] Checking argparse v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser.rs:410:29 [INFO] [stderr] | [INFO] [stderr] 410 | / write!(self.stderr, [INFO] [stderr] 411 | | "WARNING: Environment variable {}: {}\n", [INFO] [stderr] 412 | | evar.name, err).ok(); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:472:13 [INFO] [stderr] | [INFO] [stderr] 472 | stderr: stderr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stderr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | help: help, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `help` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:656:17 [INFO] [stderr] | [INFO] [stderr] 656 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:690:13 [INFO] [stderr] | [INFO] [stderr] 690 | help: help, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `help` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:691:13 [INFO] [stderr] | [INFO] [stderr] 691 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | write!(writer, "{}: {}\n", command, message).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:824:32 [INFO] [stderr] | [INFO] [stderr] 824 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:824:48 [INFO] [stderr] | [INFO] [stderr] 824 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:831:32 [INFO] [stderr] | [INFO] [stderr] 831 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:831:48 [INFO] [stderr] | [INFO] [stderr] 831 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:37:49 [INFO] [stderr] | [INFO] [stderr] 37 | return Flag(Box::new(StoreConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:44:48 [INFO] [stderr] | [INFO] [stderr] 44 | return Flag(Box::new(PushConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | return Single(Box::new(StoreAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:56:52 [INFO] [stderr] | [INFO] [stderr] 56 | return Single(Box::new(StoreOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:62:43 [INFO] [stderr] | [INFO] [stderr] 62 | return Many(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:68:43 [INFO] [stderr] | [INFO] [stderr] 68 | return Push(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | return Single(Box::new(ParseAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:31:52 [INFO] [stderr] | [INFO] [stderr] 31 | return Single(Box::new(ParseOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | return Many(Box::new(ParseListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | return Push(Box::new(ParseListAction { cell: cell })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/help.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bool.rs:13:49 [INFO] [stderr] | [INFO] [stderr] 13 | return Flag(Box::new(StoreConstAction { cell: cell, value: true })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bool.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | return Flag(Box::new(StoreConstAction { cell: cell, value: false })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/num.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | return Flag(Box::new(IncrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/num.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | return Flag(Box::new(DecrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser.rs:410:29 [INFO] [stderr] | [INFO] [stderr] 410 | / write!(self.stderr, [INFO] [stderr] 411 | | "WARNING: Environment variable {}: {}\n", [INFO] [stderr] 412 | | evar.name, err).ok(); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:466:13 [INFO] [stderr] | [INFO] [stderr] 466 | parser: parser, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:472:13 [INFO] [stderr] | [INFO] [stderr] 472 | stderr: stderr, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stderr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:547:13 [INFO] [stderr] | [INFO] [stderr] 547 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:548:13 [INFO] [stderr] | [INFO] [stderr] 548 | help: help, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `help` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:656:17 [INFO] [stderr] | [INFO] [stderr] 656 | id: id, [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:690:13 [INFO] [stderr] | [INFO] [stderr] 690 | help: help, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `help` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:691:13 [INFO] [stderr] | [INFO] [stderr] 691 | action: action, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/parser.rs:764:9 [INFO] [stderr] | [INFO] [stderr] 764 | write!(writer, "{}: {}\n", command, message).ok(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:824:32 [INFO] [stderr] | [INFO] [stderr] 824 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:824:48 [INFO] [stderr] | [INFO] [stderr] 824 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:831:32 [INFO] [stderr] | [INFO] [stderr] 831 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `parser` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:831:48 [INFO] [stderr] | [INFO] [stderr] 831 | return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:37:49 [INFO] [stderr] | [INFO] [stderr] 37 | return Flag(Box::new(StoreConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:44:48 [INFO] [stderr] | [INFO] [stderr] 44 | return Flag(Box::new(PushConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | return Single(Box::new(StoreAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:56:52 [INFO] [stderr] | [INFO] [stderr] 56 | return Single(Box::new(StoreOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:62:43 [INFO] [stderr] | [INFO] [stderr] 62 | return Many(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/generic.rs:68:43 [INFO] [stderr] | [INFO] [stderr] 68 | return Push(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:25:46 [INFO] [stderr] | [INFO] [stderr] 25 | return Single(Box::new(ParseAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:31:52 [INFO] [stderr] | [INFO] [stderr] 31 | return Single(Box::new(ParseOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:37:48 [INFO] [stderr] | [INFO] [stderr] 37 | return Many(Box::new(ParseListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/custom.rs:45:48 [INFO] [stderr] | [INFO] [stderr] 45 | return Push(Box::new(ParseListAction { cell: cell })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/help.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bool.rs:13:49 [INFO] [stderr] | [INFO] [stderr] 13 | return Flag(Box::new(StoreConstAction { cell: cell, value: true })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bool.rs:19:49 [INFO] [stderr] | [INFO] [stderr] 19 | return Flag(Box::new(StoreConstAction { cell: cell, value: false })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/num.rs:24:45 [INFO] [stderr] | [INFO] [stderr] 24 | return Flag(Box::new(IncrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/num.rs:31:45 [INFO] [stderr] | [INFO] [stderr] 31 | return Flag(Box::new(DecrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return match char1 { [INFO] [stderr] 52 | | Some('-') => match char2 { [INFO] [stderr] 53 | | Some('-') => match char3 { [INFO] [stderr] 54 | | Some(_) => LongOption, // --opt [INFO] [stderr] ... | [INFO] [stderr] 60 | | Some(_) | None => Positional, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | match char1 { [INFO] [stderr] 52 | Some('-') => match char2 { [INFO] [stderr] 53 | Some('-') => match char3 { [INFO] [stderr] 54 | Some(_) => LongOption, // --opt [INFO] [stderr] 55 | None => Delimiter, // just -- [INFO] [stderr] 56 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return self.id == other.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id == other.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return self.id == other.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id == other.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.id == other.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id == other.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | return action.parse_arg(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `action.parse_arg(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:221:33 [INFO] [stderr] | [INFO] [stderr] 221 | / return Error(format!( [INFO] [stderr] 222 | | "Option {} does not accept an argument", [INFO] [stderr] 223 | | optname)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 221 | Error(format!( [INFO] [stderr] 222 | "Option {} does not accept an argument", [INFO] [stderr] 223 | optname)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:232:33 [INFO] [stderr] | [INFO] [stderr] 232 | return action.parse_flag(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `action.parse_flag()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:237:25 [INFO] [stderr] | [INFO] [stderr] 237 | return self.parse_option(opt.clone(), valueref); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_option(opt.clone(), valueref)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | return Error(format!("Unknown option {}", arg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Unknown option {}", arg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:459:9 [INFO] [stderr] | [INFO] [stderr] 459 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:572:9 [INFO] [stderr] | [INFO] [stderr] 572 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:582:9 [INFO] [stderr] | [INFO] [stderr] 582 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:592:9 [INFO] [stderr] | [INFO] [stderr] 592 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:605:9 [INFO] [stderr] | [INFO] [stderr] 605 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:644:9 [INFO] [stderr] | [INFO] [stderr] 644 | return ap; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:660:9 [INFO] [stderr] | [INFO] [stderr] 660 | / return Box::new(Ref { [INFO] [stderr] 661 | | cell: cell.clone(), [INFO] [stderr] 662 | | varid: id, [INFO] [stderr] 663 | | parser: self, [INFO] [stderr] 664 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 660 | Box::new(Ref { [INFO] [stderr] 661 | cell: cell.clone(), [INFO] [stderr] 662 | varid: id, [INFO] [stderr] 663 | parser: self, [INFO] [stderr] 664 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:724:9 [INFO] [stderr] | [INFO] [stderr] 724 | return HelpFormatter::print_help(self, name, writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HelpFormatter::print_help(self, name, writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:732:9 [INFO] [stderr] | [INFO] [stderr] 732 | return HelpFormatter::print_usage(self, name, writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HelpFormatter::print_usage(self, name, writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:745:23 [INFO] [stderr] | [INFO] [stderr] 745 | Parsed => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:746:21 [INFO] [stderr] | [INFO] [stderr] 746 | Exit => return Err(0), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:749:17 [INFO] [stderr] | [INFO] [stderr] 749 | return Err(0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:753:17 [INFO] [stderr] | [INFO] [stderr] 753 | return Err(2); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:798:9 [INFO] [stderr] | [INFO] [stderr] 798 | / return self.parse(env::args().collect(), [INFO] [stderr] 799 | | &mut stdout(), &mut stderr()); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 798 | self.parse(env::args().collect(), [INFO] [stderr] 799 | &mut stdout(), &mut stderr()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:824:9 [INFO] [stderr] | [INFO] [stderr] 824 | / return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 825 | | .write_usage(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 824 | HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 825 | .write_usage() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:831:9 [INFO] [stderr] | [INFO] [stderr] 831 | / return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 832 | | .write_help(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 831 | HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 832 | .write_help() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:853:9 [INFO] [stderr] | [INFO] [stderr] 853 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:889:9 [INFO] [stderr] | [INFO] [stderr] 889 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:921:9 [INFO] [stderr] | [INFO] [stderr] 921 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:964:9 [INFO] [stderr] | [INFO] [stderr] 964 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Flag(Box::new(StoreConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(StoreConstAction { cell: cell, value: val.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Flag(Box::new(PushConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(PushConstAction { cell: cell, value: val.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return Single(Box::new(StoreAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(StoreAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return Single(Box::new(StoreOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(StoreOptionAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Many(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Many(Box::new(ListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return Push(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Push(Box::new(ListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | return Error(format!("Bad value {}", arg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {}", arg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Error(format!("Bad value {}", arg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {}", arg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return Single(Box::new(ParseAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(ParseAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return Single(Box::new(ParseOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(ParseOptionAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Many(Box::new(ParseListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Many(Box::new(ParseListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Push(Box::new(ParseListAction { cell: cell })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Push(Box::new(ParseListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | return Error(format!("Bad value {:?}: {}", arg, error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {:?}: {}", arg, error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | return Error(format!("Bad value {:?}: {}", arg, error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {:?}: {}", arg, error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return Help; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Help` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return WordsIter { [INFO] [stderr] 25 | | data: data, [INFO] [stderr] 26 | | iter: data.char_indices(), [INFO] [stderr] 27 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | WordsIter { [INFO] [stderr] 25 | data: data, [INFO] [stderr] 26 | iter: data.char_indices(), [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Some(&self.data[word_start..self.data.len()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.data[word_start..self.data.len()])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/help.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | Some((idx, ch)) => ((idx, ch)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/help.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | Some((idx, ch)) => ((idx, ch)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/print.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return ParseResult::Exit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseResult::Exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bool.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return Flag(Box::new(StoreConstAction { cell: cell, value: true })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(StoreConstAction { cell: cell, value: true }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bool.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return Flag(Box::new(StoreConstAction { cell: cell, value: false })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(StoreConstAction { cell: cell, value: false }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return Flag(Box::new(IncrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(IncrByAction { cell: cell, delta: delta.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return Flag(Box::new(DecrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(DecrByAction { cell: cell, delta: delta.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:51:9 [INFO] [stderr] | [INFO] [stderr] 51 | / return match char1 { [INFO] [stderr] 52 | | Some('-') => match char2 { [INFO] [stderr] 53 | | Some('-') => match char3 { [INFO] [stderr] 54 | | Some(_) => LongOption, // --opt [INFO] [stderr] ... | [INFO] [stderr] 60 | | Some(_) | None => Positional, [INFO] [stderr] 61 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 51 | match char1 { [INFO] [stderr] 52 | Some('-') => match char2 { [INFO] [stderr] 53 | Some('-') => match char3 { [INFO] [stderr] 54 | Some(_) => LongOption, // --opt [INFO] [stderr] 55 | None => Delimiter, // just -- [INFO] [stderr] 56 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:95:9 [INFO] [stderr] | [INFO] [stderr] 95 | return self.id == other.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id == other.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | return self.id == other.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id == other.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:129:9 [INFO] [stderr] | [INFO] [stderr] 129 | return self.id == other.id; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.id == other.id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:173:17 [INFO] [stderr] | [INFO] [stderr] 173 | return action.parse_arg(value); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `action.parse_arg(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:180:17 [INFO] [stderr] | [INFO] [stderr] 180 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:204:17 [INFO] [stderr] | [INFO] [stderr] 204 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:221:33 [INFO] [stderr] | [INFO] [stderr] 221 | / return Error(format!( [INFO] [stderr] 222 | | "Option {} does not accept an argument", [INFO] [stderr] 223 | | optname)); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 221 | Error(format!( [INFO] [stderr] 222 | "Option {} does not accept an argument", [INFO] [stderr] 223 | optname)) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:232:33 [INFO] [stderr] | [INFO] [stderr] 232 | return action.parse_flag(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `action.parse_flag()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:237:25 [INFO] [stderr] | [INFO] [stderr] 237 | return self.parse_option(opt.clone(), valueref); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.parse_option(opt.clone(), valueref)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:242:17 [INFO] [stderr] | [INFO] [stderr] 242 | return Error(format!("Unknown option {}", arg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Unknown option {}", arg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:280:9 [INFO] [stderr] | [INFO] [stderr] 280 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:397:9 [INFO] [stderr] | [INFO] [stderr] 397 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:420:9 [INFO] [stderr] | [INFO] [stderr] 420 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:459:9 [INFO] [stderr] | [INFO] [stderr] 459 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:500:9 [INFO] [stderr] | [INFO] [stderr] 500 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:572:9 [INFO] [stderr] | [INFO] [stderr] 572 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:582:9 [INFO] [stderr] | [INFO] [stderr] 582 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:592:9 [INFO] [stderr] | [INFO] [stderr] 592 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:605:9 [INFO] [stderr] | [INFO] [stderr] 605 | return self; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:644:9 [INFO] [stderr] | [INFO] [stderr] 644 | return ap; [INFO] [stderr] | ^^^^^^^^^^ help: remove `return` as shown: `ap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:660:9 [INFO] [stderr] | [INFO] [stderr] 660 | / return Box::new(Ref { [INFO] [stderr] 661 | | cell: cell.clone(), [INFO] [stderr] 662 | | varid: id, [INFO] [stderr] 663 | | parser: self, [INFO] [stderr] 664 | | }); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 660 | Box::new(Ref { [INFO] [stderr] 661 | cell: cell.clone(), [INFO] [stderr] 662 | varid: id, [INFO] [stderr] 663 | parser: self, [INFO] [stderr] 664 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:724:9 [INFO] [stderr] | [INFO] [stderr] 724 | return HelpFormatter::print_help(self, name, writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HelpFormatter::print_help(self, name, writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:732:9 [INFO] [stderr] | [INFO] [stderr] 732 | return HelpFormatter::print_usage(self, name, writer); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HelpFormatter::print_usage(self, name, writer)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:745:23 [INFO] [stderr] | [INFO] [stderr] 745 | Parsed => return Ok(()), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:746:21 [INFO] [stderr] | [INFO] [stderr] 746 | Exit => return Err(0), [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `Err(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:749:17 [INFO] [stderr] | [INFO] [stderr] 749 | return Err(0); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:753:17 [INFO] [stderr] | [INFO] [stderr] 753 | return Err(2); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:798:9 [INFO] [stderr] | [INFO] [stderr] 798 | / return self.parse(env::args().collect(), [INFO] [stderr] 799 | | &mut stdout(), &mut stderr()); [INFO] [stderr] | |__________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 798 | self.parse(env::args().collect(), [INFO] [stderr] 799 | &mut stdout(), &mut stderr()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:824:9 [INFO] [stderr] | [INFO] [stderr] 824 | / return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 825 | | .write_usage(); [INFO] [stderr] | |___________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 824 | HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 825 | .write_usage() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:831:9 [INFO] [stderr] | [INFO] [stderr] 831 | / return HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 832 | | .write_help(); [INFO] [stderr] | |__________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 831 | HelpFormatter { parser: parser, name: name, buf: writer } [INFO] [stderr] 832 | .write_help() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:853:9 [INFO] [stderr] | [INFO] [stderr] 853 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:889:9 [INFO] [stderr] | [INFO] [stderr] 889 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:921:9 [INFO] [stderr] | [INFO] [stderr] 921 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:964:9 [INFO] [stderr] | [INFO] [stderr] 964 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Flag(Box::new(StoreConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(StoreConstAction { cell: cell, value: val.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | return Flag(Box::new(PushConstAction { cell: cell, value: val.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(PushConstAction { cell: cell, value: val.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:50:9 [INFO] [stderr] | [INFO] [stderr] 50 | return Single(Box::new(StoreAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(StoreAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | return Single(Box::new(StoreOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(StoreOptionAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:62:9 [INFO] [stderr] | [INFO] [stderr] 62 | return Many(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Many(Box::new(ListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:68:9 [INFO] [stderr] | [INFO] [stderr] 68 | return Push(Box::new(ListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Push(Box::new(ListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:76:9 [INFO] [stderr] | [INFO] [stderr] 76 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | return Error(format!("Bad value {}", arg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {}", arg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:107:17 [INFO] [stderr] | [INFO] [stderr] 107 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:110:17 [INFO] [stderr] | [INFO] [stderr] 110 | return Error(format!("Bad value {}", arg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {}", arg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/generic.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return Single(Box::new(ParseAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(ParseAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return Single(Box::new(ParseOptionAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Single(Box::new(ParseOptionAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return Many(Box::new(ParseListAction { cell: cell })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Many(Box::new(ParseListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | return Push(Box::new(ParseListAction { cell: cell })) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Push(Box::new(ParseListAction { cell: cell }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:54:17 [INFO] [stderr] | [INFO] [stderr] 54 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:57:17 [INFO] [stderr] | [INFO] [stderr] 57 | return Error(format!("Bad value {:?}: {}", arg, error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {:?}: {}", arg, error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:71:17 [INFO] [stderr] | [INFO] [stderr] 71 | return Error(format!("Bad value {:?}: {}", arg, error)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Error(format!("Bad value {:?}: {}", arg, error))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/custom.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | return Help; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `Help` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / return WordsIter { [INFO] [stderr] 25 | | data: data, [INFO] [stderr] 26 | | iter: data.char_indices(), [INFO] [stderr] 27 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 24 | WordsIter { [INFO] [stderr] 25 | data: data, [INFO] [stderr] 26 | iter: data.char_indices(), [INFO] [stderr] 27 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | return Some(&self.data[word_start..self.data.len()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(&self.data[word_start..self.data.len()])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/help.rs:38:36 [INFO] [stderr] | [INFO] [stderr] 38 | Some((idx, ch)) => ((idx, ch)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/help.rs:51:36 [INFO] [stderr] | [INFO] [stderr] 51 | Some((idx, ch)) => ((idx, ch)), [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/help.rs:92:5 [INFO] [stderr] | [INFO] [stderr] 92 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/print.rs:11:9 [INFO] [stderr] | [INFO] [stderr] 11 | return ParseResult::Exit; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `ParseResult::Exit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bool.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | return Flag(Box::new(StoreConstAction { cell: cell, value: true })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(StoreConstAction { cell: cell, value: true }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bool.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | return Flag(Box::new(StoreConstAction { cell: cell, value: false })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(StoreConstAction { cell: cell, value: false }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | return Flag(Box::new(IncrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(IncrByAction { cell: cell, delta: delta.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return Flag(Box::new(DecrByAction { cell: cell, delta: delta.clone() })); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Flag(Box::new(DecrByAction { cell: cell, delta: delta.clone() }))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/num.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | return Parsed; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Parsed` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_bool.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return verbose; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_bool.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return verbose; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_bool.rs:52:5 [INFO] [stderr] | [INFO] [stderr] 52 | return verbose; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_bool.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | return verbose; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `verbose` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_int.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_int.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_int.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_int.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_float.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_str.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Variant name ends with the enum's name [INFO] [stderr] --> src/test_enum.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | NoGreeting, [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_enum.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | / return match src { [INFO] [stderr] 21 | | "hello" => Ok(Hello), [INFO] [stderr] 22 | | "hi" => Ok(Hi), [INFO] [stderr] 23 | | _ => Err(()), [INFO] [stderr] 24 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 20 | match src { [INFO] [stderr] 21 | "hello" => Ok(Hello), [INFO] [stderr] 22 | "hi" => Ok(Hi), [INFO] [stderr] 23 | _ => Err(()), [INFO] [stderr] 24 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_enum.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_pos.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_pos.rs:51:5 [INFO] [stderr] | [INFO] [stderr] 51 | return (val1, val2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(val1, val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_pos.rs:90:5 [INFO] [stderr] | [INFO] [stderr] 90 | return (val1, val2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(val1, val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_pos.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return (val1, val2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(val1, val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_pos.rs:157:5 [INFO] [stderr] | [INFO] [stderr] 157 | return (val1, val2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(val1, val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_pos.rs:185:5 [INFO] [stderr] | [INFO] [stderr] 185 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_many.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return (val1, val2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(val1, val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_many.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | return lst; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_many.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return lst; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `lst` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_many.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | return vec; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `vec` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_optional.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_optional.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_env.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (val1, val2) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(val1, val2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_const.rs:19:5 [INFO] [stderr] | [INFO] [stderr] 19 | return res; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/test_path.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | return val; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match opt.varid { [INFO] [stderr] 168 | | Some(varid) => { self.set_vars.insert(varid); } [INFO] [stderr] 169 | | None => {} [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(varid) = opt.varid { self.set_vars.insert(varid); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | / match optarg { [INFO] [stderr] 189 | | Some(_) => return Parsed, [INFO] [stderr] 190 | | _ => {} [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(_) = optarg { return Parsed }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:195:54 [INFO] [stderr] | [INFO] [stderr] 195 | Some(arg) if arg.starts_with("-") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:226:33 [INFO] [stderr] | [INFO] [stderr] 226 | / match opt.varid { [INFO] [stderr] 227 | | Some(varid) => { [INFO] [stderr] 228 | | self.set_vars.insert(varid); [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | None => {} [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 226 | if let Some(varid) = opt.varid { [INFO] [stderr] 227 | self.set_vars.insert(varid); [INFO] [stderr] 228 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / match opt.varid { [INFO] [stderr] 260 | | Some(varid) => { self.set_vars.insert(varid); } [INFO] [stderr] 261 | | None => {} [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(varid) = opt.varid { self.set_vars.insert(varid); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | / let value; [INFO] [stderr] 267 | | if idx + 1 < arg.len() { [INFO] [stderr] 268 | | value = Some(&arg[idx+1..arg.len()]); [INFO] [stderr] 269 | | } else { [INFO] [stderr] 270 | | value = None; [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let value = if idx + 1 < arg.len() { Some(&arg[idx+1..arg.len()]) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | / match env::var(evar.name) { [INFO] [stderr] 403 | | Ok(val) => { [INFO] [stderr] 404 | | match evar.action.parse_arg(&val[..]) { [INFO] [stderr] 405 | | Parsed => { [INFO] [stderr] ... | [INFO] [stderr] 417 | | Err(_) => {} [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 402 | if let Ok(val) = env::var(evar.name) { [INFO] [stderr] 403 | match evar.action.parse_arg(&val[..]) { [INFO] [stderr] 404 | Parsed => { [INFO] [stderr] 405 | self.set_vars.insert(evar.varid); [INFO] [stderr] 406 | continue; [INFO] [stderr] 407 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | fn parse(parser: &ArgumentParser, args: &Vec, stderr: &mut Write) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:518:16 [INFO] [stderr] | [INFO] [stderr] 518 | if var.metavar.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `var.metavar.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:554:17 [INFO] [stderr] | [INFO] [stderr] 554 | / match self.parser.catchall_argument { [INFO] [stderr] 555 | | Some(ref y) => panic!(format!( [INFO] [stderr] 556 | | "Option {} conflicts with option {}", [INFO] [stderr] 557 | | name, y.name)), [INFO] [stderr] 558 | | None => {}, [INFO] [stderr] 559 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 554 | if let Some(ref y) = self.parser.catchall_argument { panic!(format!( [INFO] [stderr] 555 | "Option {} conflicts with option {}", [INFO] [stderr] 556 | name, y.name)) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:568:16 [INFO] [stderr] | [INFO] [stderr] 568 | if var.metavar.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `var.metavar.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::ArgumentParser<'parser>` [INFO] [stderr] --> src/parser.rs:628:5 [INFO] [stderr] | [INFO] [stderr] 628 | / pub fn new() -> ArgumentParser<'parser> { [INFO] [stderr] 629 | | [INFO] [stderr] 630 | | let mut ap = ArgumentParser { [INFO] [stderr] 631 | | description: "", [INFO] [stderr] ... | [INFO] [stderr] 644 | | return ap; [INFO] [stderr] 645 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 610 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:694:12 [INFO] [stderr] | [INFO] [stderr] 694 | if names.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:743:23 [INFO] [stderr] | [INFO] [stderr] 743 | let name = if args.len() > 0 { &args[0][..] } else { "unknown" }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:895:12 [INFO] [stderr] | [INFO] [stderr] 895 | if self.parser.description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:899:12 [INFO] [stderr] | [INFO] [stderr] 899 | if self.parser.arguments.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.arguments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:906:13 [INFO] [stderr] | [INFO] [stderr] 906 | / match self.parser.catchall_argument { [INFO] [stderr] 907 | | Some(ref opt) => { [INFO] [stderr] 908 | | try!(self.print_argument(&**opt)); [INFO] [stderr] 909 | | } [INFO] [stderr] 910 | | None => {} [INFO] [stderr] 911 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 906 | if let Some(ref opt) = self.parser.catchall_argument { [INFO] [stderr] 907 | try!(self.print_argument(&**opt)); [INFO] [stderr] 908 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:913:12 [INFO] [stderr] | [INFO] [stderr] 913 | if self.parser.short_options.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.short_options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:914:16 [INFO] [stderr] | [INFO] [stderr] 914 | || self.parser.long_options.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.long_options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:927:12 [INFO] [stderr] | [INFO] [stderr] 927 | if self.parser.options.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | / match self.parser.catchall_argument { [INFO] [stderr] 946 | | Some(ref opt) => { [INFO] [stderr] 947 | | let var = &self.parser.vars[opt.varid]; [INFO] [stderr] 948 | | try!(write!(self.buf, " ")); [INFO] [stderr] ... | [INFO] [stderr] 960 | | None => {} [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 945 | if let Some(ref opt) = self.parser.catchall_argument { [INFO] [stderr] 946 | let var = &self.parser.vars[opt.varid]; [INFO] [stderr] 947 | try!(write!(self.buf, " ")); [INFO] [stderr] 948 | if !var.required { [INFO] [stderr] 949 | try!(write!(self.buf, "[")); [INFO] [stderr] 950 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | try!(buf.write(word.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | try!(buf.write(b"\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | try!(buf.write(b" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | try!(buf.write(b" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | try!(buf.write(word.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/print.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | if self.0.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `argparse`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:167:9 [INFO] [stderr] | [INFO] [stderr] 167 | / match opt.varid { [INFO] [stderr] 168 | | Some(varid) => { self.set_vars.insert(varid); } [INFO] [stderr] 169 | | None => {} [INFO] [stderr] 170 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(varid) = opt.varid { self.set_vars.insert(varid); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:188:17 [INFO] [stderr] | [INFO] [stderr] 188 | / match optarg { [INFO] [stderr] 189 | | Some(_) => return Parsed, [INFO] [stderr] 190 | | _ => {} [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________________^ help: try this: `if let Some(_) = optarg { return Parsed }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/parser.rs:195:54 [INFO] [stderr] | [INFO] [stderr] 195 | Some(arg) if arg.starts_with("-") => { [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:226:33 [INFO] [stderr] | [INFO] [stderr] 226 | / match opt.varid { [INFO] [stderr] 227 | | Some(varid) => { [INFO] [stderr] 228 | | self.set_vars.insert(varid); [INFO] [stderr] 229 | | } [INFO] [stderr] 230 | | None => {} [INFO] [stderr] 231 | | } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 226 | if let Some(varid) = opt.varid { [INFO] [stderr] 227 | self.set_vars.insert(varid); [INFO] [stderr] 228 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:259:21 [INFO] [stderr] | [INFO] [stderr] 259 | / match opt.varid { [INFO] [stderr] 260 | | Some(varid) => { self.set_vars.insert(varid); } [INFO] [stderr] 261 | | None => {} [INFO] [stderr] 262 | | } [INFO] [stderr] | |_____________________^ help: try this: `if let Some(varid) = opt.varid { self.set_vars.insert(varid); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/parser.rs:266:21 [INFO] [stderr] | [INFO] [stderr] 266 | / let value; [INFO] [stderr] 267 | | if idx + 1 < arg.len() { [INFO] [stderr] 268 | | value = Some(&arg[idx+1..arg.len()]); [INFO] [stderr] 269 | | } else { [INFO] [stderr] 270 | | value = None; [INFO] [stderr] 271 | | } [INFO] [stderr] | |_____________________^ help: it is more idiomatic to write: `let value = if idx + 1 < arg.len() { Some(&arg[idx+1..arg.len()]) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | / match env::var(evar.name) { [INFO] [stderr] 403 | | Ok(val) => { [INFO] [stderr] 404 | | match evar.action.parse_arg(&val[..]) { [INFO] [stderr] 405 | | Parsed => { [INFO] [stderr] ... | [INFO] [stderr] 417 | | Err(_) => {} [INFO] [stderr] 418 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 402 | if let Ok(val) = env::var(evar.name) { [INFO] [stderr] 403 | match evar.action.parse_arg(&val[..]) { [INFO] [stderr] 404 | Parsed => { [INFO] [stderr] 405 | self.set_vars.insert(evar.varid); [INFO] [stderr] 406 | continue; [INFO] [stderr] 407 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/parser.rs:462:45 [INFO] [stderr] | [INFO] [stderr] 462 | fn parse(parser: &ArgumentParser, args: &Vec, stderr: &mut Write) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:518:16 [INFO] [stderr] | [INFO] [stderr] 518 | if var.metavar.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `var.metavar.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:554:17 [INFO] [stderr] | [INFO] [stderr] 554 | / match self.parser.catchall_argument { [INFO] [stderr] 555 | | Some(ref y) => panic!(format!( [INFO] [stderr] 556 | | "Option {} conflicts with option {}", [INFO] [stderr] 557 | | name, y.name)), [INFO] [stderr] 558 | | None => {}, [INFO] [stderr] 559 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 554 | if let Some(ref y) = self.parser.catchall_argument { panic!(format!( [INFO] [stderr] 555 | "Option {} conflicts with option {}", [INFO] [stderr] 556 | name, y.name)) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:568:16 [INFO] [stderr] | [INFO] [stderr] 568 | if var.metavar.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `var.metavar.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `parser::ArgumentParser<'parser>` [INFO] [stderr] --> src/parser.rs:628:5 [INFO] [stderr] | [INFO] [stderr] 628 | / pub fn new() -> ArgumentParser<'parser> { [INFO] [stderr] 629 | | [INFO] [stderr] 630 | | let mut ap = ArgumentParser { [INFO] [stderr] 631 | | description: "", [INFO] [stderr] ... | [INFO] [stderr] 644 | | return ap; [INFO] [stderr] 645 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 610 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/parser.rs:694:12 [INFO] [stderr] | [INFO] [stderr] 694 | if names.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `names.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:743:23 [INFO] [stderr] | [INFO] [stderr] 743 | let name = if args.len() > 0 { &args[0][..] } else { "unknown" }; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:895:12 [INFO] [stderr] | [INFO] [stderr] 895 | if self.parser.description.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.description.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:899:12 [INFO] [stderr] | [INFO] [stderr] 899 | if self.parser.arguments.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.arguments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:906:13 [INFO] [stderr] | [INFO] [stderr] 906 | / match self.parser.catchall_argument { [INFO] [stderr] 907 | | Some(ref opt) => { [INFO] [stderr] 908 | | try!(self.print_argument(&**opt)); [INFO] [stderr] 909 | | } [INFO] [stderr] 910 | | None => {} [INFO] [stderr] 911 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 906 | if let Some(ref opt) = self.parser.catchall_argument { [INFO] [stderr] 907 | try!(self.print_argument(&**opt)); [INFO] [stderr] 908 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:913:12 [INFO] [stderr] | [INFO] [stderr] 913 | if self.parser.short_options.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.short_options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:914:16 [INFO] [stderr] | [INFO] [stderr] 914 | || self.parser.long_options.len() > 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.long_options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/parser.rs:927:12 [INFO] [stderr] | [INFO] [stderr] 927 | if self.parser.options.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.parser.options.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/parser.rs:945:13 [INFO] [stderr] | [INFO] [stderr] 945 | / match self.parser.catchall_argument { [INFO] [stderr] 946 | | Some(ref opt) => { [INFO] [stderr] 947 | | let var = &self.parser.vars[opt.varid]; [INFO] [stderr] 948 | | try!(write!(self.buf, " ")); [INFO] [stderr] ... | [INFO] [stderr] 960 | | None => {} [INFO] [stderr] 961 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 945 | if let Some(ref opt) = self.parser.catchall_argument { [INFO] [stderr] 946 | let var = &self.parser.vars[opt.varid]; [INFO] [stderr] 947 | try!(write!(self.buf, " ")); [INFO] [stderr] 948 | if !var.required { [INFO] [stderr] 949 | try!(write!(self.buf, "[")); [INFO] [stderr] 950 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | try!(buf.write(word.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | try!(buf.write(b"\n")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:82:17 [INFO] [stderr] | [INFO] [stderr] 82 | try!(buf.write(b" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | try!(buf.write(b" ")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/help.rs:89:9 [INFO] [stderr] | [INFO] [stderr] 89 | try!(buf.write(word.as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/print.rs:6:29 [INFO] [stderr] | [INFO] [stderr] 6 | if self.0.ends_with("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/test_parser.rs:31:26 [INFO] [stderr] | [INFO] [stderr] 31 | Ok(()) => panic!(format!("Expected failure, got success")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected failure, got success".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/test_parser.rs:46:26 [INFO] [stderr] | [INFO] [stderr] 46 | Ok(()) => panic!(format!("Expected failure, got success")), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Expected failure, got success".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test_float.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / assert_eq!(incr_decr(&["./argparse_test", [INFO] [stderr] 23 | | "--incr", "-iii"]), 2.0); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test_float.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / assert_eq!(incr_decr(&["./argparse_test", [INFO] [stderr] 23 | | "--incr", "-iii"]), 2.0); [INFO] [stderr] | |_________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test_float.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / assert_eq!(incr_decr(&["./argparse_test", [INFO] [stderr] 25 | | "-iiddd", "--incr", "-iii"]), 2.25); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test_float.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / assert_eq!(incr_decr(&["./argparse_test", [INFO] [stderr] 25 | | "-iiddd", "--incr", "-iii"]), 2.25); [INFO] [stderr] | |____________________________________________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/test_float.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(val, 15.125); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/test_float.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | assert_eq!(val, 15.125); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `argparse`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "74c6abb933e18b12c4b5134fbac3d69782845d0bfedb67361c1109b4fcde4ba9"` [INFO] running `"docker" "rm" "-f" "74c6abb933e18b12c4b5134fbac3d69782845d0bfedb67361c1109b4fcde4ba9"` [INFO] [stdout] 74c6abb933e18b12c4b5134fbac3d69782845d0bfedb67361c1109b4fcde4ba9