[INFO] crate argf 0.2.0 is already in cache [INFO] extracting crate argf 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/argf/0.2.0 [INFO] extracting crate argf 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/argf/0.2.0 [INFO] validating manifest of argf-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of argf-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing argf-0.2.0 [INFO] finished frobbing argf-0.2.0 [INFO] frobbed toml for argf-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/argf/0.2.0/Cargo.toml [INFO] started frobbing argf-0.2.0 [INFO] finished frobbing argf-0.2.0 [INFO] frobbed toml for argf-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/argf/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting argf-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/argf/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8275698e6e8070bfe098991f5e4e3b673889789924d98b396991fe6ccea3e331 [INFO] running `"docker" "start" "-a" "8275698e6e8070bfe098991f5e4e3b673889789924d98b396991fe6ccea3e331"` [INFO] [stderr] Checking argf v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return from_slice(&std::env::args().collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_slice(&std::env::args().collect::>())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn to_reader<'a>(path: &'a str) -> Box { [INFO] [stderr] 21 | | if path == "-" { [INFO] [stderr] 22 | | Box::new(io::stdin()) [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | Box::new(std::fs::File::open(path).unwrap()) [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | return from_slice(&std::env::args().collect::>()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_slice(&std::env::args().collect::>())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | / fn to_reader<'a>(path: &'a str) -> Box { [INFO] [stderr] 21 | | if path == "-" { [INFO] [stderr] 22 | | Box::new(io::stdin()) [INFO] [stderr] 23 | | } else { [INFO] [stderr] 24 | | Box::new(std::fs::File::open(path).unwrap()) [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.81s [INFO] running `"docker" "inspect" "8275698e6e8070bfe098991f5e4e3b673889789924d98b396991fe6ccea3e331"` [INFO] running `"docker" "rm" "-f" "8275698e6e8070bfe098991f5e4e3b673889789924d98b396991fe6ccea3e331"` [INFO] [stdout] 8275698e6e8070bfe098991f5e4e3b673889789924d98b396991fe6ccea3e331