[INFO] crate aprs-parser 0.1.1 is already in cache [INFO] extracting crate aprs-parser 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/aprs-parser/0.1.1 [INFO] extracting crate aprs-parser 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aprs-parser/0.1.1 [INFO] validating manifest of aprs-parser-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aprs-parser-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aprs-parser-0.1.1 [INFO] finished frobbing aprs-parser-0.1.1 [INFO] frobbed toml for aprs-parser-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/aprs-parser/0.1.1/Cargo.toml [INFO] started frobbing aprs-parser-0.1.1 [INFO] finished frobbing aprs-parser-0.1.1 [INFO] frobbed toml for aprs-parser-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aprs-parser/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aprs-parser-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aprs-parser/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e68afac870f399d2ef3ad2c58b75aef6cd597e1d8c5d3e33d07d53e5493aa12 [INFO] running `"docker" "start" "-a" "1e68afac870f399d2ef3ad2c58b75aef6cd597e1d8c5d3e33d07d53e5493aa12"` [INFO] [stderr] Checking approx v0.2.1 [INFO] [stderr] Checking aprs-parser v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/callsign.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | let delimiter = s.find("-"); //.ok_or_else(|| APRSError::EmptyCallsign(s.to_owned()))?; [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/callsign.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | if ssid.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ssid.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:70:56 [INFO] [stderr] | [INFO] [stderr] 70 | assert_relative_eq!(position.latitude, 48.360166); [INFO] [stderr] | ^^^^^^^^^ help: consider: `48.360_166` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/message.rs:71:57 [INFO] [stderr] | [INFO] [stderr] 71 | assert_relative_eq!(position.longitude, 12.408166); [INFO] [stderr] | ^^^^^^^^^ help: consider: `12.408_166` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/position.rs:77:46 [INFO] [stderr] | [INFO] [stderr] 77 | assert_relative_eq!(result.latitude, 48.360166); [INFO] [stderr] | ^^^^^^^^^ help: consider: `48.360_166` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/position.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | assert_relative_eq!(result.longitude, 12.408166); [INFO] [stderr] | ^^^^^^^^^ help: consider: `12.408_166` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/callsign.rs:24:32 [INFO] [stderr] | [INFO] [stderr] 24 | let delimiter = s.find("-"); //.ok_or_else(|| APRSError::EmptyCallsign(s.to_owned()))?; [INFO] [stderr] | ^^^ help: try using a char instead: `'-'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/callsign.rs:37:12 [INFO] [stderr] | [INFO] [stderr] 37 | if ssid.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `ssid.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/message.rs:70:56 [INFO] [stderr] | [INFO] [stderr] 70 | assert_relative_eq!(position.latitude, 48.360166); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `48.360_165` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/position.rs:77:46 [INFO] [stderr] | [INFO] [stderr] 77 | assert_relative_eq!(result.latitude, 48.360166); [INFO] [stderr] | ^^^^^^^^^ help: consider changing the type or truncating it to: `48.360_165` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.14s [INFO] running `"docker" "inspect" "1e68afac870f399d2ef3ad2c58b75aef6cd597e1d8c5d3e33d07d53e5493aa12"` [INFO] running `"docker" "rm" "-f" "1e68afac870f399d2ef3ad2c58b75aef6cd597e1d8c5d3e33d07d53e5493aa12"` [INFO] [stdout] 1e68afac870f399d2ef3ad2c58b75aef6cd597e1d8c5d3e33d07d53e5493aa12