[INFO] crate appscraps_static_util 0.1.0 is already in cache
[INFO] extracting crate appscraps_static_util 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/appscraps_static_util/0.1.0
[INFO] extracting crate appscraps_static_util 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps_static_util/0.1.0
[INFO] validating manifest of appscraps_static_util-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of appscraps_static_util-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing appscraps_static_util-0.1.0
[INFO] finished frobbing appscraps_static_util-0.1.0
[INFO] frobbed toml for appscraps_static_util-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/appscraps_static_util/0.1.0/Cargo.toml
[INFO] started frobbing appscraps_static_util-0.1.0
[INFO] finished frobbing appscraps_static_util-0.1.0
[INFO] frobbed toml for appscraps_static_util-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps_static_util/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting appscraps_static_util-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/appscraps_static_util/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 15f7a69553e0d3b85379d90b0e034531caa8c904a045bc45b37d349fdde8e8cf
[INFO] running `"docker" "start" "-a" "15f7a69553e0d3b85379d90b0e034531caa8c904a045bc45b37d349fdde8e8cf"`
[INFO] [stderr]     Checking appscraps_static_util v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/force_some_rw_lock_read_guard.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/force_some_rw_lock_read_guard.rs:14:13
[INFO] [stderr]    |
[INFO] [stderr] 14 |             data: data,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `data`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/error/mod.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / error_chain! {
[INFO] [stderr] 2  | |     types { }
[INFO] [stderr] 3  | | 
[INFO] [stderr] 4  | |     links { }
[INFO] [stderr] ...  |
[INFO] [stderr] 32 | |     }
[INFO] [stderr] 33 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/force_some_rw_lock_read_guard.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match self.data.deref() {
[INFO] [stderr] 22 | |             &Some(ref some) => some,
[INFO] [stderr] 23 | |             &None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr] 24 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 21 |         match *self.data.deref() {
[INFO] [stderr] 22 |             Some(ref some) => some,
[INFO] [stderr] 23 |             None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/force_some_rw_lock_read_guard.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         match self.data.deref() {
[INFO] [stderr] 33 | |             &Some(ref some) => some,
[INFO] [stderr] 34 | |             &None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 32 |         match *self.data.deref() {
[INFO] [stderr] 33 |             Some(ref some) => some,
[INFO] [stderr] 34 |             None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `safe_static::SafeStatic<T>`
[INFO] [stderr]   --> src/safe_static.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> Self {
[INFO] [stderr] 17 | |         SafeStatic {
[INFO] [stderr] 18 | |             data: RwLock::new(None),
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/safe_static.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 | /                 if let &None = ok.deref() {
[INFO] [stderr] 26 | |                     return Err(ErrorKind::StaticWasNeverSet.into())
[INFO] [stderr] 27 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 if let None = *ok.deref() {
[INFO] [stderr]    |                        ^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/safe_static.rs:43:16
[INFO] [stderr]    |
[INFO] [stderr] 43 |           if let Some(_) = mem::replace(data_ref, Some(value)) {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 44 | |             Err(ErrorKind::StaticIsAlreadySet.into())
[INFO] [stderr] 45 | |         } else {
[INFO] [stderr] 46 | |             Ok(())
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________- help: try this: `if mem::replace(data_ref, Some(value)).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/error/mod.rs:1:1
[INFO] [stderr]    |
[INFO] [stderr] 1  | / error_chain! {
[INFO] [stderr] 2  | |     types { }
[INFO] [stderr] 3  | | 
[INFO] [stderr] 4  | |     links { }
[INFO] [stderr] ...  |
[INFO] [stderr] 32 | |     }
[INFO] [stderr] 33 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/force_some_rw_lock_read_guard.rs:21:9
[INFO] [stderr]    |
[INFO] [stderr] 21 | /         match self.data.deref() {
[INFO] [stderr] 22 | |             &Some(ref some) => some,
[INFO] [stderr] 23 | |             &None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr] 24 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 21 |         match *self.data.deref() {
[INFO] [stderr] 22 |             Some(ref some) => some,
[INFO] [stderr] 23 |             None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/force_some_rw_lock_read_guard.rs:32:9
[INFO] [stderr]    |
[INFO] [stderr] 32 | /         match self.data.deref() {
[INFO] [stderr] 33 | |             &Some(ref some) => some,
[INFO] [stderr] 34 | |             &None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr] 35 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 32 |         match *self.data.deref() {
[INFO] [stderr] 33 |             Some(ref some) => some,
[INFO] [stderr] 34 |             None => panic!("Fatal error getting static. The static was never set. This should be impossible."),
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `safe_static::SafeStatic<T>`
[INFO] [stderr]   --> src/safe_static.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() -> Self {
[INFO] [stderr] 17 | |         SafeStatic {
[INFO] [stderr] 18 | |             data: RwLock::new(None),
[INFO] [stderr] 19 | |         }
[INFO] [stderr] 20 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/safe_static.rs:25:17
[INFO] [stderr]    |
[INFO] [stderr] 25 | /                 if let &None = ok.deref() {
[INFO] [stderr] 26 | |                     return Err(ErrorKind::StaticWasNeverSet.into())
[INFO] [stderr] 27 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 25 |                 if let None = *ok.deref() {
[INFO] [stderr]    |                        ^^^^   ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/safe_static.rs:43:16
[INFO] [stderr]    |
[INFO] [stderr] 43 |           if let Some(_) = mem::replace(data_ref, Some(value)) {
[INFO] [stderr]    |  _________-      ^^^^^^^
[INFO] [stderr] 44 | |             Err(ErrorKind::StaticIsAlreadySet.into())
[INFO] [stderr] 45 | |         } else {
[INFO] [stderr] 46 | |             Ok(())
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________- help: try this: `if mem::replace(data_ref, Some(value)).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.75s
[INFO] running `"docker" "inspect" "15f7a69553e0d3b85379d90b0e034531caa8c904a045bc45b37d349fdde8e8cf"`
[INFO] running `"docker" "rm" "-f" "15f7a69553e0d3b85379d90b0e034531caa8c904a045bc45b37d349fdde8e8cf"`
[INFO] [stdout] 15f7a69553e0d3b85379d90b0e034531caa8c904a045bc45b37d349fdde8e8cf