[INFO] crate appscraps_dynamic_event 0.1.0 is already in cache [INFO] extracting crate appscraps_dynamic_event 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/appscraps_dynamic_event/0.1.0 [INFO] extracting crate appscraps_dynamic_event 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps_dynamic_event/0.1.0 [INFO] validating manifest of appscraps_dynamic_event-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of appscraps_dynamic_event-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing appscraps_dynamic_event-0.1.0 [INFO] removed path dependency appscraps_module from appscraps_dynamic_event-0.1.0 [INFO] finished frobbing appscraps_dynamic_event-0.1.0 [INFO] frobbed toml for appscraps_dynamic_event-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/appscraps_dynamic_event/0.1.0/Cargo.toml [INFO] started frobbing appscraps_dynamic_event-0.1.0 [INFO] removed path dependency appscraps_module from appscraps_dynamic_event-0.1.0 [INFO] finished frobbing appscraps_dynamic_event-0.1.0 [INFO] frobbed toml for appscraps_dynamic_event-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps_dynamic_event/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting appscraps_dynamic_event-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/appscraps_dynamic_event/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 434e79793429643fbe73630fd1f7f162fc9fe6e6b137c3d490aae170b9619cc1 [INFO] running `"docker" "start" "-a" "434e79793429643fbe73630fd1f7f162fc9fe6e6b137c3d490aae170b9619cc1"` [INFO] [stderr] Compiling appscraps_module v0.1.0 [INFO] [stderr] Compiling appscraps_dynamic_event v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | dynamic_event_list: dynamic_event_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | dynamic_event_map: dynamic_event_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/dynamic_event_list.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | dynamic_events: dynamic_events, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_events` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/dynamic_event_map.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | module_and_event_name_to_index: module_and_event_name_to_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_and_event_name_to_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | dynamic_event_list: dynamic_event_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | dynamic_event_map: dynamic_event_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_event_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/dynamic_event_list.rs:10:13 [INFO] [stderr] | [INFO] [stderr] 10 | dynamic_events: dynamic_events, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `dynamic_events` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/dynamic_event_map.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | module_and_event_name_to_index: module_and_event_name_to_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_and_event_name_to_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dynamic_event-80649e27771ef80e/out/serde_types.rs:162:40 [INFO] [stderr] | [INFO] [stderr] 162 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dynamic_event-80649e27771ef80e/out/serde_types.rs:162:50 [INFO] [stderr] | [INFO] [stderr] 162 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dynamic_event-80649e27771ef80e/out/serde_types.rs:162:40 [INFO] [stderr] | [INFO] [stderr] 162 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dynamic_event-80649e27771ef80e/out/serde_types.rs:162:50 [INFO] [stderr] | [INFO] [stderr] 162 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dynamic_event-80649e27771ef80e/out/serde_types.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | "DynamicEvent" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / error_chain! { [INFO] [stderr] 5 | | types { } [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | links { [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/load/dynamic_event_loader.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | module_list: &ModuleList, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/load/dynamic_event_loader.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(_) = pre_dynamic_event_map.insert(dynamic_event_key, dynamic_event_id) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 39 | | return Err(ErrorKind::EventAlreadyExists(dynamic_event, module_index).into()) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________- help: try this: `if pre_dynamic_event_map.insert(dynamic_event_key, dynamic_event_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/load/dynamic_event_loader.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | module_list: &ModuleList, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util/dynamic_event_map.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dynamic_event-80649e27771ef80e/out/serde_types.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | "DynamicEvent" , 0 + 1 + 1 + 1 )); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / error_chain! { [INFO] [stderr] 5 | | types { } [INFO] [stderr] 6 | | [INFO] [stderr] 7 | | links { [INFO] [stderr] ... | [INFO] [stderr] 58 | | } [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/load/dynamic_event_loader.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | module_list: &ModuleList, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/load/dynamic_event_loader.rs:38:20 [INFO] [stderr] | [INFO] [stderr] 38 | if let Some(_) = pre_dynamic_event_map.insert(dynamic_event_key, dynamic_event_id) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 39 | | return Err(ErrorKind::EventAlreadyExists(dynamic_event, module_index).into()) [INFO] [stderr] 40 | | } [INFO] [stderr] | |_____________- help: try this: `if pre_dynamic_event_map.insert(dynamic_event_key, dynamic_event_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/load/dynamic_event_loader.rs:49:22 [INFO] [stderr] | [INFO] [stderr] 49 | module_list: &ModuleList, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util/dynamic_event_map.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.98s [INFO] running `"docker" "inspect" "434e79793429643fbe73630fd1f7f162fc9fe6e6b137c3d490aae170b9619cc1"` [INFO] running `"docker" "rm" "-f" "434e79793429643fbe73630fd1f7f162fc9fe6e6b137c3d490aae170b9619cc1"` [INFO] [stdout] 434e79793429643fbe73630fd1f7f162fc9fe6e6b137c3d490aae170b9619cc1