[INFO] crate appscraps_dll 0.1.0 is already in cache [INFO] extracting crate appscraps_dll 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/appscraps_dll/0.1.0 [INFO] extracting crate appscraps_dll 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps_dll/0.1.0 [INFO] validating manifest of appscraps_dll-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of appscraps_dll-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing appscraps_dll-0.1.0 [INFO] removed path dependency appscraps_dll_error from appscraps_dll-0.1.0 [INFO] removed path dependency appscraps_module from appscraps_dll-0.1.0 [INFO] removed path dependency sharedlib from appscraps_dll-0.1.0 [INFO] finished frobbing appscraps_dll-0.1.0 [INFO] frobbed toml for appscraps_dll-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/appscraps_dll/0.1.0/Cargo.toml [INFO] started frobbing appscraps_dll-0.1.0 [INFO] removed path dependency appscraps_dll_error from appscraps_dll-0.1.0 [INFO] removed path dependency appscraps_module from appscraps_dll-0.1.0 [INFO] removed path dependency sharedlib from appscraps_dll-0.1.0 [INFO] finished frobbing appscraps_dll-0.1.0 [INFO] frobbed toml for appscraps_dll-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps_dll/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting appscraps_dll-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/appscraps_dll/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6ffd6fd81a590bc18810a791c85bcf3b17de852a41fc7857f9d174c077ae2705 [INFO] running `"docker" "start" "-a" "6ffd6fd81a590bc18810a791c85bcf3b17de852a41fc7857f9d174c077ae2705"` [INFO] [stderr] Checking appscraps_dll_error v0.1.0 [INFO] [stderr] Compiling appscraps_module v0.1.0 [INFO] [stderr] Compiling appscraps_dll v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | func_list: func_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | func_map: func_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `func_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/func_list.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | funcs: funcs [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `funcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/func_map.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | module_and_func_name_to_index: module_and_func_name_to_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_and_func_name_to_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | func_list: func_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_list` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | func_map: func_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `func_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/func_list.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | funcs: funcs [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `funcs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/func_map.rs:11:13 [INFO] [stderr] | [INFO] [stderr] 11 | module_and_func_name_to_index: module_and_func_name_to_index [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_and_func_name_to_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:160:40 [INFO] [stderr] | [INFO] [stderr] 160 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:160:50 [INFO] [stderr] | [INFO] [stderr] 160 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:278:42 [INFO] [stderr] | [INFO] [stderr] 278 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:278:52 [INFO] [stderr] | [INFO] [stderr] 278 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:573:40 [INFO] [stderr] | [INFO] [stderr] 573 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:573:50 [INFO] [stderr] | [INFO] [stderr] 573 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:160:40 [INFO] [stderr] | [INFO] [stderr] 160 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:160:50 [INFO] [stderr] | [INFO] [stderr] 160 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:278:42 [INFO] [stderr] | [INFO] [stderr] 278 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:278:52 [INFO] [stderr] | [INFO] [stderr] 278 | const VARIANTS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:573:40 [INFO] [stderr] | [INFO] [stderr] 573 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^--------------- help: consider removing `'static`: `&[&'static str]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> /opt/crater/target/debug/build/appscraps_dll-994d6fc160a72bcd/out/serde_types.rs:573:50 [INFO] [stderr] | [INFO] [stderr] 573 | const FIELDS: &'static [&'static str] = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / error_chain! { [INFO] [stderr] 7 | | types { } [INFO] [stderr] 8 | | [INFO] [stderr] 9 | | links { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:25:37 [INFO] [stderr] | [INFO] [stderr] 25 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:25:37 [INFO] [stderr] | [INFO] [stderr] 25 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/register_funcs.rs:25:53 [INFO] [stderr] | [INFO] [stderr] 25 | pub unsafe fn new(dll: &LibArc, symbol: &String, func_type: $main_func_type_ident, has_input: bool, has_output: bool) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / register_funcs!( [INFO] [stderr] 35 | | (FuncType, Func) { [INFO] [stderr] 36 | | native { [INFO] [stderr] 37 | | NativeFuncNone, [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/func/register_funcs.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | / match self { [INFO] [stderr] 53 | | $( [INFO] [stderr] 54 | | &$main_func_ident::$current_func_none_ident(_) => { [INFO] [stderr] 55 | | stringify!($main_func_ident::$current_func_none_ident) [INFO] [stderr] ... | [INFO] [stderr] 66 | | ),+ [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / register_funcs!( [INFO] [stderr] 35 | | (FuncType, Func) { [INFO] [stderr] 36 | | native { [INFO] [stderr] 37 | | NativeFuncNone, [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/load/dll_loader.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | module_list: &ModuleList, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/load/dll_loader.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | let name = use_as.unwrap_or(symbol.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| symbol.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/load/dll_loader.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if let Some(_) = pre_func_map.insert(func_key.clone(), func_id) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 85 | | return Err(ErrorKind::EventLoadNameCollision(func_key.1, func_key.0).into()); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________- help: try this: `if pre_func_map.insert(func_key.clone(), func_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util/func_map.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | / error_chain! { [INFO] [stderr] 7 | | types { } [INFO] [stderr] 8 | | [INFO] [stderr] 9 | | links { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:25:37 [INFO] [stderr] | [INFO] [stderr] 25 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | / define_func!( [INFO] [stderr] 17 | | (&Any, Box) { [INFO] [stderr] 18 | | NativeFuncNone, [INFO] [stderr] 19 | | NativeFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/define_func_header.rs:9:53 [INFO] [stderr] | [INFO] [stderr] 9 | pub unsafe fn new(dll: &LibArc, symbol: &String) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:18:32 [INFO] [stderr] | [INFO] [stderr] 18 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:25:37 [INFO] [stderr] | [INFO] [stderr] 25 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:32:32 [INFO] [stderr] | [INFO] [stderr] 32 | func().map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/func/define_func.rs:39:37 [INFO] [stderr] | [INFO] [stderr] 39 | func(input).map_err(|err| Error::from(err)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:25:1 [INFO] [stderr] | [INFO] [stderr] 25 | / define_func!( [INFO] [stderr] 26 | | (&str, String) { [INFO] [stderr] 27 | | StringFuncNone, [INFO] [stderr] 28 | | StringFuncInput, [INFO] [stderr] ... | [INFO] [stderr] 31 | | } [INFO] [stderr] 32 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/func/register_funcs.rs:25:53 [INFO] [stderr] | [INFO] [stderr] 25 | pub unsafe fn new(dll: &LibArc, symbol: &String, func_type: $main_func_type_ident, has_input: bool, has_output: bool) -> Result { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / register_funcs!( [INFO] [stderr] 35 | | (FuncType, Func) { [INFO] [stderr] 36 | | native { [INFO] [stderr] 37 | | NativeFuncNone, [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/func/register_funcs.rs:52:17 [INFO] [stderr] | [INFO] [stderr] 52 | / match self { [INFO] [stderr] 53 | | $( [INFO] [stderr] 54 | | &$main_func_ident::$current_func_none_ident(_) => { [INFO] [stderr] 55 | | stringify!($main_func_ident::$current_func_none_ident) [INFO] [stderr] ... | [INFO] [stderr] 66 | | ),+ [INFO] [stderr] 67 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] ::: src/func/mod.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | / register_funcs!( [INFO] [stderr] 35 | | (FuncType, Func) { [INFO] [stderr] 36 | | native { [INFO] [stderr] 37 | | NativeFuncNone, [INFO] [stderr] ... | [INFO] [stderr] 48 | | } [INFO] [stderr] 49 | | ); [INFO] [stderr] | |__- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/load/dll_loader.rs:20:22 [INFO] [stderr] | [INFO] [stderr] 20 | module_list: &ModuleList, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/load/dll_loader.rs:80:27 [INFO] [stderr] | [INFO] [stderr] 80 | let name = use_as.unwrap_or(symbol.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| symbol.clone())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/load/dll_loader.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if let Some(_) = pre_func_map.insert(func_key.clone(), func_id) { [INFO] [stderr] | _________- ^^^^^^^ [INFO] [stderr] 85 | | return Err(ErrorKind::EventLoadNameCollision(func_key.1, func_key.0).into()); [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________- help: try this: `if pre_func_map.insert(func_key.clone(), func_id).is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util/func_map.rs:18:30 [INFO] [stderr] | [INFO] [stderr] 18 | Some(some) => Ok(some.clone()), [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*some` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/test/dll/basic_tests.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | / match hello_world_func { [INFO] [stderr] 21 | | &Func::NativeFuncNone(ref func) => unsafe { func.clone().call().unwrap() }, [INFO] [stderr] 22 | | _ => panic!(), [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 20 | match *hello_world_func { [INFO] [stderr] 21 | Func::NativeFuncNone(ref func) => unsafe { func.clone().call().unwrap() }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.99s [INFO] running `"docker" "inspect" "6ffd6fd81a590bc18810a791c85bcf3b17de852a41fc7857f9d174c077ae2705"` [INFO] running `"docker" "rm" "-f" "6ffd6fd81a590bc18810a791c85bcf3b17de852a41fc7857f9d174c077ae2705"` [INFO] [stdout] 6ffd6fd81a590bc18810a791c85bcf3b17de852a41fc7857f9d174c077ae2705