[INFO] crate appscraps 0.1.0 is already in cache [INFO] extracting crate appscraps 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/appscraps/0.1.0 [INFO] extracting crate appscraps 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps/0.1.0 [INFO] validating manifest of appscraps-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of appscraps-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing appscraps-0.1.0 [INFO] removed path dependency appscraps_dll from appscraps-0.1.0 [INFO] removed path dependency appscraps_environment from appscraps-0.1.0 [INFO] removed path dependency appscraps_event from appscraps-0.1.0 [INFO] removed path dependency appscraps_module from appscraps-0.1.0 [INFO] removed path dependency simplisp from appscraps-0.1.0 [INFO] removed path dependency simplisp_extensions from appscraps-0.1.0 [INFO] finished frobbing appscraps-0.1.0 [INFO] frobbed toml for appscraps-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/appscraps/0.1.0/Cargo.toml [INFO] started frobbing appscraps-0.1.0 [INFO] removed path dependency appscraps_dll from appscraps-0.1.0 [INFO] removed path dependency appscraps_environment from appscraps-0.1.0 [INFO] removed path dependency appscraps_event from appscraps-0.1.0 [INFO] removed path dependency appscraps_module from appscraps-0.1.0 [INFO] removed path dependency simplisp from appscraps-0.1.0 [INFO] removed path dependency simplisp_extensions from appscraps-0.1.0 [INFO] finished frobbing appscraps-0.1.0 [INFO] frobbed toml for appscraps-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/appscraps/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting appscraps-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/appscraps/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7c5d92922573de6dd61d2762cf306ecd23739902c5e326e944224fe62cd3c03a [INFO] running `"docker" "start" "-a" "7c5d92922573de6dd61d2762cf306ecd23739902c5e326e944224fe62cd3c03a"` [INFO] [stderr] Checking appscraps_dll_error v0.1.0 [INFO] [stderr] Checking simplisp v0.4.0 [INFO] [stderr] Compiling appscraps_module v0.1.0 [INFO] [stderr] Compiling appscraps_dll v0.1.0 [INFO] [stderr] Compiling appscraps_event v0.1.0 [INFO] [stderr] Checking simplisp_extensions v0.4.0 [INFO] [stderr] Checking appscraps_environment v0.1.0 [INFO] [stderr] Checking appscraps v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | output_stream: output_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | lisp_environment: lisp_environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lisp_environment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | in_stream: in_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `in_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | out_stream: out_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | event_list: event_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | event_map: event_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | func_list: func_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | func_map: func_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `func_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | module_list: module_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | module_map: module_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | path_resolver: path_resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/clone_reader.rs:14:22 [INFO] [stderr] | [INFO] [stderr] 14 | CloneReader{ reader: reader } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/clone_writer.rs:15:22 [INFO] [stderr] | [INFO] [stderr] 15 | CloneWriter{ writer: writer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `writer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/reading_end.rs:16:21 [INFO] [stderr] | [INFO] [stderr] 16 | ReadingEnd{ locking_stream: locking_stream, position: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `locking_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/stream_pair_startup.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | startup: startup, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `startup` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/stream_pair_startup.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | input_into_program: input_into_program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `input_into_program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/stream_pair_startup.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | output_from_program: output_from_program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_from_program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test/util/writing_end.rs:17:21 [INFO] [stderr] | [INFO] [stderr] 17 | WritingEnd{ locking_stream: locking_stream, position: 0 } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `locking_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | environment: environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `environment` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | output_stream: output_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/program.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:53:13 [INFO] [stderr] | [INFO] [stderr] 53 | lisp_environment: lisp_environment, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lisp_environment` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | payload: payload, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `payload` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | in_stream: in_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `in_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | out_stream: out_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `out_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/backend/startup.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | error_stream: error_stream, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `error_stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | event_list: event_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | event_map: event_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | func_list: func_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | func_map: func_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `func_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | module_list: module_list, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_list` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | module_map: module_map, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `module_map` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/load/payload.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | path_resolver: path_resolver, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `path_resolver` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/backend/program.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:35:42 [INFO] [stderr] | [INFO] [stderr] 35 | try!(func.call(&arg).map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | let result = try!(func.call(&arg).map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | try!(func.call().map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | let result = try!(func.call().map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/backend/execute.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | let mut words = words.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/program.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / if let &Event::NativeEventInput(ref construct_event) = [INFO] [stderr] 93 | | try!( [INFO] [stderr] 94 | | environment.get_event_list().get_event(construct_event_index) [INFO] [stderr] 95 | | ) { [INFO] [stderr] ... | [INFO] [stderr] 104 | | ); [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | if let Event::NativeEventInput(ref construct_event) = [INFO] [stderr] 93 | *(match $ expr { [INFO] [stderr] 94 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 95 | :: Err ( err ) => { [INFO] [stderr] 96 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 97 | $ crate :: convert :: From :: from ( err ) ) } }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/program.rs:96:61 [INFO] [stderr] | [INFO] [stderr] 96 | try!(construct_event.call(&environment).map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backend/program.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | fn destructure(self) -> (Environment, BufReader>, Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backend/startup.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn destructure(self) -> (LispEnvironment, Payload, Box, Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / error_chain! { [INFO] [stderr] 9 | | types { } [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | links { [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp_funcs/func.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match func { [INFO] [stderr] 105 | | &Func::StringFuncNone(ref func) => { [INFO] [stderr] 106 | | match func_args { [INFO] [stderr] 107 | | Some(args) => { [INFO] [stderr] ... | [INFO] [stderr] 152 | | }, [INFO] [stderr] 153 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *func { [INFO] [stderr] 105 | Func::StringFuncNone(ref func) => { [INFO] [stderr] 106 | match func_args { [INFO] [stderr] 107 | Some(args) => { [INFO] [stderr] 108 | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 109 | return err.wrap_error_to_err(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lisp_funcs/func.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | / match func_args { [INFO] [stderr] 107 | | Some(args) => { [INFO] [stderr] 108 | | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 109 | | return err.wrap_error_to_err(); [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | None => { }, [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Some(args) = func_args { [INFO] [stderr] 107 | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 108 | return err.wrap_error_to_err(); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:113:42 [INFO] [stderr] | [INFO] [stderr] 113 | try!(func.call().map_err(|err| Error::from(err)).wrap_err_to_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:125:52 [INFO] [stderr] | [INFO] [stderr] 125 | try!(func.call(&func_args).map_err(|err| Error::from(err)).wrap_err_to_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:137:52 [INFO] [stderr] | [INFO] [stderr] 137 | try!(func.call(&func_args).map_err(|err| Error::from(err)).wrap_err_to_err()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lisp_funcs/func.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | / match func_args { [INFO] [stderr] 141 | | Some(args) => { [INFO] [stderr] 142 | | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 143 | | return err.wrap_error_to_err(); [INFO] [stderr] 144 | | }, [INFO] [stderr] 145 | | None => { }, [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(args) = func_args { [INFO] [stderr] 141 | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 142 | return err.wrap_error_to_err(); [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:147:42 [INFO] [stderr] | [INFO] [stderr] 147 | try!(func.call().map_err(|err| Error::from(err)).wrap_err_to_err()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/backend/program.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:35:42 [INFO] [stderr] | [INFO] [stderr] 35 | try!(func.call(&arg).map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:39:55 [INFO] [stderr] | [INFO] [stderr] 39 | let result = try!(func.call(&arg).map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | try!(func.call().map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/execute.rs:47:51 [INFO] [stderr] | [INFO] [stderr] 47 | let result = try!(func.call().map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/backend/execute.rs:58:21 [INFO] [stderr] | [INFO] [stderr] 58 | let mut words = words.into_iter(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `words` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/backend/program.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | / if let &Event::NativeEventInput(ref construct_event) = [INFO] [stderr] 93 | | try!( [INFO] [stderr] 94 | | environment.get_event_list().get_event(construct_event_index) [INFO] [stderr] 95 | | ) { [INFO] [stderr] ... | [INFO] [stderr] 104 | | ); [INFO] [stderr] 105 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 92 | if let Event::NativeEventInput(ref construct_event) = [INFO] [stderr] 93 | *(match $ expr { [INFO] [stderr] 94 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 95 | :: Err ( err ) => { [INFO] [stderr] 96 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 97 | $ crate :: convert :: From :: from ( err ) ) } }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/backend/program.rs:96:61 [INFO] [stderr] | [INFO] [stderr] 96 | try!(construct_event.call(&environment).map_err(|err| Error::from(err))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backend/program.rs:109:29 [INFO] [stderr] | [INFO] [stderr] 109 | fn destructure(self) -> (Environment, BufReader>, Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/backend/startup.rs:61:33 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn destructure(self) -> (LispEnvironment, Payload, Box, Box, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/error/mod.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / error_chain! { [INFO] [stderr] 9 | | types { } [INFO] [stderr] 10 | | [INFO] [stderr] 11 | | links { [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lisp_funcs/func.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / match func { [INFO] [stderr] 105 | | &Func::StringFuncNone(ref func) => { [INFO] [stderr] 106 | | match func_args { [INFO] [stderr] 107 | | Some(args) => { [INFO] [stderr] ... | [INFO] [stderr] 152 | | }, [INFO] [stderr] 153 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 104 | match *func { [INFO] [stderr] 105 | Func::StringFuncNone(ref func) => { [INFO] [stderr] 106 | match func_args { [INFO] [stderr] 107 | Some(args) => { [INFO] [stderr] 108 | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 109 | return err.wrap_error_to_err(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lisp_funcs/func.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | / match func_args { [INFO] [stderr] 107 | | Some(args) => { [INFO] [stderr] 108 | | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 109 | | return err.wrap_error_to_err(); [INFO] [stderr] 110 | | }, [INFO] [stderr] 111 | | None => { }, [INFO] [stderr] 112 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 106 | if let Some(args) = func_args { [INFO] [stderr] 107 | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 108 | return err.wrap_error_to_err(); [INFO] [stderr] 109 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:113:42 [INFO] [stderr] | [INFO] [stderr] 113 | try!(func.call().map_err(|err| Error::from(err)).wrap_err_to_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:125:52 [INFO] [stderr] | [INFO] [stderr] 125 | try!(func.call(&func_args).map_err(|err| Error::from(err)).wrap_err_to_err()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:137:52 [INFO] [stderr] | [INFO] [stderr] 137 | try!(func.call(&func_args).map_err(|err| Error::from(err)).wrap_err_to_err()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lisp_funcs/func.rs:140:17 [INFO] [stderr] | [INFO] [stderr] 140 | / match func_args { [INFO] [stderr] 141 | | Some(args) => { [INFO] [stderr] 142 | | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 143 | | return err.wrap_error_to_err(); [INFO] [stderr] 144 | | }, [INFO] [stderr] 145 | | None => { }, [INFO] [stderr] 146 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 140 | if let Some(args) = func_args { [INFO] [stderr] 141 | let err: Error = ErrorKind::LispFuncUnnecessaryArgs(func_name, module_name, args).into(); [INFO] [stderr] 142 | return err.wrap_error_to_err(); [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lisp_funcs/func.rs:147:42 [INFO] [stderr] | [INFO] [stderr] 147 | try!(func.call().map_err(|err| Error::from(err)).wrap_err_to_err()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `test::util::stream_pair::StreamPair` [INFO] [stderr] --> src/test/util/stream_pair.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> StreamPair { [INFO] [stderr] 13 | | let buffer = Vec::new(); [INFO] [stderr] 14 | | let cursor = Cursor::new(buffer); [INFO] [stderr] 15 | | let mutex = Mutex::new(cursor); [INFO] [stderr] 16 | | let arc = Arc::new(mutex); [INFO] [stderr] 17 | | StreamPair{ locking_stream: arc } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 11 | impl Default for test::util::stream_pair::StreamPair { [INFO] [stderr] 12 | fn default() -> Self { [INFO] [stderr] 13 | Self::new() [INFO] [stderr] 14 | } [INFO] [stderr] 15 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/test/util/stream_pair.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn to_pair(self) -> (ReadingEnd, WritingEnd) { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.98s [INFO] running `"docker" "inspect" "7c5d92922573de6dd61d2762cf306ecd23739902c5e326e944224fe62cd3c03a"` [INFO] running `"docker" "rm" "-f" "7c5d92922573de6dd61d2762cf306ecd23739902c5e326e944224fe62cd3c03a"` [INFO] [stdout] 7c5d92922573de6dd61d2762cf306ecd23739902c5e326e944224fe62cd3c03a