[INFO] crate approvals 0.0.7 is already in cache [INFO] extracting crate approvals 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/approvals/0.0.7 [INFO] extracting crate approvals 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/approvals/0.0.7 [INFO] validating manifest of approvals-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of approvals-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing approvals-0.0.7 [INFO] finished frobbing approvals-0.0.7 [INFO] frobbed toml for approvals-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/approvals/0.0.7/Cargo.toml [INFO] started frobbing approvals-0.0.7 [INFO] finished frobbing approvals-0.0.7 [INFO] frobbed toml for approvals-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/approvals/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting approvals-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/approvals/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9afd6fe041e1e441d40c029b52ca8196748cf75cd3e78f8a37bfadac335d2edf [INFO] running `"docker" "start" "-a" "9afd6fe041e1e441d40c029b52ca8196748cf75cd3e78f8a37bfadac335d2edf"` [INFO] [stderr] Checking approvals v0.0.7 (/opt/crater/workdir) [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/method_name/mod.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | level = level + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `level += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/file_system/mod.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match fs::create_dir(path) { [INFO] [stderr] 13 | | Err(err) => panic!("Failed to create directory for approvals data: {}", err), [INFO] [stderr] 14 | | _ => {} [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = fs::create_dir(path) { panic!("Failed to create directory for approvals data: {}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/file_system/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match file.write_all(&actual.as_bytes()) { [INFO] [stderr] 58 | | Err(err) => panic!("Failed to write actual value to file: {}", err), [INFO] [stderr] 59 | | _ => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = file.write_all(&actual.as_bytes()) { panic!("Failed to write actual value to file: {}", err) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | if actual.trim_right_matches("\n") == contents.trim_right_matches("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:17:71 [INFO] [stderr] | [INFO] [stderr] 17 | if actual.trim_right_matches("\n") == contents.trim_right_matches("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/method_name/mod.rs:20:9 [INFO] [stderr] | [INFO] [stderr] 20 | level = level + 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `level += 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/file_system/mod.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match fs::create_dir(path) { [INFO] [stderr] 13 | | Err(err) => panic!("Failed to create directory for approvals data: {}", err), [INFO] [stderr] 14 | | _ => {} [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(err) = fs::create_dir(path) { panic!("Failed to create directory for approvals data: {}", err) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/file_system/mod.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | / match file.write_all(&actual.as_bytes()) { [INFO] [stderr] 58 | | Err(err) => panic!("Failed to write actual value to file: {}", err), [INFO] [stderr] 59 | | _ => {} [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ help: try this: `if let Err(err) = file.write_all(&actual.as_bytes()) { panic!("Failed to write actual value to file: {}", err) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | if actual.trim_right_matches("\n") == contents.trim_right_matches("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:17:71 [INFO] [stderr] | [INFO] [stderr] 17 | if actual.trim_right_matches("\n") == contents.trim_right_matches("\n") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\n'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.49s [INFO] running `"docker" "inspect" "9afd6fe041e1e441d40c029b52ca8196748cf75cd3e78f8a37bfadac335d2edf"` [INFO] running `"docker" "rm" "-f" "9afd6fe041e1e441d40c029b52ca8196748cf75cd3e78f8a37bfadac335d2edf"` [INFO] [stdout] 9afd6fe041e1e441d40c029b52ca8196748cf75cd3e78f8a37bfadac335d2edf