[INFO] crate app_dirs2 2.0.3 is already in cache
[INFO] extracting crate app_dirs2 2.0.3 into work/ex/clippy-test-run/sources/stable/reg/app_dirs2/2.0.3
[INFO] extracting crate app_dirs2 2.0.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/app_dirs2/2.0.3
[INFO] validating manifest of app_dirs2-2.0.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of app_dirs2-2.0.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing app_dirs2-2.0.3
[INFO] finished frobbing app_dirs2-2.0.3
[INFO] frobbed toml for app_dirs2-2.0.3 written to work/ex/clippy-test-run/sources/stable/reg/app_dirs2/2.0.3/Cargo.toml
[INFO] started frobbing app_dirs2-2.0.3
[INFO] finished frobbing app_dirs2-2.0.3
[INFO] frobbed toml for app_dirs2-2.0.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/app_dirs2/2.0.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting app_dirs2-2.0.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/app_dirs2/2.0.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 294041775f2f640f4082a53d8f5badcd909110e60a10484b6d2d21023bc30378
[INFO] running `"docker" "start" "-a" "294041775f2f640f4082a53d8f5badcd909110e60a10484b6d2d21023bc30378"`
[INFO] [stderr]     Checking app_dirs2 v2.0.3 (/opt/crater/workdir)
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/common.rs:61:27
[INFO] [stderr]    |
[INFO] [stderr] 61 | const ERR_NOT_SUPPORTED: &'static str = "App data directories not supported";
[INFO] [stderr]    |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/common.rs:62:30
[INFO] [stderr]    |
[INFO] [stderr] 62 | const ERR_INVALID_APP_INFO: &'static str = "Invalid app name or author";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/common.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 |     pub fn is_shared(&self) -> bool {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/common.rs:61:27
[INFO] [stderr]    |
[INFO] [stderr] 61 | const ERR_NOT_SUPPORTED: &'static str = "App data directories not supported";
[INFO] [stderr]    |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/common.rs:62:30
[INFO] [stderr]    |
[INFO] [stderr] 62 | const ERR_INVALID_APP_INFO: &'static str = "Invalid app name or author";
[INFO] [stderr]    |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:59:8
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.author.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:59:33
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.name.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/imp/mod.rs:63:37
[INFO] [stderr]    |
[INFO] [stderr] 63 |         for component in path.split("/").filter(|s| s.len() > 0) {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:63:53
[INFO] [stderr]    |
[INFO] [stderr] 63 |         for component in path.split("/").filter(|s| s.len() > 0) {
[INFO] [stderr]    |                                                     ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:91:8
[INFO] [stderr]    |
[INFO] [stderr] 91 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.author.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:91:33
[INFO] [stderr]    |
[INFO] [stderr] 91 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.name.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/common.rs:52:22
[INFO] [stderr]    |
[INFO] [stderr] 52 |     pub fn is_shared(&self) -> bool {
[INFO] [stderr]    |                      ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:59:8
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.author.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:59:33
[INFO] [stderr]    |
[INFO] [stderr] 59 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.name.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/imp/mod.rs:63:37
[INFO] [stderr]    |
[INFO] [stderr] 63 |         for component in path.split("/").filter(|s| s.len() > 0) {
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'/'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:63:53
[INFO] [stderr]    |
[INFO] [stderr] 63 |         for component in path.split("/").filter(|s| s.len() > 0) {
[INFO] [stderr]    |                                                     ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!s.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:91:8
[INFO] [stderr]    |
[INFO] [stderr] 91 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |        ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.author.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/imp/mod.rs:91:33
[INFO] [stderr]    |
[INFO] [stderr] 91 |     if app.author.len() == 0 || app.name.len() == 0 {
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `app.name.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:49:19
[INFO] [stderr]    |
[INFO] [stderr] 49 |             name: "Awesome App".into(),
[INFO] [stderr]    |                   ^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Awesome App"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/lib.rs:50:21
[INFO] [stderr]    |
[INFO] [stderr] 50 |             author: "Dedicated Dev".into(),
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `"Dedicated Dev"`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.64s
[INFO] running `"docker" "inspect" "294041775f2f640f4082a53d8f5badcd909110e60a10484b6d2d21023bc30378"`
[INFO] running `"docker" "rm" "-f" "294041775f2f640f4082a53d8f5badcd909110e60a10484b6d2d21023bc30378"`
[INFO] [stdout] 294041775f2f640f4082a53d8f5badcd909110e60a10484b6d2d21023bc30378