[INFO] crate app 0.6.5 is already in cache [INFO] extracting crate app 0.6.5 into work/ex/clippy-test-run/sources/stable/reg/app/0.6.5 [INFO] extracting crate app 0.6.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/app/0.6.5 [INFO] validating manifest of app-0.6.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of app-0.6.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing app-0.6.5 [INFO] finished frobbing app-0.6.5 [INFO] frobbed toml for app-0.6.5 written to work/ex/clippy-test-run/sources/stable/reg/app/0.6.5/Cargo.toml [INFO] started frobbing app-0.6.5 [INFO] finished frobbing app-0.6.5 [INFO] frobbed toml for app-0.6.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/app/0.6.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting app-0.6.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/app/0.6.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] dddd7bf525cb695dd846bebf845ad145997f090b3a8c3cac9f3894f56e78e82b [INFO] running `"docker" "start" "-a" "dddd7bf525cb695dd846bebf845ad145997f090b3a8c3cac9f3894f56e78e82b"` [INFO] [stderr] Checking stderr v0.8.0 [INFO] [stderr] Checking app v0.6.5 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:669:24 [INFO] [stderr] | [INFO] [stderr] 669 | #[allow(unknown_lints, needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:950:13 [INFO] [stderr] | [INFO] [stderr] 950 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:669:24 [INFO] [stderr] | [INFO] [stderr] 669 | #[allow(unknown_lints, needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:950:13 [INFO] [stderr] | [INFO] [stderr] 950 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:669:24 [INFO] [stderr] | [INFO] [stderr] 669 | #[allow(unknown_lints, needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:669:24 [INFO] [stderr] | [INFO] [stderr] 669 | #[allow(unknown_lints, needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:277:32 [INFO] [stderr] | [INFO] [stderr] 277 | self.helper.home_dir = env::home_dir().map(|s| s.to_string_lossy().into_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:277:32 [INFO] [stderr] | [INFO] [stderr] 277 | self.helper.home_dir = env::home_dir().map(|s| s.to_string_lossy().into_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elesref.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | fn check(&self, rg0: &usize, rg1: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elesref.rs:37:39 [INFO] [stderr] | [INFO] [stderr] 37 | fn check(&self, rg0: &usize, rg1: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ovp.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | fn check(&self, opt_name: &str, optional: &bool, count: &usize, typo: &OptTypo) -> Result<(), String>; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ovp.rs:79:61 [INFO] [stderr] | [INFO] [stderr] 79 | fn check(&self, opt_name: &str, optional: &bool, count: &usize, typo: &OptTypo) -> Result<(), String>; [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `joins` which has no body [INFO] [stderr] --> src/ovp.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 386 | | fn joins(&self, sep: &str) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elesref.rs:37:26 [INFO] [stderr] | [INFO] [stderr] 37 | fn check(&self, rg0: &usize, rg1: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/elesref.rs:37:39 [INFO] [stderr] | [INFO] [stderr] 37 | fn check(&self, rg0: &usize, rg1: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ovp.rs:525:39 [INFO] [stderr] | [INFO] [stderr] 525 | let len = typo.multiple_get().expect(&format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 526 | | "OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", [INFO] [stderr] 527 | | opt_name, self, [INFO] [stderr] 528 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", opt_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ovp.rs:79:47 [INFO] [stderr] | [INFO] [stderr] 79 | fn check(&self, opt_name: &str, optional: &bool, count: &usize, typo: &OptTypo) -> Result<(), String>; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ovp.rs:79:61 [INFO] [stderr] | [INFO] [stderr] 79 | fn check(&self, opt_name: &str, optional: &bool, count: &usize, typo: &OptTypo) -> Result<(), String>; [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ovp.rs:574:39 [INFO] [stderr] | [INFO] [stderr] 574 | let len = typo.multiple_get().expect(&format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 575 | | "OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", [INFO] [stderr] 576 | | opt_name, self, [INFO] [stderr] 577 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", opt_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/avp.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | fn check(&self, args_name: &str, optional: &bool, count: &usize, len: Option<&usize>) -> Result<(), String>; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/avp.rs:70:62 [INFO] [stderr] | [INFO] [stderr] 70 | fn check(&self, args_name: &str, optional: &bool, count: &usize, len: Option<&usize>) -> Result<(), String>; [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: use of `#[inline]` on trait method `joins` which has no body [INFO] [stderr] --> src/ovp.rs:385:5 [INFO] [stderr] | [INFO] [stderr] 385 | #[inline] [INFO] [stderr] | _____-^^^^^^^^ [INFO] [stderr] 386 | | fn joins(&self, sep: &str) -> Option; [INFO] [stderr] | |____- help: remove [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::inline_fn_without_body)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inline_fn_without_body [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ovp.rs:525:39 [INFO] [stderr] | [INFO] [stderr] 525 | let len = typo.multiple_get().expect(&format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 526 | | "OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", [INFO] [stderr] 527 | | opt_name, self, [INFO] [stderr] 528 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", opt_name))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/ovp.rs:574:39 [INFO] [stderr] | [INFO] [stderr] 574 | let len = typo.multiple_get().expect(&format!( [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 575 | | "OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", [INFO] [stderr] 576 | | opt_name, self, [INFO] [stderr] 577 | | )); [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|| panic!("OPTION(<{}>)'s value: can't set as None of the length of slice \"{:?}\"", opt_name))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:312:47 [INFO] [stderr] | [INFO] [stderr] 312 | fn flag_contains(arg: &str, flag: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/avp.rs:70:48 [INFO] [stderr] | [INFO] [stderr] 70 | fn check(&self, args_name: &str, optional: &bool, count: &usize, len: Option<&usize>) -> Result<(), String>; [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/avp.rs:70:62 [INFO] [stderr] | [INFO] [stderr] 70 | fn check(&self, args_name: &str, optional: &bool, count: &usize, len: Option<&usize>) -> Result<(), String>; [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:556:59 [INFO] [stderr] | [INFO] [stderr] 556 | fn parse(&mut self, args: &[String], app_has_subcmds: &bool) -> Result<(), String> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `app`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:312:47 [INFO] [stderr] | [INFO] [stderr] 312 | fn flag_contains(arg: &str, flag: &char) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:556:59 [INFO] [stderr] | [INFO] [stderr] 556 | fn parse(&mut self, args: &[String], app_has_subcmds: &bool) -> Result<(), String> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `app`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "dddd7bf525cb695dd846bebf845ad145997f090b3a8c3cac9f3894f56e78e82b"` [INFO] running `"docker" "rm" "-f" "dddd7bf525cb695dd846bebf845ad145997f090b3a8c3cac9f3894f56e78e82b"` [INFO] [stdout] dddd7bf525cb695dd846bebf845ad145997f090b3a8c3cac9f3894f56e78e82b