[INFO] crate apint 0.2.0 is already in cache [INFO] extracting crate apint 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/apint/0.2.0 [INFO] extracting crate apint 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/apint/0.2.0 [INFO] validating manifest of apint-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of apint-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing apint-0.2.0 [INFO] finished frobbing apint-0.2.0 [INFO] frobbed toml for apint-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/apint/0.2.0/Cargo.toml [INFO] started frobbing apint-0.2.0 [INFO] finished frobbing apint-0.2.0 [INFO] frobbed toml for apint-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/apint/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting apint-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/apint/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 054704d73bae52cd82140d98cc280ae2de91c0f2b837a3fe388011e5cff91042 [INFO] running `"docker" "start" "-a" "054704d73bae52cd82140d98cc280ae2de91c0f2b837a3fe388011e5cff91042"` [INFO] [stderr] Checking apint v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/apint/to_primitive.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / if prim_ty.is_signed() { [INFO] [stderr] 139 | | if actual_width < target_width { [INFO] [stderr] 140 | | lsd.sign_extend_from(actual_width) [INFO] [stderr] 141 | | .expect("We already asserted that `actual_width` < `target_width` \ [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if prim_ty.is_signed() && actual_width < target_width { [INFO] [stderr] 139 | lsd.sign_extend_from(actual_width) [INFO] [stderr] 140 | .expect("We already asserted that `actual_width` < `target_width` \ [INFO] [stderr] 141 | and since `target_width` is always less than or equal to \ [INFO] [stderr] 142 | `64` bits calling `Digit::sign_extend_from` is safe for it."); [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/apint/constructors.rs:391:2 [INFO] [stderr] | [INFO] [stderr] 391 | mod tests { [INFO] [stderr] | _____^ [INFO] [stderr] 392 | | use super::{powers, powers_from_to}; [INFO] [stderr] 393 | | [INFO] [stderr] 394 | | #[test] [INFO] [stderr] ... | [INFO] [stderr] 423 | | } [INFO] [stderr] 424 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/arithmetic.rs:493:11 [INFO] [stderr] | [INFO] [stderr] 493 | 1337, 123123, 999999, 987432, 77216417].into_iter().map(|v| *v) [INFO] [stderr] | ^^^^^^ help: consider: `123_123` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/arithmetic.rs:493:19 [INFO] [stderr] | [INFO] [stderr] 493 | 1337, 123123, 999999, 987432, 77216417].into_iter().map(|v| *v) [INFO] [stderr] | ^^^^^^ help: consider: `999_999` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/arithmetic.rs:493:27 [INFO] [stderr] | [INFO] [stderr] 493 | 1337, 123123, 999999, 987432, 77216417].into_iter().map(|v| *v) [INFO] [stderr] | ^^^^^^ help: consider: `987_432` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/arithmetic.rs:493:35 [INFO] [stderr] | [INFO] [stderr] 493 | 1337, 123123, 999999, 987432, 77216417].into_iter().map(|v| *v) [INFO] [stderr] | ^^^^^^^^ help: consider: `77_216_417` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/apint/to_primitive.rs:138:9 [INFO] [stderr] | [INFO] [stderr] 138 | / if prim_ty.is_signed() { [INFO] [stderr] 139 | | if actual_width < target_width { [INFO] [stderr] 140 | | lsd.sign_extend_from(actual_width) [INFO] [stderr] 141 | | .expect("We already asserted that `actual_width` < `target_width` \ [INFO] [stderr] ... | [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 138 | if prim_ty.is_signed() && actual_width < target_width { [INFO] [stderr] 139 | lsd.sign_extend_from(actual_width) [INFO] [stderr] 140 | .expect("We already asserted that `actual_width` < `target_width` \ [INFO] [stderr] 141 | and since `target_width` is always less than or equal to \ [INFO] [stderr] 142 | `64` bits calling `Digit::sign_extend_from` is safe for it."); [INFO] [stderr] 143 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/rand_impl.rs:71:88 [INFO] [stderr] | [INFO] [stderr] 71 | assert_eq!(ApInt::random_with_width_using(BitWidth::w32(), r), ApInt::from_u32(2466290541)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_466_290_541` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/rand_impl.rs:72:88 [INFO] [stderr] | [INFO] [stderr] 72 | assert_eq!(ApInt::random_with_width_using(BitWidth::w64(), r), ApInt::from_u64(16730135874920933484)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `16_730_135_874_920_933_484` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/apint/rand_impl.rs:73:90 [INFO] [stderr] | [INFO] [stderr] 73 | assert_eq!(ApInt::random_with_width_using(BitWidth::w128(), r), ApInt::from_u128(217725508292902744084870179638383324996)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `217_725_508_292_902_744_084_870_179_638_383_324_996` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/apint/serde_impl.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | 0xFEDC_BA98_7654_3210__0101_1010_0110_1001); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xFEDC_BA98_7654_3210_0101_1010_0110_1001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_hi_lo` [INFO] [stderr] --> src/digit.rs:194:2 [INFO] [stderr] | [INFO] [stderr] 194 | pub(crate) fn from_hi_lo(hi: Digit, lo: Digit) -> DoubleDigit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/digit.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | .with_annotation(format!("Encountered invalid `BitWidth` for operating \ [INFO] [stderr] | __________________________________^ [INFO] [stderr] 260 | | on a `Digit`."))) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 259 | .with_annotation("Encountered invalid `BitWidth` for operating \ [INFO] [stderr] 260 | on a `Digit`.".to_string())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:366:6 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(self.0 |= 0x01 << pos.to_usize()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 366 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:380:6 [INFO] [stderr] | [INFO] [stderr] 380 | Ok(self.0 &= !(0x01 << pos.to_usize())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 380 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:394:6 [INFO] [stderr] | [INFO] [stderr] 394 | Ok(self.0 ^= 0x01 << pos.to_usize()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 394 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:427:6 [INFO] [stderr] | [INFO] [stderr] 427 | Ok(self.0 &= !(REPR_ONES << n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 427 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitwidth.rs:135:32 [INFO] [stderr] | [INFO] [stderr] 135 | pub(crate) fn required_digits(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bitpos.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | let digit_pos = DigitPos::from(self.0 / digit::BITS); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `DigitPos::from()`: `self.0 / digit::BITS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/apint/utils.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | for (l, &r) in lhs.into_iter().zip(rhs) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/utils.rs:312:12 [INFO] [stderr] | [INFO] [stderr] 312 | digits.into_iter().all(|digit| digit.is_zero()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/utils.rs:332:27 [INFO] [stderr] | [INFO] [stderr] 332 | last.is_one() && rest.into_iter().all(|digit| digit.is_zero()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/bitwise.rs:275:8 [INFO] [stderr] | [INFO] [stderr] 275 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/bitwise.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/bitwise.rs:295:34 [INFO] [stderr] | [INFO] [stderr] 295 | for d in self.as_digit_slice().into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/relational.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | for (l, r) in lhs.into_iter().rev() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/relational.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | .zip(rhs.into_iter().rev()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/apint/arithmetic.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | for (l, r) in lhs.into_iter().zip(rhs) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/apint/arithmetic.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | for (l, r) in lhs.into_iter().zip(rhs) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | let mut l = lhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lhs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | let mut r = rhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | let mut l = lhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | let mut r = rhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/apint/shift.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | let dst_ptr = src_ptr.offset(digit_steps as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src_ptr.add(digit_steps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/shift.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | let mut signed = digit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/serialization.rs:13:38 [INFO] [stderr] | [INFO] [stderr] 13 | let mut ds = self.as_digit_slice().into_iter().rev(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/serialization.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | let mut ds = self.as_digit_slice().into_iter().rev(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/serialization.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | let mut ds = self.as_digit_slice().into_iter().rev(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/to_primitive.rs:342:20 [INFO] [stderr] | [INFO] [stderr] 342 | || rest.into_iter().any(|d| d.repr() != 0) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/to_primitive.rs:539:17 [INFO] [stderr] | [INFO] [stderr] 539 | if rest.into_iter().any(|d| d.repr() != 0) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/to_primitive.rs:577:17 [INFO] [stderr] | [INFO] [stderr] 577 | if rest.into_iter().any(|d| d.repr() != 0) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/digit.rs:259:22 [INFO] [stderr] | [INFO] [stderr] 259 | .with_annotation(format!("Encountered invalid `BitWidth` for operating \ [INFO] [stderr] | __________________________________^ [INFO] [stderr] 260 | | on a `Digit`."))) [INFO] [stderr] | |_________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] help: consider using .to_string() [INFO] [stderr] | [INFO] [stderr] 259 | .with_annotation("Encountered invalid `BitWidth` for operating \ [INFO] [stderr] 260 | on a `Digit`.".to_string())) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:366:6 [INFO] [stderr] | [INFO] [stderr] 366 | Ok(self.0 |= 0x01 << pos.to_usize()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 366 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:380:6 [INFO] [stderr] | [INFO] [stderr] 380 | Ok(self.0 &= !(0x01 << pos.to_usize())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 380 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:394:6 [INFO] [stderr] | [INFO] [stderr] 394 | Ok(self.0 ^= 0x01 << pos.to_usize()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 394 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/digit.rs:427:6 [INFO] [stderr] | [INFO] [stderr] 427 | Ok(self.0 &= !(REPR_ONES << n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 427 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/digit.rs:745:45 [INFO] [stderr] | [INFO] [stderr] 745 | assert_eq!(Digit(val).dd(), DoubleDigit(val as DoubleDigitRepr)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bitwidth.rs:135:32 [INFO] [stderr] | [INFO] [stderr] 135 | pub(crate) fn required_digits(&self) -> usize { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/bitpos.rs:44:19 [INFO] [stderr] | [INFO] [stderr] 44 | let digit_pos = DigitPos::from(self.0 / digit::BITS); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `DigitPos::from()`: `self.0 / digit::BITS` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/apint/constructors.rs:397:33 [INFO] [stderr] | [INFO] [stderr] 397 | assert_eq!(pows.next(), Some(1 << 0)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/apint/constructors.rs:410:36 [INFO] [stderr] | [INFO] [stderr] 410 | assert_eq!(powsft.next(), Some(1 << 0)); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/apint/constructors.rs:429:11 [INFO] [stderr] | [INFO] [stderr] 429 | .chain([ [INFO] [stderr] | ____________________^ [INFO] [stderr] 430 | | u8::max_value(), [INFO] [stderr] 431 | | 10, [INFO] [stderr] 432 | | 42, [INFO] [stderr] ... | [INFO] [stderr] 435 | | ].into_iter() [INFO] [stderr] 436 | | .map(|v| *v)) [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 429 | .chain([ [INFO] [stderr] 430 | u8::max_value(), [INFO] [stderr] 431 | 10, [INFO] [stderr] 432 | 42, [INFO] [stderr] 433 | 99, [INFO] [stderr] 434 | 123 [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:435:6 [INFO] [stderr] | [INFO] [stderr] 435 | ].into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/apint/constructors.rs:480:11 [INFO] [stderr] | [INFO] [stderr] 480 | .chain([ [INFO] [stderr] | ____________________^ [INFO] [stderr] 481 | | u16::max_value(), [INFO] [stderr] 482 | | 500, [INFO] [stderr] 483 | | 1000, [INFO] [stderr] ... | [INFO] [stderr] 486 | | 42_000 [INFO] [stderr] 487 | | ].into_iter().map(|v| *v)) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 480 | .chain([ [INFO] [stderr] 481 | u16::max_value(), [INFO] [stderr] 482 | 500, [INFO] [stderr] 483 | 1000, [INFO] [stderr] 484 | 1337, [INFO] [stderr] 485 | 7777, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:487:6 [INFO] [stderr] | [INFO] [stderr] 487 | ].into_iter().map(|v| *v)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/apint/constructors.rs:513:11 [INFO] [stderr] | [INFO] [stderr] 513 | .chain([ [INFO] [stderr] | ____________________^ [INFO] [stderr] 514 | | u32::max_value(), [INFO] [stderr] 515 | | 1_000_000, [INFO] [stderr] 516 | | 999_999_999, [INFO] [stderr] 517 | | 1_234_567_890 [INFO] [stderr] 518 | | ].into_iter().map(|v| *v)) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 513 | .chain([ [INFO] [stderr] 514 | u32::max_value(), [INFO] [stderr] 515 | 1_000_000, [INFO] [stderr] 516 | 999_999_999, [INFO] [stderr] 517 | 1_234_567_890 [INFO] [stderr] 518 | ].into_iter().cloned()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:518:6 [INFO] [stderr] | [INFO] [stderr] 518 | ].into_iter().map(|v| *v)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/apint/constructors.rs:544:11 [INFO] [stderr] | [INFO] [stderr] 544 | .chain([ [INFO] [stderr] | ____________________^ [INFO] [stderr] 545 | | u64::max_value(), [INFO] [stderr] 546 | | 1_000_000_000_000, [INFO] [stderr] 547 | | 999_999_999_999_999_999, [INFO] [stderr] 548 | | 0x0123_4567_89AB_CDEF [INFO] [stderr] 549 | | ].into_iter().map(|v| *v)) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 544 | .chain([ [INFO] [stderr] 545 | u64::max_value(), [INFO] [stderr] 546 | 1_000_000_000_000, [INFO] [stderr] 547 | 999_999_999_999_999_999, [INFO] [stderr] 548 | 0x0123_4567_89AB_CDEF [INFO] [stderr] 549 | ].into_iter().cloned()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:549:6 [INFO] [stderr] | [INFO] [stderr] 549 | ].into_iter().map(|v| *v)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/apint/constructors.rs:561:32 [INFO] [stderr] | [INFO] [stderr] 561 | data: ApIntData{inl: Digit(u64::from(val))} [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider removing `u64::from()`: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/apint/constructors.rs:575:11 [INFO] [stderr] | [INFO] [stderr] 575 | .chain([ [INFO] [stderr] | ____________________^ [INFO] [stderr] 576 | | u128::max_value(), [INFO] [stderr] 577 | | 1_000_000_000_000_000_000_000_000, [INFO] [stderr] 578 | | 999_999_999_999_999_999_999_999_999, [INFO] [stderr] 579 | | 0x0123_4567_89AB_CDEF_FEDC_BA98_7654_3210 [INFO] [stderr] 580 | | ].into_iter().map(|v| *v)) [INFO] [stderr] | |_____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 575 | .chain([ [INFO] [stderr] 576 | u128::max_value(), [INFO] [stderr] 577 | 1_000_000_000_000_000_000_000_000, [INFO] [stderr] 578 | 999_999_999_999_999_999_999_999_999, [INFO] [stderr] 579 | 0x0123_4567_89AB_CDEF_FEDC_BA98_7654_3210 [INFO] [stderr] 580 | ].into_iter().cloned()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:580:6 [INFO] [stderr] | [INFO] [stderr] 580 | ].into_iter().map(|v| *v)) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:634:5 [INFO] [stderr] | [INFO] [stderr] 634 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:675:5 [INFO] [stderr] | [INFO] [stderr] 675 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/constructors.rs:689:5 [INFO] [stderr] | [INFO] [stderr] 689 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/apint/utils.rs:203:24 [INFO] [stderr] | [INFO] [stderr] 203 | for (l, &r) in lhs.into_iter().zip(rhs) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/utils.rs:312:12 [INFO] [stderr] | [INFO] [stderr] 312 | digits.into_iter().all(|digit| digit.is_zero()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/utils.rs:332:27 [INFO] [stderr] | [INFO] [stderr] 332 | last.is_one() && rest.into_iter().all(|digit| digit.is_zero()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/bitwise.rs:275:8 [INFO] [stderr] | [INFO] [stderr] 275 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/bitwise.rs:283:5 [INFO] [stderr] | [INFO] [stderr] 283 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/bitwise.rs:295:34 [INFO] [stderr] | [INFO] [stderr] 295 | for d in self.as_digit_slice().into_iter().rev() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/relational.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | for (l, r) in lhs.into_iter().rev() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/relational.rs:52:31 [INFO] [stderr] | [INFO] [stderr] 52 | .zip(rhs.into_iter().rev()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/apint/arithmetic.rs:73:23 [INFO] [stderr] | [INFO] [stderr] 73 | for (l, r) in lhs.into_iter().zip(rhs) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/apint/arithmetic.rs:117:23 [INFO] [stderr] | [INFO] [stderr] 117 | for (l, r) in lhs.into_iter().zip(rhs) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | let mut l = lhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lhs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:247:17 [INFO] [stderr] | [INFO] [stderr] 247 | let mut r = rhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:340:17 [INFO] [stderr] | [INFO] [stderr] 340 | let mut l = lhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try dereferencing it: `*lhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/arithmetic.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | let mut r = rhs.clone(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `rhs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/apint/arithmetic.rs:492:4 [INFO] [stderr] | [INFO] [stderr] 492 | [0_i128, 1, 2, 4, 5, 7, 10, 42, 50, 100, 128, 150, [INFO] [stderr] | _____________^ [INFO] [stderr] 493 | | 1337, 123123, 999999, 987432, 77216417].into_iter().map(|v| *v) [INFO] [stderr] | |____________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 492 | [0_i128, 1, 2, 4, 5, 7, 10, 42, 50, 100, 128, 150, [INFO] [stderr] 493 | 1337, 123123, 999999, 987432, 77216417].into_iter().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/arithmetic.rs:493:45 [INFO] [stderr] | [INFO] [stderr] 493 | 1337, 123123, 999999, 987432, 77216417].into_iter().map(|v| *v) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/apint/shift.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | let dst_ptr = src_ptr.offset(digit_steps as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `src_ptr.add(digit_steps)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/apint/shift.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | let mut signed = digit.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try dereferencing it: `*digit` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/serialization.rs:13:38 [INFO] [stderr] | [INFO] [stderr] 13 | let mut ds = self.as_digit_slice().into_iter().rev(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/serialization.rs:43:38 [INFO] [stderr] | [INFO] [stderr] 43 | let mut ds = self.as_digit_slice().into_iter().rev(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/serialization.rs:63:38 [INFO] [stderr] | [INFO] [stderr] 63 | let mut ds = self.as_digit_slice().into_iter().rev(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/apint/serialization.rs:478:33 [INFO] [stderr] | [INFO] [stderr] 478 | [2, 4, 8, 16, 32, 7, 10, 36].into_iter().map(|&r| Radix::new(r).unwrap()) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/to_primitive.rs:342:20 [INFO] [stderr] | [INFO] [stderr] 342 | || rest.into_iter().any(|d| d.repr() != 0) [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/to_primitive.rs:539:17 [INFO] [stderr] | [INFO] [stderr] 539 | if rest.into_iter().any(|d| d.repr() != 0) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/apint/to_primitive.rs:577:17 [INFO] [stderr] | [INFO] [stderr] 577 | if rest.into_iter().any(|d| d.repr() != 0) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:651:26 [INFO] [stderr] | [INFO] [stderr] 651 | (val as u8 as u128, ApInt::from_i8(val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u128::from(val as u8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:655:26 [INFO] [stderr] | [INFO] [stderr] 655 | (val as u128, ApInt::from_u8(val)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:659:26 [INFO] [stderr] | [INFO] [stderr] 659 | (val as u16 as u128, ApInt::from_i16(val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u128::from(val as u16)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:663:26 [INFO] [stderr] | [INFO] [stderr] 663 | (val as u128, ApInt::from_u16(val)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:667:26 [INFO] [stderr] | [INFO] [stderr] 667 | (val as u32 as u128, ApInt::from_i32(val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u128::from(val as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:671:26 [INFO] [stderr] | [INFO] [stderr] 671 | (val as u128, ApInt::from_u32(val)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:675:26 [INFO] [stderr] | [INFO] [stderr] 675 | (val as u64 as u128, ApInt::from_i64(val)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u128::from(val as u64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u64 to u128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:679:26 [INFO] [stderr] | [INFO] [stderr] 679 | (val as u128, ApInt::from_u64(val)) [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:682:35 [INFO] [stderr] | [INFO] [stderr] 682 | let val = val as i128; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `i128::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i64 to i128 may become silently lossy if types change [INFO] [stderr] --> src/apint/to_primitive.rs:823:56 [INFO] [stderr] | [INFO] [stderr] 823 | assert_eq!(apint.resize_to_i128(), digit.repr() as i64 as i128); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i128::from(digit.repr() as i64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `apint`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "054704d73bae52cd82140d98cc280ae2de91c0f2b837a3fe388011e5cff91042"` [INFO] running `"docker" "rm" "-f" "054704d73bae52cd82140d98cc280ae2de91c0f2b837a3fe388011e5cff91042"` [INFO] [stdout] 054704d73bae52cd82140d98cc280ae2de91c0f2b837a3fe388011e5cff91042