[INFO] crate aovec 1.1.0 is already in cache [INFO] extracting crate aovec 1.1.0 into work/ex/clippy-test-run/sources/stable/reg/aovec/1.1.0 [INFO] extracting crate aovec 1.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aovec/1.1.0 [INFO] validating manifest of aovec-1.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aovec-1.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aovec-1.1.0 [INFO] finished frobbing aovec-1.1.0 [INFO] frobbed toml for aovec-1.1.0 written to work/ex/clippy-test-run/sources/stable/reg/aovec/1.1.0/Cargo.toml [INFO] started frobbing aovec-1.1.0 [INFO] finished frobbing aovec-1.1.0 [INFO] frobbed toml for aovec-1.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aovec/1.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting aovec-1.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aovec/1.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2a7a5ac74c1f9f9c4f40d4a69e4ca7a893b1f4d4f82e82a239051945d7856af7 [INFO] running `"docker" "start" "-a" "2a7a5ac74c1f9f9c4f40d4a69e4ca7a893b1f4d4f82e82a239051945d7856af7"` [INFO] [stderr] Checking aovec v1.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: item `Aovec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / impl Aovec { [INFO] [stderr] 20 | | /// Creates a new `Aovec` [INFO] [stderr] 21 | | /// [INFO] [stderr] 22 | | /// The `base` of the vector is how many elements the first allocation [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | compare = compare << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compare <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if (*allocation).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*allocation).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: item `Aovec` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | / impl Aovec { [INFO] [stderr] 20 | | /// Creates a new `Aovec` [INFO] [stderr] 21 | | /// [INFO] [stderr] 22 | | /// The `base` of the vector is how many elements the first allocation [INFO] [stderr] ... | [INFO] [stderr] 113 | | } [INFO] [stderr] 114 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | compare = compare << 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compare <<= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:107:16 [INFO] [stderr] | [INFO] [stderr] 107 | if (*allocation).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*allocation).is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `vec` [INFO] [stderr] --> src/lib.rs:142:18 [INFO] [stderr] | [INFO] [stderr] 142 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 142 | for (i, ) in vec.iter().enumerate().take(n) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `vec`. [INFO] [stderr] --> src/lib.rs:189:18 [INFO] [stderr] | [INFO] [stderr] 189 | for i in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 189 | for in vec.iter().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.51s [INFO] running `"docker" "inspect" "2a7a5ac74c1f9f9c4f40d4a69e4ca7a893b1f4d4f82e82a239051945d7856af7"` [INFO] running `"docker" "rm" "-f" "2a7a5ac74c1f9f9c4f40d4a69e4ca7a893b1f4d4f82e82a239051945d7856af7"` [INFO] [stdout] 2a7a5ac74c1f9f9c4f40d4a69e4ca7a893b1f4d4f82e82a239051945d7856af7