[INFO] crate anymsg 0.1.0 is already in cache [INFO] extracting crate anymsg 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/anymsg/0.1.0 [INFO] extracting crate anymsg 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/anymsg/0.1.0 [INFO] validating manifest of anymsg-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anymsg-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anymsg-0.1.0 [INFO] finished frobbing anymsg-0.1.0 [INFO] frobbed toml for anymsg-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/anymsg/0.1.0/Cargo.toml [INFO] started frobbing anymsg-0.1.0 [INFO] finished frobbing anymsg-0.1.0 [INFO] frobbed toml for anymsg-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/anymsg/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anymsg-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/anymsg/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e2235920b6e1ed5b66e7ed3f7c39745d830fae4747cbbb9e29ac4f78d02d027 [INFO] running `"docker" "start" "-a" "1e2235920b6e1ed5b66e7ed3f7c39745d830fae4747cbbb9e29ac4f78d02d027"` [INFO] [stderr] Checking anymsg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking criterion v0.2.9 [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:147:19 [INFO] [stderr] | [INFO] [stderr] 147 | let res = self.sender.send((TypeId::of::(), Arc::new(msg))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Pump` [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn new() -> Self { [INFO] [stderr] 99 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 100 | | Self { [INFO] [stderr] 101 | | incoming_txside: tx, [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | impl Default for Pump { [INFO] [stderr] 98 | fn default() -> Self { [INFO] [stderr] 99 | Self::new() [INFO] [stderr] 100 | } [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | self.outgoing.entry(*msg_id).or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:133:43 [INFO] [stderr] | [INFO] [stderr] 133 | outgoing.entry(msg.0).or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EventLoopMapping` [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new() -> Self { [INFO] [stderr] 170 | | Self { [INFO] [stderr] 171 | | client_map: Map::new(), [INFO] [stderr] 172 | | handler_map: Map::new() [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 163 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn add_client<'a, C: Any + Send>(&'a mut self, client: C) -> ELHandlerAdder<'a, C> { [INFO] [stderr] 177 | | assert!(!self.client_map.contains_key(&TypeId::of::())); [INFO] [stderr] 178 | | self.client_map.insert(TypeId::of::(), Box::new(client)); [INFO] [stderr] 179 | | [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:227:14 [INFO] [stderr] | [INFO] [stderr] 227 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:148:9 [INFO] [stderr] | [INFO] [stderr] 148 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:147:19 [INFO] [stderr] | [INFO] [stderr] 147 | let res = self.sender.send((TypeId::of::(), Arc::new(msg))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Pump` [INFO] [stderr] --> src/lib.rs:98:5 [INFO] [stderr] | [INFO] [stderr] 98 | / pub fn new() -> Self { [INFO] [stderr] 99 | | let (tx, rx) = mpsc::channel(); [INFO] [stderr] 100 | | Self { [INFO] [stderr] 101 | | incoming_txside: tx, [INFO] [stderr] ... | [INFO] [stderr] 104 | | } [INFO] [stderr] 105 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 97 | impl Default for Pump { [INFO] [stderr] 98 | fn default() -> Self { [INFO] [stderr] 99 | Self::new() [INFO] [stderr] 100 | } [INFO] [stderr] 101 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:110:42 [INFO] [stderr] | [INFO] [stderr] 110 | self.outgoing.entry(*msg_id).or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:133:43 [INFO] [stderr] | [INFO] [stderr] 133 | outgoing.entry(msg.0).or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `EventLoopMapping` [INFO] [stderr] --> src/lib.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | / pub fn new() -> Self { [INFO] [stderr] 170 | | Self { [INFO] [stderr] 171 | | client_map: Map::new(), [INFO] [stderr] 172 | | handler_map: Map::new() [INFO] [stderr] 173 | | } [INFO] [stderr] 174 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 163 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:176:5 [INFO] [stderr] | [INFO] [stderr] 176 | / pub fn add_client<'a, C: Any + Send>(&'a mut self, client: C) -> ELHandlerAdder<'a, C> { [INFO] [stderr] 177 | | assert!(!self.client_map.contains_key(&TypeId::of::())); [INFO] [stderr] 178 | | self.client_map.insert(TypeId::of::(), Box::new(client)); [INFO] [stderr] 179 | | [INFO] [stderr] ... | [INFO] [stderr] 183 | | } [INFO] [stderr] 184 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:227:14 [INFO] [stderr] | [INFO] [stderr] 227 | .or_insert(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> benches/throughput.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `this` [INFO] [stderr] --> benches/throughput.rs:20:23 [INFO] [stderr] | [INFO] [stderr] 20 | .add_handler(|this, _: &MsgIncr| { [INFO] [stderr] | ^^^^ help: consider using `_this` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `this` [INFO] [stderr] --> benches/throughput.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | .add_handler(|this, _: &MsgIncr| { [INFO] [stderr] | ^^^^ help: consider using `_this` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `this` [INFO] [stderr] --> benches/throughput.rs:53:23 [INFO] [stderr] | [INFO] [stderr] 53 | .add_handler(|this, _: &MsgFin| { [INFO] [stderr] | ^^^^ help: consider using `_this` instead [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> benches/throughput.rs:38:46 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn receive_events(b: &mut Bencher, size: &usize) { [INFO] [stderr] | ^^^^^^ help: consider passing by value instead: `usize` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.32s [INFO] running `"docker" "inspect" "1e2235920b6e1ed5b66e7ed3f7c39745d830fae4747cbbb9e29ac4f78d02d027"` [INFO] running `"docker" "rm" "-f" "1e2235920b6e1ed5b66e7ed3f7c39745d830fae4747cbbb9e29ac4f78d02d027"` [INFO] [stdout] 1e2235920b6e1ed5b66e7ed3f7c39745d830fae4747cbbb9e29ac4f78d02d027