[INFO] crate annotate-snippets 0.1.0 is already in cache [INFO] extracting crate annotate-snippets 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/annotate-snippets/0.1.0 [INFO] extracting crate annotate-snippets 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/annotate-snippets/0.1.0 [INFO] validating manifest of annotate-snippets-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of annotate-snippets-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing annotate-snippets-0.1.0 [INFO] finished frobbing annotate-snippets-0.1.0 [INFO] frobbed toml for annotate-snippets-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/annotate-snippets/0.1.0/Cargo.toml [INFO] started frobbing annotate-snippets-0.1.0 [INFO] finished frobbing annotate-snippets-0.1.0 [INFO] frobbed toml for annotate-snippets-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/annotate-snippets/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting annotate-snippets-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/annotate-snippets/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 88a2d974dbcd7e699aedf429aa81967065365c80891a472e2f660e8200aa1685 [INFO] running `"docker" "start" "-a" "88a2d974dbcd7e699aedf429aa81967065365c80891a472e2f660e8200aa1685"` [INFO] [stderr] Checking annotate-snippets v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/display_list/from_snippet.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | let label = annotation.label.clone().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/display_list/from_snippet.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | let label = annotation.label.clone().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `line_index_ranges`. [INFO] [stderr] --> src/display_list/from_snippet.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | for idx in 0..body.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 201 | for in line_index_ranges.iter().take(body.len()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/formatter/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 66 | | Self { [INFO] [stderr] 67 | | stylesheet: Box::new(NoColorStylesheet {}), [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/formatter/mod.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | if color { [INFO] [stderr] | __________________^ [INFO] [stderr] 59 | | Self { [INFO] [stderr] 60 | | #[cfg(feature = "ansi_term")] [INFO] [stderr] 61 | | stylesheet: Box::new(AnsiTermStylesheet {}), [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/display_list/from_snippet.rs:28:42 [INFO] [stderr] | [INFO] [stderr] 28 | let label = annotation.label.clone().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/display_list/from_snippet.rs:42:42 [INFO] [stderr] | [INFO] [stderr] 42 | let label = annotation.label.clone().unwrap_or("".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_string())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: the loop variable `idx` is only used to index `line_index_ranges`. [INFO] [stderr] --> src/display_list/from_snippet.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | for idx in 0..body.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 201 | for in line_index_ranges.iter().take(body.len()) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `annotate-snippets`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/formatter/mod.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 66 | | Self { [INFO] [stderr] 67 | | stylesheet: Box::new(NoColorStylesheet {}), [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/formatter/mod.rs:58:18 [INFO] [stderr] | [INFO] [stderr] 58 | if color { [INFO] [stderr] | __________________^ [INFO] [stderr] 59 | | Self { [INFO] [stderr] 60 | | #[cfg(feature = "ansi_term")] [INFO] [stderr] 61 | | stylesheet: Box::new(AnsiTermStylesheet {}), [INFO] [stderr] ... | [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `annotate-snippets`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "88a2d974dbcd7e699aedf429aa81967065365c80891a472e2f660e8200aa1685"` [INFO] running `"docker" "rm" "-f" "88a2d974dbcd7e699aedf429aa81967065365c80891a472e2f660e8200aa1685"` [INFO] [stdout] 88a2d974dbcd7e699aedf429aa81967065365c80891a472e2f660e8200aa1685