[INFO] crate anitomy 0.1.1 is already in cache [INFO] extracting crate anitomy 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/anitomy/0.1.1 [INFO] extracting crate anitomy 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/anitomy/0.1.1 [INFO] validating manifest of anitomy-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of anitomy-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing anitomy-0.1.1 [INFO] finished frobbing anitomy-0.1.1 [INFO] frobbed toml for anitomy-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/anitomy/0.1.1/Cargo.toml [INFO] started frobbing anitomy-0.1.1 [INFO] finished frobbing anitomy-0.1.1 [INFO] frobbed toml for anitomy-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/anitomy/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting anitomy-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/anitomy/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf06afd9a0b689de163763a1ed6127a02b0dc3b77d4d4289fd95b1d06455c057 [INFO] running `"docker" "start" "-a" "cf06afd9a0b689de163763a1ed6127a02b0dc3b77d4d4289fd95b1d06455c057"` [INFO] [stderr] Compiling anitomy-sys v0.1.2 [INFO] [stderr] Checking anitomy v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:72:33 [INFO] [stderr] | [INFO] [stderr] 72 | allowed_delimiters: allowed_delimiters.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | self.allowed_delimiters = delimiters.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Anitomy` [INFO] [stderr] --> src/lib.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / pub fn new() -> Self { [INFO] [stderr] 240 | | Self { [INFO] [stderr] 241 | | anitomy: unsafe { sys::Anitomy::new() }, [INFO] [stderr] 242 | | } [INFO] [stderr] 243 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 237 | impl Default for Anitomy { [INFO] [stderr] 238 | fn default() -> Self { [INFO] [stderr] 239 | Self::new() [INFO] [stderr] 240 | } [INFO] [stderr] 241 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:300:35 [INFO] [stderr] | [INFO] [stderr] 300 | const BLACK_BULLET_FILENAME: &'static str = [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:302:31 [INFO] [stderr] | [INFO] [stderr] 302 | const TORADORA_FILENAME: &'static str = "[TaigaSubs]_Toradora!_(2008)_-_01v2_-_Tiger_and_Dragon_[1280x720_H.264_FLAC][1234ABCD].mkv"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:72:33 [INFO] [stderr] | [INFO] [stderr] 72 | allowed_delimiters: allowed_delimiters.iter().cloned().collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_cloned_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: called `cloned().collect()` on a slice to create a `Vec`. Calling `to_vec()` is both faster and more readable [INFO] [stderr] --> src/lib.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | self.allowed_delimiters = delimiters.iter().cloned().collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_cloned_collect [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `Anitomy` [INFO] [stderr] --> src/lib.rs:239:5 [INFO] [stderr] | [INFO] [stderr] 239 | / pub fn new() -> Self { [INFO] [stderr] 240 | | Self { [INFO] [stderr] 241 | | anitomy: unsafe { sys::Anitomy::new() }, [INFO] [stderr] 242 | | } [INFO] [stderr] 243 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 237 | impl Default for Anitomy { [INFO] [stderr] 238 | fn default() -> Self { [INFO] [stderr] 239 | Self::new() [INFO] [stderr] 240 | } [INFO] [stderr] 241 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.73s [INFO] running `"docker" "inspect" "cf06afd9a0b689de163763a1ed6127a02b0dc3b77d4d4289fd95b1d06455c057"` [INFO] running `"docker" "rm" "-f" "cf06afd9a0b689de163763a1ed6127a02b0dc3b77d4d4289fd95b1d06455c057"` [INFO] [stdout] cf06afd9a0b689de163763a1ed6127a02b0dc3b77d4d4289fd95b1d06455c057