[INFO] crate android-sparse 0.5.0 is already in cache [INFO] extracting crate android-sparse 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/android-sparse/0.5.0 [INFO] extracting crate android-sparse 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/android-sparse/0.5.0 [INFO] validating manifest of android-sparse-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of android-sparse-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing android-sparse-0.5.0 [INFO] finished frobbing android-sparse-0.5.0 [INFO] frobbed toml for android-sparse-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/android-sparse/0.5.0/Cargo.toml [INFO] started frobbing android-sparse-0.5.0 [INFO] finished frobbing android-sparse-0.5.0 [INFO] frobbed toml for android-sparse-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/android-sparse/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting android-sparse-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/android-sparse/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 475259764e75fbe134e93a8fd1e4273b749296ff486601cef488c5d91f0061ab [INFO] running `"docker" "start" "-a" "475259764e75fbe134e93a8fd1e4273b749296ff486601cef488c5d91f0061ab"` [INFO] [stderr] Checking android-sparse v0.5.0 (/opt/crater/workdir) [INFO] [stderr] Checking predicates v0.9.1 [INFO] [stderr] Checking assert_cmd v0.9.1 [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> tests/read.rs:26:32 [INFO] [stderr] | [INFO] [stderr] 26 | expected.push(Block::Crc32(0xffb880a5)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffb8_80a5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw1` [INFO] [stderr] --> tests/util/mod.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for i in 0..raw1.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for (i, ) in raw1.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/read.rs:266:31 [INFO] [stderr] | [INFO] [stderr] 266 | const U32_BUF: &[u32] = &[0xaaaaaaaa; U32_BLOCK_SIZE]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xaaaa_aaaa` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ext.rs:53:39 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(block_crc(&block), 0xfea63440); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfea6_3440` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ext.rs:59:39 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(block_crc(&block), 0xfea63440); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xfea6_3440` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ext.rs:65:39 [INFO] [stderr] | [INFO] [stderr] 65 | assert_eq!(block_crc(&block), 0xc71c0011); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xc71c_0011` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ext.rs:70:34 [INFO] [stderr] | [INFO] [stderr] 70 | let block = Block::Crc32(0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/headers.rs:159:23 [INFO] [stderr] | [INFO] [stderr] 159 | total_blocks: 262144, [INFO] [stderr] | ^^^^^^ help: consider: `262_144` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw1` [INFO] [stderr] --> tests/util/mod.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for i in 0..raw1.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for (i, ) in raw1.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `raw1` [INFO] [stderr] --> tests/util/mod.rs:30:14 [INFO] [stderr] | [INFO] [stderr] 30 | for i in 0..raw1.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 30 | for (i, ) in raw1.iter_mut().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.63s [INFO] running `"docker" "inspect" "475259764e75fbe134e93a8fd1e4273b749296ff486601cef488c5d91f0061ab"` [INFO] running `"docker" "rm" "-f" "475259764e75fbe134e93a8fd1e4273b749296ff486601cef488c5d91f0061ab"` [INFO] [stdout] 475259764e75fbe134e93a8fd1e4273b749296ff486601cef488c5d91f0061ab