[INFO] crate andrew 0.1.4 is already in cache [INFO] extracting crate andrew 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/andrew/0.1.4 [INFO] extracting crate andrew 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/andrew/0.1.4 [INFO] validating manifest of andrew-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of andrew-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing andrew-0.1.4 [INFO] finished frobbing andrew-0.1.4 [INFO] frobbed toml for andrew-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/andrew/0.1.4/Cargo.toml [INFO] started frobbing andrew-0.1.4 [INFO] finished frobbing andrew-0.1.4 [INFO] frobbed toml for andrew-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/andrew/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting andrew-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/andrew/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ddf7e83b71a18e1a5126f069c530306f8b219e6a9b3ecc1e7b063ee9d1e6e374 [INFO] running `"docker" "start" "-a" "ddf7e83b71a18e1a5126f069c530306f8b219e6a9b3ecc1e7b063ee9d1e6e374"` [INFO] [stderr] Checking wayland-sys v0.21.11 [INFO] [stderr] Compiling wayland-client v0.21.11 [INFO] [stderr] Checking andrew v0.1.4 (/opt/crater/workdir) [INFO] [stderr] Checking wayland-commons v0.21.11 [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/shapes/rectangle.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | for y in area_pos.1..area_pos.1 + area_size.1 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `area_pos.1..=area_pos.1 + area_size.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] Checking wayland-protocols v0.21.11 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/shapes/rectangle.rs:116:22 [INFO] [stderr] | [INFO] [stderr] 116 | for y in area_pos.1..area_pos.1 + area_size.1 + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `area_pos.1..=area_pos.1 + area_size.1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> examples/basic_test.rs:61:71 [INFO] [stderr] | [INFO] [stderr] 61 | let _keyboard = map_keyboard_auto(&seat, move |event: KbEvent, _| match event { [INFO] [stderr] | _______________________________________________________________________^ [INFO] [stderr] 62 | | KbEvent::Key { [INFO] [stderr] 63 | | state, [INFO] [stderr] 64 | | utf8: Some(text), [INFO] [stderr] ... | [INFO] [stderr] 67 | | _ => (), [INFO] [stderr] 68 | | }); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 61 | let _keyboard = map_keyboard_auto(&seat, move |event: KbEvent, _| if let KbEvent::Key { [INFO] [stderr] 62 | state, [INFO] [stderr] 63 | utf8: Some(text), [INFO] [stderr] 64 | .. [INFO] [stderr] 65 | } = event { if text == "p" && state == KeyState::Pressed {} }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> examples/basic_test.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | / fontconfig::FontConfig::new() [INFO] [stderr] 127 | | .unwrap() [INFO] [stderr] 128 | | .get_regular_family_fonts("sans") [INFO] [stderr] 129 | | .unwrap() [INFO] [stderr] 130 | | .get(0) [INFO] [stderr] 131 | | .unwrap(), [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 126 | &fontconfig::FontConfig::new() [INFO] [stderr] 127 | .unwrap() [INFO] [stderr] 128 | .get_regular_family_fonts("sans") [INFO] [stderr] 129 | .unwrap()[0], [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> examples/basic_test.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | writer.write(canvas.buffer).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `andrew`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ddf7e83b71a18e1a5126f069c530306f8b219e6a9b3ecc1e7b063ee9d1e6e374"` [INFO] running `"docker" "rm" "-f" "ddf7e83b71a18e1a5126f069c530306f8b219e6a9b3ecc1e7b063ee9d1e6e374"` [INFO] [stdout] ddf7e83b71a18e1a5126f069c530306f8b219e6a9b3ecc1e7b063ee9d1e6e374