[INFO] crate an-rope 0.3.1 is already in cache
[INFO] extracting crate an-rope 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/an-rope/0.3.1
[INFO] extracting crate an-rope 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/an-rope/0.3.1
[INFO] validating manifest of an-rope-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of an-rope-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing an-rope-0.3.1
[INFO] finished frobbing an-rope-0.3.1
[INFO] frobbed toml for an-rope-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/an-rope/0.3.1/Cargo.toml
[INFO] started frobbing an-rope-0.3.1
[INFO] finished frobbing an-rope-0.3.1
[INFO] frobbed toml for an-rope-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/an-rope/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting an-rope-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/an-rope/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7f7cd929c769dfa95900aad498b6171e3211dd96f7204e760726c17ce63c4c85
[INFO] running `"docker" "start" "-a" "7f7cd929c769dfa95900aad498b6171e3211dd96f7204e760726c17ce63c4c85"`
[INFO] [stderr] Checking an-rope v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/internals/node.rs:97:16
[INFO] [stderr] |
[INFO] [stderr] 97 | Node { value: value, ..Default::default() }
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/internals/node.rs:246:18
[INFO] [stderr] |
[INFO] [stderr] 246 | Branch { left: left, right: right }
[INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/internals/node.rs:246:30
[INFO] [stderr] |
[INFO] [stderr] 246 | Branch { left: left, right: right }
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:454:21
[INFO] [stderr] |
[INFO] [stderr] 454 | RopeSlice { node: node
[INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:455:21
[INFO] [stderr] |
[INFO] [stderr] 455 | , offset: offset
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:474:21
[INFO] [stderr] |
[INFO] [stderr] 474 | RopeSlice { node: node
[INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:475:21
[INFO] [stderr] |
[INFO] [stderr] 475 | , offset: offset
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/internals/node.rs:97:16
[INFO] [stderr] |
[INFO] [stderr] 97 | Node { value: value, ..Default::default() }
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `value`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/internals/node.rs:246:18
[INFO] [stderr] |
[INFO] [stderr] 246 | Branch { left: left, right: right }
[INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `left`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/internals/node.rs:246:30
[INFO] [stderr] |
[INFO] [stderr] 246 | Branch { left: left, right: right }
[INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `right`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:454:21
[INFO] [stderr] |
[INFO] [stderr] 454 | RopeSlice { node: node
[INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:455:21
[INFO] [stderr] |
[INFO] [stderr] 455 | , offset: offset
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:474:21
[INFO] [stderr] |
[INFO] [stderr] 474 | RopeSlice { node: node
[INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr] --> src/slice.rs:475:21
[INFO] [stderr] |
[INFO] [stderr] 475 | , offset: offset
[INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr]
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr] --> src/lib.rs:762:46
[INFO] [stderr] |
[INFO] [stderr] 762 | .scan(0, move |mut l, i| {
[INFO] [stderr] | ----^
[INFO] [stderr] | |
[INFO] [stderr] | help: remove this `mut`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(unused_mut)] on by default
[INFO] [stderr]
[INFO] [stderr] warning: method is never used: `nodes`
[INFO] [stderr] --> src/internals/mod.rs:446:5
[INFO] [stderr] |
[INFO] [stderr] 446 | fn nodes(&self) -> Nodes {
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(dead_code)] on by default
[INFO] [stderr]
[INFO] [stderr] warning: struct is never constructed: `Nodes`
[INFO] [stderr] --> src/internals/mod.rs:645:1
[INFO] [stderr] |
[INFO] [stderr] 645 | struct Nodes<'a>(Vec<&'a Node>);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr] --> src/internals/node.rs:218:25
[INFO] [stderr] |
[INFO] [stderr] 218 | &string[idx..idx+1]
[INFO] [stderr] | ^^^^^^^^^^ help: use: `idx..=idx`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr]
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr] --> src/internals/mod.rs:149:16
[INFO] [stderr] |
[INFO] [stderr] 149 | } else {
[INFO] [stderr] | ________________^
[INFO] [stderr] 150 | | // let mut leaves: Vec