[INFO] crate amt 0.1.1 is already in cache [INFO] extracting crate amt 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/amt/0.1.1 [INFO] extracting crate amt 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amt/0.1.1 [INFO] validating manifest of amt-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amt-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amt-0.1.1 [INFO] finished frobbing amt-0.1.1 [INFO] frobbed toml for amt-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/amt/0.1.1/Cargo.toml [INFO] started frobbing amt-0.1.1 [INFO] finished frobbing amt-0.1.1 [INFO] frobbed toml for amt-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amt/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amt-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amt/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b8be23eed7e4a049cc8784e86b48c7c4ba43f044b6549a69a7bec67a68ac29ec [INFO] running `"docker" "start" "-a" "b8be23eed7e4a049cc8784e86b48c7c4ba43f044b6549a69a7bec67a68ac29ec"` [INFO] [stderr] Checking mailparse v0.6.4 [INFO] [stderr] Checking amt v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:134:49 [INFO] [stderr] | [INFO] [stderr] 134 | .unwrap_or_else(|e| { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 135 | | eprintln!("Failed to get mail header key: {} - {:?}", path.display(), e); [INFO] [stderr] 136 | | exit(1) [INFO] [stderr] 137 | | }) == "Subject" { [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | fn get_trailers(message: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/main.rs:134:49 [INFO] [stderr] | [INFO] [stderr] 134 | .unwrap_or_else(|e| { [INFO] [stderr] | _________________________________________________^ [INFO] [stderr] 135 | | eprintln!("Failed to get mail header key: {} - {:?}", path.display(), e); [INFO] [stderr] 136 | | exit(1) [INFO] [stderr] 137 | | }) == "Subject" { [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:174:26 [INFO] [stderr] | [INFO] [stderr] 174 | fn get_trailers(message: &String) -> Vec { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.94s [INFO] running `"docker" "inspect" "b8be23eed7e4a049cc8784e86b48c7c4ba43f044b6549a69a7bec67a68ac29ec"` [INFO] running `"docker" "rm" "-f" "b8be23eed7e4a049cc8784e86b48c7c4ba43f044b6549a69a7bec67a68ac29ec"` [INFO] [stdout] b8be23eed7e4a049cc8784e86b48c7c4ba43f044b6549a69a7bec67a68ac29ec