[INFO] crate amq-protocol-types 1.0.0 is already in cache
[INFO] extracting crate amq-protocol-types 1.0.0 into work/ex/clippy-test-run/sources/stable/reg/amq-protocol-types/1.0.0
[INFO] extracting crate amq-protocol-types 1.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amq-protocol-types/1.0.0
[INFO] validating manifest of amq-protocol-types-1.0.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of amq-protocol-types-1.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing amq-protocol-types-1.0.0
[INFO] finished frobbing amq-protocol-types-1.0.0
[INFO] frobbed toml for amq-protocol-types-1.0.0 written to work/ex/clippy-test-run/sources/stable/reg/amq-protocol-types/1.0.0/Cargo.toml
[INFO] started frobbing amq-protocol-types-1.0.0
[INFO] finished frobbing amq-protocol-types-1.0.0
[INFO] frobbed toml for amq-protocol-types-1.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amq-protocol-types/1.0.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting amq-protocol-types-1.0.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amq-protocol-types/1.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] be875fd40340a49edf332ef718096c3baea274344ee5be88182f18cb28074ad4
[INFO] running `"docker" "start" "-a" "be875fd40340a49edf332ef718096c3baea274344ee5be88182f18cb28074ad4"`
[INFO] [stderr]     Checking amq-protocol-types v1.0.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[macro_use] extern crate cookie_factory;
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[macro_use] extern crate cookie_factory;
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/flags.rs:71:52
[INFO] [stderr]    |
[INFO] [stderr] 71 |         assert_eq!(flags.get_bytes().as_slice(), &[0b00011001])
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: consider: `0b0001_1001`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/flags.rs:87:52
[INFO] [stderr]    |
[INFO] [stderr] 87 |         assert_eq!(flags.get_bytes().as_slice(), &[0b00111001, 0b00000011])
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: consider: `0b0011_1001`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/flags.rs:87:64
[INFO] [stderr]    |
[INFO] [stderr] 87 |         assert_eq!(flags.get_bytes().as_slice(), &[0b00111001, 0b00000011])
[INFO] [stderr]    |                                                                ^^^^^^^^^^ help: consider: `0b0000_0011`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generation.rs:221:59
[INFO] [stderr]     |
[INFO] [stderr] 221 |         assert_eq!(gen_long_uint((&mut [0, 0, 0, 0], 0), &4294967295), Ok((&mut [255, 255, 255, 255][..], 4)));
[INFO] [stderr]     |                                                           ^^^^^^^^^^ help: consider: `4_294_967_295`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generation.rs:233:76
[INFO] [stderr]     |
[INFO] [stderr] 233 |         assert_eq!(gen_long_long_uint((&mut [0, 0, 0, 0, 0, 0, 0, 0], 0), &18446744073709551615), Ok((&mut [255, 255, 255, 255, 255, 255, 255, 255][..], 8)));
[INFO] [stderr]     |                                                                            ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generation.rs:275:71
[INFO] [stderr]     |
[INFO] [stderr] 275 |         assert_eq!(gen_timestamp((&mut [0, 0, 0, 0, 0, 0, 0, 0], 0), &18446744073709551615), Ok((&mut [255, 255, 255, 255, 255, 255, 255, 255][..], 8)));
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generation.rs:300:64
[INFO] [stderr]     |
[INFO] [stderr] 300 |         assert_eq!(gen_flags((&mut [0], 0), &flags), Ok((&mut [0b00001101][..], 1)));
[INFO] [stderr]     |                                                                ^^^^^^^^^^ help: consider: `0b0000_1101`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generation.rs:307:67
[INFO] [stderr]     |
[INFO] [stderr] 307 |         assert_eq!(gen_flags((&mut [0, 0], 0), &flags), Ok((&mut [0b11011101, 0b00000010][..], 2)));
[INFO] [stderr]     |                                                                   ^^^^^^^^^^ help: consider: `0b1101_1101`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/generation.rs:307:79
[INFO] [stderr]     |
[INFO] [stderr] 307 |         assert_eq!(gen_flags((&mut [0, 0], 0), &flags), Ok((&mut [0b11011101, 0b00000010][..], 2)));
[INFO] [stderr]     |                                                                               ^^^^^^^^^^ help: consider: `0b0000_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/parsing.rs:72:19
[INFO] [stderr]    |
[INFO] [stderr] 72 |     const EMPTY: &'static [u8] = b"";
[INFO] [stderr]    |                  -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/parsing.rs:76:108
[INFO] [stderr]    |
[INFO] [stderr] 76 |         assert_eq!(parse_value(&[84, 42, 42, 42, 42, 42,  42,  42,  42]),  Ok((EMPTY, AMQPValue::Timestamp(3038287259199220266))));
[INFO] [stderr]    |                                                                                                            ^^^^^^^^^^^^^^^^^^^ help: consider: `3_038_287_259_199_220_266`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/parsing.rs:82:133
[INFO] [stderr]    |
[INFO] [stderr] 82 |         assert_eq!(parse_raw_value(&[42, 42, 42, 42, 42,  42,  42,  42],  &AMQPType::Timestamp),    Ok((EMPTY, AMQPValue::Timestamp(3038287259199220266))));
[INFO] [stderr]    |                                                                                                                                     ^^^^^^^^^^^^^^^^^^^ help: consider: `3_038_287_259_199_220_266`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/parsing.rs:85:135
[INFO] [stderr]    |
[INFO] [stderr] 85 |         assert_eq!(parse_raw_value(&[42, 42, 42, 42, 42,  42,  42,  42],  &AMQPType::LongLongUInt), Ok((EMPTY, AMQPValue::LongLongInt(3038287259199220266))));
[INFO] [stderr]    |                                                                                                                                       ^^^^^^^^^^^^^^^^^^^ help: consider: `3_038_287_259_199_220_266`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:140:71
[INFO] [stderr]     |
[INFO] [stderr] 140 |         assert_eq!(parse_long_uint(&[255, 255, 255, 255]), Ok((EMPTY, 4294967295)));
[INFO] [stderr]     |                                                                       ^^^^^^^^^^ help: consider: `4_294_967_295`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:152:96
[INFO] [stderr]     |
[INFO] [stderr] 152 |         assert_eq!(parse_long_long_uint(&[255, 255, 255, 255, 255, 255, 255, 255]), Ok((EMPTY, 18446744073709551615)));
[INFO] [stderr]     |                                                                                                ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:170:114
[INFO] [stderr]     |
[INFO] [stderr] 170 |         assert_eq!(parse_decimal_value(&[255, 255, 255, 255, 255]), Ok((EMPTY, DecimalValue { scale: 255, value: 4294967295 })));
[INFO] [stderr]     |                                                                                                                  ^^^^^^^^^^ help: consider: `4_294_967_295`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:194:91
[INFO] [stderr]     |
[INFO] [stderr] 194 |         assert_eq!(parse_timestamp(&[255, 255, 255, 255, 255, 255, 255, 255]), Ok((EMPTY, 18446744073709551615)));
[INFO] [stderr]     |                                                                                           ^^^^^^^^^^^^^^^^^^^^ help: consider: `18_446_744_073_709_551_615`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:220:34
[INFO] [stderr]     |
[INFO] [stderr] 220 |         assert_eq!(parse_flags(&[0b00001101], &names), Ok((EMPTY, flags.clone())));
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: consider: `0b0000_1101`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:227:34
[INFO] [stderr]     |
[INFO] [stderr] 227 |         assert_eq!(parse_flags(&[0b11011101, 0b00000010], &names), Ok((EMPTY, flags)));
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: consider: `0b1101_1101`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/parsing.rs:227:46
[INFO] [stderr]     |
[INFO] [stderr] 227 |         assert_eq!(parse_flags(&[0b11011101, 0b00000010], &names), Ok((EMPTY, flags)));
[INFO] [stderr]     |                                              ^^^^^^^^^^ help: consider: `0b0000_0010`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:41:49
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn gen_id<'a>(x: (&'a mut [u8], usize), id: &ShortUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                 ^^^^^^^^^^ help: consider passing by value instead: `ShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:46:53
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn gen_boolean<'a>(x: (&'a mut [u8], usize), b: &Boolean) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                     ^^^^^^^^ help: consider passing by value instead: `Boolean`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:51:61
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub fn gen_short_short_int<'a>(x: (&'a mut [u8], usize), i: &ShortShortInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^ help: consider passing by value instead: `ShortShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:56:62
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn gen_short_short_uint<'a>(x: (&'a mut [u8], usize), u: &ShortShortUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^ help: consider passing by value instead: `ShortShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:61:55
[INFO] [stderr]    |
[INFO] [stderr] 61 | pub fn gen_short_int<'a>(x: (&'a mut [u8], usize), i: &ShortInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                       ^^^^^^^^^ help: consider passing by value instead: `ShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:66:56
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn gen_short_uint<'a>(x: (&'a mut [u8], usize), u: &ShortUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                        ^^^^^^^^^^ help: consider passing by value instead: `ShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:71:54
[INFO] [stderr]    |
[INFO] [stderr] 71 | pub fn gen_long_int<'a>(x: (&'a mut [u8], usize), i: &LongInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                      ^^^^^^^^ help: consider passing by value instead: `LongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:76:55
[INFO] [stderr]    |
[INFO] [stderr] 76 | pub fn gen_long_uint<'a>(x: (&'a mut [u8], usize), u: &LongUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                       ^^^^^^^^^ help: consider passing by value instead: `LongUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:81:59
[INFO] [stderr]    |
[INFO] [stderr] 81 | pub fn gen_long_long_int<'a>(x: (&'a mut [u8], usize), i: &LongLongInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^ help: consider passing by value instead: `LongLongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:86:60
[INFO] [stderr]    |
[INFO] [stderr] 86 | pub fn gen_long_long_uint<'a>(x: (&'a mut [u8], usize), i: &LongLongUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^ help: consider passing by value instead: `LongLongUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:91:51
[INFO] [stderr]    |
[INFO] [stderr] 91 | pub fn gen_float<'a>(x: (&'a mut [u8], usize), f: &Float) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                   ^^^^^^ help: consider passing by value instead: `Float`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:96:52
[INFO] [stderr]    |
[INFO] [stderr] 96 | pub fn gen_double<'a>(x: (&'a mut [u8], usize), d: &Double) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                    ^^^^^^^ help: consider passing by value instead: `Double`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/generation.rs:106:58
[INFO] [stderr]     |
[INFO] [stderr] 106 | pub fn gen_short_string<'a>(x: (&'a mut [u8], usize), s: &ShortString) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/generation.rs:111:57
[INFO] [stderr]     |
[INFO] [stderr] 111 | pub fn gen_long_string<'a>(x: (&'a mut [u8], usize), s: &LongString) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                         ^^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/generation.rs:116:57
[INFO] [stderr]     |
[INFO] [stderr] 116 | pub fn gen_field_array<'a>(x: (&'a mut [u8], usize), a: &FieldArray) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/generation.rs:125:55
[INFO] [stderr]     |
[INFO] [stderr] 125 | pub fn gen_timestamp<'a>(x: (&'a mut [u8], usize), t: &Timestamp) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: consider passing by value instead: `Timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/generation.rs:143:56
[INFO] [stderr]     |
[INFO] [stderr] 143 | pub fn gen_byte_array<'a>(x: (&'a mut [u8], usize), a: &ByteArray) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                        ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:10:76
[INFO] [stderr]    |
[INFO] [stderr] 10 |         AMQPType::Boolean        => map!(i, call!(parse_boolean),          |b| AMQPValue::Boolean(b)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Boolean`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:11:76
[INFO] [stderr]    |
[INFO] [stderr] 11 |         AMQPType::ShortShortInt  => map!(i, call!(parse_short_short_int),  |i| AMQPValue::ShortShortInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:12:76
[INFO] [stderr]    |
[INFO] [stderr] 12 |         AMQPType::ShortShortUInt => map!(i, call!(parse_short_short_uint), |u| AMQPValue::ShortShortUInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:13:76
[INFO] [stderr]    |
[INFO] [stderr] 13 |         AMQPType::ShortInt       => map!(i, call!(parse_short_int),        |i| AMQPValue::ShortInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:14:76
[INFO] [stderr]    |
[INFO] [stderr] 14 |         AMQPType::ShortUInt      => map!(i, call!(parse_short_uint),       |u| AMQPValue::ShortUInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:15:76
[INFO] [stderr]    |
[INFO] [stderr] 15 |         AMQPType::LongInt        => map!(i, call!(parse_long_int),         |i| AMQPValue::LongInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:16:76
[INFO] [stderr]    |
[INFO] [stderr] 16 |         AMQPType::LongUInt       => map!(i, call!(parse_long_uint),        |u| AMQPValue::LongUInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:17:76
[INFO] [stderr]    |
[INFO] [stderr] 17 |         AMQPType::LongLongInt    => map!(i, call!(parse_long_long_int),    |i| AMQPValue::LongLongInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongLongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:19:76
[INFO] [stderr]    |
[INFO] [stderr] 19 |         AMQPType::LongLongUInt   => map!(i, call!(parse_long_long_int),    |u| AMQPValue::LongLongInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongLongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:20:76
[INFO] [stderr]    |
[INFO] [stderr] 20 |         AMQPType::Float          => map!(i, call!(parse_float),            |f| AMQPValue::Float(f)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Float`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:21:76
[INFO] [stderr]    |
[INFO] [stderr] 21 |         AMQPType::Double         => map!(i, call!(parse_double),           |d| AMQPValue::Double(d)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Double`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:22:76
[INFO] [stderr]    |
[INFO] [stderr] 22 |         AMQPType::DecimalValue   => map!(i, call!(parse_decimal_value),    |d| AMQPValue::DecimalValue(d)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::DecimalValue`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:24:76
[INFO] [stderr]    |
[INFO] [stderr] 24 |         AMQPType::ShortString    => map!(i, call!(parse_short_string),     |s| AMQPValue::LongString(s)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongString`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:25:76
[INFO] [stderr]    |
[INFO] [stderr] 25 |         AMQPType::LongString     => map!(i, call!(parse_long_string),      |s| AMQPValue::LongString(s)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongString`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:26:76
[INFO] [stderr]    |
[INFO] [stderr] 26 |         AMQPType::FieldArray     => map!(i, call!(parse_field_array),      |a| AMQPValue::FieldArray(a)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::FieldArray`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:27:76
[INFO] [stderr]    |
[INFO] [stderr] 27 |         AMQPType::Timestamp      => map!(i, call!(parse_timestamp),        |t| AMQPValue::Timestamp(t)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Timestamp`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:28:76
[INFO] [stderr]    |
[INFO] [stderr] 28 |         AMQPType::FieldTable     => map!(i, call!(parse_field_table),      |t| AMQPValue::FieldTable(t)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::FieldTable`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:29:76
[INFO] [stderr]    |
[INFO] [stderr] 29 |         AMQPType::ByteArray      => map!(i, call!(parse_byte_array),       |a| AMQPValue::ByteArray(a)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ByteArray`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:41:49
[INFO] [stderr]    |
[INFO] [stderr] 41 | pub fn gen_id<'a>(x: (&'a mut [u8], usize), id: &ShortUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                 ^^^^^^^^^^ help: consider passing by value instead: `ShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:46:53
[INFO] [stderr]    |
[INFO] [stderr] 46 | pub fn gen_boolean<'a>(x: (&'a mut [u8], usize), b: &Boolean) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                     ^^^^^^^^ help: consider passing by value instead: `Boolean`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:51:61
[INFO] [stderr]    |
[INFO] [stderr] 51 | pub fn gen_short_short_int<'a>(x: (&'a mut [u8], usize), i: &ShortShortInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                             ^^^^^^^^^^^^^^ help: consider passing by value instead: `ShortShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:56:62
[INFO] [stderr]    |
[INFO] [stderr] 56 | pub fn gen_short_short_uint<'a>(x: (&'a mut [u8], usize), u: &ShortShortUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                              ^^^^^^^^^^^^^^^ help: consider passing by value instead: `ShortShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:61:55
[INFO] [stderr]    |
[INFO] [stderr] 61 | pub fn gen_short_int<'a>(x: (&'a mut [u8], usize), i: &ShortInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                       ^^^^^^^^^ help: consider passing by value instead: `ShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:66:56
[INFO] [stderr]    |
[INFO] [stderr] 66 | pub fn gen_short_uint<'a>(x: (&'a mut [u8], usize), u: &ShortUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                        ^^^^^^^^^^ help: consider passing by value instead: `ShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:71:54
[INFO] [stderr]    |
[INFO] [stderr] 71 | pub fn gen_long_int<'a>(x: (&'a mut [u8], usize), i: &LongInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                      ^^^^^^^^ help: consider passing by value instead: `LongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:76:55
[INFO] [stderr]    |
[INFO] [stderr] 76 | pub fn gen_long_uint<'a>(x: (&'a mut [u8], usize), u: &LongUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                       ^^^^^^^^^ help: consider passing by value instead: `LongUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:81:59
[INFO] [stderr]    |
[INFO] [stderr] 81 | pub fn gen_long_long_int<'a>(x: (&'a mut [u8], usize), i: &LongLongInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                           ^^^^^^^^^^^^ help: consider passing by value instead: `LongLongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:86:60
[INFO] [stderr]    |
[INFO] [stderr] 86 | pub fn gen_long_long_uint<'a>(x: (&'a mut [u8], usize), i: &LongLongUInt) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                            ^^^^^^^^^^^^^ help: consider passing by value instead: `LongLongUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:91:51
[INFO] [stderr]    |
[INFO] [stderr] 91 | pub fn gen_float<'a>(x: (&'a mut [u8], usize), f: &Float) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                   ^^^^^^ help: consider passing by value instead: `Float`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/generation.rs:96:52
[INFO] [stderr]    |
[INFO] [stderr] 96 | pub fn gen_double<'a>(x: (&'a mut [u8], usize), d: &Double) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]    |                                                    ^^^^^^^ help: consider passing by value instead: `Double`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/generation.rs:106:58
[INFO] [stderr]     |
[INFO] [stderr] 106 | pub fn gen_short_string<'a>(x: (&'a mut [u8], usize), s: &ShortString) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/generation.rs:111:57
[INFO] [stderr]     |
[INFO] [stderr] 111 | pub fn gen_long_string<'a>(x: (&'a mut [u8], usize), s: &LongString) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                         ^^^^^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/generation.rs:116:57
[INFO] [stderr]     |
[INFO] [stderr] 116 | pub fn gen_field_array<'a>(x: (&'a mut [u8], usize), a: &FieldArray) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]    --> src/generation.rs:125:55
[INFO] [stderr]     |
[INFO] [stderr] 125 | pub fn gen_timestamp<'a>(x: (&'a mut [u8], usize), t: &Timestamp) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                       ^^^^^^^^^^ help: consider passing by value instead: `Timestamp`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/generation.rs:143:56
[INFO] [stderr]     |
[INFO] [stderr] 143 | pub fn gen_byte_array<'a>(x: (&'a mut [u8], usize), a: &ByteArray) -> Result<(&'a mut [u8], usize), GenError> {
[INFO] [stderr]     |                                                        ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:10:76
[INFO] [stderr]    |
[INFO] [stderr] 10 |         AMQPType::Boolean        => map!(i, call!(parse_boolean),          |b| AMQPValue::Boolean(b)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Boolean`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:11:76
[INFO] [stderr]    |
[INFO] [stderr] 11 |         AMQPType::ShortShortInt  => map!(i, call!(parse_short_short_int),  |i| AMQPValue::ShortShortInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:12:76
[INFO] [stderr]    |
[INFO] [stderr] 12 |         AMQPType::ShortShortUInt => map!(i, call!(parse_short_short_uint), |u| AMQPValue::ShortShortUInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:13:76
[INFO] [stderr]    |
[INFO] [stderr] 13 |         AMQPType::ShortInt       => map!(i, call!(parse_short_int),        |i| AMQPValue::ShortInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:14:76
[INFO] [stderr]    |
[INFO] [stderr] 14 |         AMQPType::ShortUInt      => map!(i, call!(parse_short_uint),       |u| AMQPValue::ShortUInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ShortUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:15:76
[INFO] [stderr]    |
[INFO] [stderr] 15 |         AMQPType::LongInt        => map!(i, call!(parse_long_int),         |i| AMQPValue::LongInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:16:76
[INFO] [stderr]    |
[INFO] [stderr] 16 |         AMQPType::LongUInt       => map!(i, call!(parse_long_uint),        |u| AMQPValue::LongUInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongUInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:17:76
[INFO] [stderr]    |
[INFO] [stderr] 17 |         AMQPType::LongLongInt    => map!(i, call!(parse_long_long_int),    |i| AMQPValue::LongLongInt(i)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongLongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:19:76
[INFO] [stderr]    |
[INFO] [stderr] 19 |         AMQPType::LongLongUInt   => map!(i, call!(parse_long_long_int),    |u| AMQPValue::LongLongInt(u)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongLongInt`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:20:76
[INFO] [stderr]    |
[INFO] [stderr] 20 |         AMQPType::Float          => map!(i, call!(parse_float),            |f| AMQPValue::Float(f)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Float`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:21:76
[INFO] [stderr]    |
[INFO] [stderr] 21 |         AMQPType::Double         => map!(i, call!(parse_double),           |d| AMQPValue::Double(d)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Double`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:22:76
[INFO] [stderr]    |
[INFO] [stderr] 22 |         AMQPType::DecimalValue   => map!(i, call!(parse_decimal_value),    |d| AMQPValue::DecimalValue(d)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::DecimalValue`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:24:76
[INFO] [stderr]    |
[INFO] [stderr] 24 |         AMQPType::ShortString    => map!(i, call!(parse_short_string),     |s| AMQPValue::LongString(s)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongString`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:25:76
[INFO] [stderr]    |
[INFO] [stderr] 25 |         AMQPType::LongString     => map!(i, call!(parse_long_string),      |s| AMQPValue::LongString(s)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::LongString`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:26:76
[INFO] [stderr]    |
[INFO] [stderr] 26 |         AMQPType::FieldArray     => map!(i, call!(parse_field_array),      |a| AMQPValue::FieldArray(a)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::FieldArray`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:27:76
[INFO] [stderr]    |
[INFO] [stderr] 27 |         AMQPType::Timestamp      => map!(i, call!(parse_timestamp),        |t| AMQPValue::Timestamp(t)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::Timestamp`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:28:76
[INFO] [stderr]    |
[INFO] [stderr] 28 |         AMQPType::FieldTable     => map!(i, call!(parse_field_table),      |t| AMQPValue::FieldTable(t)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::FieldTable`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/parsing.rs:29:76
[INFO] [stderr]    |
[INFO] [stderr] 29 |         AMQPType::ByteArray      => map!(i, call!(parse_byte_array),       |a| AMQPValue::ByteArray(a)),
[INFO] [stderr]    |                                                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `AMQPValue::ByteArray`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/integration.rs:30:56
[INFO] [stderr]    |
[INFO] [stderr] 30 |     table.insert("jjjj".to_string(), AMQPValue::Double(0.00987654321));
[INFO] [stderr]    |                                                        ^^^^^^^^^^^^^ help: consider: `0.009_876_543_21`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> tests/integration.rs:31:59
[INFO] [stderr]    |
[INFO] [stderr] 31 |     table.insert("kkkk".to_string(), AMQPValue::Timestamp(1234567890));
[INFO] [stderr]    |                                                           ^^^^^^^^^^ help: consider: `1_234_567_890`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 6.04s
[INFO] running `"docker" "inspect" "be875fd40340a49edf332ef718096c3baea274344ee5be88182f18cb28074ad4"`
[INFO] running `"docker" "rm" "-f" "be875fd40340a49edf332ef718096c3baea274344ee5be88182f18cb28074ad4"`
[INFO] [stdout] be875fd40340a49edf332ef718096c3baea274344ee5be88182f18cb28074ad4