[INFO] crate amq-proto 0.1.0 is already in cache [INFO] extracting crate amq-proto 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/amq-proto/0.1.0 [INFO] extracting crate amq-proto 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amq-proto/0.1.0 [INFO] validating manifest of amq-proto-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amq-proto-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amq-proto-0.1.0 [INFO] finished frobbing amq-proto-0.1.0 [INFO] frobbed toml for amq-proto-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/amq-proto/0.1.0/Cargo.toml [INFO] started frobbing amq-proto-0.1.0 [INFO] finished frobbing amq-proto-0.1.0 [INFO] frobbed toml for amq-proto-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amq-proto/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amq-proto-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amq-proto/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0a7fe8df2d0e07c0e3c0663029795dee23382e8fb3f94f61cb4f22bab9611e34 [INFO] running `"docker" "start" "-a" "0a7fe8df2d0e07c0e3c0663029795dee23382e8fb3f94f61cb4f22bab9611e34"` [INFO] [stderr] Checking amq-proto v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | FrameHeader { frame_type_id: frame_type_id, channel: channel, payload_size: payload_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:72:53 [INFO] [stderr] | [INFO] [stderr] 72 | FrameHeader { frame_type_id: frame_type_id, channel: channel, payload_size: payload_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:72:71 [INFO] [stderr] | [INFO] [stderr] 72 | FrameHeader { frame_type_id: frame_type_id, channel: channel, payload_size: payload_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payload_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(MethodFrame { class_id: class_id, method_id: method_id, arguments: EncodedMethod::new(arguments) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `class_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:103:46 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(MethodFrame { class_id: class_id, method_id: method_id, arguments: EncodedMethod::new(arguments) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `method_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | content_class: content_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | body_size: body_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `body_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | properties_flags: properties_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:72:23 [INFO] [stderr] | [INFO] [stderr] 72 | FrameHeader { frame_type_id: frame_type_id, channel: channel, payload_size: payload_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:72:53 [INFO] [stderr] | [INFO] [stderr] 72 | FrameHeader { frame_type_id: frame_type_id, channel: channel, payload_size: payload_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:72:71 [INFO] [stderr] | [INFO] [stderr] 72 | FrameHeader { frame_type_id: frame_type_id, channel: channel, payload_size: payload_size } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payload_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(MethodFrame { class_id: class_id, method_id: method_id, arguments: EncodedMethod::new(arguments) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `class_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:103:46 [INFO] [stderr] | [INFO] [stderr] 103 | Ok(MethodFrame { class_id: class_id, method_id: method_id, arguments: EncodedMethod::new(arguments) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `method_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:138:13 [INFO] [stderr] | [INFO] [stderr] 138 | frame_type: frame_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:175:13 [INFO] [stderr] | [INFO] [stderr] 175 | content_class: content_class, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `content_class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | body_size: body_size, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `body_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framing.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | properties_flags: properties_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `properties_flags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/method.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | channel: channel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `channel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen_macros.rs:329:96 [INFO] [stderr] | [INFO] [stderr] 329 | let f = Foo { a: 1, b: "test".to_string(), c: "bar".to_string(), d: false, e: true, f: 0xDEADBEEF }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen_macros.rs:343:96 [INFO] [stderr] | [INFO] [stderr] 343 | let f = Foo { a: 1, b: "test".to_string(), c: "bar".to_string(), d: false, e: true, f: 0xDEADBEEF }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/codegen_macros.rs:358:96 [INFO] [stderr] | [INFO] [stderr] 358 | let f = Foo { a: 1, b: "test".to_string(), c: "bar".to_string(), d: false, e: true, f: 0xDEADBEEF }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xDEAD_BEEF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:49:21 [INFO] [stderr] | [INFO] [stderr] 49 | pub const VERSION: &'static str = env!("CARGO_PKG_VERSION"); [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unused variable: `f` [INFO] [stderr] --> src/codegen_macros.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | let f = Foo { a: 1, b: "test".to_string(), c: "bar".to_string(), d: false, e: true, f: 0xDEADBEEF }; [INFO] [stderr] | ^ help: consider using `_f` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `table_size` [INFO] [stderr] --> src/codegen_macros.rs:59:53 [INFO] [stderr] | [INFO] [stderr] 59 | decode_table(&mut self.cursor).map(|(table, table_size)| table) [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_table_size` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `idx` is never read [INFO] [stderr] --> src/codegen_macros.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `idx` is never read [INFO] [stderr] --> src/codegen_macros.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: unused variable: `table_size` [INFO] [stderr] --> src/codegen_macros.rs:59:53 [INFO] [stderr] | [INFO] [stderr] 59 | decode_table(&mut self.cursor).map(|(table, table_size)| table) [INFO] [stderr] | ^^^^^^^^^^ help: consider using `_table_size` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `idx` is never read [INFO] [stderr] --> src/codegen_macros.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `decode` [INFO] [stderr] --> src/codegen_macros.rs:275:13 [INFO] [stderr] | [INFO] [stderr] 275 | pub fn decode(content_header_frame: ContentHeaderFrame) -> Result<$struct_name> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `encode` [INFO] [stderr] --> src/codegen_macros.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | pub fn encode(self) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: method is never used: `flags` [INFO] [stderr] --> src/codegen_macros.rs:300:13 [INFO] [stderr] | [INFO] [stderr] 300 | pub fn flags(&self) -> u16 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/table.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | try!(reader.read(&mut buffer[..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | try!(writer.write(&tmp_buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/table.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | try!(reader.read(&mut field_name[..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/codegen_macros.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.cursor.read(&mut buffer[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/codegen_macros.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.cursor.read(&mut buffer[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen_macros.rs:75:60 [INFO] [stderr] | [INFO] [stderr] 75 | self.bits.get(7 - (self.current_bit - 1) as usize).ok_or(ErrorKind::Protocol("Bitmap is not correct".to_owned()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::Protocol("Bitmap is not correct".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:91:41 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn write_octet(&mut self, data: &u8) -> Result<()> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn write_long(&mut self, data: &u32) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:101:44 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn write_longlong(&mut self, data: &u64) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn write_short(&mut self, data: &u16) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/codegen_macros.rs:111:44 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn write_shortstr(&mut self, data: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/codegen_macros.rs:118:43 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn write_longstr(&mut self, data: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn write_timestamp(&mut self, data: &u64) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:137:39 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn write_bit(&mut self, data: &bool) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/codegen_macros.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | self.flush_bits(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codegen_macros.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn as_bytes(mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/codegen_macros.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | self.flush_bits(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:282:31 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:283:52 [INFO] [stderr] | [INFO] [stderr] 283 | match properties_flags.get(idx - 1) { [INFO] [stderr] | ^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:282:31 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/codegen_macros.rs:307:35 [INFO] [stderr] | [INFO] [stderr] 307 | let flags : u16 = bits.to_bytes()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bits.to_bytes()[0])` [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/codegen_macros.rs:308:31 [INFO] [stderr] | [INFO] [stderr] 308 | (flags << 8 | bits.to_bytes()[1] as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bits.to_bytes()[1])` [INFO] [stderr] ... [INFO] [stderr] 325 | properties_struct!(Test, a => octet, b => shortstr, c => longstr, d => bit, e => bit, f => long); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/table.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | try!(reader.read(&mut buffer[..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/table.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | try!(writer.write(&tmp_buffer)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/table.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | try!(reader.read(&mut field_name[..])); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/codegen_macros.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | self.cursor.read(&mut buffer[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle read amount returned or use `Read::read_exact` instead [INFO] [stderr] --> src/codegen_macros.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | self.cursor.read(&mut buffer[..])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/codegen_macros.rs:75:60 [INFO] [stderr] | [INFO] [stderr] 75 | self.bits.get(7 - (self.current_bit - 1) as usize).ok_or(ErrorKind::Protocol("Bitmap is not correct".to_owned()).into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorKind::Protocol("Bitmap is not correct".to_owned()).into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:91:41 [INFO] [stderr] | [INFO] [stderr] 91 | pub fn write_octet(&mut self, data: &u8) -> Result<()> { [INFO] [stderr] | ^^^ help: consider passing by value instead: `u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:96:40 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn write_long(&mut self, data: &u32) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:101:44 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn write_longlong(&mut self, data: &u64) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:106:41 [INFO] [stderr] | [INFO] [stderr] 106 | pub fn write_short(&mut self, data: &u16) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/codegen_macros.rs:111:44 [INFO] [stderr] | [INFO] [stderr] 111 | pub fn write_shortstr(&mut self, data: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/codegen_macros.rs:118:43 [INFO] [stderr] | [INFO] [stderr] 118 | pub fn write_longstr(&mut self, data: &String) -> Result<()> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:131:45 [INFO] [stderr] | [INFO] [stderr] 131 | pub fn write_timestamp(&mut self, data: &u64) -> Result<()> { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/codegen_macros.rs:137:39 [INFO] [stderr] | [INFO] [stderr] 137 | pub fn write_bit(&mut self, data: &bool) -> Result<()> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/codegen_macros.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | self.flush_bits(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/codegen_macros.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | pub fn as_bytes(mut self) -> Vec { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/codegen_macros.rs:158:9 [INFO] [stderr] | [INFO] [stderr] 158 | self.flush_bits(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:282:31 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:283:52 [INFO] [stderr] | [INFO] [stderr] 283 | match properties_flags.get(idx - 1) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/codegen_macros.rs:307:35 [INFO] [stderr] | [INFO] [stderr] 307 | let flags : u16 = bits.to_bytes()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bits.to_bytes()[0])` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/codegen_macros.rs:308:31 [INFO] [stderr] | [INFO] [stderr] 308 | (flags << 8 | bits.to_bytes()[1] as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bits.to_bytes()[1])` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:282:31 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::eval_order_dependence)] on by default [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:283:52 [INFO] [stderr] | [INFO] [stderr] 283 | match properties_flags.get(idx - 1) { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: unsequenced read of a variable [INFO] [stderr] --> src/codegen_macros.rs:282:31 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: whether read occurs before this write depends on evaluation order [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eval_order_dependence [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:282:25 [INFO] [stderr] | [INFO] [stderr] 282 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/codegen_macros.rs:305:21 [INFO] [stderr] | [INFO] [stderr] 305 | idx = idx + 1; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `idx += 1` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/codegen_macros.rs:307:35 [INFO] [stderr] | [INFO] [stderr] 307 | let flags : u16 = bits.to_bytes()[0] as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bits.to_bytes()[0])` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/codegen_macros.rs:308:31 [INFO] [stderr] | [INFO] [stderr] 308 | (flags << 8 | bits.to_bytes()[1] as u16) as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(bits.to_bytes()[1])` [INFO] [stderr] | [INFO] [stderr] ::: src/protocol.rs:390:5 [INFO] [stderr] | [INFO] [stderr] 390 | / properties_struct!(BasicProperties, [INFO] [stderr] 391 | | content_type => shortstr, [INFO] [stderr] 392 | | content_encoding => shortstr, [INFO] [stderr] 393 | | headers => table, [INFO] [stderr] ... | [INFO] [stderr] 404 | | cluster_id => shortstr [INFO] [stderr] 405 | | ); [INFO] [stderr] | |______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `amq-proto`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `amq-proto`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0a7fe8df2d0e07c0e3c0663029795dee23382e8fb3f94f61cb4f22bab9611e34"` [INFO] running `"docker" "rm" "-f" "0a7fe8df2d0e07c0e3c0663029795dee23382e8fb3f94f61cb4f22bab9611e34"` [INFO] [stdout] 0a7fe8df2d0e07c0e3c0663029795dee23382e8fb3f94f61cb4f22bab9611e34