[INFO] crate ami 0.13.0 is already in cache [INFO] extracting crate ami 0.13.0 into work/ex/clippy-test-run/sources/stable/reg/ami/0.13.0 [INFO] extracting crate ami 0.13.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ami/0.13.0 [INFO] validating manifest of ami-0.13.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of ami-0.13.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing ami-0.13.0 [INFO] finished frobbing ami-0.13.0 [INFO] frobbed toml for ami-0.13.0 written to work/ex/clippy-test-run/sources/stable/reg/ami/0.13.0/Cargo.toml [INFO] started frobbing ami-0.13.0 [INFO] finished frobbing ami-0.13.0 [INFO] frobbed toml for ami-0.13.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/ami/0.13.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting ami-0.13.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/ami/0.13.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 90a0a278d921bea304dfbd5899f5ecd67b871691d2e9800dfd98281314614765 [INFO] running `"docker" "start" "-a" "90a0a278d921bea304dfbd5899f5ecd67b871691d2e9800dfd98281314614765"` [INFO] [stderr] Checking ami v0.13.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/octree.rs:348:11 [INFO] [stderr] | [INFO] [stderr] 348 | BCube { center: center, half_len: half_len } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/octree.rs:348:27 [INFO] [stderr] | [INFO] [stderr] 348 | BCube { center: center, half_len: half_len } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `half_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:733:4 [INFO] [stderr] | [INFO] [stderr] 733 | write!(f, "No Root\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:736:4 [INFO] [stderr] | [INFO] [stderr] 736 | write!(f, "Root {}:{:?}\n", root, self.bcube)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/octree.rs:750:5 [INFO] [stderr] | [INFO] [stderr] 750 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:761:4 [INFO] [stderr] | [INFO] [stderr] 761 | write!(f, "No Root\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:764:4 [INFO] [stderr] | [INFO] [stderr] 764 | write!(f, "root {}\n", root)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:770:5 [INFO] [stderr] | [INFO] [stderr] 770 | write!(f, "{}: {:?}\n", i, self.nodes[i])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/octree.rs:348:11 [INFO] [stderr] | [INFO] [stderr] 348 | BCube { center: center, half_len: half_len } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `center` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/octree.rs:348:27 [INFO] [stderr] | [INFO] [stderr] 348 | BCube { center: center, half_len: half_len } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `half_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:733:4 [INFO] [stderr] | [INFO] [stderr] 733 | write!(f, "No Root\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:736:4 [INFO] [stderr] | [INFO] [stderr] 736 | write!(f, "Root {}:{:?}\n", root, self.bcube)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(f, "")` [INFO] [stderr] --> src/octree.rs:750:5 [INFO] [stderr] | [INFO] [stderr] 750 | writeln!(f, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(f)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:761:4 [INFO] [stderr] | [INFO] [stderr] 761 | write!(f, "No Root\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:764:4 [INFO] [stderr] | [INFO] [stderr] 764 | write!(f, "root {}\n", root)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/octree.rs:770:5 [INFO] [stderr] | [INFO] [stderr] 770 | write!(f, "{}: {:?}\n", i, self.nodes[i])?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/octree.rs:246:3 [INFO] [stderr] | [INFO] [stderr] 246 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/octree.rs:261:3 [INFO] [stderr] | [INFO] [stderr] 261 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/octree.rs:325:3 [INFO] [stderr] | [INFO] [stderr] 325 | a [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/octree.rs:313:11 [INFO] [stderr] | [INFO] [stderr] 313 | let a = Some(match (min[0], min[1], min[2]) { [INFO] [stderr] | _________________^ [INFO] [stderr] 314 | | (true, true, true) => 0, [INFO] [stderr] 315 | | (true, true, false) => 1, [INFO] [stderr] 316 | | (true, false, true) => 2, [INFO] [stderr] ... | [INFO] [stderr] 321 | | (false, false, false) => 7, [INFO] [stderr] 322 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/octree.rs:373:3 [INFO] [stderr] | [INFO] [stderr] 373 | o [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/octree.rs:363:11 [INFO] [stderr] | [INFO] [stderr] 363 | let o = Octree { [INFO] [stderr] | _________________^ [INFO] [stderr] 364 | | colliders: vec![], [INFO] [stderr] 365 | | collider_garbage: vec![], [INFO] [stderr] 366 | | nodes: vec![], [INFO] [stderr] ... | [INFO] [stderr] 370 | | n_colliders: 0, [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/octree.rs:246:3 [INFO] [stderr] | [INFO] [stderr] 246 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/octree.rs:261:3 [INFO] [stderr] | [INFO] [stderr] 261 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/octree.rs:325:3 [INFO] [stderr] | [INFO] [stderr] 325 | a [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/octree.rs:313:11 [INFO] [stderr] | [INFO] [stderr] 313 | let a = Some(match (min[0], min[1], min[2]) { [INFO] [stderr] | _________________^ [INFO] [stderr] 314 | | (true, true, true) => 0, [INFO] [stderr] 315 | | (true, true, false) => 1, [INFO] [stderr] 316 | | (true, false, true) => 2, [INFO] [stderr] ... | [INFO] [stderr] 321 | | (false, false, false) => 7, [INFO] [stderr] 322 | | }); [INFO] [stderr] | |__________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/octree.rs:373:3 [INFO] [stderr] | [INFO] [stderr] 373 | o [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/octree.rs:363:11 [INFO] [stderr] | [INFO] [stderr] 363 | let o = Octree { [INFO] [stderr] | _________________^ [INFO] [stderr] 364 | | colliders: vec![], [INFO] [stderr] 365 | | collider_garbage: vec![], [INFO] [stderr] 366 | | nodes: vec![], [INFO] [stderr] ... | [INFO] [stderr] 370 | | n_colliders: 0, [INFO] [stderr] 371 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/octree.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | fn is_none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/octree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | fn is_some(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/octree.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | fn is_none(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/octree.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | fn is_some(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `octree::Octree` [INFO] [stderr] --> src/octree.rs:362:2 [INFO] [stderr] | [INFO] [stderr] 362 | pub fn new() -> Octree { [INFO] [stderr] | _____^ [INFO] [stderr] 363 | | let o = Octree { [INFO] [stderr] 364 | | colliders: vec![], [INFO] [stderr] 365 | | collider_garbage: vec![], [INFO] [stderr] ... | [INFO] [stderr] 373 | | o [INFO] [stderr] 374 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | impl Default for octree::Octree { [INFO] [stderr] 361 | fn default() -> Self { [INFO] [stderr] 362 | Self::new() [INFO] [stderr] 363 | } [INFO] [stderr] 364 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/octree.rs:717:2 [INFO] [stderr] | [INFO] [stderr] 717 | fn index<'a>(&'a self, index: Id) -> &'a T { [INFO] [stderr] | _____^ [INFO] [stderr] 718 | | let index: usize = index.into(); [INFO] [stderr] 719 | | &self.colliders[index] [INFO] [stderr] 720 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/octree.rs:724:2 [INFO] [stderr] | [INFO] [stderr] 724 | fn index_mut<'a>(&'a mut self, index: Id) -> &'a mut T { [INFO] [stderr] | _____^ [INFO] [stderr] 725 | | let index: usize = index.into(); [INFO] [stderr] 726 | | &mut self.colliders[index] [INFO] [stderr] 727 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `octree::Octree` [INFO] [stderr] --> src/octree.rs:362:2 [INFO] [stderr] | [INFO] [stderr] 362 | pub fn new() -> Octree { [INFO] [stderr] | _____^ [INFO] [stderr] 363 | | let o = Octree { [INFO] [stderr] 364 | | colliders: vec![], [INFO] [stderr] 365 | | collider_garbage: vec![], [INFO] [stderr] ... | [INFO] [stderr] 373 | | o [INFO] [stderr] 374 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 360 | impl Default for octree::Octree { [INFO] [stderr] 361 | fn default() -> Self { [INFO] [stderr] 362 | Self::new() [INFO] [stderr] 363 | } [INFO] [stderr] 364 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/plane.rs:51:34 [INFO] [stderr] | [INFO] [stderr] 51 | let neg_side = self.facing.dot(b.into()) - self.offset; [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/octree.rs:717:2 [INFO] [stderr] | [INFO] [stderr] 717 | fn index<'a>(&'a self, index: Id) -> &'a T { [INFO] [stderr] | _____^ [INFO] [stderr] 718 | | let index: usize = index.into(); [INFO] [stderr] 719 | | &self.colliders[index] [INFO] [stderr] 720 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/octree.rs:724:2 [INFO] [stderr] | [INFO] [stderr] 724 | fn index_mut<'a>(&'a mut self, index: Id) -> &'a mut T { [INFO] [stderr] | _____^ [INFO] [stderr] 725 | | let index: usize = index.into(); [INFO] [stderr] 726 | | &mut self.colliders[index] [INFO] [stderr] 727 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vector.rs:177:4 [INFO] [stderr] | [INFO] [stderr] 177 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const vector::Vector as *const [f32; 3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/matrix.rs:112:2 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn new( [INFO] [stderr] | _____^ [INFO] [stderr] 113 | | m00: f32, m01: f32, m02: f32, m03: f32, [INFO] [stderr] 114 | | m10: f32, m11: f32, m12: f32, m13: f32, [INFO] [stderr] 115 | | m20: f32, m21: f32, m22: f32, m23: f32, [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/plane.rs:51:34 [INFO] [stderr] | [INFO] [stderr] 51 | let neg_side = self.facing.dot(b.into()) - self.offset; [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/matrix.rs:293:4 [INFO] [stderr] | [INFO] [stderr] 293 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const matrix::Matrix as *const [[f32; 4]; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/vector.rs:177:4 [INFO] [stderr] | [INFO] [stderr] 177 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const vector::Vector as *const [f32; 3])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_ptr_to_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/rotation.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const rotation::Rotation as *const [f32; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (16/7) [INFO] [stderr] --> src/matrix.rs:112:2 [INFO] [stderr] | [INFO] [stderr] 112 | pub fn new( [INFO] [stderr] | _____^ [INFO] [stderr] 113 | | m00: f32, m01: f32, m02: f32, m03: f32, [INFO] [stderr] 114 | | m10: f32, m11: f32, m12: f32, m13: f32, [INFO] [stderr] 115 | | m20: f32, m21: f32, m22: f32, m23: f32, [INFO] [stderr] ... | [INFO] [stderr] 123 | | } [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/matrix.rs:293:4 [INFO] [stderr] | [INFO] [stderr] 293 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const matrix::Matrix as *const [[f32; 4]; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a reference [INFO] [stderr] --> src/rotation.rs:111:4 [INFO] [stderr] | [INFO] [stderr] 111 | mem::transmute(self) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `&*(self as *const rotation::Rotation as *const [f32; 4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_ptr_to_ptr [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.49s [INFO] running `"docker" "inspect" "90a0a278d921bea304dfbd5899f5ecd67b871691d2e9800dfd98281314614765"` [INFO] running `"docker" "rm" "-f" "90a0a278d921bea304dfbd5899f5ecd67b871691d2e9800dfd98281314614765"` [INFO] [stdout] 90a0a278d921bea304dfbd5899f5ecd67b871691d2e9800dfd98281314614765