[INFO] crate amethyst_utils 0.5.0 is already in cache [INFO] extracting crate amethyst_utils 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_utils/0.5.0 [INFO] extracting crate amethyst_utils 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_utils/0.5.0 [INFO] validating manifest of amethyst_utils-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_utils-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_utils-0.5.0 [INFO] finished frobbing amethyst_utils-0.5.0 [INFO] frobbed toml for amethyst_utils-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_utils/0.5.0/Cargo.toml [INFO] started frobbing amethyst_utils-0.5.0 [INFO] finished frobbing amethyst_utils-0.5.0 [INFO] frobbed toml for amethyst_utils-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_utils/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_utils-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_utils/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cf40e74b517ef4084b0796671f8862e657bfbda0f4607adfad9bf2c693b17788 [INFO] running `"docker" "start" "-a" "cf40e74b517ef4084b0796671f8862e657bfbda0f4607adfad9bf2c693b17788"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Checking hetseq v0.2.0 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling nonzero_signed v1.0.3 [INFO] [stderr] Checking crossbeam-deque v0.5.2 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling amethyst_derive v0.3.0 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking ron v0.4.1 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking amethyst_config v0.9.0 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking genmesh v0.6.2 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking glsl-layout v0.1.1 [INFO] [stderr] Checking gfx_window_glutin v0.27.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_assets v0.6.0 [INFO] [stderr] Checking amethyst_renderer v0.10.4 [INFO] [stderr] Checking amethyst_input v0.6.0 [INFO] [stderr] Checking amethyst_controls v0.4.0 [INFO] [stderr] Checking amethyst_utils v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ortho_camera.rs:218:48 [INFO] [stderr] | [INFO] [stderr] 218 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] // cmp just used to recognize change [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: lint name `float_cmp` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/ortho_camera.rs:218:48 [INFO] [stderr] | [INFO] [stderr] 218 | #[cfg_attr(feature = "cargo-clippy", allow(float_cmp))] // cmp just used to recognize change [INFO] [stderr] | ^^^^^^^^^ help: change it to: `clippy::float_cmp` [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ortho_camera.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/scene.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Deserialize, Serialize, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/ortho_camera.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | &self, [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/ortho_camera.rs:307:22 [INFO] [stderr] | [INFO] [stderr] 307 | let aspect = 1.0 / 1.0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/ortho_camera.rs:316:22 [INFO] [stderr] | [INFO] [stderr] 316 | let aspect = 1.0 / 1.0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/ortho_camera.rs:339:22 [INFO] [stderr] | [INFO] [stderr] 339 | let aspect = 1.0 / 1.0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `/` [INFO] [stderr] --> src/ortho_camera.rs:361:22 [INFO] [stderr] | [INFO] [stderr] 361 | let aspect = 1.0 / 1.0; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/scene.rs:29:34 [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Deserialize, Serialize, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `amethyst_utils`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "cf40e74b517ef4084b0796671f8862e657bfbda0f4607adfad9bf2c693b17788"` [INFO] running `"docker" "rm" "-f" "cf40e74b517ef4084b0796671f8862e657bfbda0f4607adfad9bf2c693b17788"` [INFO] [stdout] cf40e74b517ef4084b0796671f8862e657bfbda0f4607adfad9bf2c693b17788