[INFO] crate amethyst_network 0.3.0 is already in cache [INFO] extracting crate amethyst_network 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_network/0.3.0 [INFO] extracting crate amethyst_network 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_network/0.3.0 [INFO] validating manifest of amethyst_network-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_network-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_network-0.3.0 [INFO] finished frobbing amethyst_network-0.3.0 [INFO] frobbed toml for amethyst_network-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_network/0.3.0/Cargo.toml [INFO] started frobbing amethyst_network-0.3.0 [INFO] finished frobbing amethyst_network-0.3.0 [INFO] frobbed toml for amethyst_network-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_network/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_network-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_network/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 18e9c2073d474bdb6604357ff4f02d6ea5de6b2418e495f4092213dd77cd8d9c [INFO] running `"docker" "start" "-a" "18e9c2073d474bdb6604357ff4f02d6ea5de6b2418e495f4092213dd77cd8d9c"` [INFO] [stderr] Checking num-complex v0.2.1 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking uuid v0.7.2 [INFO] [stderr] Checking hibitset v0.5.4 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking laminar v0.1.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_network v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filter::FilterConnected` [INFO] [stderr] --> src/filter.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | FilterConnected { _pd: PhantomData } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: module has the same name as its containing module [INFO] [stderr] --> src/test.rs:2:1 [INFO] [stderr] | [INFO] [stderr] 2 | / mod test { [INFO] [stderr] 3 | | use std::{net::SocketAddr, thread::sleep, time::Duration}; [INFO] [stderr] 4 | | [INFO] [stderr] 5 | | use amethyst_core::{ [INFO] [stderr] ... | [INFO] [stderr] 105 | | } [INFO] [stderr] 106 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::module_inception)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/network_socket.rs:128:36 [INFO] [stderr] | [INFO] [stderr] 128 | if let Err(_) = receive_queue.send(RawEvent::from(packet)) { [INFO] [stderr] | _____________________________- ^^^^^^ [INFO] [stderr] 129 | | error!("`NetworkSocketSystem` was dropped"); [INFO] [stderr] 130 | | break 'outer; [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____________________________- help: try this: `if receive_queue.send(RawEvent::from(packet)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `filter::FilterConnected` [INFO] [stderr] --> src/filter.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | / pub fn new() -> Self { [INFO] [stderr] 24 | | FilterConnected { _pd: PhantomData } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/network_socket.rs:128:36 [INFO] [stderr] | [INFO] [stderr] 128 | if let Err(_) = receive_queue.send(RawEvent::from(packet)) { [INFO] [stderr] | _____________________________- ^^^^^^ [INFO] [stderr] 129 | | error!("`NetworkSocketSystem` was dropped"); [INFO] [stderr] 130 | | break 'outer; [INFO] [stderr] 131 | | } [INFO] [stderr] | |_____________________________- help: try this: `if receive_queue.send(RawEvent::from(packet)).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | build(addr1.clone(), addr2.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `addr1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test.rs:17:34 [INFO] [stderr] | [INFO] [stderr] 17 | build(addr1.clone(), addr2.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `addr2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/test.rs:31:30 [INFO] [stderr] | [INFO] [stderr] 31 | cl_dispatch.dispatch(&mut world_cl.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/test.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | sv_dispatch.dispatch(&mut world_sv.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test.rs:48:19 [INFO] [stderr] | [INFO] [stderr] 48 | build(addr1.clone(), addr2.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `addr1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/test.rs:48:34 [INFO] [stderr] | [INFO] [stderr] 48 | build(addr1.clone(), addr2.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `addr2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/test.rs:72:30 [INFO] [stderr] | [INFO] [stderr] 72 | cl_dispatch.dispatch(&mut world_cl.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `dispatch` doesn't need a mutable reference [INFO] [stderr] --> src/test.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | sv_dispatch.dispatch(&mut world_sv.res); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 31s [INFO] running `"docker" "inspect" "18e9c2073d474bdb6604357ff4f02d6ea5de6b2418e495f4092213dd77cd8d9c"` [INFO] running `"docker" "rm" "-f" "18e9c2073d474bdb6604357ff4f02d6ea5de6b2418e495f4092213dd77cd8d9c"` [INFO] [stdout] 18e9c2073d474bdb6604357ff4f02d6ea5de6b2418e495f4092213dd77cd8d9c