[INFO] crate amethyst_input 0.6.0 is already in cache [INFO] extracting crate amethyst_input 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_input/0.6.0 [INFO] extracting crate amethyst_input 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_input/0.6.0 [INFO] validating manifest of amethyst_input-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_input-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_input-0.6.0 [INFO] finished frobbing amethyst_input-0.6.0 [INFO] frobbed toml for amethyst_input-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_input/0.6.0/Cargo.toml [INFO] started frobbing amethyst_input-0.6.0 [INFO] finished frobbing amethyst_input-0.6.0 [INFO] frobbed toml for amethyst_input-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_input/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_input-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_input/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bbbf74029f2978d27491841e23143e8a8aff8e14257097eba1b73dd513cdc569 [INFO] running `"docker" "start" "-a" "bbbf74029f2978d27491841e23143e8a8aff8e14257097eba1b73dd513cdc569"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking mint v0.5.1 [INFO] [stderr] Compiling cgmath v0.16.1 [INFO] [stderr] Checking hetseq v0.2.0 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling amethyst_derive v0.3.0 [INFO] [stderr] Checking serde v1.0.85 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Compiling glsl-layout-derive v0.1.1 [INFO] [stderr] Checking genmesh v0.6.2 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking ron v0.4.1 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking amethyst_config v0.9.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking glsl-layout v0.1.1 [INFO] [stderr] Checking gfx_window_glutin v0.27.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_assets v0.6.0 [INFO] [stderr] Checking amethyst_renderer v0.10.4 [INFO] [stderr] Checking amethyst_input v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/input_handler.rs:346:53 [INFO] [stderr] | [INFO] [stderr] 346 | .filter(|b| { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 347 | | b != &&Button::Controller(controller_id, button) [INFO] [stderr] 348 | | }) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/input_handler.rs:460:34 [INFO] [stderr] | [INFO] [stderr] 460 | pub fn buttons_that_are_down<'a>(&self) -> impl Iterator + '_ { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/input_handler.rs:603:17 [INFO] [stderr] | [INFO] [stderr] 603 | for ref combination in combinations { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ------------ help: try: `let combination = &combinations;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/system.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 60 | | Read<'a, EventChannel>, [INFO] [stderr] 61 | | Write<'a, InputHandler>, [INFO] [stderr] 62 | | Write<'a, EventChannel>>, [INFO] [stderr] 63 | | ReadExpect<'a, ScreenDimensions>, [INFO] [stderr] 64 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/input_handler.rs:346:53 [INFO] [stderr] | [INFO] [stderr] 346 | .filter(|b| { [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 347 | | b != &&Button::Controller(controller_id, button) [INFO] [stderr] 348 | | }) [INFO] [stderr] | |_________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/input_handler.rs:460:34 [INFO] [stderr] | [INFO] [stderr] 460 | pub fn buttons_that_are_down<'a>(&self) -> impl Iterator + '_ { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/input_handler.rs:603:17 [INFO] [stderr] | [INFO] [stderr] 603 | for ref combination in combinations { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ------------ help: try: `let combination = &combinations;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/system.rs:59:23 [INFO] [stderr] | [INFO] [stderr] 59 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 60 | | Read<'a, EventChannel>, [INFO] [stderr] 61 | | Write<'a, InputHandler>, [INFO] [stderr] 62 | | Write<'a, EventChannel>>, [INFO] [stderr] 63 | | ReadExpect<'a, ScreenDimensions>, [INFO] [stderr] 64 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4m 04s [INFO] running `"docker" "inspect" "bbbf74029f2978d27491841e23143e8a8aff8e14257097eba1b73dd513cdc569"` [INFO] running `"docker" "rm" "-f" "bbbf74029f2978d27491841e23143e8a8aff8e14257097eba1b73dd513cdc569"` [INFO] [stdout] bbbf74029f2978d27491841e23143e8a8aff8e14257097eba1b73dd513cdc569