[INFO] crate amethyst_gltf 0.5.0 is already in cache [INFO] extracting crate amethyst_gltf 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_gltf/0.5.0 [INFO] extracting crate amethyst_gltf 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_gltf/0.5.0 [INFO] validating manifest of amethyst_gltf-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_gltf-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_gltf-0.5.0 [INFO] finished frobbing amethyst_gltf-0.5.0 [INFO] frobbed toml for amethyst_gltf-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_gltf/0.5.0/Cargo.toml [INFO] started frobbing amethyst_gltf-0.5.0 [INFO] finished frobbing amethyst_gltf-0.5.0 [INFO] frobbed toml for amethyst_gltf-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_gltf/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_gltf-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_gltf/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 25461847409eca89076af12ba6d9baa0e597aab6b20111fa4ddbdad19f8c0c66 [INFO] running `"docker" "start" "-a" "25461847409eca89076af12ba6d9baa0e597aab6b20111fa4ddbdad19f8c0c66"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling inflections v1.1.1 [INFO] [stderr] Checking hetseq v0.2.0 [INFO] [stderr] Compiling mikktspace v0.1.1 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling syn v0.13.11 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling amethyst_derive v0.3.0 [INFO] [stderr] Checking cgmath v0.15.0 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Compiling gltf-derive v0.11.2 [INFO] [stderr] Checking ron v0.4.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking gltf-json v0.11.2 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Compiling glsl-layout-derive v0.1.1 [INFO] [stderr] Checking minterpolate v0.4.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking gltf v0.11.2 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking glsl-layout v0.1.1 [INFO] [stderr] Checking gfx_window_glutin v0.27.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_assets v0.6.0 [INFO] [stderr] Checking amethyst_renderer v0.10.4 [INFO] [stderr] Checking amethyst_animation v0.5.0 [INFO] [stderr] Checking amethyst_gltf v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `base64` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use base64; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `mikktspace` [INFO] [stderr] --> src/lib.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use mikktspace; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/format/importer.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | header: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Glb { json, bin, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unused import: `base64` [INFO] [stderr] --> src/lib.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use base64; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `mikktspace` [INFO] [stderr] --> src/lib.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | use mikktspace; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/format/importer.rs:130:9 [INFO] [stderr] | [INFO] [stderr] 130 | header: _, [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Glb { json, bin, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/animation.rs:105:34 [INFO] [stderr] | [INFO] [stderr] 105 | fn map_interpolation_type(ty: &gltf::animation::Interpolation) -> InterpolationFunction [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `gltf::animation::Interpolation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/format/importer.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | let encoded = uri.split(",").nth(1).expect("URI does not contain ','"); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/format/importer.rs:96:51 [INFO] [stderr] | [INFO] [stderr] 96 | let path = base_path.parent().unwrap_or(Path::new("./")).join(uri); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("./"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/format/importer.rs:174:47 [INFO] [stderr] | [INFO] [stderr] 174 | let path = base_path.parent().unwrap_or(Path::new("./")).join(uri); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("./"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/format/material.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | .map(|data| TexturePrefab::Data(data))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TexturePrefab::Data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/format/material.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | .map(|data| TexturePrefab::Data(data))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TexturePrefab::Data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format/material.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | let metadata = match srgb { [INFO] [stderr] | ____________________^ [INFO] [stderr] 188 | | true => TextureMetadata::srgb(), [INFO] [stderr] 189 | | false => TextureMetadata::unorm(), [INFO] [stderr] 190 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if srgb { TextureMetadata::srgb() } else { TextureMetadata::unorm() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/format/mesh.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | ) -> Result, Range<[f32; 3]>)>, GltfError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/format/mesh.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | let f = faces [INFO] [stderr] | _________________________^ [INFO] [stderr] 65 | | .as_ref() [INFO] [stderr] 66 | | .map(|f| f.clone()) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 64 | let f = faces [INFO] [stderr] 65 | .as_ref().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/format/mesh.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | once(normal.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/format/mesh.rs:75:41 [INFO] [stderr] | [INFO] [stderr] 75 | .chain(once(normal.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/format/mesh.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let f = faces [INFO] [stderr] | _________________________^ [INFO] [stderr] 117 | | .as_ref() [INFO] [stderr] 118 | | .map(|f| f.clone()) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 116 | let f = faces [INFO] [stderr] 117 | .as_ref().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/format/skin.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .unwrap_or(vec![Matrix4::identity().into(); joints.len()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![Matrix4::identity().into(); joints.len()])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/format/skin.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | .unwrap_or(vec![Matrix4::identity().into(); joints.len()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Matrix4::identity()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/format/mod.rs:288:1 [INFO] [stderr] | [INFO] [stderr] 288 | / fn load_node( [INFO] [stderr] 289 | | gltf: &Gltf, [INFO] [stderr] 290 | | node: &gltf::Node<'_>, [INFO] [stderr] 291 | | entity_index: usize, [INFO] [stderr] ... | [INFO] [stderr] 415 | | Ok(()) [INFO] [stderr] 416 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/format/mod.rs:343:17 [INFO] [stderr] | [INFO] [stderr] 343 | / if !material_set.materials.contains_key(&material_id) { [INFO] [stderr] 344 | | material_set.materials.insert( [INFO] [stderr] 345 | | material_id, [INFO] [stderr] 346 | | load_material(&material, buffers, source.clone(), name)?, [INFO] [stderr] 347 | | ); [INFO] [stderr] 348 | | } [INFO] [stderr] | |_________________^ help: consider using: `material_set.materials.entry(material_id).or_insert(load_material(&material, buffers, source.clone(), name)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/format/mod.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | / if !material_set.materials.contains_key(&material_id) { [INFO] [stderr] 367 | | material_set.materials.insert( [INFO] [stderr] 368 | | material_id, [INFO] [stderr] 369 | | load_material(&material, buffers, source.clone(), name)?, [INFO] [stderr] 370 | | ); [INFO] [stderr] 371 | | } [INFO] [stderr] | |_____________________^ help: consider using: `material_set.materials.entry(material_id).or_insert(load_material(&material, buffers, source.clone(), name)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 198 | | >::SystemData, [INFO] [stderr] 199 | | >::SystemData, [INFO] [stderr] 200 | | >::SystemData, [INFO] [stderr] ... | [INFO] [stderr] 207 | | Write<'a, GltfMaterialSet>, [INFO] [stderr] 208 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/format/animation.rs:105:34 [INFO] [stderr] | [INFO] [stderr] 105 | fn map_interpolation_type(ty: &gltf::animation::Interpolation) -> InterpolationFunction [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `gltf::animation::Interpolation` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/format/importer.rs:77:29 [INFO] [stderr] | [INFO] [stderr] 77 | let encoded = uri.split(",").nth(1).expect("URI does not contain ','"); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/format/importer.rs:96:51 [INFO] [stderr] | [INFO] [stderr] 96 | let path = base_path.parent().unwrap_or(Path::new("./")).join(uri); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("./"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/format/importer.rs:174:47 [INFO] [stderr] | [INFO] [stderr] 174 | let path = base_path.parent().unwrap_or(Path::new("./")).join(uri); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Path::new("./"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/format/material.rs:85:18 [INFO] [stderr] | [INFO] [stderr] 85 | .map(|data| TexturePrefab::Data(data))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TexturePrefab::Data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/format/material.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | .map(|data| TexturePrefab::Data(data))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `TexturePrefab::Data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/format/material.rs:187:20 [INFO] [stderr] | [INFO] [stderr] 187 | let metadata = match srgb { [INFO] [stderr] | ____________________^ [INFO] [stderr] 188 | | true => TextureMetadata::srgb(), [INFO] [stderr] 189 | | false => TextureMetadata::unorm(), [INFO] [stderr] 190 | | }; [INFO] [stderr] | |_____^ help: consider using an if/else expression: `if srgb { TextureMetadata::srgb() } else { TextureMetadata::unorm() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/format/mesh.rs:15:6 [INFO] [stderr] | [INFO] [stderr] 15 | ) -> Result, Range<[f32; 3]>)>, GltfError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/format/mesh.rs:64:25 [INFO] [stderr] | [INFO] [stderr] 64 | let f = faces [INFO] [stderr] | _________________________^ [INFO] [stderr] 65 | | .as_ref() [INFO] [stderr] 66 | | .map(|f| f.clone()) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 64 | let f = faces [INFO] [stderr] 65 | .as_ref().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/format/mesh.rs:74:30 [INFO] [stderr] | [INFO] [stderr] 74 | once(normal.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/format/mesh.rs:75:41 [INFO] [stderr] | [INFO] [stderr] 75 | .chain(once(normal.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `normal` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/format/mesh.rs:116:25 [INFO] [stderr] | [INFO] [stderr] 116 | let f = faces [INFO] [stderr] | _________________________^ [INFO] [stderr] 117 | | .as_ref() [INFO] [stderr] 118 | | .map(|f| f.clone()) [INFO] [stderr] | |_______________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 116 | let f = faces [INFO] [stderr] 117 | .as_ref().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/format/skin.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | .unwrap_or(vec![Matrix4::identity().into(); joints.len()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![Matrix4::identity().into(); joints.len()])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/format/skin.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | .unwrap_or(vec![Matrix4::identity().into(); joints.len()]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Matrix4::identity()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/format/mod.rs:288:1 [INFO] [stderr] | [INFO] [stderr] 288 | / fn load_node( [INFO] [stderr] 289 | | gltf: &Gltf, [INFO] [stderr] 290 | | node: &gltf::Node<'_>, [INFO] [stderr] 291 | | entity_index: usize, [INFO] [stderr] ... | [INFO] [stderr] 415 | | Ok(()) [INFO] [stderr] 416 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/format/mod.rs:343:17 [INFO] [stderr] | [INFO] [stderr] 343 | / if !material_set.materials.contains_key(&material_id) { [INFO] [stderr] 344 | | material_set.materials.insert( [INFO] [stderr] 345 | | material_id, [INFO] [stderr] 346 | | load_material(&material, buffers, source.clone(), name)?, [INFO] [stderr] 347 | | ); [INFO] [stderr] 348 | | } [INFO] [stderr] | |_________________^ help: consider using: `material_set.materials.entry(material_id).or_insert(load_material(&material, buffers, source.clone(), name)?)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/format/mod.rs:366:21 [INFO] [stderr] | [INFO] [stderr] 366 | / if !material_set.materials.contains_key(&material_id) { [INFO] [stderr] 367 | | material_set.materials.insert( [INFO] [stderr] 368 | | material_id, [INFO] [stderr] 369 | | load_material(&material, buffers, source.clone(), name)?, [INFO] [stderr] 370 | | ); [INFO] [stderr] 371 | | } [INFO] [stderr] | |_____________________^ help: consider using: `material_set.materials.entry(material_id).or_insert(load_material(&material, buffers, source.clone(), name)?)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 198 | | >::SystemData, [INFO] [stderr] 199 | | >::SystemData, [INFO] [stderr] 200 | | >::SystemData, [INFO] [stderr] ... | [INFO] [stderr] 207 | | Write<'a, GltfMaterialSet>, [INFO] [stderr] 208 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4m 24s [INFO] running `"docker" "inspect" "25461847409eca89076af12ba6d9baa0e597aab6b20111fa4ddbdad19f8c0c66"` [INFO] running `"docker" "rm" "-f" "25461847409eca89076af12ba6d9baa0e597aab6b20111fa4ddbdad19f8c0c66"` [INFO] [stdout] 25461847409eca89076af12ba6d9baa0e597aab6b20111fa4ddbdad19f8c0c66