[INFO] crate amethyst_derive 0.3.0 is already in cache [INFO] extracting crate amethyst_derive 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_derive/0.3.0 [INFO] extracting crate amethyst_derive 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_derive/0.3.0 [INFO] validating manifest of amethyst_derive-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_derive-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_derive-0.3.0 [INFO] finished frobbing amethyst_derive-0.3.0 [INFO] frobbed toml for amethyst_derive-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_derive/0.3.0/Cargo.toml [INFO] started frobbing amethyst_derive-0.3.0 [INFO] finished frobbing amethyst_derive-0.3.0 [INFO] frobbed toml for amethyst_derive-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_derive/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_derive-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_derive/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c7b04377b4fa67040206c0d84e2bccaa600f916d4e0c048ec4d8cc259a3c8151 [INFO] running `"docker" "start" "-a" "c7b04377b4fa67040206c0d84e2bccaa600f916d4e0c048ec4d8cc259a3c8151"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Compiling nonzero_signed v1.0.3 [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Compiling shred-derive v0.5.1 [INFO] [stderr] Compiling amethyst_derive v0.3.0 (/opt/crater/workdir) [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking hibitset v0.5.4 [INFO] [stderr] Checking ron v0.4.1 [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/event_reader.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match meta { [INFO] [stderr] 18 | | Meta::List(l) => { [INFO] [stderr] 19 | | for nested_meta in l.nested.iter() { [INFO] [stderr] 20 | | match *nested_meta { [INFO] [stderr] ... | [INFO] [stderr] 28 | | _ => (), [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Meta::List(l) = meta { [INFO] [stderr] 18 | for nested_meta in l.nested.iter() { [INFO] [stderr] 19 | match *nested_meta { [INFO] [stderr] 20 | NestedMeta::Meta(Meta::Word(ref word)) => { [INFO] [stderr] 21 | reader_name = Some(word.clone()); [INFO] [stderr] 22 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/event_reader.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let reader_name = reader_name.expect(&format!( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 33 | | r#" [INFO] [stderr] 34 | | #[derive(EventReader)] requested for {}, but #[reader(SomeEventReader)] attribute is missing [INFO] [stderr] 35 | | [INFO] [stderr] ... | [INFO] [stderr] 44 | | event_name [INFO] [stderr] 45 | | )); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | let reader_name = reader_name.unwrap_or_else(|| panic!(r#" [INFO] [stderr] 33 | #[derive(EventReader)] requested for {}, but #[reader(SomeEventReader)] attribute is missing [INFO] [stderr] 34 | [INFO] [stderr] 35 | Example usage: [INFO] [stderr] 36 | #[derive(EventReader)] [INFO] [stderr] 37 | #[reader(SomeEventReader)] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | let ref lt = x.lifetime; [INFO] [stderr] | ----^^^^^^-------------- help: try: `let lt = &x.lifetime;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | let ref bounds = x.bounds; [INFO] [stderr] | ----^^^^^^^^^^------------ help: try: `let bounds = &x.bounds;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | let ref ty = x.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let ty = &x.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | let ref bounds = x.bounds; [INFO] [stderr] | ----^^^^^^^^^^------------ help: try: `let bounds = &x.bounds;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/prefab_data.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match meta { [INFO] [stderr] 165 | | Meta::List(l) => { [INFO] [stderr] 166 | | for nested_meta in l.nested.iter() { [INFO] [stderr] 167 | | match *nested_meta { [INFO] [stderr] ... | [INFO] [stderr] 177 | | _ => (), [INFO] [stderr] 178 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Meta::List(l) = meta { [INFO] [stderr] 165 | for nested_meta in l.nested.iter() { [INFO] [stderr] 166 | match *nested_meta { [INFO] [stderr] 167 | NestedMeta::Meta(Meta::Word(ref word)) => { [INFO] [stderr] 168 | if word == "Component" { [INFO] [stderr] 169 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_assets v0.6.0 [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/event_reader.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | / match meta { [INFO] [stderr] 18 | | Meta::List(l) => { [INFO] [stderr] 19 | | for nested_meta in l.nested.iter() { [INFO] [stderr] 20 | | match *nested_meta { [INFO] [stderr] ... | [INFO] [stderr] 28 | | _ => (), [INFO] [stderr] 29 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | if let Meta::List(l) = meta { [INFO] [stderr] 18 | for nested_meta in l.nested.iter() { [INFO] [stderr] 19 | match *nested_meta { [INFO] [stderr] 20 | NestedMeta::Meta(Meta::Word(ref word)) => { [INFO] [stderr] 21 | reader_name = Some(word.clone()); [INFO] [stderr] 22 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/event_reader.rs:32:35 [INFO] [stderr] | [INFO] [stderr] 32 | let reader_name = reader_name.expect(&format!( [INFO] [stderr] | ___________________________________^ [INFO] [stderr] 33 | | r#" [INFO] [stderr] 34 | | #[derive(EventReader)] requested for {}, but #[reader(SomeEventReader)] attribute is missing [INFO] [stderr] 35 | | [INFO] [stderr] ... | [INFO] [stderr] 44 | | event_name [INFO] [stderr] 45 | | )); [INFO] [stderr] | |______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 32 | let reader_name = reader_name.unwrap_or_else(|| panic!(r#" [INFO] [stderr] 33 | #[derive(EventReader)] requested for {}, but #[reader(SomeEventReader)] attribute is missing [INFO] [stderr] 34 | [INFO] [stderr] 35 | Example usage: [INFO] [stderr] 36 | #[derive(EventReader)] [INFO] [stderr] 37 | #[reader(SomeEventReader)] [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:127:17 [INFO] [stderr] | [INFO] [stderr] 127 | let ref lt = x.lifetime; [INFO] [stderr] | ----^^^^^^-------------- help: try: `let lt = &x.lifetime;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:128:17 [INFO] [stderr] | [INFO] [stderr] 128 | let ref bounds = x.bounds; [INFO] [stderr] | ----^^^^^^^^^^------------ help: try: `let bounds = &x.bounds;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | let ref ty = x.ident; [INFO] [stderr] | ----^^^^^^----------- help: try: `let ty = &x.ident;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/prefab_data.rs:146:17 [INFO] [stderr] | [INFO] [stderr] 146 | let ref bounds = x.bounds; [INFO] [stderr] | ----^^^^^^^^^^------------ help: try: `let bounds = &x.bounds;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/prefab_data.rs:164:9 [INFO] [stderr] | [INFO] [stderr] 164 | / match meta { [INFO] [stderr] 165 | | Meta::List(l) => { [INFO] [stderr] 166 | | for nested_meta in l.nested.iter() { [INFO] [stderr] 167 | | match *nested_meta { [INFO] [stderr] ... | [INFO] [stderr] 177 | | _ => (), [INFO] [stderr] 178 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 164 | if let Meta::List(l) = meta { [INFO] [stderr] 165 | for nested_meta in l.nested.iter() { [INFO] [stderr] 166 | match *nested_meta { [INFO] [stderr] 167 | NestedMeta::Meta(Meta::Word(ref word)) => { [INFO] [stderr] 168 | if word == "Component" { [INFO] [stderr] 169 | return true; [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> tests/test.rs:40:17 [INFO] [stderr] | [INFO] [stderr] 40 | #[derive(Clone, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 42s [INFO] running `"docker" "inspect" "c7b04377b4fa67040206c0d84e2bccaa600f916d4e0c048ec4d8cc259a3c8151"` [INFO] running `"docker" "rm" "-f" "c7b04377b4fa67040206c0d84e2bccaa600f916d4e0c048ec4d8cc259a3c8151"` [INFO] [stdout] c7b04377b4fa67040206c0d84e2bccaa600f916d4e0c048ec4d8cc259a3c8151