[INFO] crate amethyst_controls 0.4.0 is already in cache [INFO] extracting crate amethyst_controls 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_controls/0.4.0 [INFO] extracting crate amethyst_controls 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_controls/0.4.0 [INFO] validating manifest of amethyst_controls-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_controls-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_controls-0.4.0 [INFO] finished frobbing amethyst_controls-0.4.0 [INFO] frobbed toml for amethyst_controls-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_controls/0.4.0/Cargo.toml [INFO] started frobbing amethyst_controls-0.4.0 [INFO] finished frobbing amethyst_controls-0.4.0 [INFO] frobbed toml for amethyst_controls-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_controls/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_controls-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_controls/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 840a7dc39c04e0d8c033d6c065bc154aa1753d7bb22b5a7e91fbddfa28d0d67a [INFO] running `"docker" "start" "-a" "840a7dc39c04e0d8c033d6c065bc154aa1753d7bb22b5a7e91fbddfa28d0d67a"` [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling wayland-scanner v0.21.11 [INFO] [stderr] Compiling glsl-layout-derive v0.1.1 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling amethyst_derive v0.3.0 [INFO] [stderr] Checking wayland-sys v0.21.11 [INFO] [stderr] Checking genmesh v0.6.2 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking num-complex v0.2.1 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking wayland-commons v0.21.11 [INFO] [stderr] Checking ron v0.4.1 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Compiling wayland-client v0.21.11 [INFO] [stderr] Compiling wayland-protocols v0.21.11 [INFO] [stderr] Checking amethyst_config v0.9.0 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking glsl-layout v0.1.1 [INFO] [stderr] Checking gfx_window_glutin v0.27.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_assets v0.6.0 [INFO] [stderr] Checking amethyst_renderer v0.10.4 [INFO] [stderr] Checking amethyst_input v0.6.0 [INFO] [stderr] Checking amethyst_controls v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/systems.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 255 | | if self.is_hidden { [INFO] [stderr] 256 | | release_cursor(&mut msg); [INFO] [stderr] 257 | | self.is_hidden = false; [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 254 | } else if self.is_hidden { [INFO] [stderr] 255 | release_cursor(&mut msg); [INFO] [stderr] 256 | self.is_hidden = false; [INFO] [stderr] 257 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/systems.rs:254:16 [INFO] [stderr] | [INFO] [stderr] 254 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 255 | | if self.is_hidden { [INFO] [stderr] 256 | | release_cursor(&mut msg); [INFO] [stderr] 257 | | self.is_hidden = false; [INFO] [stderr] 258 | | } [INFO] [stderr] 259 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 254 | } else if self.is_hidden { [INFO] [stderr] 255 | release_cursor(&mut msg); [INFO] [stderr] 256 | self.is_hidden = false; [INFO] [stderr] 257 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bundles::ArcBallControlBundle` [INFO] [stderr] --> src/bundles.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn new() -> Self { [INFO] [stderr] 121 | | ArcBallControlBundle { [INFO] [stderr] 122 | | sensitivity_x: 1.0, [INFO] [stderr] 123 | | sensitivity_y: 1.0, [INFO] [stderr] 124 | | _marker: PhantomData, [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 66 | | Read<'a, Time>, [INFO] [stderr] 67 | | WriteStorage<'a, Transform>, [INFO] [stderr] 68 | | Read<'a, InputHandler>, [INFO] [stderr] 69 | | ReadStorage<'a, FlyControlTag>, [INFO] [stderr] 70 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 154 | | Read<'a, EventChannel>, [INFO] [stderr] 155 | | WriteStorage<'a, Transform>, [INFO] [stderr] 156 | | ReadStorage<'a, FlyControlTag>, [INFO] [stderr] 157 | | Read<'a, WindowFocus>, [INFO] [stderr] 158 | | Read<'a, HideCursor>, [INFO] [stderr] 159 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `systems::MouseFocusUpdateSystem` [INFO] [stderr] --> src/systems.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | / pub fn new() -> MouseFocusUpdateSystem { [INFO] [stderr] 197 | | MouseFocusUpdateSystem { event_reader: None } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 190 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `systems::CursorHideSystem` [INFO] [stderr] --> src/systems.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / pub fn new() -> CursorHideSystem { [INFO] [stderr] 232 | | CursorHideSystem { is_hidden: false } [INFO] [stderr] 233 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `bundles::ArcBallControlBundle` [INFO] [stderr] --> src/bundles.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | / pub fn new() -> Self { [INFO] [stderr] 121 | | ArcBallControlBundle { [INFO] [stderr] 122 | | sensitivity_x: 1.0, [INFO] [stderr] 123 | | sensitivity_y: 1.0, [INFO] [stderr] 124 | | _marker: PhantomData, [INFO] [stderr] 125 | | } [INFO] [stderr] 126 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 112 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 66 | | Read<'a, Time>, [INFO] [stderr] 67 | | WriteStorage<'a, Transform>, [INFO] [stderr] 68 | | Read<'a, InputHandler>, [INFO] [stderr] 69 | | ReadStorage<'a, FlyControlTag>, [INFO] [stderr] 70 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems.rs:153:23 [INFO] [stderr] | [INFO] [stderr] 153 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 154 | | Read<'a, EventChannel>, [INFO] [stderr] 155 | | WriteStorage<'a, Transform>, [INFO] [stderr] 156 | | ReadStorage<'a, FlyControlTag>, [INFO] [stderr] 157 | | Read<'a, WindowFocus>, [INFO] [stderr] 158 | | Read<'a, HideCursor>, [INFO] [stderr] 159 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `systems::MouseFocusUpdateSystem` [INFO] [stderr] --> src/systems.rs:196:5 [INFO] [stderr] | [INFO] [stderr] 196 | / pub fn new() -> MouseFocusUpdateSystem { [INFO] [stderr] 197 | | MouseFocusUpdateSystem { event_reader: None } [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 190 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `systems::CursorHideSystem` [INFO] [stderr] --> src/systems.rs:231:5 [INFO] [stderr] | [INFO] [stderr] 231 | / pub fn new() -> CursorHideSystem { [INFO] [stderr] 232 | | CursorHideSystem { is_hidden: false } [INFO] [stderr] 233 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 225 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 49s [INFO] running `"docker" "inspect" "840a7dc39c04e0d8c033d6c065bc154aa1753d7bb22b5a7e91fbddfa28d0d67a"` [INFO] running `"docker" "rm" "-f" "840a7dc39c04e0d8c033d6c065bc154aa1753d7bb22b5a7e91fbddfa28d0d67a"` [INFO] [stdout] 840a7dc39c04e0d8c033d6c065bc154aa1753d7bb22b5a7e91fbddfa28d0d67a