[INFO] crate amethyst_assets 0.6.0 is already in cache
[INFO] extracting crate amethyst_assets 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_assets/0.6.0
[INFO] extracting crate amethyst_assets 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_assets/0.6.0
[INFO] validating manifest of amethyst_assets-0.6.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of amethyst_assets-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing amethyst_assets-0.6.0
[INFO] finished frobbing amethyst_assets-0.6.0
[INFO] frobbed toml for amethyst_assets-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_assets/0.6.0/Cargo.toml
[INFO] started frobbing amethyst_assets-0.6.0
[INFO] finished frobbing amethyst_assets-0.6.0
[INFO] frobbed toml for amethyst_assets-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_assets/0.6.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting amethyst_assets-0.6.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_assets/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f5c2689a8f0963315ad19be388107b43b4f2c539e0182bc1f6608c97fe4b0409
[INFO] running `"docker" "start" "-a" "f5c2689a8f0963315ad19be388107b43b4f2c539e0182bc1f6608c97fe4b0409"`
[INFO] [stderr]    Compiling num-complex v0.2.1
[INFO] [stderr]     Checking mint v0.5.1
[INFO] [stderr]     Checking approx v0.3.1
[INFO] [stderr]     Checking serde v1.0.85
[INFO] [stderr]     Checking hibitset v0.5.4
[INFO] [stderr]     Checking specs v0.14.3
[INFO] [stderr]     Checking specs-hierarchy v0.3.0
[INFO] [stderr]     Checking ron v0.4.1
[INFO] [stderr]     Checking alga v0.7.2
[INFO] [stderr]     Checking nalgebra v0.16.13
[INFO] [stderr]     Checking amethyst_core v0.5.0
[INFO] [stderr]     Checking amethyst_assets v0.6.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused import: `amethyst_core`
[INFO] [stderr]   --> src/lib.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | use amethyst_core;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/prefab/system.rs:75:17
[INFO] [stderr]    |
[INFO] [stderr] 75 | /                 if !d.loading() {
[INFO] [stderr] 76 | |                     if !d
[INFO] [stderr] 77 | |                         .load_sub_assets(&mut prefab_system_data)
[INFO] [stderr] 78 | |                         .chain_err(|| "Failed starting sub asset loading")?
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |                     }
[INFO] [stderr] 82 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 if !d.loading() && !d
[INFO] [stderr] 76 |                         .load_sub_assets(&mut prefab_system_data)
[INFO] [stderr] 77 |                         .chain_err(|| "Failed starting sub asset loading")? {
[INFO] [stderr] 78 |     return Ok(ProcessingState::Loaded(d));
[INFO] [stderr] 79 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/progress.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         rv
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/progress.rs:63:18
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let rv = lock.drain(..).collect();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `amethyst_core`
[INFO] [stderr]   --> src/lib.rs:12:5
[INFO] [stderr]    |
[INFO] [stderr] 12 | use amethyst_core;
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/prefab/system.rs:75:17
[INFO] [stderr]    |
[INFO] [stderr] 75 | /                 if !d.loading() {
[INFO] [stderr] 76 | |                     if !d
[INFO] [stderr] 77 | |                         .load_sub_assets(&mut prefab_system_data)
[INFO] [stderr] 78 | |                         .chain_err(|| "Failed starting sub asset loading")?
[INFO] [stderr] ...  |
[INFO] [stderr] 81 | |                     }
[INFO] [stderr] 82 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 75 |                 if !d.loading() && !d
[INFO] [stderr] 76 |                         .load_sub_assets(&mut prefab_system_data)
[INFO] [stderr] 77 |                         .chain_err(|| "Failed starting sub asset loading")? {
[INFO] [stderr] 78 |     return Ok(ProcessingState::Loaded(d));
[INFO] [stderr] 79 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]   --> src/progress.rs:65:9
[INFO] [stderr]    |
[INFO] [stderr] 65 |         rv
[INFO] [stderr]    |         ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]   --> src/progress.rs:63:18
[INFO] [stderr]    |
[INFO] [stderr] 63 |         let rv = lock.drain(..).collect();
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 131 |   impl_data!(A:0);
[INFO] [stderr]     |   ---------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 132 |   impl_data!(A:0, B:1);
[INFO] [stderr]     |   --------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 133 |   impl_data!(A:0, B:1, C:2);
[INFO] [stderr]     |   -------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 134 |   impl_data!(A:0, B:1, C:2, D:3);
[INFO] [stderr]     |   ------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 135 |   impl_data!(A:0, B:1, C:2, D:3, E:4);
[INFO] [stderr]     |   ------------------------------------ in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 136 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5);
[INFO] [stderr]     |   ----------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 137 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6);
[INFO] [stderr]     |   ---------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 138 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7);
[INFO] [stderr]     |   --------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 139 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8);
[INFO] [stderr]     |   -------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 140 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9);
[INFO] [stderr]     |   ------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 141 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10);
[INFO] [stderr]     |   ------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 142 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11);
[INFO] [stderr]     |   ------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 143 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12);
[INFO] [stderr]     |   ------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 144 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 145 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 146 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 147 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 148 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 149 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17, S:18);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 150 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17, S:18, T:19);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 151 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17, S:18, T:19, U:20);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/prefab/system.rs:46:23
[INFO] [stderr]    |
[INFO] [stderr] 46 |       type SystemData = (
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 47 | |         Entities<'a>,
[INFO] [stderr] 48 | |         Write<'a, AssetStorage<Prefab<T>>>,
[INFO] [stderr] 49 | |         ReadStorage<'a, Handle<Prefab<T>>>,
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |         T::SystemData,
[INFO] [stderr] 56 | |     );
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: item `prefab::Prefab<T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/prefab/mod.rs:176:1
[INFO] [stderr]     |
[INFO] [stderr] 176 | / impl<T> Prefab<T> {
[INFO] [stderr] 177 | |     /// Create new empty prefab
[INFO] [stderr] 178 | |     pub fn new() -> Self {
[INFO] [stderr] 179 | |         Prefab {
[INFO] [stderr] ...   |
[INFO] [stderr] 274 | |     }
[INFO] [stderr] 275 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/progress.rs:196:74
[INFO] [stderr]     |
[INFO] [stderr] 196 | fn show_error(handle_id: u32, asset_type_name: &'static str, asset_name: &String, error: &Error) {
[INFO] [stderr]     |                                                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: calling `as_bytes()` on a string literal
[INFO] [stderr]   --> src/source/dir.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |             "data".as_bytes().to_vec(),
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"data"`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::string_lit_as_bytes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::Processor<A>`
[INFO] [stderr]    --> src/storage.rs:426:5
[INFO] [stderr]     |
[INFO] [stderr] 426 | /     pub fn new() -> Self {
[INFO] [stderr] 427 | |         Processor {
[INFO] [stderr] 428 | |             marker: PhantomData,
[INFO] [stderr] 429 | |         }
[INFO] [stderr] 430 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 419 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/storage.rs:438:23
[INFO] [stderr]     |
[INFO] [stderr] 438 |       type SystemData = (
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 439 | |         Write<'a, AssetStorage<A>>,
[INFO] [stderr] 440 | |         ReadExpect<'a, Arc<ThreadPool>>,
[INFO] [stderr] 441 | |         Read<'a, Time>,
[INFO] [stderr] 442 | |         Option<Read<'a, HotReloadStrategy>>,
[INFO] [stderr] 443 | |     );
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 131 |   impl_data!(A:0);
[INFO] [stderr]     |   ---------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 132 |   impl_data!(A:0, B:1);
[INFO] [stderr]     |   --------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 133 |   impl_data!(A:0, B:1, C:2);
[INFO] [stderr]     |   -------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 134 |   impl_data!(A:0, B:1, C:2, D:3);
[INFO] [stderr]     |   ------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 135 |   impl_data!(A:0, B:1, C:2, D:3, E:4);
[INFO] [stderr]     |   ------------------------------------ in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 136 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5);
[INFO] [stderr]     |   ----------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 137 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6);
[INFO] [stderr]     |   ---------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 138 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7);
[INFO] [stderr]     |   --------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 139 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8);
[INFO] [stderr]     |   -------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 140 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9);
[INFO] [stderr]     |   ------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 141 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10);
[INFO] [stderr]     |   ------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 142 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11);
[INFO] [stderr]     |   ------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 143 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12);
[INFO] [stderr]     |   ------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 144 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 145 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 146 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 147 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 148 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 149 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17, S:18);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 150 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17, S:18, T:19);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/prefab/impls.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 | /                 let mut ret = false;
[INFO] [stderr] 119 | |                 $(
[INFO] [stderr] 120 | |                     if self.$i.load_sub_assets(progress, &mut system_data.$i)? {
[INFO] [stderr] 121 | |                         ret = true;
[INFO] [stderr] 122 | |                     }
[INFO] [stderr]     | |_____________________^ help: it is more idiomatic to write: `let <mut> ret = if self.$i.load_sub_assets(progress, &mut system_data.$i)? { true } else { false };`
[INFO] [stderr] ...
[INFO] [stderr] 151 |   impl_data!(A:0, B:1, C:2, D:3, E:4, F:5, G:6, H:7, I:8, J:9, K:10, L:11, M:12, N:13, O:14, P:15, Q:16, R:17, S:18, T:19, U:20);
[INFO] [stderr]     |   ------------------------------------------------------------------------------------------------------------------------------- in this macro invocation
[INFO] [stderr]     |
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/prefab/system.rs:46:23
[INFO] [stderr]    |
[INFO] [stderr] 46 |       type SystemData = (
[INFO] [stderr]    |  _______________________^
[INFO] [stderr] 47 | |         Entities<'a>,
[INFO] [stderr] 48 | |         Write<'a, AssetStorage<Prefab<T>>>,
[INFO] [stderr] 49 | |         ReadStorage<'a, Handle<Prefab<T>>>,
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |         T::SystemData,
[INFO] [stderr] 56 | |     );
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: item `prefab::Prefab<T>` has a public `len` method but no corresponding `is_empty` method
[INFO] [stderr]    --> src/prefab/mod.rs:176:1
[INFO] [stderr]     |
[INFO] [stderr] 176 | / impl<T> Prefab<T> {
[INFO] [stderr] 177 | |     /// Create new empty prefab
[INFO] [stderr] 178 | |     pub fn new() -> Self {
[INFO] [stderr] 179 | |         Prefab {
[INFO] [stderr] ...   |
[INFO] [stderr] 274 | |     }
[INFO] [stderr] 275 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_without_is_empty)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]    --> src/progress.rs:196:74
[INFO] [stderr]     |
[INFO] [stderr] 196 | fn show_error(handle_id: u32, asset_type_name: &'static str, asset_name: &String, error: &Error) {
[INFO] [stderr]     |                                                                          ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `storage::Processor<A>`
[INFO] [stderr]    --> src/storage.rs:426:5
[INFO] [stderr]     |
[INFO] [stderr] 426 | /     pub fn new() -> Self {
[INFO] [stderr] 427 | |         Processor {
[INFO] [stderr] 428 | |             marker: PhantomData,
[INFO] [stderr] 429 | |         }
[INFO] [stderr] 430 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 419 | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]    --> src/storage.rs:438:23
[INFO] [stderr]     |
[INFO] [stderr] 438 |       type SystemData = (
[INFO] [stderr]     |  _______________________^
[INFO] [stderr] 439 | |         Write<'a, AssetStorage<A>>,
[INFO] [stderr] 440 | |         ReadExpect<'a, Arc<ThreadPool>>,
[INFO] [stderr] 441 | |         Read<'a, Time>,
[INFO] [stderr] 442 | |         Option<Read<'a, HotReloadStrategy>>,
[INFO] [stderr] 443 | |     );
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 39s
[INFO] running `"docker" "inspect" "f5c2689a8f0963315ad19be388107b43b4f2c539e0182bc1f6608c97fe4b0409"`
[INFO] running `"docker" "rm" "-f" "f5c2689a8f0963315ad19be388107b43b4f2c539e0182bc1f6608c97fe4b0409"`
[INFO] [stdout] f5c2689a8f0963315ad19be388107b43b4f2c539e0182bc1f6608c97fe4b0409