[INFO] crate amethyst_animation 0.5.0 is already in cache [INFO] extracting crate amethyst_animation 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/amethyst_animation/0.5.0 [INFO] extracting crate amethyst_animation 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_animation/0.5.0 [INFO] validating manifest of amethyst_animation-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of amethyst_animation-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing amethyst_animation-0.5.0 [INFO] finished frobbing amethyst_animation-0.5.0 [INFO] frobbed toml for amethyst_animation-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/amethyst_animation/0.5.0/Cargo.toml [INFO] started frobbing amethyst_animation-0.5.0 [INFO] finished frobbing amethyst_animation-0.5.0 [INFO] frobbed toml for amethyst_animation-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/amethyst_animation/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting amethyst_animation-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/amethyst_animation/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 057a22eb334e0249eb3b99b3960643daa1e05911686343ebbbec8e66e0386f54 [INFO] running `"docker" "start" "-a" "057a22eb334e0249eb3b99b3960643daa1e05911686343ebbbec8e66e0386f54"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Compiling glsl-layout-derive v0.1.1 [INFO] [stderr] Checking rusttype v0.7.3 [INFO] [stderr] Compiling amethyst_derive v0.3.0 [INFO] [stderr] Checking genmesh v0.6.2 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking smallvec v0.6.8 [INFO] [stderr] Checking draw_state v0.8.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking ron v0.4.1 [INFO] [stderr] Checking andrew v0.1.6 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.4.0 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking smithay-client-toolkit v0.4.4 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking gfx_core v0.8.3 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking minterpolate v0.4.0 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking winit v0.18.1 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking specs v0.14.3 [INFO] [stderr] Checking glutin v0.19.0 [INFO] [stderr] Checking specs-hierarchy v0.3.0 [INFO] [stderr] Checking gfx_device_gl v0.15.5 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking glsl-layout v0.1.1 [INFO] [stderr] Checking gfx_window_glutin v0.27.0 [INFO] [stderr] Checking amethyst_core v0.5.0 [INFO] [stderr] Checking amethyst_assets v0.6.0 [INFO] [stderr] Checking amethyst_renderer v0.10.4 [INFO] [stderr] Checking amethyst_animation v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/prefab.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 86 | | ReadExpect<'a, Loader>, [INFO] [stderr] 87 | | Read<'a, AssetStorage>>, [INFO] [stderr] 88 | | Read<'a, AssetStorage>>, [INFO] [stderr] 89 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/prefab.rs:236:57 [INFO] [stderr] | [INFO] [stderr] 236 | #[derive(Default, Clone, Debug, Deserialize, Serialize, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/resources.rs:234:16 [INFO] [stderr] | [INFO] [stderr] 234 | pub nodes: Vec<(usize, T::Channel, Handle>)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `resources::Animation` [INFO] [stderr] --> src/resources.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / pub fn new() -> Self { [INFO] [stderr] 243 | | Animation { nodes: vec![] } [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 229 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/resources.rs:835:5 [INFO] [stderr] | [INFO] [stderr] 835 | / pub fn add_deferred_animation( [INFO] [stderr] 836 | | &mut self, [INFO] [stderr] 837 | | id: I, [INFO] [stderr] 838 | | animation: &Handle>, [INFO] [stderr] ... | [INFO] [stderr] 858 | | }); [INFO] [stderr] 859 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/skinning/resources.rs:129:57 [INFO] [stderr] | [INFO] [stderr] 129 | #[derive(Clone, Default, Debug, Serialize, Deserialize, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `skinning::systems::VertexSkinningSystem` [INFO] [stderr] --> src/skinning/systems.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Self { [INFO] [stderr] 25 | | Self { [INFO] [stderr] 26 | | updated: BitSet::new(), [INFO] [stderr] 27 | | updated_skins: BitSet::new(), [INFO] [stderr] 28 | | updated_id: None, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems/control.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 66 | | Entities<'a>, [INFO] [stderr] 67 | | Read<'a, AssetStorage>>, [INFO] [stderr] 68 | | Read<'a, AssetStorage>>, [INFO] [stderr] ... | [INFO] [stderr] 74 | | >::ApplyData, [INFO] [stderr] 75 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/systems/control.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | entity: &Entity, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/systems/control.rs:280:1 [INFO] [stderr] | [INFO] [stderr] 280 | / fn process_animation_control( [INFO] [stderr] 281 | | entity: &Entity, [INFO] [stderr] 282 | | animation: &Animation, [INFO] [stderr] 283 | | control: &mut AnimationControl, [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/systems/control.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | entity: &Entity, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/systems/control.rs:435:1 [INFO] [stderr] | [INFO] [stderr] 435 | / fn start_animation( [INFO] [stderr] 436 | | animation: &Animation, [INFO] [stderr] 437 | | sampler_storage: &AssetStorage>, [INFO] [stderr] 438 | | control: &AnimationControl, [INFO] [stderr] ... | [INFO] [stderr] 507 | | true [INFO] [stderr] 508 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/systems/control.rs:452:57 [INFO] [stderr] | [INFO] [stderr] 452 | .any(|&(ref node_index, _, ref sampler_handle)| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 453 | | !hierarchy.nodes.contains_key(node_index) [INFO] [stderr] 454 | | || sampler_storage.get(sampler_handle).is_none() [INFO] [stderr] 455 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/systems/control.rs:573:14 [INFO] [stderr] | [INFO] [stderr] 573 | weights: &Vec<(usize, T::Channel, f32)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, T::Channel, f32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems/sampling.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 58 | | Read<'a, Time>, [INFO] [stderr] 59 | | Read<'a, AssetStorage>>, [INFO] [stderr] 60 | | WriteStorage<'a, SamplerControlSet>, [INFO] [stderr] 61 | | WriteStorage<'a, T>, [INFO] [stderr] 62 | | >::ApplyData, [INFO] [stderr] 63 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/systems/sampling.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | output: &Vec<(f32, T::Channel, T::Primitive)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(f32, T::Channel, T::Primitive)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/prefab.rs:85:23 [INFO] [stderr] | [INFO] [stderr] 85 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 86 | | ReadExpect<'a, Loader>, [INFO] [stderr] 87 | | Read<'a, AssetStorage>>, [INFO] [stderr] 88 | | Read<'a, AssetStorage>>, [INFO] [stderr] 89 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/prefab.rs:236:57 [INFO] [stderr] | [INFO] [stderr] 236 | #[derive(Default, Clone, Debug, Deserialize, Serialize, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/resources.rs:234:16 [INFO] [stderr] | [INFO] [stderr] 234 | pub nodes: Vec<(usize, T::Channel, Handle>)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `resources::Animation` [INFO] [stderr] --> src/resources.rs:242:5 [INFO] [stderr] | [INFO] [stderr] 242 | / pub fn new() -> Self { [INFO] [stderr] 243 | | Animation { nodes: vec![] } [INFO] [stderr] 244 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 229 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/resources.rs:835:5 [INFO] [stderr] | [INFO] [stderr] 835 | / pub fn add_deferred_animation( [INFO] [stderr] 836 | | &mut self, [INFO] [stderr] 837 | | id: I, [INFO] [stderr] 838 | | animation: &Handle>, [INFO] [stderr] ... | [INFO] [stderr] 858 | | }); [INFO] [stderr] 859 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/skinning/resources.rs:129:57 [INFO] [stderr] | [INFO] [stderr] 129 | #[derive(Clone, Default, Debug, Serialize, Deserialize, PrefabData)] [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `skinning::systems::VertexSkinningSystem` [INFO] [stderr] --> src/skinning/systems.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | / pub fn new() -> Self { [INFO] [stderr] 25 | | Self { [INFO] [stderr] 26 | | updated: BitSet::new(), [INFO] [stderr] 27 | | updated_skins: BitSet::new(), [INFO] [stderr] 28 | | updated_id: None, [INFO] [stderr] 29 | | } [INFO] [stderr] 30 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems/control.rs:65:23 [INFO] [stderr] | [INFO] [stderr] 65 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 66 | | Entities<'a>, [INFO] [stderr] 67 | | Read<'a, AssetStorage>>, [INFO] [stderr] 68 | | Read<'a, AssetStorage>>, [INFO] [stderr] ... | [INFO] [stderr] 74 | | >::ApplyData, [INFO] [stderr] 75 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/systems/control.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | entity: &Entity, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/systems/control.rs:280:1 [INFO] [stderr] | [INFO] [stderr] 280 | / fn process_animation_control( [INFO] [stderr] 281 | | entity: &Entity, [INFO] [stderr] 282 | | animation: &Animation, [INFO] [stderr] 283 | | control: &mut AnimationControl, [INFO] [stderr] ... | [INFO] [stderr] 416 | | } [INFO] [stderr] 417 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/systems/control.rs:281:13 [INFO] [stderr] | [INFO] [stderr] 281 | entity: &Entity, [INFO] [stderr] | ^^^^^^^ help: consider passing by value instead: `Entity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/systems/control.rs:435:1 [INFO] [stderr] | [INFO] [stderr] 435 | / fn start_animation( [INFO] [stderr] 436 | | animation: &Animation, [INFO] [stderr] 437 | | sampler_storage: &AssetStorage>, [INFO] [stderr] 438 | | control: &AnimationControl, [INFO] [stderr] ... | [INFO] [stderr] 507 | | true [INFO] [stderr] 508 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/systems/control.rs:452:57 [INFO] [stderr] | [INFO] [stderr] 452 | .any(|&(ref node_index, _, ref sampler_handle)| { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 453 | | !hierarchy.nodes.contains_key(node_index) [INFO] [stderr] 454 | | || sampler_storage.get(sampler_handle).is_none() [INFO] [stderr] 455 | | }) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/systems/control.rs:573:14 [INFO] [stderr] | [INFO] [stderr] 573 | weights: &Vec<(usize, T::Channel, f32)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, T::Channel, f32)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/systems/sampling.rs:57:23 [INFO] [stderr] | [INFO] [stderr] 57 | type SystemData = ( [INFO] [stderr] | _______________________^ [INFO] [stderr] 58 | | Read<'a, Time>, [INFO] [stderr] 59 | | Read<'a, AssetStorage>>, [INFO] [stderr] 60 | | WriteStorage<'a, SamplerControlSet>, [INFO] [stderr] 61 | | WriteStorage<'a, T>, [INFO] [stderr] 62 | | >::ApplyData, [INFO] [stderr] 63 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/systems/sampling.rs:260:13 [INFO] [stderr] | [INFO] [stderr] 260 | output: &Vec<(f32, T::Channel, T::Primitive)>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(f32, T::Channel, T::Primitive)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3m 11s [INFO] running `"docker" "inspect" "057a22eb334e0249eb3b99b3960643daa1e05911686343ebbbec8e66e0386f54"` [INFO] running `"docker" "rm" "-f" "057a22eb334e0249eb3b99b3960643daa1e05911686343ebbbec8e66e0386f54"` [INFO] [stdout] 057a22eb334e0249eb3b99b3960643daa1e05911686343ebbbec8e66e0386f54