[INFO] crate alphanumeric-sort 1.0.6 is already in cache [INFO] extracting crate alphanumeric-sort 1.0.6 into work/ex/clippy-test-run/sources/stable/reg/alphanumeric-sort/1.0.6 [INFO] extracting crate alphanumeric-sort 1.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alphanumeric-sort/1.0.6 [INFO] validating manifest of alphanumeric-sort-1.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alphanumeric-sort-1.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alphanumeric-sort-1.0.6 [INFO] finished frobbing alphanumeric-sort-1.0.6 [INFO] frobbed toml for alphanumeric-sort-1.0.6 written to work/ex/clippy-test-run/sources/stable/reg/alphanumeric-sort/1.0.6/Cargo.toml [INFO] started frobbing alphanumeric-sort-1.0.6 [INFO] finished frobbing alphanumeric-sort-1.0.6 [INFO] frobbed toml for alphanumeric-sort-1.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alphanumeric-sort/1.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alphanumeric-sort-1.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/alphanumeric-sort/1.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e983c20209910386da19f710c3c06c54da3a0007af1a8c3d6f93d035dcc9822 [INFO] running `"docker" "start" "-a" "9e983c20209910386da19f710c3c06c54da3a0007af1a8c3d6f93d035dcc9822"` [INFO] [stderr] Checking alphanumeric-sort v1.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 142 | | if ca != cb { [INFO] [stderr] 143 | | if (ca > (255 as char)) ^ (cb > (255 as char)) { [INFO] [stderr] 144 | | return ordering!(cb, ca); [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 141 | } else if ca != cb { [INFO] [stderr] 142 | if (ca > (255 as char)) ^ (cb > (255 as char)) { [INFO] [stderr] 143 | return ordering!(cb, ca); [INFO] [stderr] 144 | } else { [INFO] [stderr] 145 | return ordering!(ca, cb); [INFO] [stderr] 146 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | let mut da = ca as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(ca as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:45 [INFO] [stderr] | [INFO] [stderr] 107 | let mut da = ca as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | let mut db = cb as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(cb as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:108:45 [INFO] [stderr] | [INFO] [stderr] 108 | let mut db = cb as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / loop { [INFO] [stderr] 111 | | let ca = match c1.next() { [INFO] [stderr] 112 | | Some(c) => c, [INFO] [stderr] 113 | | None => { break; } [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(c) = c1.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:117:39 [INFO] [stderr] | [INFO] [stderr] 117 | da = da * 10.0 + (ca as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(ca as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:117:58 [INFO] [stderr] | [INFO] [stderr] 117 | da = da * 10.0 + (ca as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | / loop { [INFO] [stderr] 126 | | let cb = match c2.next() { [INFO] [stderr] 127 | | Some(c) => c, [INFO] [stderr] 128 | | None => { break; } [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(c) = c2.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:39 [INFO] [stderr] | [INFO] [stderr] 132 | db = db * 10.0 + (cb as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(cb as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:58 [INFO] [stderr] | [INFO] [stderr] 132 | db = db * 10.0 + (cb as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:141:16 [INFO] [stderr] | [INFO] [stderr] 141 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 142 | | if ca != cb { [INFO] [stderr] 143 | | if (ca > (255 as char)) ^ (cb > (255 as char)) { [INFO] [stderr] 144 | | return ordering!(cb, ca); [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 141 | } else if ca != cb { [INFO] [stderr] 142 | if (ca > (255 as char)) ^ (cb > (255 as char)) { [INFO] [stderr] 143 | return ordering!(cb, ca); [INFO] [stderr] 144 | } else { [INFO] [stderr] 145 | return ordering!(ca, cb); [INFO] [stderr] 146 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:26 [INFO] [stderr] | [INFO] [stderr] 107 | let mut da = ca as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(ca as u32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:107:45 [INFO] [stderr] | [INFO] [stderr] 107 | let mut da = ca as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:108:26 [INFO] [stderr] | [INFO] [stderr] 108 | let mut db = cb as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(cb as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:108:45 [INFO] [stderr] | [INFO] [stderr] 108 | let mut db = cb as u32 as f64 - b'0' as f64; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | / loop { [INFO] [stderr] 111 | | let ca = match c1.next() { [INFO] [stderr] 112 | | Some(c) => c, [INFO] [stderr] 113 | | None => { break; } [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(c) = c1.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:117:39 [INFO] [stderr] | [INFO] [stderr] 117 | da = da * 10.0 + (ca as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(ca as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:117:58 [INFO] [stderr] | [INFO] [stderr] 117 | da = da * 10.0 + (ca as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | / loop { [INFO] [stderr] 126 | | let cb = match c2.next() { [INFO] [stderr] 127 | | Some(c) => c, [INFO] [stderr] 128 | | None => { break; } [INFO] [stderr] ... | [INFO] [stderr] 137 | | } [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____________^ help: try: `while let Some(c) = c2.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:39 [INFO] [stderr] | [INFO] [stderr] 132 | db = db * 10.0 + (cb as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(cb as u32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:132:58 [INFO] [stderr] | [INFO] [stderr] 132 | db = db * 10.0 + (cb as u32 as f64 - b'0' as f64); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `f64::from(b'0')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.90s [INFO] running `"docker" "inspect" "9e983c20209910386da19f710c3c06c54da3a0007af1a8c3d6f93d035dcc9822"` [INFO] running `"docker" "rm" "-f" "9e983c20209910386da19f710c3c06c54da3a0007af1a8c3d6f93d035dcc9822"` [INFO] [stdout] 9e983c20209910386da19f710c3c06c54da3a0007af1a8c3d6f93d035dcc9822