[INFO] crate allocator_api 0.5.0 is already in cache [INFO] extracting crate allocator_api 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/allocator_api/0.5.0 [INFO] extracting crate allocator_api 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/allocator_api/0.5.0 [INFO] validating manifest of allocator_api-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of allocator_api-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing allocator_api-0.5.0 [INFO] finished frobbing allocator_api-0.5.0 [INFO] frobbed toml for allocator_api-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/allocator_api/0.5.0/Cargo.toml [INFO] started frobbing allocator_api-0.5.0 [INFO] finished frobbing allocator_api-0.5.0 [INFO] frobbed toml for allocator_api-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/allocator_api/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting allocator_api-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/allocator_api/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 705517f64cadcf7579f7a0cab950cd97522329b31593afbb050a3ff9b4ddd872 [INFO] running `"docker" "start" "-a" "705517f64cadcf7579f7a0cab950cd97522329b31593afbb050a3ff9b4ddd872"` [INFO] [stderr] Compiling allocator_api v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/liballoc/boxed.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/liballoc/boxed.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/liballoc/boxed.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/liballoc/boxed.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | ptr: ptr, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/liballoc/boxed.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/liballoc/boxed.rs:165:13 [INFO] [stderr] | [INFO] [stderr] 165 | a: a, [INFO] [stderr] | ^^^^ help: replace it with: `a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return len_rounded_up.wrapping_sub(len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `len_rounded_up.wrapping_sub(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:774:13 [INFO] [stderr] | [INFO] [stderr] 774 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:776:13 [INFO] [stderr] | [INFO] [stderr] 776 | return Err(CannotReallocInPlace); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CannotReallocInPlace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:829:13 [INFO] [stderr] | [INFO] [stderr] 829 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:831:13 [INFO] [stderr] | [INFO] [stderr] 831 | return Err(CannotReallocInPlace); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CannotReallocInPlace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | return len_rounded_up.wrapping_sub(len); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `len_rounded_up.wrapping_sub(len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:774:13 [INFO] [stderr] | [INFO] [stderr] 774 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:776:13 [INFO] [stderr] | [INFO] [stderr] 776 | return Err(CannotReallocInPlace); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CannotReallocInPlace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:829:13 [INFO] [stderr] | [INFO] [stderr] 829 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/libcore/alloc.rs:831:13 [INFO] [stderr] | [INFO] [stderr] 831 | return Err(CannotReallocInPlace); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(CannotReallocInPlace)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libcore/alloc.rs:628:53 [INFO] [stderr] | [INFO] [stderr] 628 | if let Ok(()) = self.grow_in_place(ptr, layout.clone(), new_size) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libcore/alloc.rs:632:55 [INFO] [stderr] | [INFO] [stderr] 632 | if let Ok(()) = self.shrink_in_place(ptr, layout.clone(), new_size) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/libcore/alloc.rs:1026:20 [INFO] [stderr] | [INFO] [stderr] 1026 | Ok(self.dealloc(ptr.cast(), k.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1026 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/libstd/alloc.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/liballoc/boxed.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn into_raw(b: Box) -> *mut T { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/liballoc/boxed.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | / fn ne(&self, other: &Box) -> bool { [INFO] [stderr] 367 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 368 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/liballoc/boxed.rs:568:36 [INFO] [stderr] | [INFO] [stderr] 568 | let max = unsafe { data.offset(self.len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(self.len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:120:22 [INFO] [stderr] | [INFO] [stderr] 120 | ptr: ptr.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `raw_vec::RawVec` [INFO] [stderr] --> src/liballoc/raw_vec.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new() -> Self { [INFO] [stderr] 137 | | Self::new_in(Default::default()) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | impl Default for raw_vec::RawVec { [INFO] [stderr] 131 | fn default() -> Self { [INFO] [stderr] 132 | Self::new() [INFO] [stderr] 133 | } [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:331:50 [INFO] [stderr] | [INFO] [stderr] 331 | let ptr_res = self.a.realloc(NonNull::from(self.ptr).cast(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:335:46 [INFO] [stderr] | [INFO] [stderr] 335 | Ok(ptr) => (new_cap, ptr.cast().into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ptr.cast()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:346:46 [INFO] [stderr] | [INFO] [stderr] 346 | Ok(ptr) => (new_cap, ptr.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:392:40 [INFO] [stderr] | [INFO] [stderr] 392 | match self.a.grow_in_place(NonNull::from(self.ptr).cast(), old_layout, new_size) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:567:17 [INFO] [stderr] | [INFO] [stderr] 567 | NonNull::from(self.ptr).cast(), old_layout, new_layout.size(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:628:38 [INFO] [stderr] | [INFO] [stderr] 628 | match self.a.realloc(NonNull::from(self.ptr).cast(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:631:41 [INFO] [stderr] | [INFO] [stderr] 631 | Ok(p) => self.ptr = p.cast().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `p.cast()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:690:36 [INFO] [stderr] | [INFO] [stderr] 690 | self.a.realloc(NonNull::from(self.ptr).cast(), layout, new_layout.size()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/liballoc/raw_vec.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | / match (&res, fallibility) { [INFO] [stderr] 696 | | (Err(AllocErr), Infallible) => handle_alloc_error(new_layout), [INFO] [stderr] 697 | | _ => {} [INFO] [stderr] 698 | | } [INFO] [stderr] | |_____________^ help: try this: `if let (Err(AllocErr), Infallible) = (&res, fallibility) { handle_alloc_error(new_layout) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:700:24 [INFO] [stderr] | [INFO] [stderr] 700 | self.ptr = res?.cast().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `res?.cast()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:734:32 [INFO] [stderr] | [INFO] [stderr] 734 | self.a.dealloc(NonNull::from(self.ptr).cast(), layout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libcore/alloc.rs:628:53 [INFO] [stderr] | [INFO] [stderr] 628 | if let Ok(()) = self.grow_in_place(ptr, layout.clone(), new_size) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `layout` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/libcore/alloc.rs:632:55 [INFO] [stderr] | [INFO] [stderr] 632 | if let Ok(()) = self.shrink_in_place(ptr, layout.clone(), new_size) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try removing the `clone` call: `layout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/libcore/alloc.rs:1026:20 [INFO] [stderr] | [INFO] [stderr] 1026 | Ok(self.dealloc(ptr.cast(), k.clone())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 1026 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: empty `loop {}` detected. You may want to either use `panic!()` or add `std::thread::sleep(..);` to the loop body. [INFO] [stderr] --> src/libstd/alloc.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | loop {} [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::empty_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/liballoc/boxed.rs:198:21 [INFO] [stderr] | [INFO] [stderr] 198 | pub fn into_raw(b: Box) -> *mut T { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: re-implementing `PartialEq::ne` is unnecessary [INFO] [stderr] --> src/liballoc/boxed.rs:366:5 [INFO] [stderr] | [INFO] [stderr] 366 | / fn ne(&self, other: &Box) -> bool { [INFO] [stderr] 367 | | PartialEq::ne(&**self, &**other) [INFO] [stderr] 368 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::partialeq_ne_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_ne_impl [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/liballoc/boxed.rs:568:36 [INFO] [stderr] | [INFO] [stderr] 568 | let max = unsafe { data.offset(self.len as isize) }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data.add(self.len)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:120:22 [INFO] [stderr] | [INFO] [stderr] 120 | ptr: ptr.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `raw_vec::RawVec` [INFO] [stderr] --> src/liballoc/raw_vec.rs:136:5 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new() -> Self { [INFO] [stderr] 137 | | Self::new_in(Default::default()) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | impl Default for raw_vec::RawVec { [INFO] [stderr] 131 | fn default() -> Self { [INFO] [stderr] 132 | Self::new() [INFO] [stderr] 133 | } [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:331:50 [INFO] [stderr] | [INFO] [stderr] 331 | let ptr_res = self.a.realloc(NonNull::from(self.ptr).cast(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:335:46 [INFO] [stderr] | [INFO] [stderr] 335 | Ok(ptr) => (new_cap, ptr.cast().into()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `ptr.cast()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:346:46 [INFO] [stderr] | [INFO] [stderr] 346 | Ok(ptr) => (new_cap, ptr.into()), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:392:40 [INFO] [stderr] | [INFO] [stderr] 392 | match self.a.grow_in_place(NonNull::from(self.ptr).cast(), old_layout, new_size) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:567:17 [INFO] [stderr] | [INFO] [stderr] 567 | NonNull::from(self.ptr).cast(), old_layout, new_layout.size(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:628:38 [INFO] [stderr] | [INFO] [stderr] 628 | match self.a.realloc(NonNull::from(self.ptr).cast(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:631:41 [INFO] [stderr] | [INFO] [stderr] 631 | Ok(p) => self.ptr = p.cast().into(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider removing `.into()`: `p.cast()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:690:36 [INFO] [stderr] | [INFO] [stderr] 690 | self.a.realloc(NonNull::from(self.ptr).cast(), layout, new_layout.size()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/liballoc/raw_vec.rs:695:13 [INFO] [stderr] | [INFO] [stderr] 695 | / match (&res, fallibility) { [INFO] [stderr] 696 | | (Err(AllocErr), Infallible) => handle_alloc_error(new_layout), [INFO] [stderr] 697 | | _ => {} [INFO] [stderr] 698 | | } [INFO] [stderr] | |_____________^ help: try this: `if let (Err(AllocErr), Infallible) = (&res, fallibility) { handle_alloc_error(new_layout) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:700:24 [INFO] [stderr] | [INFO] [stderr] 700 | self.ptr = res?.cast().into(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `res?.cast()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/liballoc/raw_vec.rs:734:32 [INFO] [stderr] | [INFO] [stderr] 734 | self.a.dealloc(NonNull::from(self.ptr).cast(), layout); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `NonNull::from()`: `self.ptr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.15s [INFO] running `"docker" "inspect" "705517f64cadcf7579f7a0cab950cd97522329b31593afbb050a3ff9b4ddd872"` [INFO] running `"docker" "rm" "-f" "705517f64cadcf7579f7a0cab950cd97522329b31593afbb050a3ff9b4ddd872"` [INFO] [stdout] 705517f64cadcf7579f7a0cab950cd97522329b31593afbb050a3ff9b4ddd872