[INFO] crate alloc-stdlib 0.2.1 is already in cache [INFO] extracting crate alloc-stdlib 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/alloc-stdlib/0.2.1 [INFO] extracting crate alloc-stdlib 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alloc-stdlib/0.2.1 [INFO] validating manifest of alloc-stdlib-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alloc-stdlib-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alloc-stdlib-0.2.1 [INFO] finished frobbing alloc-stdlib-0.2.1 [INFO] frobbed toml for alloc-stdlib-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/alloc-stdlib/0.2.1/Cargo.toml [INFO] started frobbing alloc-stdlib-0.2.1 [INFO] finished frobbing alloc-stdlib-0.2.1 [INFO] frobbed toml for alloc-stdlib-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alloc-stdlib/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alloc-stdlib-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/alloc-stdlib/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3e57d9ae8958e58625c40f76a87f055ae705d8839ee0784c4906fe30d326aae7 [INFO] running `"docker" "start" "-a" "3e57d9ae8958e58625c40f76a87f055ae705d8839ee0784c4906fe30d326aae7"` [INFO] [stderr] Checking alloc-stdlib v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | return WrapBox::(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WrapBox::(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | return &*self.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `&*self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:40:8 [INFO] [stderr] | [INFO] [stderr] 40 | return &mut*self.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut*self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | return HeapAlloc::{default_value : data}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HeapAlloc::{default_value : data}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:92:8 [INFO] [stderr] | [INFO] [stderr] 92 | return WrapBox::(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WrapBox::(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return retval.into_boxed_slice(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `retval.into_boxed_slice()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | return retval; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/heap_alloc.rs:142:36 [INFO] [stderr] | [INFO] [stderr] 142 | memory_pool : &'a mut Box<[T]>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&'a mut [T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:28:8 [INFO] [stderr] | [INFO] [stderr] 28 | return WrapBox::(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WrapBox::(b)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:34:8 [INFO] [stderr] | [INFO] [stderr] 34 | return &*self.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `&*self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:40:8 [INFO] [stderr] | [INFO] [stderr] 40 | return &mut*self.0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&mut*self.0` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:82:7 [INFO] [stderr] | [INFO] [stderr] 82 | return HeapAlloc::{default_value : data}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `HeapAlloc::{default_value : data}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:92:8 [INFO] [stderr] | [INFO] [stderr] 92 | return WrapBox::(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `WrapBox::(b)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return retval.into_boxed_slice(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `retval.into_boxed_slice()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/heap_alloc.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | return retval; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `retval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/heap_alloc.rs:142:36 [INFO] [stderr] | [INFO] [stderr] 142 | memory_pool : &'a mut Box<[T]>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `&'a mut [T]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/example.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | let mut x = halloc.alloc_cell(100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/example.rs:113:37 [INFO] [stderr] | [INFO] [stderr] 113 | let mut y = halloc.alloc_cell(110000); [INFO] [stderr] | ^^^^^^ help: consider: `110_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/example.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | let mut z = halloc.alloc_cell(120000); [INFO] [stderr] | ^^^^^^ help: consider: `120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/tests.rs:12:37 [INFO] [stderr] | [INFO] [stderr] 12 | let mut x = halloc.alloc_cell(100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/tests.rs:14:37 [INFO] [stderr] | [INFO] [stderr] 14 | let mut y = halloc.alloc_cell(110000); [INFO] [stderr] | ^^^^^^ help: consider: `110_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/tests.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | let mut z = halloc.alloc_cell(120000); [INFO] [stderr] | ^^^^^^ help: consider: `120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/tests.rs:31:77 [INFO] [stderr] | [INFO] [stderr] 31 | let mut x = >::alloc_cell(&mut halloc, 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/tests.rs:33:77 [INFO] [stderr] | [INFO] [stderr] 33 | let mut y = >::alloc_cell(&mut halloc, 110000); [INFO] [stderr] | ^^^^^^ help: consider: `110_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/tests.rs:35:77 [INFO] [stderr] | [INFO] [stderr] 35 | let mut z = >::alloc_cell(&mut halloc, 120000); [INFO] [stderr] | ^^^^^^ help: consider: `120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/example.rs:111:37 [INFO] [stderr] | [INFO] [stderr] 111 | let mut x = halloc.alloc_cell(100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/example.rs:113:37 [INFO] [stderr] | [INFO] [stderr] 113 | let mut y = halloc.alloc_cell(110000); [INFO] [stderr] | ^^^^^^ help: consider: `110_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bin/example.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | let mut z = halloc.alloc_cell(120000); [INFO] [stderr] | ^^^^^^ help: consider: `120_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 25.64s [INFO] running `"docker" "inspect" "3e57d9ae8958e58625c40f76a87f055ae705d8839ee0784c4906fe30d326aae7"` [INFO] running `"docker" "rm" "-f" "3e57d9ae8958e58625c40f76a87f055ae705d8839ee0784c4906fe30d326aae7"` [INFO] [stdout] 3e57d9ae8958e58625c40f76a87f055ae705d8839ee0784c4906fe30d326aae7