[INFO] crate allenap-tftp-offload 0.2.1 is already in cache
[INFO] extracting crate allenap-tftp-offload 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/allenap-tftp-offload/0.2.1
[INFO] extracting crate allenap-tftp-offload 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/allenap-tftp-offload/0.2.1
[INFO] validating manifest of allenap-tftp-offload-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of allenap-tftp-offload-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing allenap-tftp-offload-0.2.1
[INFO] finished frobbing allenap-tftp-offload-0.2.1
[INFO] frobbed toml for allenap-tftp-offload-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/allenap-tftp-offload/0.2.1/Cargo.toml
[INFO] started frobbing allenap-tftp-offload-0.2.1
[INFO] finished frobbing allenap-tftp-offload-0.2.1
[INFO] frobbed toml for allenap-tftp-offload-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/allenap-tftp-offload/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting allenap-tftp-offload-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/allenap-tftp-offload/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 50880bec0d7f4bfa5be9b0eddac4570e98476ef7f20c0b59411177e3a24b076c
[INFO] running `"docker" "start" "-a" "50880bec0d7f4bfa5be9b0eddac4570e98476ef7f20c0b59411177e3a24b076c"`
[INFO] [stderr]     Checking allenap-libtftp v0.2.1
[INFO] [stderr]     Checking allenap-tftp-offload v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/offload.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 | /         return Ok(OffloadFile{
[INFO] [stderr] 92 | |             filename: filename.to_owned(),
[INFO] [stderr] 93 | |             ephemeral: eph == "EPH",
[INFO] [stderr] 94 | |         });
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 91 |         Ok(OffloadFile{
[INFO] [stderr] 92 |             filename: filename.to_owned(),
[INFO] [stderr] 93 |             ephemeral: eph == "EPH",
[INFO] [stderr] 94 |         })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/offload.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |         return Err(error);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/offload.rs:91:9
[INFO] [stderr]    |
[INFO] [stderr] 91 | /         return Ok(OffloadFile{
[INFO] [stderr] 92 | |             filename: filename.to_owned(),
[INFO] [stderr] 93 | |             ephemeral: eph == "EPH",
[INFO] [stderr] 94 | |         });
[INFO] [stderr]    | |___________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 91 |         Ok(OffloadFile{
[INFO] [stderr] 92 |             filename: filename.to_owned(),
[INFO] [stderr] 93 |             ephemeral: eph == "EPH",
[INFO] [stderr] 94 |         })
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/offload.rs:102:9
[INFO] [stderr]     |
[INFO] [stderr] 102 |         return Err(error);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(error)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/offload.rs:76:36
[INFO] [stderr]    |
[INFO] [stderr] 76 |     let mut parts = response.split("\0");
[INFO] [stderr]    |                                    ^^^^ help: try using a char instead: `'\0'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/offload.rs:76:36
[INFO] [stderr]    |
[INFO] [stderr] 76 |     let mut parts = response.split("\0");
[INFO] [stderr]    |                                    ^^^^ help: try using a char instead: `'\0'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 3.38s
[INFO] running `"docker" "inspect" "50880bec0d7f4bfa5be9b0eddac4570e98476ef7f20c0b59411177e3a24b076c"`
[INFO] running `"docker" "rm" "-f" "50880bec0d7f4bfa5be9b0eddac4570e98476ef7f20c0b59411177e3a24b076c"`
[INFO] [stdout] 50880bec0d7f4bfa5be9b0eddac4570e98476ef7f20c0b59411177e3a24b076c