[INFO] crate allenap-libtftp 0.2.1 is already in cache [INFO] extracting crate allenap-libtftp 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/allenap-libtftp/0.2.1 [INFO] extracting crate allenap-libtftp 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/allenap-libtftp/0.2.1 [INFO] validating manifest of allenap-libtftp-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of allenap-libtftp-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing allenap-libtftp-0.2.1 [INFO] finished frobbing allenap-libtftp-0.2.1 [INFO] frobbed toml for allenap-libtftp-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/allenap-libtftp/0.2.1/Cargo.toml [INFO] started frobbing allenap-libtftp-0.2.1 [INFO] finished frobbing allenap-libtftp-0.2.1 [INFO] frobbed toml for allenap-libtftp-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/allenap-libtftp/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting allenap-libtftp-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/allenap-libtftp/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d937aa8b1a73f5ff1b44ad6ac2f61d8c114d625a7446bf839af4ba28979573f8 [INFO] running `"docker" "start" "-a" "d937aa8b1a73f5ff1b44ad6ac2f61d8c114d625a7446bf839af4ba28979573f8"` [INFO] [stderr] Checking allenap-libtftp v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:310:26 [INFO] [stderr] | [INFO] [stderr] 310 | OptionStringIter{buf: buf, pos: 0} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/options.rs:310:26 [INFO] [stderr] | [INFO] [stderr] 310 | OptionStringIter{buf: buf, pos: 0} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/options.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return OptionString::Unterminated(cstr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OptionString::Unterminated(cstr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/options.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return OptionString::None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OptionString::None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/options.rs:324:13 [INFO] [stderr] | [INFO] [stderr] 324 | return OptionString::Unterminated(cstr); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OptionString::Unterminated(cstr)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/options.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | return OptionString::None; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `OptionString::None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `options::Options` [INFO] [stderr] --> src/options.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> Options { [INFO] [stderr] 27 | | Options{ [INFO] [stderr] 28 | | blksize: None, [INFO] [stderr] 29 | | timeout: None, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn parse<'a>(buf: &'a [u8]) -> result::Result { [INFO] [stderr] 83 | | let mut container = Self::new(); [INFO] [stderr] 84 | | let mut options = OptionStringIter::new(buf); [INFO] [stderr] 85 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 117 | | }; [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/packet.rs:195:40 [INFO] [stderr] | [INFO] [stderr] 195 | if buffer.eq_ignore_ascii_case("netascii".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"netascii"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/packet.rs:198:45 [INFO] [stderr] | [INFO] [stderr] 198 | else if buffer.eq_ignore_ascii_case("octet".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"octet"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packetreader.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let ref bytes = self.buf[self.pos..pos]; [INFO] [stderr] | ----^^^^^^^^^--------------------------- help: try: `let bytes = &self.buf[self.pos..pos];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packetwriter.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | if value.contains("\0") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/rrq.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / fn send_to( [INFO] [stderr] 63 | | data: &mut io::Read, [INFO] [stderr] 64 | | len: Option, [INFO] [stderr] 65 | | socket: net::UdpSocket, [INFO] [stderr] ... | [INFO] [stderr] 217 | | Result::Ok(()) [INFO] [stderr] 218 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rrq.rs:90:43 [INFO] [stderr] | [INFO] [stderr] 90 | time::Duration::from_secs(timeout as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/rrq.rs:143:49 [INFO] [stderr] | [INFO] [stderr] 143 | match Packet::parse(&mut bufin[..amt]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | match Packet::parse(&mut bufin[..size]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | / match handler.handle(addr, src, packet) { [INFO] [stderr] 38 | | Some(packet) => { [INFO] [stderr] 39 | | let size = packet.write(&mut bufout)?; [INFO] [stderr] 40 | | socket.send_to(&bufout[..size], &src)?; [INFO] [stderr] 41 | | }, [INFO] [stderr] 42 | | None => {}, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(packet) = handler.handle(addr, src, packet) { [INFO] [stderr] 38 | let size = packet.write(&mut bufout)?; [INFO] [stderr] 39 | socket.send_to(&bufout[..size], &src)?; [INFO] [stderr] 40 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `options::Options` [INFO] [stderr] --> src/options.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | / pub fn new() -> Options { [INFO] [stderr] 27 | | Options{ [INFO] [stderr] 28 | | blksize: None, [INFO] [stderr] 29 | | timeout: None, [INFO] [stderr] ... | [INFO] [stderr] 32 | | } [INFO] [stderr] 33 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/options.rs:82:5 [INFO] [stderr] | [INFO] [stderr] 82 | / pub fn parse<'a>(buf: &'a [u8]) -> result::Result { [INFO] [stderr] 83 | | let mut container = Self::new(); [INFO] [stderr] 84 | | let mut options = OptionStringIter::new(buf); [INFO] [stderr] 85 | | loop { [INFO] [stderr] ... | [INFO] [stderr] 117 | | }; [INFO] [stderr] 118 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:248:19 [INFO] [stderr] | [INFO] [stderr] 248 | let buf = "".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:258:19 [INFO] [stderr] | [INFO] [stderr] 258 | let buf = "blksize".as_bytes(); // No trailing null byte. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"blksize"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:344:58 [INFO] [stderr] | [INFO] [stderr] 344 | assert_eq!(iter.next(), OptionString::Terminated("one".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"one"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:345:58 [INFO] [stderr] | [INFO] [stderr] 345 | assert_eq!(iter.next(), OptionString::Terminated("two".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"two"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:346:60 [INFO] [stderr] | [INFO] [stderr] 346 | assert_eq!(iter.next(), OptionString::Unterminated("three".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"three"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:352:19 [INFO] [stderr] | [INFO] [stderr] 352 | let buf = "one".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"one"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:354:60 [INFO] [stderr] | [INFO] [stderr] 354 | assert_eq!(iter.next(), OptionString::Unterminated("one".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"one"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:362:58 [INFO] [stderr] | [INFO] [stderr] 362 | assert_eq!(iter.next(), OptionString::Terminated("one".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"one"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:363:58 [INFO] [stderr] | [INFO] [stderr] 363 | assert_eq!(iter.next(), OptionString::Terminated("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:364:60 [INFO] [stderr] | [INFO] [stderr] 364 | assert_eq!(iter.next(), OptionString::Unterminated("three".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"three"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/options.rs:370:19 [INFO] [stderr] | [INFO] [stderr] 370 | let buf = "".as_bytes(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/packet.rs:195:40 [INFO] [stderr] | [INFO] [stderr] 195 | if buffer.eq_ignore_ascii_case("netascii".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"netascii"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/packet.rs:198:45 [INFO] [stderr] | [INFO] [stderr] 198 | else if buffer.eq_ignore_ascii_case("octet".as_bytes()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"octet"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/packetreader.rs:99:21 [INFO] [stderr] | [INFO] [stderr] 99 | let ref bytes = self.buf[self.pos..pos]; [INFO] [stderr] | ----^^^^^^^^^--------------------------- help: try: `let bytes = &self.buf[self.pos..pos];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packetreader.rs:133:40 [INFO] [stderr] | [INFO] [stderr] 133 | let buffer = PacketReader::new(&mut storage); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packetreader.rs:143:44 [INFO] [stderr] | [INFO] [stderr] 143 | let mut buffer = PacketReader::new(&mut storage); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packetreader.rs:151:44 [INFO] [stderr] | [INFO] [stderr] 151 | let mut buffer = PacketReader::new(&mut storage); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packetreader.rs:159:44 [INFO] [stderr] | [INFO] [stderr] 159 | let mut buffer = PacketReader::new(&mut storage); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/packetreader.rs:166:32 [INFO] [stderr] | [INFO] [stderr] 166 | let mut storage = vec!['a' as u8; 10]; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'a' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: The function/method `::new` doesn't need a mutable reference [INFO] [stderr] --> src/packetreader.rs:167:44 [INFO] [stderr] | [INFO] [stderr] 167 | let mut buffer = PacketReader::new(&mut storage); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/packetwriter.rs:101:31 [INFO] [stderr] | [INFO] [stderr] 101 | if value.contains("\0") { [INFO] [stderr] | ^^^^ help: try using a char instead: `'\0'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/rrq.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | / fn send_to( [INFO] [stderr] 63 | | data: &mut io::Read, [INFO] [stderr] 64 | | len: Option, [INFO] [stderr] 65 | | socket: net::UdpSocket, [INFO] [stderr] ... | [INFO] [stderr] 217 | | Result::Ok(()) [INFO] [stderr] 218 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/rrq.rs:90:43 [INFO] [stderr] | [INFO] [stderr] 90 | time::Duration::from_secs(timeout as u64) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u64::from(timeout)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/rrq.rs:143:49 [INFO] [stderr] | [INFO] [stderr] 143 | match Packet::parse(&mut bufin[..amt]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: The function/method `::parse` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:35:37 [INFO] [stderr] | [INFO] [stderr] 35 | match Packet::parse(&mut bufin[..size]) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:37:25 [INFO] [stderr] | [INFO] [stderr] 37 | / match handler.handle(addr, src, packet) { [INFO] [stderr] 38 | | Some(packet) => { [INFO] [stderr] 39 | | let size = packet.write(&mut bufout)?; [INFO] [stderr] 40 | | socket.send_to(&bufout[..size], &src)?; [INFO] [stderr] 41 | | }, [INFO] [stderr] 42 | | None => {}, [INFO] [stderr] 43 | | }; [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 37 | if let Some(packet) = handler.handle(addr, src, packet) { [INFO] [stderr] 38 | let size = packet.write(&mut bufout)?; [INFO] [stderr] 39 | socket.send_to(&bufout[..size], &src)?; [INFO] [stderr] 40 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.02s [INFO] running `"docker" "inspect" "d937aa8b1a73f5ff1b44ad6ac2f61d8c114d625a7446bf839af4ba28979573f8"` [INFO] running `"docker" "rm" "-f" "d937aa8b1a73f5ff1b44ad6ac2f61d8c114d625a7446bf839af4ba28979573f8"` [INFO] [stdout] d937aa8b1a73f5ff1b44ad6ac2f61d8c114d625a7446bf839af4ba28979573f8