[INFO] crate alice-open-data 0.2.0 is already in cache [INFO] extracting crate alice-open-data 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/alice-open-data/0.2.0 [INFO] extracting crate alice-open-data 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alice-open-data/0.2.0 [INFO] validating manifest of alice-open-data-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of alice-open-data-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing alice-open-data-0.2.0 [INFO] finished frobbing alice-open-data-0.2.0 [INFO] frobbed toml for alice-open-data-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/alice-open-data/0.2.0/Cargo.toml [INFO] started frobbing alice-open-data-0.2.0 [INFO] finished frobbing alice-open-data-0.2.0 [INFO] frobbed toml for alice-open-data-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alice-open-data/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting alice-open-data-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/alice-open-data/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b197b02c421dfaa1fa89a5cbad36ebe7d99d1bd0aa25dd5f2a75c5c70d0fe6ee [INFO] running `"docker" "start" "-a" "b197b02c421dfaa1fa89a5cbad36ebe7d99d1bd0aa25dd5f2a75c5c70d0fe6ee"` [INFO] [stderr] Checking alice-open-data v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / return Ok(content.lines() [INFO] [stderr] 79 | | .map(|l| format!("http://eospublichttp.cern.ch/{}", &l[26..])) [INFO] [stderr] 80 | | .map(|l| l.parse::().expect("Invalid file URI")) [INFO] [stderr] 81 | | .collect()); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | Ok(content.lines() [INFO] [stderr] 79 | .map(|l| format!("http://eospublichttp.cern.ch/{}", &l[26..])) [INFO] [stderr] 80 | .map(|l| l.parse::().expect("Invalid file URI")) [INFO] [stderr] 81 | .collect()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | 139038 => "1102/files/ALICE_LHC10h_PbPb_ESD_139038_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_038` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | 139173 => "1103/files/ALICE_LHC10h_PbPb_ESD_139173_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_173` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | 139437 => "1104/files/ALICE_LHC10h_PbPb_ESD_139437_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_437` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | 139438 => "1105/files/ALICE_LHC10h_PbPb_ESD_139438_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_438` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | 139465 => "1106/files/ALICE_LHC10h_PbPb_ESD_139465_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_465` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | let mut dir = env::home_dir().ok_or(format_err!("No home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let mut dir = env::home_dir().ok_or(format_err!("No home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No home directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / return Ok(content.lines() [INFO] [stderr] 79 | | .map(|l| format!("http://eospublichttp.cern.ch/{}", &l[26..])) [INFO] [stderr] 80 | | .map(|l| l.parse::().expect("Invalid file URI")) [INFO] [stderr] 81 | | .collect()); [INFO] [stderr] | |______________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 78 | Ok(content.lines() [INFO] [stderr] 79 | .map(|l| format!("http://eospublichttp.cern.ch/{}", &l[26..])) [INFO] [stderr] 80 | .map(|l| l.parse::().expect("Invalid file URI")) [INFO] [stderr] 81 | .collect()) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | 139038 => "1102/files/ALICE_LHC10h_PbPb_ESD_139038_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_038` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | 139173 => "1103/files/ALICE_LHC10h_PbPb_ESD_139173_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_173` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | 139437 => "1104/files/ALICE_LHC10h_PbPb_ESD_139437_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_437` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | 139438 => "1105/files/ALICE_LHC10h_PbPb_ESD_139438_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_438` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | 139465 => "1106/files/ALICE_LHC10h_PbPb_ESD_139465_file_index.txt", [INFO] [stderr] | ^^^^^^ help: consider: `139_465` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:42 [INFO] [stderr] | [INFO] [stderr] 114 | let uris = &super::get_file_list(139038).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `139_038` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:121:40 [INFO] [stderr] | [INFO] [stderr] 121 | let uri = super::get_file_list(139038).unwrap()[0].clone(); [INFO] [stderr] | ^^^^^^ help: consider: `139_038` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:132:77 [INFO] [stderr] | [INFO] [stderr] 132 | assert_eq!(super::download(base_dir.clone(), uri.clone()).unwrap(), 14283265); [INFO] [stderr] | ^^^^^^^^ help: consider: `14_283_265` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/lib.rs:39:19 [INFO] [stderr] | [INFO] [stderr] 39 | let mut dir = env::home_dir().ok_or(format_err!("No home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:39:35 [INFO] [stderr] | [INFO] [stderr] 39 | let mut dir = env::home_dir().ok_or(format_err!("No home directory"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("No home directory"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.82s [INFO] running `"docker" "inspect" "b197b02c421dfaa1fa89a5cbad36ebe7d99d1bd0aa25dd5f2a75c5c70d0fe6ee"` [INFO] running `"docker" "rm" "-f" "b197b02c421dfaa1fa89a5cbad36ebe7d99d1bd0aa25dd5f2a75c5c70d0fe6ee"` [INFO] [stdout] b197b02c421dfaa1fa89a5cbad36ebe7d99d1bd0aa25dd5f2a75c5c70d0fe6ee