[INFO] crate alga_derive 0.7.1 is already in cache
[INFO] extracting crate alga_derive 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/alga_derive/0.7.1
[INFO] extracting crate alga_derive 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alga_derive/0.7.1
[INFO] validating manifest of alga_derive-0.7.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of alga_derive-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing alga_derive-0.7.1
[INFO] finished frobbing alga_derive-0.7.1
[INFO] frobbed toml for alga_derive-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/alga_derive/0.7.1/Cargo.toml
[INFO] started frobbing alga_derive-0.7.1
[INFO] finished frobbing alga_derive-0.7.1
[INFO] frobbed toml for alga_derive-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/alga_derive/0.7.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting alga_derive-0.7.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/alga_derive/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] f814d116da4521324968c9e697e3d48b35190d80c0c5e43a2388750be3f67c02
[INFO] running `"docker" "start" "-a" "f814d116da4521324968c9e697e3d48b35190d80c0c5e43a2388750be3f67c02"`
[INFO] [stderr] Checking alga_derive v0.7.1 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr] --> src/lib.rs:218:25
[INFO] [stderr] |
[INFO] [stderr] 218 | n => unreachable!("Trait `{}` with unknown arity {} encountered.", name, n),
[INFO] [stderr] | ^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr]
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr] --> src/lib.rs:218:25
[INFO] [stderr] |
[INFO] [stderr] 218 | n => unreachable!("Trait `{}` with unknown arity {} encountered.", name, n),
[INFO] [stderr] | ^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr]
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr] --> src/lib.rs:246:20
[INFO] [stderr] |
[INFO] [stderr] 246 | } else {
[INFO] [stderr] | ____________________^
[INFO] [stderr] 247 | | if first {
[INFO] [stderr] 248 | | panic!("There is where clause before any traits to apply it to.");
[INFO] [stderr] 249 | | } else {
[INFO] [stderr] 250 | | panic!("There is multiple where clauses next to each other.");
[INFO] [stderr] 251 | | }
[INFO] [stderr] 252 | | }
[INFO] [stderr] | |_____________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr] |
[INFO] [stderr] 246 | } else if first {
[INFO] [stderr] 247 | panic!("There is where clause before any traits to apply it to.");
[INFO] [stderr] 248 | } else {
[INFO] [stderr] 249 | panic!("There is multiple where clauses next to each other.");
[INFO] [stderr] 250 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr] --> src/lib.rs:246:20
[INFO] [stderr] |
[INFO] [stderr] 246 | } else {
[INFO] [stderr] | ____________________^
[INFO] [stderr] 247 | | if first {
[INFO] [stderr] 248 | | panic!("There is where clause before any traits to apply it to.");
[INFO] [stderr] 249 | | } else {
[INFO] [stderr] 250 | | panic!("There is multiple where clauses next to each other.");
[INFO] [stderr] 251 | | }
[INFO] [stderr] 252 | | }
[INFO] [stderr] | |_____________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr] |
[INFO] [stderr] 246 | } else if first {
[INFO] [stderr] 247 | panic!("There is where clause before any traits to apply it to.");
[INFO] [stderr] 248 | } else {
[INFO] [stderr] 249 | panic!("There is multiple where clauses next to each other.");
[INFO] [stderr] 250 | }
[INFO] [stderr] |
[INFO] [stderr]
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr] --> src/lib.rs:351:42
[INFO] [stderr] |
[INFO] [stderr] 351 | if let Some((_, checked_generics)) = item.attrs
[INFO] [stderr] | __________________________________________^
[INFO] [stderr] 352 | | .iter()
[INFO] [stderr] 353 | | .filter_map(|a| match a.value {
[INFO] [stderr] 354 | | Word(ref name) => Some((name, None)),
[INFO] [stderr] ... |
[INFO] [stderr] 358 | | .filter(|&(n, _)| n.as_ref() == "alga_quickcheck")
[INFO] [stderr] 359 | | .next()
[INFO] [stderr] | |_______________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr] = note: replace `filter(|&(n, _)| n.as_ref() == "alga_quickcheck").next()` with `find(|&(n, _)| n.as_ref() == "alga_quickcheck")`
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr]
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr] --> src/lib.rs:391:14
[INFO] [stderr] |
[INFO] [stderr] 391 | .unwrap_or(vec![]);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead.
[INFO] [stderr] --> src/lib.rs:351:42
[INFO] [stderr] |
[INFO] [stderr] 351 | if let Some((_, checked_generics)) = item.attrs
[INFO] [stderr] | __________________________________________^
[INFO] [stderr] 352 | | .iter()
[INFO] [stderr] 353 | | .filter_map(|a| match a.value {
[INFO] [stderr] 354 | | Word(ref name) => Some((name, None)),
[INFO] [stderr] ... |
[INFO] [stderr] 358 | | .filter(|&(n, _)| n.as_ref() == "alga_quickcheck")
[INFO] [stderr] 359 | | .next()
[INFO] [stderr] | |_______________^
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default
[INFO] [stderr] = note: replace `filter(|&(n, _)| n.as_ref() == "alga_quickcheck").next()` with `find(|&(n, _)| n.as_ref() == "alga_quickcheck")`
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next
[INFO] [stderr]
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr] --> src/lib.rs:391:14
[INFO] [stderr] |
[INFO] [stderr] 391 | .unwrap_or(vec![]);
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])`
[INFO] [stderr] |
[INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr] --> src/lib.rs:472:39
[INFO] [stderr] |
[INFO] [stderr] 472 | let hint = self.size_hint().1.unwrap_or(Vec::::new().capacity());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::::new().capacity())`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr] --> src/lib.rs:472:39
[INFO] [stderr] |
[INFO] [stderr] 472 | let hint = self.size_hint().1.unwrap_or(Vec::::new().capacity());
[INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Vec::::new().capacity())`
[INFO] [stderr] |
[INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr]
[INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.50s
[INFO] running `"docker" "inspect" "f814d116da4521324968c9e697e3d48b35190d80c0c5e43a2388750be3f67c02"`
[INFO] running `"docker" "rm" "-f" "f814d116da4521324968c9e697e3d48b35190d80c0c5e43a2388750be3f67c02"`
[INFO] [stdout] f814d116da4521324968c9e697e3d48b35190d80c0c5e43a2388750be3f67c02