[INFO] crate aklat 0.0.20 is already in cache [INFO] extracting crate aklat 0.0.20 into work/ex/clippy-test-run/sources/stable/reg/aklat/0.0.20 [INFO] extracting crate aklat 0.0.20 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aklat/0.0.20 [INFO] validating manifest of aklat-0.0.20 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of aklat-0.0.20 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing aklat-0.0.20 [INFO] finished frobbing aklat-0.0.20 [INFO] frobbed toml for aklat-0.0.20 written to work/ex/clippy-test-run/sources/stable/reg/aklat/0.0.20/Cargo.toml [INFO] started frobbing aklat-0.0.20 [INFO] finished frobbing aklat-0.0.20 [INFO] frobbed toml for aklat-0.0.20 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/aklat/0.0.20/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] [stderr] warning: Package `toml v0.3.2` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] [stderr] warning: Package `toml v0.3.2` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] warning: Package `toml v0.3.2` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] warning: Package `toml v0.3.2` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] linting aklat-0.0.20 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/aklat/0.0.20:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66e238bf43235f938a543b1e2d6c8a3ec97b189d7d64ad856e283c95e948d927 [INFO] running `"docker" "start" "-a" "66e238bf43235f938a543b1e2d6c8a3ec97b189d7d64ad856e283c95e948d927"` [INFO] [stderr] warning: Package `toml v0.3.2` does not have feature `serde`. It has a required dependency with that name, but only optional dependencies can be used as features. This is currently a warning to ease the transition, but it will become an error in the future. [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/book.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/general.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/menu.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/nav-icons.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/page.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/print.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/sidebar.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/theme-popup.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/themes/base.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/themes/coal.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/themes/index.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/themes/light.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/themes/navy.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/themes/rust.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] warning: Pattern matching for Cargo's include/exclude fields is changing and file `src/theme/stylus/variables.styl` WILL be excluded in a future Cargo version. [INFO] [stderr] See https://github.com/rust-lang/cargo/issues/4268 for more info [INFO] [stderr] Compiling pulldown-cmark v0.0.15 [INFO] [stderr] Compiling aklat v0.0.20 (/opt/crater/workdir) [INFO] [stderr] Checking memenhancer v0.1.0 [INFO] [stderr] Checking svgbob v0.1.14 [INFO] [stderr] Checking toml v0.3.2 [INFO] [stderr] Checking pulldown-cmark v0.0.8 [INFO] [stderr] Checking domafic v0.1.2 [INFO] [stderr] Checking ws v0.6.1 [INFO] [stderr] Checking handlebars v0.25.3 [INFO] [stderr] Checking mount v0.3.0 [INFO] [stderr] Checking comic v0.1.0 [INFO] [stderr] Checking spongedown v0.1.2 [INFO] [stderr] Checking staticfile v0.4.0 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/bookitem.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/bookitem.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/html_handlebars/helpers/playpen.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | editable: editable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `editable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/html_handlebars/helpers/playpen.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | escaped: escaped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `escaped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/bookitem.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/book/bookitem.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/html_handlebars/helpers/playpen.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | editable: editable, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `editable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/renderer/html_handlebars/helpers/playpen.rs:107:13 [INFO] [stderr] | [INFO] [stderr] 107 | escaped: escaped, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `escaped` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `section` [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:94:25 [INFO] [stderr] | [INFO] [stderr] 94 | if let Some(section) = item.get("section") { [INFO] [stderr] | ^^^^^^^ help: consider using `_section` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ascii::AsciiExt` [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:8:5 [INFO] [stderr] | [INFO] [stderr] 8 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `section` [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:94:25 [INFO] [stderr] | [INFO] [stderr] 94 | if let Some(section) = item.get("section") { [INFO] [stderr] | ^^^^^^^ help: consider using `_section` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | format!("{}", text) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `text.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/renderer/html_handlebars/hbs_renderer.rs:329:13 [INFO] [stderr] | [INFO] [stderr] 329 | format!("{}", text) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `text.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:43:46 [INFO] [stderr] | [INFO] [stderr] 43 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"
  • "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"
  • "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"
  • "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | try!(rc.writer.write_all(" src/renderer/html_handlebars/helpers/toc.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | try!(rc.writer.write_all(">".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:84:46 [INFO] [stderr] | [INFO] [stderr] 84 | try!(rc.writer.write_all(">".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:97:42 [INFO] [stderr] | [INFO] [stderr] 97 | try!(rc.writer.write_all(" ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:126:38 [INFO] [stderr] | [INFO] [stderr] 126 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:131:38 [INFO] [stderr] | [INFO] [stderr] 131 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:135:34 [INFO] [stderr] | [INFO] [stderr] 135 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:43:46 [INFO] [stderr] | [INFO] [stderr] 43 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"
  • "` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:47:42 [INFO] [stderr] | [INFO] [stderr] 47 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"
  • "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:50:46 [INFO] [stderr] | [INFO] [stderr] 50 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:51:46 [INFO] [stderr] | [INFO] [stderr] 51 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:54:42 [INFO] [stderr] | [INFO] [stderr] 54 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"
  • "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:56:42 [INFO] [stderr] | [INFO] [stderr] 56 | try!(rc.writer.write_all(" src/renderer/html_handlebars/helpers/toc.rs:60:42 [INFO] [stderr] | [INFO] [stderr] 60 | try!(rc.writer.write_all(">".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:84:46 [INFO] [stderr] | [INFO] [stderr] 84 | try!(rc.writer.write_all(">".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b">"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:95:42 [INFO] [stderr] | [INFO] [stderr] 95 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:97:42 [INFO] [stderr] | [INFO] [stderr] 97 | try!(rc.writer.write_all(" ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b" "` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:123:42 [INFO] [stderr] | [INFO] [stderr] 123 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:126:38 [INFO] [stderr] | [INFO] [stderr] 126 | try!(rc.writer.write_all("
  • ".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:130:38 [INFO] [stderr] | [INFO] [stderr] 130 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:131:38 [INFO] [stderr] | [INFO] [stderr] 131 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/renderer/html_handlebars/helpers/toc.rs:135:34 [INFO] [stderr] | [INFO] [stderr] 135 | try!(rc.writer.write_all("".as_bytes())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/utils/fs.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | Err(_) => panic!("Could not create a temp dir"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:177:16 [INFO] [stderr] | [INFO] [stderr] 177 | if let Err(_) = fs::File::create(&tmp.path().join("file.txt")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 178 | | panic!("Could not create file.txt") [INFO] [stderr] 179 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.txt")).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:180:16 [INFO] [stderr] | [INFO] [stderr] 180 | if let Err(_) = fs::File::create(&tmp.path().join("file.md")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 181 | | panic!("Could not create file.md") [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.md")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:183:16 [INFO] [stderr] | [INFO] [stderr] 183 | if let Err(_) = fs::File::create(&tmp.path().join("file.png")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 184 | | panic!("Could not create file.png") [INFO] [stderr] 185 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("file.png")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:186:16 [INFO] [stderr] | [INFO] [stderr] 186 | if let Err(_) = fs::create_dir(&tmp.path().join("sub_dir")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 187 | | panic!("Could not create sub_dir") [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("sub_dir")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:189:16 [INFO] [stderr] | [INFO] [stderr] 189 | if let Err(_) = fs::File::create(&tmp.path().join("sub_dir/file.png")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 190 | | panic!("Could not create sub_dir/file.png") [INFO] [stderr] 191 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("sub_dir/file.png")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:192:16 [INFO] [stderr] | [INFO] [stderr] 192 | if let Err(_) = fs::create_dir(&tmp.path().join("sub_dir_exists")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 193 | | panic!("Could not create sub_dir_exists") [INFO] [stderr] 194 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("sub_dir_exists")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:195:16 [INFO] [stderr] | [INFO] [stderr] 195 | if let Err(_) = fs::File::create(&tmp.path().join("sub_dir_exists/file.txt")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 196 | | panic!("Could not create sub_dir_exists/file.txt") [INFO] [stderr] 197 | | } [INFO] [stderr] | |_________- help: try this: `if fs::File::create(&tmp.path().join("sub_dir_exists/file.txt")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:200:16 [INFO] [stderr] | [INFO] [stderr] 200 | if let Err(_) = fs::create_dir(&tmp.path().join("output")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 201 | | panic!("Could not create output") [INFO] [stderr] 202 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("output")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/utils/fs.rs:203:16 [INFO] [stderr] | [INFO] [stderr] 203 | if let Err(_) = fs::create_dir(&tmp.path().join("output/sub_dir_exists")) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 204 | | panic!("Could not create output/sub_dir_exists") [INFO] [stderr] 205 | | } [INFO] [stderr] | |_________- help: try this: `if fs::create_dir(&tmp.path().join("output/sub_dir_exists")).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/utils/fs.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | / match copy_files_except_ext(&tmp.path(), &tmp.path().join("output"), true, &["md"]) { [INFO] [stderr] 208 | | Err(e) => panic!("Error while executing the function:\n{:?}", e), [INFO] [stderr] 209 | | Ok(_) => {}, [INFO] [stderr] 210 | | } [INFO] [stderr] | |_________^ help: try this: `if let Err(e) = copy_files_except_ext(&tmp.path(), &tmp.path().join("output"), true, &["md"]) { panic!("Error while executing the function:\n{:?}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/mdbook.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/mdbook.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/mdbook.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/bin/mdbook.rs:283:9 [INFO] [stderr] | [INFO] [stderr] 283 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/mdbook.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | const NAME: &'static str = "mdbook"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/mdbook.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | const RELOAD_COMMAND: &'static str = "reload"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bin/mdbook.rs:323:56 [INFO] [stderr] | [INFO] [stderr] 323 | fn trigger_on_change(book: &mut MDBook, closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/mdbook.rs:43:14 [INFO] [stderr] | [INFO] [stderr] 43 | const NAME: &'static str = "mdbook"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/bin/mdbook.rs:218:28 [INFO] [stderr] | [INFO] [stderr] 218 | const RELOAD_COMMAND: &'static str = "reload"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/bin/mdbook.rs:323:56 [INFO] [stderr] | [INFO] [stderr] 323 | fn trigger_on_change(book: &mut MDBook, closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 34.18s [INFO] running `"docker" "inspect" "66e238bf43235f938a543b1e2d6c8a3ec97b189d7d64ad856e283c95e948d927"` [INFO] running `"docker" "rm" "-f" "66e238bf43235f938a543b1e2d6c8a3ec97b189d7d64ad856e283c95e948d927"` [INFO] [stdout] 66e238bf43235f938a543b1e2d6c8a3ec97b189d7d64ad856e283c95e948d927