[INFO] crate akaze 0.1.0 is already in cache [INFO] extracting crate akaze 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/akaze/0.1.0 [INFO] extracting crate akaze 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/akaze/0.1.0 [INFO] validating manifest of akaze-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of akaze-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing akaze-0.1.0 [INFO] finished frobbing akaze-0.1.0 [INFO] frobbed toml for akaze-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/akaze/0.1.0/Cargo.toml [INFO] started frobbing akaze-0.1.0 [INFO] finished frobbing akaze-0.1.0 [INFO] frobbed toml for akaze-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/akaze/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting akaze-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/akaze/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0eac37a743edb46a7d504583223e94f137a7f0f05abd1d8f5decddc174a0eded [INFO] running `"docker" "start" "-a" "0eac37a743edb46a7d504583223e94f137a7f0f05abd1d8f5decddc174a0eded"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking primal-check v0.2.3 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking serde_cbor v0.9.0 [INFO] [stderr] Checking rustfmt v0.10.0 [INFO] [stderr] Checking primal v0.2.3 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking akaze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | let x = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let x = Lstep.width() - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let x = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | let x = Lstep.width() - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | etime: etime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `etime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | esigma: esigma, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `esigma` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | octave: octave, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `octave` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | sublevel: sublevel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sublevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/image.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/image.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | let y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let y = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | let x = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | let x = Lstep.width() - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:118:17 [INFO] [stderr] | [INFO] [stderr] 118 | let x = 0; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:125:17 [INFO] [stderr] | [INFO] [stderr] 125 | let x = Lstep.width() - 1; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | etime: etime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `etime` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:109:13 [INFO] [stderr] | [INFO] [stderr] 109 | esigma: esigma, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `esigma` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:110:13 [INFO] [stderr] | [INFO] [stderr] 110 | octave: octave, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `octave` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/evolution.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | sublevel: sublevel, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sublevel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/image.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/types/image.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ops/feature_matching.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 47 | | if distance < second_to_min_distance { [INFO] [stderr] 48 | | second_to_min_distance = distance; [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | } else if distance < second_to_min_distance { [INFO] [stderr] 47 | second_to_min_distance = distance; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | 0.02546481f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.025_464_81f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | 0.02350698f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.023_506_98f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | 0.01849125f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.018_491_25f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | 0.01239505f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.012_395_05f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | 0.00708017f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.007_080_17f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | 0.00142946f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_429_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | 0.02350698f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.023_506_98f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | 0.02169968f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.021_699_68f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | 0.01706957f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.017_069_57f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | 0.01144208f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.011_442_08f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | 0.00653582f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.006_535_82f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | 0.00318132f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_181_32f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | 0.00131956f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_319_56f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | 0.01849125f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.018_491_25f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | 0.01706957f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.017_069_57f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | 0.01342740f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.013_427_40f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | 0.00900066f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.009_000_66f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | 0.00514126f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.005_141_26f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | 0.00250252f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.002_502_52f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | 0.00103800f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_038_00f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | 0.01239505f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.012_395_05f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | 0.01144208f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.011_442_08f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | 0.00900066f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.009_000_66f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | 0.00603332f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.006_033_32f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | 0.00167749f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_677_49f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | 0.00069579f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_695_79f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | 0.00708017f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.007_080_17f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | 0.00653582f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.006_535_82f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | 0.00514126f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.005_141_26f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | 0.00196855f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_968_55f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | 0.00095820f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_958_20f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | 0.00039744f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_397_44f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | 0.00318132f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_181_32f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | 0.00250252f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.002_502_52f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | 0.00167749f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_677_49f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | 0.00095820f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_958_20f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | 0.00046640f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_466_40f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | 0.00019346f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_193_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | 0.00142946f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_429_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | 0.00131956f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_319_56f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | 0.00103800f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_038_00f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | 0.00069579f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_695_79f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | 0.00039744f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_397_44f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | 0.00019346f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_193_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | 0.00008024f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_080_24f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | inliers [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:265:19 [INFO] [stderr] | [INFO] [stderr] 265 | let inliers = remove_outliers( [INFO] [stderr] | ___________________^ [INFO] [stderr] 266 | | &keypoints_0, [INFO] [stderr] 267 | | &keypoints_1, [INFO] [stderr] 268 | | &mut output, [INFO] [stderr] ... | [INFO] [stderr] 271 | | 0.25f32, [INFO] [stderr] 272 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ops/feature_matching.rs:46:20 [INFO] [stderr] | [INFO] [stderr] 46 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 47 | | if distance < second_to_min_distance { [INFO] [stderr] 48 | | second_to_min_distance = distance; [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 46 | } else if distance < second_to_min_distance { [INFO] [stderr] 47 | second_to_min_distance = distance; [INFO] [stderr] 48 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:204:9 [INFO] [stderr] | [INFO] [stderr] 204 | 0.02546481f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.025_464_81f32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:205:9 [INFO] [stderr] | [INFO] [stderr] 205 | 0.02350698f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.023_506_98f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:206:9 [INFO] [stderr] | [INFO] [stderr] 206 | 0.01849125f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.018_491_25f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:207:9 [INFO] [stderr] | [INFO] [stderr] 207 | 0.01239505f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.012_395_05f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:208:9 [INFO] [stderr] | [INFO] [stderr] 208 | 0.00708017f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.007_080_17f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:210:9 [INFO] [stderr] | [INFO] [stderr] 210 | 0.00142946f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_429_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:213:9 [INFO] [stderr] | [INFO] [stderr] 213 | 0.02350698f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.023_506_98f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:214:9 [INFO] [stderr] | [INFO] [stderr] 214 | 0.02169968f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.021_699_68f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:215:9 [INFO] [stderr] | [INFO] [stderr] 215 | 0.01706957f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.017_069_57f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:216:9 [INFO] [stderr] | [INFO] [stderr] 216 | 0.01144208f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.011_442_08f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:217:9 [INFO] [stderr] | [INFO] [stderr] 217 | 0.00653582f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.006_535_82f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | 0.00318132f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_181_32f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | 0.00131956f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_319_56f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:222:9 [INFO] [stderr] | [INFO] [stderr] 222 | 0.01849125f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.018_491_25f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:223:9 [INFO] [stderr] | [INFO] [stderr] 223 | 0.01706957f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.017_069_57f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | 0.01342740f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.013_427_40f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:225:9 [INFO] [stderr] | [INFO] [stderr] 225 | 0.00900066f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.009_000_66f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | 0.00514126f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.005_141_26f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:227:9 [INFO] [stderr] | [INFO] [stderr] 227 | 0.00250252f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.002_502_52f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | 0.00103800f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_038_00f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:231:9 [INFO] [stderr] | [INFO] [stderr] 231 | 0.01239505f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.012_395_05f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:232:9 [INFO] [stderr] | [INFO] [stderr] 232 | 0.01144208f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.011_442_08f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:233:9 [INFO] [stderr] | [INFO] [stderr] 233 | 0.00900066f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.009_000_66f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | 0.00603332f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.006_033_32f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | 0.00167749f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_677_49f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | 0.00069579f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_695_79f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:240:9 [INFO] [stderr] | [INFO] [stderr] 240 | 0.00708017f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.007_080_17f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:241:9 [INFO] [stderr] | [INFO] [stderr] 241 | 0.00653582f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.006_535_82f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:242:9 [INFO] [stderr] | [INFO] [stderr] 242 | 0.00514126f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.005_141_26f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:243:9 [INFO] [stderr] | [INFO] [stderr] 243 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:244:9 [INFO] [stderr] | [INFO] [stderr] 244 | 0.00196855f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_968_55f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | 0.00095820f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_958_20f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:246:9 [INFO] [stderr] | [INFO] [stderr] 246 | 0.00039744f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_397_44f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:249:9 [INFO] [stderr] | [INFO] [stderr] 249 | 0.00344629f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_446_29f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:250:9 [INFO] [stderr] | [INFO] [stderr] 250 | 0.00318132f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.003_181_32f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:251:9 [INFO] [stderr] | [INFO] [stderr] 251 | 0.00250252f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.002_502_52f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:252:9 [INFO] [stderr] | [INFO] [stderr] 252 | 0.00167749f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_677_49f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:253:9 [INFO] [stderr] | [INFO] [stderr] 253 | 0.00095820f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_958_20f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:254:9 [INFO] [stderr] | [INFO] [stderr] 254 | 0.00046640f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_466_40f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:255:9 [INFO] [stderr] | [INFO] [stderr] 255 | 0.00019346f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_193_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | 0.00142946f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_429_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | 0.00131956f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_319_56f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:260:9 [INFO] [stderr] | [INFO] [stderr] 260 | 0.00103800f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.001_038_00f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | 0.00069579f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_695_79f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:262:9 [INFO] [stderr] | [INFO] [stderr] 262 | 0.00039744f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_397_44f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:263:9 [INFO] [stderr] | [INFO] [stderr] 263 | 0.00019346f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_193_46f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ops/scale_space_extrema.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | 0.00008024f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0.000_080_24f32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.106_288_52` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:25 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.140_321_33` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:37 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.165_770_07` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:49 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.175_240_14` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:61 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.165_770_07` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:73 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.140_321_33` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/types/image.rs:490:85 [INFO] [stderr] | [INFO] [stderr] 490 | 0.10628852, 0.14032133, 0.16577007, 0.17524014, 0.16577007, 0.14032133, 0.10628852, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.106_288_52` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:273:5 [INFO] [stderr] | [INFO] [stderr] 273 | inliers [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:265:19 [INFO] [stderr] | [INFO] [stderr] 265 | let inliers = remove_outliers( [INFO] [stderr] | ___________________^ [INFO] [stderr] 266 | | &keypoints_0, [INFO] [stderr] 267 | | &keypoints_1, [INFO] [stderr] 268 | | &mut output, [INFO] [stderr] ... | [INFO] [stderr] 271 | | 0.25f32, [INFO] [stderr] 272 | | ); [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/contrast_factor.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / let mut kperc: f64 = 0.03; [INFO] [stderr] 67 | | if num_elements >= threshold { [INFO] [stderr] 68 | | kperc = hmax * (k as f64) / (num_bins as f64); [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let kperc = if num_elements >= threshold { hmax * (k as f64) / (num_bins as f64) } else { 0.03 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | let Lx: f64 = Lx.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Lx.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | let Ly: f64 = Ly.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ly.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | let Lx: f64 = Lx.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Lx.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | let Ly: f64 = Ly.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ly.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/contrast_factor.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | bin_number = bin_number - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bin_number -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/contrast_factor.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | num_elements = num_elements + histogram[k] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_elements += histogram[k] as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/derivatives.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | let norm = 1.0 / (2.0 * (scale as f64) * (w + 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | keypoints: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `lvl` is used to index `size_mult` [INFO] [stderr] --> src/ops/descriptors.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | for lvl in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (lvl, ) in size_mult.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/ops/descriptors.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / fn mldb_fill_values( [INFO] [stderr] 86 | | values: &mut Vec, [INFO] [stderr] 87 | | sample_step: usize, [INFO] [stderr] 88 | | level: usize, [INFO] [stderr] ... | [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | values: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/descriptors.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | / let mut res = 0u8; [INFO] [stderr] 159 | | if ival > values[nr_channels * j + pos] { [INFO] [stderr] 160 | | res = 1u8; [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let res = if ival > values[nr_channels * j + pos] { 1u8 } else { 0u8 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/detector_response.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | let ratio = f64::powf(2.0f64, evolution.octave as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(evolution.octave)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/detector_response.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | let ratio = f64::powf(2.0, evolution.octave as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(evolution.octave)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:18:18 [INFO] [stderr] | [INFO] [stderr] 18 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | matches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 102 | matches: &[Match], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `matches.clone()` to [INFO] [stderr] | [INFO] [stderr] 109 | return matches.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match estimate_fundamental_matrix( [INFO] [stderr] 129 | | &keypoints_0, [INFO] [stderr] 130 | | &keypoints_1, [INFO] [stderr] 131 | | &mut model_matches, [INFO] [stderr] ... | [INFO] [stderr] 151 | | None => {} [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(model) = estimate_fundamental_matrix( [INFO] [stderr] 129 | &keypoints_0, [INFO] [stderr] 130 | &keypoints_1, [INFO] [stderr] 131 | &mut model_matches, [INFO] [stderr] 132 | epsilon_model, [INFO] [stderr] 133 | ) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/feature_matching.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | descriptors_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/feature_matching.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | descriptors_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/fed_tau.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | fed_tau_by_cycle_time(T / (M as f64), tau_max, reordering) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(M)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/fed_tau.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / let mut tauh: Vec = vec![]; // unsorted tauh [INFO] [stderr] 63 | | if reordering { [INFO] [stderr] 64 | | tauh = vec![0f64; n]; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let tauh = if reordering { $ crate :: vec :: from_elem ( $ elem , $ n ) } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `tau`. [INFO] [stderr] --> src/ops/fed_tau.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | for l in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for in tau.iter_mut().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `w * y` [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | let mut Ld_xn_i = Ld_xn.nth(w * y + 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `w * y` [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | let mut c_xn_i = c_xn.nth(w * y + 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:142:1 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn eval( [INFO] [stderr] 143 | | c: &GrayFloatImage, [INFO] [stderr] 144 | | Ld: &GrayFloatImage, [INFO] [stderr] 145 | | x: usize, [INFO] [stderr] ... | [INFO] [stderr] 174 | | * (Ld.get(set_x_3 as usize, set_y_3 as usize) - Ld.get(set_x_4 as usize, set_y_4 as usize)) [INFO] [stderr] 175 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `keypoint_cache`. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for j in i..keypoint_cache.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for in keypoint_cache.iter().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:142:19 [INFO] [stderr] | [INFO] [stderr] 142 | in_keypoints: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/ops/scale_space_extrema.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | let d_xy = 0.25f32 * (x_p + x_m) - 0.25f32 * (x_p + x_m); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ops/scale_space_extrema.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | let lu = LU::new(a.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `solve` doesn't need a mutable reference [INFO] [stderr] --> src/ops/scale_space_extrema.rs:165:18 [INFO] [stderr] | [INFO] [stderr] 165 | lu.solve(&mut b); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ops/scale_space_extrema.rs:167:38 [INFO] [stderr] | [INFO] [stderr] 167 | let mut keypoint_clone = keypoint.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*keypoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/ops/scale_space_extrema.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | 0.01342740f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.013_427_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:269:66 [INFO] [stderr] | [INFO] [stderr] 269 | fn compute_main_orientation(keypoint: &mut Keypoint, evolutions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/scale_space_extrema.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | / let mut ang2 = ang1 + PI / 3.0f32; [INFO] [stderr] 301 | | if ang1 + PI / 3.0f32 > 2.0f32 * PI { [INFO] [stderr] 302 | | ang2 = ang1 - 5.0f32 * PI / 3.0f32; [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ang2 = if ang1 + PI / 3.0f32 > 2.0f32 * PI { ang1 - 5.0f32 * PI / 3.0f32 } else { ang1 + PI / 3.0f32 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ops/scale_space_extrema.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | / { [INFO] [stderr] 312 | | sum_x += res_x[k]; [INFO] [stderr] 313 | | sum_y += res_y[k]; [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ops/scale_space_extrema.rs:307:56 [INFO] [stderr] | [INFO] [stderr] 307 | if ang1 < ang2 && ang1 < ang && ang < ang2 { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 308 | | sum_x += res_x[k]; [INFO] [stderr] 309 | | sum_y += res_y[k]; [INFO] [stderr] 310 | | } else if ang2 < ang1 && ((ang > 0f32 && ang < ang2) || (ang > ang1 && ang < 2.0 * PI)) [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | (sublevel as f64) / (options.num_sublevels as f64) + (octave as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(sublevel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | (sublevel as f64) / (options.num_sublevels as f64) + (octave as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(options.num_sublevels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:104:66 [INFO] [stderr] | [INFO] [stderr] 104 | (sublevel as f64) / (options.num_sublevels as f64) + (octave as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(octave)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:137:50 [INFO] [stderr] | [INFO] [stderr] 137 | let rfactor = 1.0f64 / f64::powf(2.0f64, i as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | let level_height = ((height as f64) * rfactor) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:139:28 [INFO] [stderr] | [INFO] [stderr] 139 | let level_width = ((width as f64) * rfactor) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/types/evolution.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | write!(to_write, "{}{:05}.png", path_label, idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/evolution.rs:175:37 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn write_evolutions(evolutions: &Vec, destination_dir: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `evolutions` [INFO] [stderr] --> src/types/evolution.rs:176:14 [INFO] [stderr] | [INFO] [stderr] 176 | for i in 0..evolutions.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 176 | for (i, ) in evolutions.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | matches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Match]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn serialize_to_file(matches: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Match]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/feature_match.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/feature_match.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | file.write(&serialized[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/feature_match.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | *output_ptr = (pixel_value as f32) * 1f32 / 255f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types/image.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | pixel = pixel - min_pixel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel -= min_pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types/image.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | pixel = pixel / new_max_pixel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel /= new_max_pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/image.rs:270:58 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn horizontal_filter(image: &GrayFloatImage, kernel: &Vec) -> GrayFloatImage { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/image.rs:305:56 [INFO] [stderr] | [INFO] [stderr] 305 | pub fn vertical_filter(image: &GrayFloatImage, kernel: &Vec) -> GrayFloatImage { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:403:11 [INFO] [stderr] | [INFO] [stderr] 403 | (((p1.0 as f32) + (p2.0 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:403:27 [INFO] [stderr] | [INFO] [stderr] 403 | (((p1.0 as f32) + (p2.0 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p2.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:404:11 [INFO] [stderr] | [INFO] [stderr] 404 | (((p1.1 as f32) + (p2.1 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p1.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:404:27 [INFO] [stderr] | [INFO] [stderr] 404 | (((p1.1 as f32) + (p2.1 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p2.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:405:11 [INFO] [stderr] | [INFO] [stderr] 405 | (((p1.2 as f32) + (p2.2 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p1.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:405:27 [INFO] [stderr] | [INFO] [stderr] 405 | (((p1.2 as f32) + (p2.2 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p2.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/contrast_factor.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | / let mut kperc: f64 = 0.03; [INFO] [stderr] 67 | | if num_elements >= threshold { [INFO] [stderr] 68 | | kperc = hmax * (k as f64) / (num_bins as f64); [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let kperc = if num_elements >= threshold { hmax * (k as f64) / (num_bins as f64) } else { 0.03 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:32:27 [INFO] [stderr] | [INFO] [stderr] 32 | let Lx: f64 = Lx.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Lx.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:33:27 [INFO] [stderr] | [INFO] [stderr] 33 | let Ly: f64 = Ly.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ly.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:42:27 [INFO] [stderr] | [INFO] [stderr] 42 | let Lx: f64 = Lx.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Lx.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/contrast_factor.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | let Ly: f64 = Ly.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ly.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/contrast_factor.rs:48:21 [INFO] [stderr] | [INFO] [stderr] 48 | bin_number = bin_number - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bin_number -= 1` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/ops/contrast_factor.rs:59:9 [INFO] [stderr] | [INFO] [stderr] 59 | num_elements = num_elements + histogram[k] as usize; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_elements += histogram[k] as usize` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/derivatives.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(expected_kernel[i], produced_kernel[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/derivatives.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | assert_eq!(expected_kernel[i], produced_kernel[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/ops/derivatives.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | assert_eq!(expected_kernel[i], produced_kernel[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/ops/derivatives.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | assert_eq!(expected_kernel[i], produced_kernel[i]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/derivatives.rs:94:29 [INFO] [stderr] | [INFO] [stderr] 94 | let norm = 1.0 / (2.0 * (scale as f64) * (w + 2.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(scale)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:15:17 [INFO] [stderr] | [INFO] [stderr] 15 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | keypoints: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:38:17 [INFO] [stderr] | [INFO] [stderr] 38 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `lvl` is used to index `size_mult` [INFO] [stderr] --> src/ops/descriptors.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | for lvl in 0..3 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for (lvl, ) in size_mult.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:56:71 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn draw_keypoints_to_image(input_image: &mut RgbImage, keypoints: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/ops/descriptors.rs:85:1 [INFO] [stderr] | [INFO] [stderr] 85 | / fn mldb_fill_values( [INFO] [stderr] 86 | | values: &mut Vec, [INFO] [stderr] 87 | | sample_step: usize, [INFO] [stderr] 88 | | level: usize, [INFO] [stderr] ... | [INFO] [stderr] 143 | | } [INFO] [stderr] 144 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:72:62 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn draw_keypoints(input_image: &DynamicImage, keypoints: &Vec) -> RgbImage { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &Vec, descriptors: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &[Keypoint], descriptors: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `keypoints.clone()` to [INFO] [stderr] | [INFO] [stderr] 91 | keypoints: keypoints.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:86:66 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &Vec, descriptors: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &Vec, descriptors: &[Descriptor], path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: change `descriptors.clone()` to [INFO] [stderr] | [INFO] [stderr] 92 | descriptors: descriptors.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/descriptors.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | values: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/keypoint.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/keypoint.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | file.write(&serialized[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/keypoint.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/descriptors.rs:158:17 [INFO] [stderr] | [INFO] [stderr] 158 | / let mut res = 0u8; [INFO] [stderr] 159 | | if ival > values[nr_channels * j + pos] { [INFO] [stderr] 160 | | res = 1u8; [INFO] [stderr] 161 | | } [INFO] [stderr] | |_________________^ help: it is more idiomatic to write: `let res = if ival > values[nr_channels * j + pos] { 1u8 } else { 0u8 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/detector_response.rs:22:47 [INFO] [stderr] | [INFO] [stderr] 22 | let ratio = f64::powf(2.0f64, evolution.octave as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(evolution.octave)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/detector_response.rs:41:36 [INFO] [stderr] | [INFO] [stderr] 41 | let ratio = f64::powf(2.0, evolution.octave as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(evolution.octave)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:18:18 [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] | [INFO] [stderr] 18 | keypoints_0: &Vec, [INFO] [stderr] --> src/lib.rs:46:33 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 46 | let Lx_pixel: f64 = Lx.get(x, y) as f64; [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Lx.get(x, y))` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:19:18 [INFO] [stderr] | [INFO] [stderr] 19 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | let Ly_pixel: f64 = Ly.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ly.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:102:14 [INFO] [stderr] | [INFO] [stderr] 102 | matches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 102 | matches: &[Match], [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] help: change `matches.clone()` to [INFO] [stderr] | [INFO] [stderr] 109 | return matches.to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ops/estimate_fundamental_matrix.rs:128:9 [INFO] [stderr] | [INFO] [stderr] 128 | / match estimate_fundamental_matrix( [INFO] [stderr] 129 | | &keypoints_0, [INFO] [stderr] 130 | | &keypoints_1, [INFO] [stderr] 131 | | &mut model_matches, [INFO] [stderr] ... | [INFO] [stderr] 151 | | None => {} [INFO] [stderr] 152 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 128 | if let Some(model) = estimate_fundamental_matrix( [INFO] [stderr] 129 | &keypoints_0, [INFO] [stderr] 130 | &keypoints_1, [INFO] [stderr] 131 | &mut model_matches, [INFO] [stderr] 132 | epsilon_model, [INFO] [stderr] 133 | ) { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/feature_matching.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | descriptors_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/feature_matching.rs:25:20 [INFO] [stderr] | [INFO] [stderr] 25 | descriptors_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | contrast_factor = contrast_factor * 0.75; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contrast_factor *= 0.75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ops/fed_tau.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | fed_tau_by_cycle_time(T / (M as f64), tau_max, reordering) [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(M)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/fed_tau.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / let mut tauh: Vec = vec![]; // unsorted tauh [INFO] [stderr] 63 | | if reordering { [INFO] [stderr] 64 | | tauh = vec![0f64; n]; [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let tauh = if reordering { $ crate :: vec :: from_elem ( $ elem , $ n ) } else { < [ _ ] > :: into_vec ( box [ $ ( $ x ) , * ] ) };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the loop variable `l` is only used to index `tau`. [INFO] [stderr] --> src/ops/fed_tau.rs:92:22 [INFO] [stderr] | [INFO] [stderr] 92 | for l in 0..n { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 92 | for in tau.iter_mut().take(n) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `w * y` [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:29:37 [INFO] [stderr] | [INFO] [stderr] 29 | let mut Ld_xn_i = Ld_xn.nth(w * y + 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:250:18 [INFO] [stderr] | [INFO] [stderr] 250 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:251:20 [INFO] [stderr] | [INFO] [stderr] 251 | descriptors_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:253:20 [INFO] [stderr] | [INFO] [stderr] 253 | descriptors_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `w * y` [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:44:35 [INFO] [stderr] | [INFO] [stderr] 44 | let mut c_xn_i = c_xn.nth(w * y + 0).unwrap(); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_outliers` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | &mut output, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/ops/nonlinear_diffusion.rs:142:1 [INFO] [stderr] | [INFO] [stderr] 142 | / pub fn eval( [INFO] [stderr] 143 | | c: &GrayFloatImage, [INFO] [stderr] 144 | | Ld: &GrayFloatImage, [INFO] [stderr] 145 | | x: usize, [INFO] [stderr] ... | [INFO] [stderr] 174 | | * (Ld.get(set_x_3 as usize, set_y_3 as usize) - Ld.get(set_x_4 as usize, set_y_4 as usize)) [INFO] [stderr] 175 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is only used to index `keypoint_cache`. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:114:18 [INFO] [stderr] | [INFO] [stderr] 114 | for j in i..keypoint_cache.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 114 | for in keypoint_cache.iter().skip(i) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 8 previous errors [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:142:19 [INFO] [stderr] | [INFO] [stderr] 142 | in_keypoints: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | evolutions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `-` [INFO] [stderr] --> src/ops/scale_space_extrema.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | let d_xy = 0.25f32 * (x_p + x_m) - 0.25f32 * (x_p + x_m); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ops/scale_space_extrema.rs:164:26 [INFO] [stderr] | [INFO] [stderr] 164 | let lu = LU::new(a.clone()); [INFO] [stderr] | ^^^^^^^^^ help: try removing the `clone` call: `a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: The function/method `solve` doesn't need a mutable reference [INFO] [stderr] --> src/ops/scale_space_extrema.rs:165:18 [INFO] [stderr] | [INFO] [stderr] 165 | lu.solve(&mut b); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ops/scale_space_extrema.rs:167:38 [INFO] [stderr] | [INFO] [stderr] 167 | let mut keypoint_clone = keypoint.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*keypoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/ops/scale_space_extrema.rs:224:9 [INFO] [stderr] | [INFO] [stderr] 224 | 0.01342740f32, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `0.013_427_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ops/scale_space_extrema.rs:269:66 [INFO] [stderr] | [INFO] [stderr] 269 | fn compute_main_orientation(keypoint: &mut Keypoint, evolutions: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ops/scale_space_extrema.rs:300:9 [INFO] [stderr] | [INFO] [stderr] 300 | / let mut ang2 = ang1 + PI / 3.0f32; [INFO] [stderr] 301 | | if ang1 + PI / 3.0f32 > 2.0f32 * PI { [INFO] [stderr] 302 | | ang2 = ang1 - 5.0f32 * PI / 3.0f32; [INFO] [stderr] 303 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let ang2 = if ang1 + PI / 3.0f32 > 2.0f32 * PI { ang1 - 5.0f32 * PI / 3.0f32 } else { ang1 + PI / 3.0f32 };` [INFO] [stderr] | [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ops/scale_space_extrema.rs:311:13 [INFO] [stderr] | [INFO] [stderr] 311 | / { [INFO] [stderr] 312 | | sum_x += res_x[k]; [INFO] [stderr] 313 | | sum_y += res_y[k]; [INFO] [stderr] 314 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ops/scale_space_extrema.rs:307:56 [INFO] [stderr] | [INFO] [stderr] 307 | if ang1 < ang2 && ang1 < ang && ang < ang2 { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 308 | | sum_x += res_x[k]; [INFO] [stderr] 309 | | sum_y += res_y[k]; [INFO] [stderr] 310 | | } else if ang2 < ang1 && ((ang > 0f32 && ang < ang2) || (ang > ang1 && ang < 2.0 * PI)) [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: Could not compile `akaze`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:104:13 [INFO] [stderr] | [INFO] [stderr] 104 | (sublevel as f64) / (options.num_sublevels as f64) + (octave as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `f64::from(sublevel)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:104:33 [INFO] [stderr] | [INFO] [stderr] 104 | (sublevel as f64) / (options.num_sublevels as f64) + (octave as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(options.num_sublevels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:104:66 [INFO] [stderr] | [INFO] [stderr] 104 | (sublevel as f64) / (options.num_sublevels as f64) + (octave as f64), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(octave)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:137:50 [INFO] [stderr] | [INFO] [stderr] 137 | let rfactor = 1.0f64 / f64::powf(2.0f64, i as f64); [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:138:29 [INFO] [stderr] | [INFO] [stderr] 138 | let level_height = ((height as f64) * rfactor) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/types/evolution.rs:139:28 [INFO] [stderr] | [INFO] [stderr] 139 | let level_width = ((width as f64) * rfactor) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `f64::from(width)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/types/evolution.rs:164:5 [INFO] [stderr] | [INFO] [stderr] 164 | write!(to_write, "{}{:05}.png", path_label, idx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/evolution.rs:175:37 [INFO] [stderr] | [INFO] [stderr] 175 | pub fn write_evolutions(evolutions: &Vec, destination_dir: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change this to: `&[EvolutionStep]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `evolutions` [INFO] [stderr] --> src/types/evolution.rs:176:14 [INFO] [stderr] | [INFO] [stderr] 176 | for i in 0..evolutions.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 176 | for (i, ) in evolutions.iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:40:18 [INFO] [stderr] | [INFO] [stderr] 40 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:41:14 [INFO] [stderr] | [INFO] [stderr] 41 | matches: &Vec, [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Match]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/feature_match.rs:93:35 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn serialize_to_file(matches: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Match]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/feature_match.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/feature_match.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | file.write(&serialized[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/feature_match.rs:106:9 [INFO] [stderr] | [INFO] [stderr] 106 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:136:27 [INFO] [stderr] | [INFO] [stderr] 136 | *output_ptr = (pixel_value as f32) * 1f32 / 255f32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(pixel_value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types/image.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | pixel = pixel - min_pixel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel -= min_pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/types/image.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | pixel = pixel / new_max_pixel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pixel /= new_max_pixel` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/image.rs:270:58 [INFO] [stderr] | [INFO] [stderr] 270 | pub fn horizontal_filter(image: &GrayFloatImage, kernel: &Vec) -> GrayFloatImage { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/image.rs:305:56 [INFO] [stderr] | [INFO] [stderr] 305 | pub fn vertical_filter(image: &GrayFloatImage, kernel: &Vec) -> GrayFloatImage { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[f32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:403:11 [INFO] [stderr] | [INFO] [stderr] 403 | (((p1.0 as f32) + (p2.0 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p1.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:403:27 [INFO] [stderr] | [INFO] [stderr] 403 | (((p1.0 as f32) + (p2.0 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p2.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:404:11 [INFO] [stderr] | [INFO] [stderr] 404 | (((p1.1 as f32) + (p2.1 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p1.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:404:27 [INFO] [stderr] | [INFO] [stderr] 404 | (((p1.1 as f32) + (p2.1 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p2.1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:405:11 [INFO] [stderr] | [INFO] [stderr] 405 | (((p1.2 as f32) + (p2.2 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p1.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/types/image.rs:405:27 [INFO] [stderr] | [INFO] [stderr] 405 | (((p1.2 as f32) + (p2.2 as f32)) / 2f32) as u8, [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(p2.2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:56:71 [INFO] [stderr] | [INFO] [stderr] 56 | pub fn draw_keypoints_to_image(input_image: &mut RgbImage, keypoints: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:72:62 [INFO] [stderr] | [INFO] [stderr] 72 | pub fn draw_keypoints(input_image: &DynamicImage, keypoints: &Vec) -> RgbImage { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:86:37 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &Vec, descriptors: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &[Keypoint], descriptors: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] help: change `keypoints.clone()` to [INFO] [stderr] | [INFO] [stderr] 91 | keypoints: keypoints.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/types/keypoint.rs:86:66 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &Vec, descriptors: &Vec, path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 86 | pub fn serialize_to_file(keypoints: &Vec, descriptors: &[Descriptor], path: PathBuf) { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] help: change `descriptors.clone()` to [INFO] [stderr] | [INFO] [stderr] 92 | descriptors: descriptors.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/keypoint.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/keypoint.rs:99:9 [INFO] [stderr] | [INFO] [stderr] 99 | file.write(&serialized[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/types/keypoint.rs:103:9 [INFO] [stderr] | [INFO] [stderr] 103 | file.write(serialized.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:46:33 [INFO] [stderr] | [INFO] [stderr] 46 | let Lx_pixel: f64 = Lx.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Lx.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:47:33 [INFO] [stderr] | [INFO] [stderr] 47 | let Ly_pixel: f64 = Ly.get(x, y) as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(Ly.get(x, y))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | contrast_factor = contrast_factor * 0.75; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `contrast_factor *= 0.75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:250:18 [INFO] [stderr] | [INFO] [stderr] 250 | keypoints_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:251:20 [INFO] [stderr] | [INFO] [stderr] 251 | descriptors_0: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | keypoints_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[Keypoint]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:253:20 [INFO] [stderr] | [INFO] [stderr] 253 | descriptors_1: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: change this to: `&[Descriptor]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: The function/method `remove_outliers` doesn't need a mutable reference [INFO] [stderr] --> src/lib.rs:268:9 [INFO] [stderr] | [INFO] [stderr] 268 | &mut output, [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] error: aborting due to 10 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `akaze`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0eac37a743edb46a7d504583223e94f137a7f0f05abd1d8f5decddc174a0eded"` [INFO] running `"docker" "rm" "-f" "0eac37a743edb46a7d504583223e94f137a7f0f05abd1d8f5decddc174a0eded"` [INFO] [stdout] 0eac37a743edb46a7d504583223e94f137a7f0f05abd1d8f5decddc174a0eded